446cf2
commit 97476447edff96e526daa1a22d6ed3665181ff93
446cf2
Author: DJ Delorie <dj@redhat.com>
446cf2
Date:   Wed Oct 23 17:52:26 2019 -0400
446cf2
446cf2
    Install charmaps uncompressed in testroot
446cf2
    
446cf2
    The testroot does not have a gunzip command, so the charmap files
446cf2
    should not be installed gzipped else they cannot be used (and thus
446cf2
    tested).  With this patch, installing with INSTALL_UNCOMPRESSED=yes
446cf2
    installs uncompressed charmaps instead.
446cf2
    
446cf2
    Note that we must purge the $(symbolic_link_list) as it contains
446cf2
    references to $(DESTDIR), which we change during the testroot
446cf2
    installation.
446cf2
    
446cf2
    Reviewed-by: Carlos O'Donell <carlos@redhat.com>
446cf2
446cf2
diff --git a/Makefile b/Makefile
446cf2
index 3748d6f7cfb6223b..6d73241bbc811c13 100644
446cf2
--- a/Makefile
446cf2
+++ b/Makefile
446cf2
@@ -398,8 +398,15 @@ ifeq ($(run-built-tests),yes)
446cf2
 	    $(test-wrapper) cp $$dso $(objpfx)testroot.pristine$$dso ;\
446cf2
 	  done
446cf2
 endif
446cf2
+	# $(symbolic-link-list) is a file that encodes $(DESTDIR) so we
446cf2
+	# have to purge it
446cf2
+	rm -f $(symbolic-link-list)
446cf2
+	# Setting INSTALL_UNCOMPRESSED causes localedata/Makefile to
446cf2
+	# install the charmaps uncompressed, as the testroot does not
446cf2
+	# provide a gunzip program.
446cf2
 	$(MAKE) install DESTDIR=$(objpfx)testroot.pristine \
446cf2
-	  subdirs='$(sorted-subdirs)'
446cf2
+	  INSTALL_UNCOMPRESSED=yes subdirs='$(sorted-subdirs)'
446cf2
+	rm -f $(symbolic-link-list)
446cf2
 	touch $(objpfx)testroot.pristine/install.stamp
446cf2
 
446cf2
 tests-special-notdir = $(patsubst $(objpfx)%, %, $(tests-special))
446cf2
diff --git a/localedata/Makefile b/localedata/Makefile
446cf2
index 0fed95dcae6a9183..14fcc37fed21e740 100644
446cf2
--- a/localedata/Makefile
446cf2
+++ b/localedata/Makefile
446cf2
@@ -167,9 +167,17 @@ endif
446cf2
 endif
446cf2
 
446cf2
 # Files to install.
446cf2
+ifeq ($(INSTALL_UNCOMPRESSED),yes)
446cf2
+# This option is for testing inside the testroot container, as the
446cf2
+# container does not include a working gunzip program.
446cf2
+install-others := $(addprefix $(inst_i18ndir)/, \
446cf2
+			      $(charmaps) \
446cf2
+			      $(locales))
446cf2
+else
446cf2
 install-others := $(addprefix $(inst_i18ndir)/, \
446cf2
 			      $(addsuffix .gz, $(charmaps)) \
446cf2
 			      $(locales))
446cf2
+endif
446cf2
 
446cf2
 tests: $(objdir)/iconvdata/gconv-modules
446cf2
 
446cf2
@@ -282,12 +290,22 @@ endif
446cf2
 
446cf2
 include ../Rules
446cf2
 
446cf2
+ifeq ($(INSTALL_UNCOMPRESSED),yes)
446cf2
+# Install the charmap files as-is.  This option is for testing inside
446cf2
+# the testroot container, as the container does not include a working
446cf2
+# gunzip program.
446cf2
+$(inst_i18ndir)/charmaps/%: charmaps/% $(+force)
446cf2
+	$(make-target-directory)
446cf2
+	rm -f $@
446cf2
+	$(INSTALL_DATA) $< $@
446cf2
+else
446cf2
 # Install the charmap files in gzipped format.
446cf2
 $(inst_i18ndir)/charmaps/%.gz: charmaps/% $(+force)
446cf2
 	$(make-target-directory)
446cf2
 	rm -f $(@:.gz=) $@
446cf2
 	$(INSTALL_DATA) $< $(@:.gz=)
446cf2
 	gzip -9n $(@:.gz=)
446cf2
+endif
446cf2
 
446cf2
 # Install the locale source files in the appropriate directory.
446cf2
 $(inst_i18ndir)/locales/%: locales/% $(+force); $(do-install)