|
 |
d8307d |
commit ac64195ccd4f320659fd0058bc7524c6fd0b37b4
|
|
|
d8307d |
Author: DJ Delorie <dj@redhat.com>
|
|
|
d8307d |
Date: Wed Mar 20 23:56:59 2019 -0400
|
|
|
d8307d |
|
|
|
d8307d |
iconv, localedef: avoid floating point rounding differences [BZ #24372]
|
|
|
d8307d |
|
|
|
d8307d |
Two cases of "int * 1.4" may result in imprecise results, which
|
|
|
d8307d |
in at least one case resulted in i686 and x86-64 producing
|
|
|
d8307d |
different locale files. This replaced that floating point multiply
|
|
|
d8307d |
with integer operations. While the hash table margin is increased
|
|
|
d8307d |
from 40% to 50%, testing shows only 2% increase in overall size
|
|
|
d8307d |
of the locale archive.
|
|
|
d8307d |
|
|
|
d8307d |
https://bugzilla.redhat.com/show_bug.cgi?id=1311954
|
|
|
d8307d |
|
|
|
d8307d |
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
|
|
|
d8307d |
|
|
|
d8307d |
diff --git a/iconv/iconvconfig.c b/iconv/iconvconfig.c
|
|
|
d8307d |
index d5e8e714233f78d8..696fc8d31231ca2d 100644
|
|
|
d8307d |
--- a/iconv/iconvconfig.c
|
|
|
d8307d |
+++ b/iconv/iconvconfig.c
|
|
|
d8307d |
@@ -1079,9 +1079,9 @@ write_output (void)
|
|
|
d8307d |
|
|
|
d8307d |
/* Create the hashing table. We know how many strings we have.
|
|
|
d8307d |
Creating a perfect hash table is not reasonable here. Therefore
|
|
|
d8307d |
- we use open hashing and a table size which is the next prime 40%
|
|
|
d8307d |
+ we use open hashing and a table size which is the next prime 50%
|
|
|
d8307d |
larger than the number of strings. */
|
|
|
d8307d |
- hash_size = next_prime (nnames * 1.4);
|
|
|
d8307d |
+ hash_size = next_prime (nnames + nnames >> 1);
|
|
|
d8307d |
hash_table = (struct hash_entry *) xcalloc (hash_size,
|
|
|
d8307d |
sizeof (struct hash_entry));
|
|
|
d8307d |
/* Fill the hash table. */
|
|
|
d8307d |
diff --git a/locale/programs/ld-collate.c b/locale/programs/ld-collate.c
|
|
|
d8307d |
index d2eebcfdbb0677e5..9a1639b999d0e2aa 100644
|
|
|
d8307d |
--- a/locale/programs/ld-collate.c
|
|
|
d8307d |
+++ b/locale/programs/ld-collate.c
|
|
|
d8307d |
@@ -2401,8 +2401,8 @@ collate_output (struct localedef_t *locale, const struct charmap_t *charmap,
|
|
|
d8307d |
|
|
|
d8307d |
runp = runp->next;
|
|
|
d8307d |
}
|
|
|
d8307d |
- /* Add 40% and find the next prime number. */
|
|
|
d8307d |
- elem_size = next_prime (elem_size * 1.4);
|
|
|
d8307d |
+ /* Add 50% and find the next prime number. */
|
|
|
d8307d |
+ elem_size = next_prime (elem_size + elem_size >> 1);
|
|
|
d8307d |
|
|
|
d8307d |
/* Allocate the table. Each entry consists of two words: the hash
|
|
|
d8307d |
value and an index in a secondary table which provides the index
|