|
 |
d8307d |
commit d2a7436c1c6144bbba2eb2a7b25db9b90515f0e6
|
|
|
d8307d |
Author: Stefan Liebler <stli@linux.ibm.com>
|
|
|
d8307d |
Date: Tue Dec 18 13:57:24 2018 +0100
|
|
|
d8307d |
|
|
|
d8307d |
S390: Refactor wmemset ifunc handling.
|
|
|
d8307d |
|
|
|
d8307d |
The ifunc handling for wmemset is adjusted in order to omit ifunc
|
|
|
d8307d |
if the minimum architecture level already supports newer CPUs by default.
|
|
|
d8307d |
Unfortunately the c ifunc variant can't be omitted at all as it is used
|
|
|
d8307d |
by the z13 ifunc variant as fallback if the pointers are not 4-byte aligned.
|
|
|
d8307d |
Glibc internal calls will use the "newer" ifunc variant.
|
|
|
d8307d |
|
|
|
d8307d |
ChangeLog:
|
|
|
d8307d |
|
|
|
d8307d |
* sysdeps/s390/multiarch/Makefile
|
|
|
d8307d |
(sysdep_routines): Remove wmemset variants.
|
|
|
d8307d |
* sysdeps/s390/Makefile (sysdep_routines): Add wmemset variants.
|
|
|
d8307d |
* sysdeps/s390/multiarch/ifunc-impl-list.c
|
|
|
d8307d |
(__libc_ifunc_impl_list): Refactor ifunc handling for wmemset.
|
|
|
d8307d |
* sysdeps/s390/multiarch/wmemset-c.c: Move to ...
|
|
|
d8307d |
* sysdeps/s390/wmemset-c.c: ... here and adjust ifunc handling.
|
|
|
d8307d |
* sysdeps/s390/multiarch/wmemset-vx.S: Move to ...
|
|
|
d8307d |
* sysdeps/s390/wmemset-vx.S: ... here and adjust ifunc handling.
|
|
|
d8307d |
* sysdeps/s390/multiarch/wmemset.c: Move to ...
|
|
|
d8307d |
* sysdeps/s390/wmemset.c: ... here and adjust ifunc handling.
|
|
|
d8307d |
* sysdeps/s390/ifunc-wmemset.h: New file.
|
|
|
d8307d |
|
|
|
d8307d |
diff --git a/sysdeps/s390/Makefile b/sysdeps/s390/Makefile
|
|
|
d8307d |
index fdfd1c605c28ddc7..f9a71276331b396a 100644
|
|
|
d8307d |
--- a/sysdeps/s390/Makefile
|
|
|
d8307d |
+++ b/sysdeps/s390/Makefile
|
|
|
d8307d |
@@ -76,5 +76,6 @@ sysdep_routines += wcslen wcslen-vx wcslen-c \
|
|
|
d8307d |
wcsspn wcsspn-vx wcsspn-c \
|
|
|
d8307d |
wcspbrk wcspbrk-vx wcspbrk-c \
|
|
|
d8307d |
wcscspn wcscspn-vx wcscspn-c \
|
|
|
d8307d |
- wmemchr wmemchr-vx wmemchr-c
|
|
|
d8307d |
+ wmemchr wmemchr-vx wmemchr-c \
|
|
|
d8307d |
+ wmemset wmemset-vx wmemset-c
|
|
|
d8307d |
endif
|
|
|
d8307d |
diff --git a/sysdeps/s390/ifunc-wmemset.h b/sysdeps/s390/ifunc-wmemset.h
|
|
|
d8307d |
new file mode 100644
|
|
|
d8307d |
index 0000000000000000..c9d1d17c3bfc7e9e
|
|
|
d8307d |
--- /dev/null
|
|
|
d8307d |
+++ b/sysdeps/s390/ifunc-wmemset.h
|
|
|
d8307d |
@@ -0,0 +1,53 @@
|
|
|
d8307d |
+/* wmemset variant information on S/390 version.
|
|
|
d8307d |
+ Copyright (C) 2018 Free Software Foundation, Inc.
|
|
|
d8307d |
+ This file is part of the GNU C Library.
|
|
|
d8307d |
+
|
|
|
d8307d |
+ The GNU C Library is free software; you can redistribute it and/or
|
|
|
d8307d |
+ modify it under the terms of the GNU Lesser General Public
|
|
|
d8307d |
+ License as published by the Free Software Foundation; either
|
|
|
d8307d |
+ version 2.1 of the License, or (at your option) any later version.
|
|
|
d8307d |
+
|
|
|
d8307d |
+ The GNU C Library is distributed in the hope that it will be useful,
|
|
|
d8307d |
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
d8307d |
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
d8307d |
+ Lesser General Public License for more details.
|
|
|
d8307d |
+
|
|
|
d8307d |
+ You should have received a copy of the GNU Lesser General Public
|
|
|
d8307d |
+ License along with the GNU C Library; if not, see
|
|
|
d8307d |
+ <http://www.gnu.org/licenses/>. */
|
|
|
d8307d |
+
|
|
|
d8307d |
+#if defined USE_MULTIARCH && IS_IN (libc) \
|
|
|
d8307d |
+ && ! defined HAVE_S390_MIN_Z13_ZARCH_ASM_SUPPORT
|
|
|
d8307d |
+# define HAVE_WMEMSET_IFUNC 1
|
|
|
d8307d |
+#else
|
|
|
d8307d |
+# define HAVE_WMEMSET_IFUNC 0
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
+
|
|
|
d8307d |
+#ifdef HAVE_S390_VX_ASM_SUPPORT
|
|
|
d8307d |
+# define HAVE_WMEMSET_IFUNC_AND_VX_SUPPORT HAVE_WMEMSET_IFUNC
|
|
|
d8307d |
+#else
|
|
|
d8307d |
+# define HAVE_WMEMSET_IFUNC_AND_VX_SUPPORT 0
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
+
|
|
|
d8307d |
+#if defined HAVE_S390_MIN_Z13_ZARCH_ASM_SUPPORT
|
|
|
d8307d |
+# define WMEMSET_DEFAULT WMEMSET_Z13
|
|
|
d8307d |
+/* The z13 ifunc variant is using the common code variant as fallback! */
|
|
|
d8307d |
+# define HAVE_WMEMSET_C 1
|
|
|
d8307d |
+# define HAVE_WMEMSET_Z13 1
|
|
|
d8307d |
+#else
|
|
|
d8307d |
+# define WMEMSET_DEFAULT WMEMSET_C
|
|
|
d8307d |
+# define HAVE_WMEMSET_C 1
|
|
|
d8307d |
+# define HAVE_WMEMSET_Z13 HAVE_WMEMSET_IFUNC_AND_VX_SUPPORT
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
+
|
|
|
d8307d |
+#if HAVE_WMEMSET_C
|
|
|
d8307d |
+# define WMEMSET_C __wmemset_c
|
|
|
d8307d |
+#else
|
|
|
d8307d |
+# define WMEMSET_C NULL
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
+
|
|
|
d8307d |
+#if HAVE_WMEMSET_Z13
|
|
|
d8307d |
+# define WMEMSET_Z13 __wmemset_vx
|
|
|
d8307d |
+#else
|
|
|
d8307d |
+# define WMEMSET_Z13 NULL
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
diff --git a/sysdeps/s390/multiarch/Makefile b/sysdeps/s390/multiarch/Makefile
|
|
|
d8307d |
index 92e28dc45ddbae37..cc6dd7adb10ee8ad 100644
|
|
|
d8307d |
--- a/sysdeps/s390/multiarch/Makefile
|
|
|
d8307d |
+++ b/sysdeps/s390/multiarch/Makefile
|
|
|
d8307d |
@@ -1,6 +1,5 @@
|
|
|
d8307d |
ifeq ($(subdir),wcsmbs)
|
|
|
d8307d |
-sysdep_routines += wmemset wmemset-vx wmemset-c \
|
|
|
d8307d |
- wmemcmp wmemcmp-vx wmemcmp-c
|
|
|
d8307d |
+sysdep_routines += wmemcmp wmemcmp-vx wmemcmp-c
|
|
|
d8307d |
endif
|
|
|
d8307d |
|
|
|
d8307d |
ifeq ($(subdir),iconvdata)
|
|
|
d8307d |
diff --git a/sysdeps/s390/multiarch/ifunc-impl-list.c b/sysdeps/s390/multiarch/ifunc-impl-list.c
|
|
|
d8307d |
index b5f55deb7faae9c4..7040959269c1612b 100644
|
|
|
d8307d |
--- a/sysdeps/s390/multiarch/ifunc-impl-list.c
|
|
|
d8307d |
+++ b/sysdeps/s390/multiarch/ifunc-impl-list.c
|
|
|
d8307d |
@@ -63,6 +63,7 @@
|
|
|
d8307d |
#include <ifunc-wcspbrk.h>
|
|
|
d8307d |
#include <ifunc-wcscspn.h>
|
|
|
d8307d |
#include <ifunc-wmemchr.h>
|
|
|
d8307d |
+#include <ifunc-wmemset.h>
|
|
|
d8307d |
|
|
|
d8307d |
/* Maximum number of IFUNC implementations. */
|
|
|
d8307d |
#define MAX_IFUNC 3
|
|
|
d8307d |
@@ -645,6 +646,18 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
|
|
|
d8307d |
)
|
|
|
d8307d |
#endif /* HAVE_WMEMCHR_IFUNC */
|
|
|
d8307d |
|
|
|
d8307d |
+#if HAVE_WMEMSET_IFUNC
|
|
|
d8307d |
+ IFUNC_IMPL (i, name, wmemset,
|
|
|
d8307d |
+# if HAVE_WMEMSET_Z13
|
|
|
d8307d |
+ IFUNC_IMPL_ADD (array, i, wmemset,
|
|
|
d8307d |
+ dl_hwcap & HWCAP_S390_VX, WMEMSET_Z13)
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
+# if HAVE_WMEMSET_C
|
|
|
d8307d |
+ IFUNC_IMPL_ADD (array, i, wmemset, 1, WMEMSET_C)
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
+ )
|
|
|
d8307d |
+#endif /* HAVE_WMEMSET_IFUNC */
|
|
|
d8307d |
+
|
|
|
d8307d |
#ifdef HAVE_S390_VX_ASM_SUPPORT
|
|
|
d8307d |
|
|
|
d8307d |
# define IFUNC_VX_IMPL(FUNC) \
|
|
|
d8307d |
@@ -653,8 +666,6 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
|
|
|
d8307d |
__##FUNC##_vx) \
|
|
|
d8307d |
IFUNC_IMPL_ADD (array, i, FUNC, 1, __##FUNC##_c))
|
|
|
d8307d |
|
|
|
d8307d |
- IFUNC_VX_IMPL (wmemset);
|
|
|
d8307d |
-
|
|
|
d8307d |
IFUNC_VX_IMPL (wmemcmp);
|
|
|
d8307d |
|
|
|
d8307d |
#endif /* HAVE_S390_VX_ASM_SUPPORT */
|
|
|
d8307d |
diff --git a/sysdeps/s390/multiarch/wmemset-c.c b/sysdeps/s390/wmemset-c.c
|
|
|
d8307d |
similarity index 59%
|
|
|
d8307d |
rename from sysdeps/s390/multiarch/wmemset-c.c
|
|
|
d8307d |
rename to sysdeps/s390/wmemset-c.c
|
|
|
d8307d |
index 1969cf93dcf08892..01e625496d8c2e4e 100644
|
|
|
d8307d |
--- a/sysdeps/s390/multiarch/wmemset-c.c
|
|
|
d8307d |
+++ b/sysdeps/s390/wmemset-c.c
|
|
|
d8307d |
@@ -16,22 +16,29 @@
|
|
|
d8307d |
License along with the GNU C Library; if not, see
|
|
|
d8307d |
<http://www.gnu.org/licenses/>. */
|
|
|
d8307d |
|
|
|
d8307d |
-#if defined HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc)
|
|
|
d8307d |
-# define WMEMSET __wmemset_c
|
|
|
d8307d |
-
|
|
|
d8307d |
-# include <wchar.h>
|
|
|
d8307d |
-extern __typeof (__wmemset) __wmemset_c;
|
|
|
d8307d |
-# undef weak_alias
|
|
|
d8307d |
-# define weak_alias(name, alias)
|
|
|
d8307d |
-# ifdef SHARED
|
|
|
d8307d |
-# undef libc_hidden_def
|
|
|
d8307d |
-# define libc_hidden_def(name) \
|
|
|
d8307d |
- __hidden_ver1 (__wmemset_c, __GI___wmemset, __wmemset_c);
|
|
|
d8307d |
-# undef libc_hidden_weak
|
|
|
d8307d |
-# define libc_hidden_weak(name) \
|
|
|
d8307d |
+#include <ifunc-wmemset.h>
|
|
|
d8307d |
+
|
|
|
d8307d |
+#if HAVE_WMEMSET_C
|
|
|
d8307d |
+# if HAVE_WMEMSET_IFUNC || HAVE_WMEMSET_Z13
|
|
|
d8307d |
+# define WMEMSET WMEMSET_C
|
|
|
d8307d |
+
|
|
|
d8307d |
+# undef weak_alias
|
|
|
d8307d |
+# define weak_alias(name, alias)
|
|
|
d8307d |
+
|
|
|
d8307d |
+# if defined SHARED && IS_IN (libc)
|
|
|
d8307d |
+# undef libc_hidden_weak
|
|
|
d8307d |
+# define libc_hidden_weak(name)
|
|
|
d8307d |
+# undef libc_hidden_def
|
|
|
d8307d |
+# if ! defined HAVE_S390_MIN_Z13_ZARCH_ASM_SUPPORT
|
|
|
d8307d |
+# define libc_hidden_def(name) \
|
|
|
d8307d |
+ __hidden_ver1 (__wmemset_c, __GI_wmemset, __wmemset_c) __attribute__((weak)); \
|
|
|
d8307d |
strong_alias (__wmemset_c, __wmemset_c_1); \
|
|
|
d8307d |
- __hidden_ver1 (__wmemset_c_1, __GI_wmemset, __wmemset_c_1);
|
|
|
d8307d |
-# endif /* SHARED */
|
|
|
d8307d |
+ __hidden_ver1 (__wmemset_c_1, __GI___wmemset, __wmemset_c_1);
|
|
|
d8307d |
+# else
|
|
|
d8307d |
+# define libc_hidden_def(name)
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
|
|
|
d8307d |
# include <wcsmbs/wmemset.c>
|
|
|
d8307d |
-#endif /* HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc) */
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
diff --git a/sysdeps/s390/multiarch/wmemset-vx.S b/sysdeps/s390/wmemset-vx.S
|
|
|
d8307d |
similarity index 91%
|
|
|
d8307d |
rename from sysdeps/s390/multiarch/wmemset-vx.S
|
|
|
d8307d |
rename to sysdeps/s390/wmemset-vx.S
|
|
|
d8307d |
index 0c2f6337b0e554ec..4b6050b5accd732b 100644
|
|
|
d8307d |
--- a/sysdeps/s390/multiarch/wmemset-vx.S
|
|
|
d8307d |
+++ b/sysdeps/s390/wmemset-vx.S
|
|
|
d8307d |
@@ -16,7 +16,8 @@
|
|
|
d8307d |
License along with the GNU C Library; if not, see
|
|
|
d8307d |
<http://www.gnu.org/licenses/>. */
|
|
|
d8307d |
|
|
|
d8307d |
-#if defined HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc)
|
|
|
d8307d |
+#include <ifunc-wmemset.h>
|
|
|
d8307d |
+#if HAVE_WMEMSET_Z13
|
|
|
d8307d |
|
|
|
d8307d |
# include "sysdep.h"
|
|
|
d8307d |
# include "asm-syntax.h"
|
|
|
d8307d |
@@ -38,7 +39,7 @@
|
|
|
d8307d |
-v17,v18,v19=copy of v16 for vstm
|
|
|
d8307d |
-v31=saved dest for return
|
|
|
d8307d |
*/
|
|
|
d8307d |
-ENTRY(__wmemset_vx)
|
|
|
d8307d |
+ENTRY(WMEMSET_Z13)
|
|
|
d8307d |
.machine "z13"
|
|
|
d8307d |
.machinemode "zarch_nohighgprs"
|
|
|
d8307d |
|
|
|
d8307d |
@@ -137,6 +138,17 @@ ENTRY(__wmemset_vx)
|
|
|
d8307d |
br %r14
|
|
|
d8307d |
.Lfallback:
|
|
|
d8307d |
srlg %r4,%r4,2 /* Convert byte-count to character-count. */
|
|
|
d8307d |
- jg __wmemset_c
|
|
|
d8307d |
-END(__wmemset_vx)
|
|
|
d8307d |
-#endif /* HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc) */
|
|
|
d8307d |
+ jg WMEMSET_C
|
|
|
d8307d |
+END(WMEMSET_Z13)
|
|
|
d8307d |
+
|
|
|
d8307d |
+# if ! HAVE_WMEMSET_IFUNC
|
|
|
d8307d |
+strong_alias (WMEMSET_Z13, __wmemset)
|
|
|
d8307d |
+weak_alias (__wmemset, wmemset)
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
+
|
|
|
d8307d |
+# if defined HAVE_S390_MIN_Z13_ZARCH_ASM_SUPPORT \
|
|
|
d8307d |
+ && defined SHARED && IS_IN (libc)
|
|
|
d8307d |
+strong_alias (WMEMSET_Z13, __GI___wmemset)
|
|
|
d8307d |
+weak_alias (WMEMSET_Z13, __GI_wmemset)
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
diff --git a/sysdeps/s390/multiarch/wmemset.c b/sysdeps/s390/wmemset.c
|
|
|
d8307d |
similarity index 70%
|
|
|
d8307d |
rename from sysdeps/s390/multiarch/wmemset.c
|
|
|
d8307d |
rename to sysdeps/s390/wmemset.c
|
|
|
d8307d |
index 149b4814708d820a..6118754d1df71948 100644
|
|
|
d8307d |
--- a/sysdeps/s390/multiarch/wmemset.c
|
|
|
d8307d |
+++ b/sysdeps/s390/wmemset.c
|
|
|
d8307d |
@@ -16,7 +16,9 @@
|
|
|
d8307d |
License along with the GNU C Library; if not, see
|
|
|
d8307d |
<http://www.gnu.org/licenses/>. */
|
|
|
d8307d |
|
|
|
d8307d |
-#if defined HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc)
|
|
|
d8307d |
+#include <ifunc-wmemset.h>
|
|
|
d8307d |
+
|
|
|
d8307d |
+#if HAVE_WMEMSET_IFUNC
|
|
|
d8307d |
# define wmemset __redirect_wmemset
|
|
|
d8307d |
# define __wmemset __redirect___wmemset
|
|
|
d8307d |
# include <wchar.h>
|
|
|
d8307d |
@@ -24,9 +26,18 @@
|
|
|
d8307d |
# undef __wmemset
|
|
|
d8307d |
# include <ifunc-resolve.h>
|
|
|
d8307d |
|
|
|
d8307d |
-s390_vx_libc_ifunc_redirected (__redirect___wmemset, __wmemset)
|
|
|
d8307d |
-weak_alias (__wmemset, wmemset)
|
|
|
d8307d |
+# if HAVE_WMEMSET_C
|
|
|
d8307d |
+extern __typeof (__redirect___wmemset) WMEMSET_C attribute_hidden;
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
|
|
|
d8307d |
-#else
|
|
|
d8307d |
-# include <wcsmbs/wmemset.c>
|
|
|
d8307d |
-#endif /* !(defined HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc)) */
|
|
|
d8307d |
+# if HAVE_WMEMSET_Z13
|
|
|
d8307d |
+extern __typeof (__redirect___wmemset) WMEMSET_Z13 attribute_hidden;
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
+
|
|
|
d8307d |
+s390_libc_ifunc_expr (__redirect___wmemset, __wmemset,
|
|
|
d8307d |
+ (HAVE_WMEMSET_Z13 && (hwcap & HWCAP_S390_VX))
|
|
|
d8307d |
+ ? WMEMSET_Z13
|
|
|
d8307d |
+ : WMEMSET_DEFAULT
|
|
|
d8307d |
+ )
|
|
|
d8307d |
+weak_alias (__wmemset, wmemset)
|
|
|
d8307d |
+#endif
|