|
 |
d8307d |
commit c62534ae524111eae48b2c2adf3f9a2ca90824f5
|
|
|
d8307d |
Author: Stefan Liebler <stli@linux.ibm.com>
|
|
|
d8307d |
Date: Tue Dec 18 13:57:24 2018 +0100
|
|
|
d8307d |
|
|
|
d8307d |
S390: Refactor wmemchr ifunc handling.
|
|
|
d8307d |
|
|
|
d8307d |
The ifunc handling for wmemchr is adjusted in order to omit ifunc
|
|
|
d8307d |
if the minimum architecture level already supports newer CPUs by default.
|
|
|
d8307d |
Unfortunately the c ifunc variant can't be omitted at all as it is used
|
|
|
d8307d |
by the z13 ifunc variant as fallback if the pointers are not 4-byte aligned.
|
|
|
d8307d |
Glibc internal calls will use the "newer" ifunc variant.
|
|
|
d8307d |
|
|
|
d8307d |
ChangeLog:
|
|
|
d8307d |
|
|
|
d8307d |
* sysdeps/s390/multiarch/Makefile
|
|
|
d8307d |
(sysdep_routines): Remove wmemchr variants.
|
|
|
d8307d |
* sysdeps/s390/Makefile (sysdep_routines): Add wmemchr variants.
|
|
|
d8307d |
* sysdeps/s390/multiarch/ifunc-impl-list.c
|
|
|
d8307d |
(__libc_ifunc_impl_list): Refactor ifunc handling for wmemchr.
|
|
|
d8307d |
* sysdeps/s390/multiarch/wmemchr-c.c: Move to ...
|
|
|
d8307d |
* sysdeps/s390/wmemchr-c.c: ... here and adjust ifunc handling.
|
|
|
d8307d |
* sysdeps/s390/multiarch/wmemchr-vx.S: Move to ...
|
|
|
d8307d |
* sysdeps/s390/wmemchr-vx.S: ... here and adjust ifunc handling.
|
|
|
d8307d |
* sysdeps/s390/multiarch/wmemchr.c: Move to ...
|
|
|
d8307d |
* sysdeps/s390/wmemchr.c: ... here and adjust ifunc handling.
|
|
|
d8307d |
* sysdeps/s390/ifunc-wmemchr.h: New file.
|
|
|
d8307d |
|
|
|
d8307d |
diff --git a/sysdeps/s390/Makefile b/sysdeps/s390/Makefile
|
|
|
d8307d |
index da96ac3a36bd7f4e..fdfd1c605c28ddc7 100644
|
|
|
d8307d |
--- a/sysdeps/s390/Makefile
|
|
|
d8307d |
+++ b/sysdeps/s390/Makefile
|
|
|
d8307d |
@@ -75,5 +75,6 @@ sysdep_routines += wcslen wcslen-vx wcslen-c \
|
|
|
d8307d |
wcsrchr wcsrchr-vx wcsrchr-c \
|
|
|
d8307d |
wcsspn wcsspn-vx wcsspn-c \
|
|
|
d8307d |
wcspbrk wcspbrk-vx wcspbrk-c \
|
|
|
d8307d |
- wcscspn wcscspn-vx wcscspn-c
|
|
|
d8307d |
+ wcscspn wcscspn-vx wcscspn-c \
|
|
|
d8307d |
+ wmemchr wmemchr-vx wmemchr-c
|
|
|
d8307d |
endif
|
|
|
d8307d |
diff --git a/sysdeps/s390/ifunc-wmemchr.h b/sysdeps/s390/ifunc-wmemchr.h
|
|
|
d8307d |
new file mode 100644
|
|
|
d8307d |
index 0000000000000000..0610cfb5d4a7fb18
|
|
|
d8307d |
--- /dev/null
|
|
|
d8307d |
+++ b/sysdeps/s390/ifunc-wmemchr.h
|
|
|
d8307d |
@@ -0,0 +1,53 @@
|
|
|
d8307d |
+/* wmemchr variant information on S/390 version.
|
|
|
d8307d |
+ Copyright (C) 2018 Free Software Foundation, Inc.
|
|
|
d8307d |
+ This file is part of the GNU C Library.
|
|
|
d8307d |
+
|
|
|
d8307d |
+ The GNU C Library is free software; you can redistribute it and/or
|
|
|
d8307d |
+ modify it under the terms of the GNU Lesser General Public
|
|
|
d8307d |
+ License as published by the Free Software Foundation; either
|
|
|
d8307d |
+ version 2.1 of the License, or (at your option) any later version.
|
|
|
d8307d |
+
|
|
|
d8307d |
+ The GNU C Library is distributed in the hope that it will be useful,
|
|
|
d8307d |
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
d8307d |
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
d8307d |
+ Lesser General Public License for more details.
|
|
|
d8307d |
+
|
|
|
d8307d |
+ You should have received a copy of the GNU Lesser General Public
|
|
|
d8307d |
+ License along with the GNU C Library; if not, see
|
|
|
d8307d |
+ <http://www.gnu.org/licenses/>. */
|
|
|
d8307d |
+
|
|
|
d8307d |
+#if defined USE_MULTIARCH && IS_IN (libc) \
|
|
|
d8307d |
+ && ! defined HAVE_S390_MIN_Z13_ZARCH_ASM_SUPPORT
|
|
|
d8307d |
+# define HAVE_WMEMCHR_IFUNC 1
|
|
|
d8307d |
+#else
|
|
|
d8307d |
+# define HAVE_WMEMCHR_IFUNC 0
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
+
|
|
|
d8307d |
+#ifdef HAVE_S390_VX_ASM_SUPPORT
|
|
|
d8307d |
+# define HAVE_WMEMCHR_IFUNC_AND_VX_SUPPORT HAVE_WMEMCHR_IFUNC
|
|
|
d8307d |
+#else
|
|
|
d8307d |
+# define HAVE_WMEMCHR_IFUNC_AND_VX_SUPPORT 0
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
+
|
|
|
d8307d |
+#if defined HAVE_S390_MIN_Z13_ZARCH_ASM_SUPPORT
|
|
|
d8307d |
+# define WMEMCHR_DEFAULT WMEMCHR_Z13
|
|
|
d8307d |
+/* The z13 ifunc variant is using the common code variant as fallback! */
|
|
|
d8307d |
+# define HAVE_WMEMCHR_C 1
|
|
|
d8307d |
+# define HAVE_WMEMCHR_Z13 1
|
|
|
d8307d |
+#else
|
|
|
d8307d |
+# define WMEMCHR_DEFAULT WMEMCHR_C
|
|
|
d8307d |
+# define HAVE_WMEMCHR_C 1
|
|
|
d8307d |
+# define HAVE_WMEMCHR_Z13 HAVE_WMEMCHR_IFUNC_AND_VX_SUPPORT
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
+
|
|
|
d8307d |
+#if HAVE_WMEMCHR_C
|
|
|
d8307d |
+# define WMEMCHR_C __wmemchr_c
|
|
|
d8307d |
+#else
|
|
|
d8307d |
+# define WMEMCHR_C NULL
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
+
|
|
|
d8307d |
+#if HAVE_WMEMCHR_Z13
|
|
|
d8307d |
+# define WMEMCHR_Z13 __wmemchr_vx
|
|
|
d8307d |
+#else
|
|
|
d8307d |
+# define WMEMCHR_Z13 NULL
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
diff --git a/sysdeps/s390/multiarch/Makefile b/sysdeps/s390/multiarch/Makefile
|
|
|
d8307d |
index 5be635542361b355..92e28dc45ddbae37 100644
|
|
|
d8307d |
--- a/sysdeps/s390/multiarch/Makefile
|
|
|
d8307d |
+++ b/sysdeps/s390/multiarch/Makefile
|
|
|
d8307d |
@@ -1,6 +1,5 @@
|
|
|
d8307d |
ifeq ($(subdir),wcsmbs)
|
|
|
d8307d |
-sysdep_routines += wmemchr wmemchr-vx wmemchr-c \
|
|
|
d8307d |
- wmemset wmemset-vx wmemset-c \
|
|
|
d8307d |
+sysdep_routines += wmemset wmemset-vx wmemset-c \
|
|
|
d8307d |
wmemcmp wmemcmp-vx wmemcmp-c
|
|
|
d8307d |
endif
|
|
|
d8307d |
|
|
|
d8307d |
diff --git a/sysdeps/s390/multiarch/ifunc-impl-list.c b/sysdeps/s390/multiarch/ifunc-impl-list.c
|
|
|
d8307d |
index 7d8031a069bd23ba..b5f55deb7faae9c4 100644
|
|
|
d8307d |
--- a/sysdeps/s390/multiarch/ifunc-impl-list.c
|
|
|
d8307d |
+++ b/sysdeps/s390/multiarch/ifunc-impl-list.c
|
|
|
d8307d |
@@ -62,6 +62,7 @@
|
|
|
d8307d |
#include <ifunc-wcsspn.h>
|
|
|
d8307d |
#include <ifunc-wcspbrk.h>
|
|
|
d8307d |
#include <ifunc-wcscspn.h>
|
|
|
d8307d |
+#include <ifunc-wmemchr.h>
|
|
|
d8307d |
|
|
|
d8307d |
/* Maximum number of IFUNC implementations. */
|
|
|
d8307d |
#define MAX_IFUNC 3
|
|
|
d8307d |
@@ -632,6 +633,18 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
|
|
|
d8307d |
)
|
|
|
d8307d |
#endif /* HAVE_WCSCSPN_IFUNC */
|
|
|
d8307d |
|
|
|
d8307d |
+#if HAVE_WMEMCHR_IFUNC
|
|
|
d8307d |
+ IFUNC_IMPL (i, name, wmemchr,
|
|
|
d8307d |
+# if HAVE_WMEMCHR_Z13
|
|
|
d8307d |
+ IFUNC_IMPL_ADD (array, i, wmemchr,
|
|
|
d8307d |
+ dl_hwcap & HWCAP_S390_VX, WMEMCHR_Z13)
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
+# if HAVE_WMEMCHR_C
|
|
|
d8307d |
+ IFUNC_IMPL_ADD (array, i, wmemchr, 1, WMEMCHR_C)
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
+ )
|
|
|
d8307d |
+#endif /* HAVE_WMEMCHR_IFUNC */
|
|
|
d8307d |
+
|
|
|
d8307d |
#ifdef HAVE_S390_VX_ASM_SUPPORT
|
|
|
d8307d |
|
|
|
d8307d |
# define IFUNC_VX_IMPL(FUNC) \
|
|
|
d8307d |
@@ -640,8 +653,6 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
|
|
|
d8307d |
__##FUNC##_vx) \
|
|
|
d8307d |
IFUNC_IMPL_ADD (array, i, FUNC, 1, __##FUNC##_c))
|
|
|
d8307d |
|
|
|
d8307d |
- IFUNC_VX_IMPL (wmemchr);
|
|
|
d8307d |
-
|
|
|
d8307d |
IFUNC_VX_IMPL (wmemset);
|
|
|
d8307d |
|
|
|
d8307d |
IFUNC_VX_IMPL (wmemcmp);
|
|
|
d8307d |
diff --git a/sysdeps/s390/multiarch/wmemchr-c.c b/sysdeps/s390/wmemchr-c.c
|
|
|
d8307d |
similarity index 59%
|
|
|
d8307d |
rename from sysdeps/s390/multiarch/wmemchr-c.c
|
|
|
d8307d |
rename to sysdeps/s390/wmemchr-c.c
|
|
|
d8307d |
index 089392b512d29187..bb2526e76c41d0c7 100644
|
|
|
d8307d |
--- a/sysdeps/s390/multiarch/wmemchr-c.c
|
|
|
d8307d |
+++ b/sysdeps/s390/wmemchr-c.c
|
|
|
d8307d |
@@ -16,22 +16,29 @@
|
|
|
d8307d |
License along with the GNU C Library; if not, see
|
|
|
d8307d |
<http://www.gnu.org/licenses/>. */
|
|
|
d8307d |
|
|
|
d8307d |
-#if defined HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc)
|
|
|
d8307d |
-# define WMEMCHR __wmemchr_c
|
|
|
d8307d |
-
|
|
|
d8307d |
-# include <wchar.h>
|
|
|
d8307d |
-extern __typeof (wmemchr) __wmemchr_c;
|
|
|
d8307d |
-# undef weak_alias
|
|
|
d8307d |
-# define weak_alias(name, alias)
|
|
|
d8307d |
-# ifdef SHARED
|
|
|
d8307d |
-# undef libc_hidden_def
|
|
|
d8307d |
-# define libc_hidden_def(name) \
|
|
|
d8307d |
- __hidden_ver1 (__wmemchr_c, __GI___wmemchr, __wmemchr_c);
|
|
|
d8307d |
-# undef libc_hidden_weak
|
|
|
d8307d |
-# define libc_hidden_weak(name) \
|
|
|
d8307d |
+#include <ifunc-wmemchr.h>
|
|
|
d8307d |
+
|
|
|
d8307d |
+#if HAVE_WMEMCHR_C
|
|
|
d8307d |
+# if HAVE_WMEMCHR_IFUNC || HAVE_WMEMCHR_Z13
|
|
|
d8307d |
+# define WMEMCHR WMEMCHR_C
|
|
|
d8307d |
+
|
|
|
d8307d |
+# undef weak_alias
|
|
|
d8307d |
+# define weak_alias(name, alias)
|
|
|
d8307d |
+
|
|
|
d8307d |
+# if defined SHARED && IS_IN (libc)
|
|
|
d8307d |
+# undef libc_hidden_weak
|
|
|
d8307d |
+# define libc_hidden_weak(name)
|
|
|
d8307d |
+# undef libc_hidden_def
|
|
|
d8307d |
+# if ! defined HAVE_S390_MIN_Z13_ZARCH_ASM_SUPPORT
|
|
|
d8307d |
+# define libc_hidden_def(name) \
|
|
|
d8307d |
+ __hidden_ver1 (__wmemchr_c, __GI_wmemchr, __wmemchr_c) __attribute__((weak)); \
|
|
|
d8307d |
strong_alias (__wmemchr_c, __wmemchr_c_1); \
|
|
|
d8307d |
- __hidden_ver1 (__wmemchr_c_1, __GI_wmemchr, __wmemchr_c_1);
|
|
|
d8307d |
-# endif /* SHARED */
|
|
|
d8307d |
+ __hidden_ver1 (__wmemchr_c_1, __GI___wmemchr, __wmemchr_c_1);
|
|
|
d8307d |
+# else
|
|
|
d8307d |
+# define libc_hidden_def(name)
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
|
|
|
d8307d |
# include <wcsmbs/wmemchr.c>
|
|
|
d8307d |
-#endif /* HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc) */
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
diff --git a/sysdeps/s390/multiarch/wmemchr-vx.S b/sysdeps/s390/wmemchr-vx.S
|
|
|
d8307d |
similarity index 92%
|
|
|
d8307d |
rename from sysdeps/s390/multiarch/wmemchr-vx.S
|
|
|
d8307d |
rename to sysdeps/s390/wmemchr-vx.S
|
|
|
d8307d |
index db057b579a7230f0..72e9ef59af77b8f7 100644
|
|
|
d8307d |
--- a/sysdeps/s390/multiarch/wmemchr-vx.S
|
|
|
d8307d |
+++ b/sysdeps/s390/wmemchr-vx.S
|
|
|
d8307d |
@@ -16,7 +16,8 @@
|
|
|
d8307d |
License along with the GNU C Library; if not, see
|
|
|
d8307d |
<http://www.gnu.org/licenses/>. */
|
|
|
d8307d |
|
|
|
d8307d |
-#if defined HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc)
|
|
|
d8307d |
+#include <ifunc-wmemchr.h>
|
|
|
d8307d |
+#if HAVE_WMEMCHR_Z13
|
|
|
d8307d |
|
|
|
d8307d |
# include "sysdep.h"
|
|
|
d8307d |
# include "asm-syntax.h"
|
|
|
d8307d |
@@ -38,7 +39,7 @@
|
|
|
d8307d |
-v17=index of found c
|
|
|
d8307d |
-v18=c replicated
|
|
|
d8307d |
*/
|
|
|
d8307d |
-ENTRY(__wmemchr_vx)
|
|
|
d8307d |
+ENTRY(WMEMCHR_Z13)
|
|
|
d8307d |
.machine "z13"
|
|
|
d8307d |
.machinemode "zarch_nohighgprs"
|
|
|
d8307d |
|
|
|
d8307d |
@@ -161,6 +162,17 @@ ENTRY(__wmemchr_vx)
|
|
|
d8307d |
|
|
|
d8307d |
j .Llt64
|
|
|
d8307d |
.Lfallback:
|
|
|
d8307d |
- jg __wmemchr_c
|
|
|
d8307d |
-END(__wmemchr_vx)
|
|
|
d8307d |
-#endif /* HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc) */
|
|
|
d8307d |
+ jg WMEMCHR_C
|
|
|
d8307d |
+END(WMEMCHR_Z13)
|
|
|
d8307d |
+
|
|
|
d8307d |
+# if ! HAVE_WMEMCHR_IFUNC
|
|
|
d8307d |
+strong_alias (WMEMCHR_Z13, __wmemchr)
|
|
|
d8307d |
+weak_alias (__wmemchr, wmemchr)
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
+
|
|
|
d8307d |
+# if defined HAVE_S390_MIN_Z13_ZARCH_ASM_SUPPORT \
|
|
|
d8307d |
+ && defined SHARED && IS_IN (libc)
|
|
|
d8307d |
+strong_alias (WMEMCHR_Z13, __GI___wmemchr)
|
|
|
d8307d |
+weak_alias (WMEMCHR_Z13, __GI_wmemchr)
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
diff --git a/sysdeps/s390/multiarch/wmemchr.c b/sysdeps/s390/wmemchr.c
|
|
|
d8307d |
similarity index 70%
|
|
|
d8307d |
rename from sysdeps/s390/multiarch/wmemchr.c
|
|
|
d8307d |
rename to sysdeps/s390/wmemchr.c
|
|
|
d8307d |
index 6b55c1d7fa10afb9..0d2fbb22c6d65a97 100644
|
|
|
d8307d |
--- a/sysdeps/s390/multiarch/wmemchr.c
|
|
|
d8307d |
+++ b/sysdeps/s390/wmemchr.c
|
|
|
d8307d |
@@ -16,7 +16,9 @@
|
|
|
d8307d |
License along with the GNU C Library; if not, see
|
|
|
d8307d |
<http://www.gnu.org/licenses/>. */
|
|
|
d8307d |
|
|
|
d8307d |
-#if defined HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc)
|
|
|
d8307d |
+#include <ifunc-wmemchr.h>
|
|
|
d8307d |
+
|
|
|
d8307d |
+#if HAVE_WMEMCHR_IFUNC
|
|
|
d8307d |
# define wmemchr __redirect_wmemchr
|
|
|
d8307d |
# define __wmemchr __redirect___wmemchr
|
|
|
d8307d |
# include <wchar.h>
|
|
|
d8307d |
@@ -24,9 +26,18 @@
|
|
|
d8307d |
# undef __wmemchr
|
|
|
d8307d |
# include <ifunc-resolve.h>
|
|
|
d8307d |
|
|
|
d8307d |
-s390_vx_libc_ifunc_redirected (__redirect___wmemchr, __wmemchr)
|
|
|
d8307d |
-weak_alias (__wmemchr, wmemchr)
|
|
|
d8307d |
+# if HAVE_WMEMCHR_C
|
|
|
d8307d |
+extern __typeof (__redirect___wmemchr) WMEMCHR_C attribute_hidden;
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
|
|
|
d8307d |
-#else
|
|
|
d8307d |
-# include <wcsmbs/wmemchr.c>
|
|
|
d8307d |
-#endif /* !(defined HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc)) */
|
|
|
d8307d |
+# if HAVE_WMEMCHR_Z13
|
|
|
d8307d |
+extern __typeof (__redirect___wmemchr) WMEMCHR_Z13 attribute_hidden;
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
+
|
|
|
d8307d |
+s390_libc_ifunc_expr (__redirect___wmemchr, __wmemchr,
|
|
|
d8307d |
+ (HAVE_WMEMCHR_Z13 && (hwcap & HWCAP_S390_VX))
|
|
|
d8307d |
+ ? WMEMCHR_Z13
|
|
|
d8307d |
+ : WMEMCHR_DEFAULT
|
|
|
d8307d |
+ )
|
|
|
d8307d |
+weak_alias (__wmemchr, wmemchr)
|
|
|
d8307d |
+#endif
|