|
 |
d8307d |
commit 8e87c1f6d45a63dc2175825c2dc5d66192a13aab
|
|
|
d8307d |
Author: Stefan Liebler <stli@linux.ibm.com>
|
|
|
d8307d |
Date: Tue Dec 18 13:57:23 2018 +0100
|
|
|
d8307d |
|
|
|
d8307d |
S390: Refactor wcspbrk ifunc handling.
|
|
|
d8307d |
|
|
|
d8307d |
The ifunc handling for wcspbrk is adjusted in order to omit ifunc
|
|
|
d8307d |
if the minimum architecture level already supports newer CPUs by default.
|
|
|
d8307d |
Unfortunately the c ifunc variant can't be omitted at all as it is used
|
|
|
d8307d |
by the z13 ifunc variant as fallback if the pointers are not 4-byte aligned.
|
|
|
d8307d |
Glibc internal calls will use the "newer" ifunc variant.
|
|
|
d8307d |
|
|
|
d8307d |
ChangeLog:
|
|
|
d8307d |
|
|
|
d8307d |
* sysdeps/s390/multiarch/Makefile
|
|
|
d8307d |
(sysdep_routines): Remove wcspbrk variants.
|
|
|
d8307d |
* sysdeps/s390/Makefile (sysdep_routines): Add wcspbrk variants.
|
|
|
d8307d |
* sysdeps/s390/multiarch/ifunc-impl-list.c
|
|
|
d8307d |
(__libc_ifunc_impl_list): Refactor ifunc handling for wcspbrk.
|
|
|
d8307d |
* sysdeps/s390/multiarch/wcspbrk-c.c: Move to ...
|
|
|
d8307d |
* sysdeps/s390/wcspbrk-c.c: ... here and adjust ifunc handling.
|
|
|
d8307d |
* sysdeps/s390/multiarch/wcspbrk-vx.S: Move to ...
|
|
|
d8307d |
* sysdeps/s390/wcspbrk-vx.S: ... here and adjust ifunc handling.
|
|
|
d8307d |
* sysdeps/s390/multiarch/wcspbrk.c: Move to ...
|
|
|
d8307d |
* sysdeps/s390/wcspbrk.c: ... here and adjust ifunc handling.
|
|
|
d8307d |
* sysdeps/s390/ifunc-wcspbrk.h: New file.
|
|
|
d8307d |
|
|
|
d8307d |
diff --git a/sysdeps/s390/Makefile b/sysdeps/s390/Makefile
|
|
|
d8307d |
index 38dbba8ccfd3cd66..af595050d43c63ed 100644
|
|
|
d8307d |
--- a/sysdeps/s390/Makefile
|
|
|
d8307d |
+++ b/sysdeps/s390/Makefile
|
|
|
d8307d |
@@ -73,5 +73,6 @@ sysdep_routines += wcslen wcslen-vx wcslen-c \
|
|
|
d8307d |
wcschr wcschr-vx wcschr-c \
|
|
|
d8307d |
wcschrnul wcschrnul-vx wcschrnul-c \
|
|
|
d8307d |
wcsrchr wcsrchr-vx wcsrchr-c \
|
|
|
d8307d |
- wcsspn wcsspn-vx wcsspn-c
|
|
|
d8307d |
+ wcsspn wcsspn-vx wcsspn-c \
|
|
|
d8307d |
+ wcspbrk wcspbrk-vx wcspbrk-c
|
|
|
d8307d |
endif
|
|
|
d8307d |
diff --git a/sysdeps/s390/ifunc-wcspbrk.h b/sysdeps/s390/ifunc-wcspbrk.h
|
|
|
d8307d |
new file mode 100644
|
|
|
d8307d |
index 0000000000000000..d3b9b7363a73fab0
|
|
|
d8307d |
--- /dev/null
|
|
|
d8307d |
+++ b/sysdeps/s390/ifunc-wcspbrk.h
|
|
|
d8307d |
@@ -0,0 +1,53 @@
|
|
|
d8307d |
+/* wcspbrk variant information on S/390 version.
|
|
|
d8307d |
+ Copyright (C) 2018 Free Software Foundation, Inc.
|
|
|
d8307d |
+ This file is part of the GNU C Library.
|
|
|
d8307d |
+
|
|
|
d8307d |
+ The GNU C Library is free software; you can redistribute it and/or
|
|
|
d8307d |
+ modify it under the terms of the GNU Lesser General Public
|
|
|
d8307d |
+ License as published by the Free Software Foundation; either
|
|
|
d8307d |
+ version 2.1 of the License, or (at your option) any later version.
|
|
|
d8307d |
+
|
|
|
d8307d |
+ The GNU C Library is distributed in the hope that it will be useful,
|
|
|
d8307d |
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
d8307d |
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
d8307d |
+ Lesser General Public License for more details.
|
|
|
d8307d |
+
|
|
|
d8307d |
+ You should have received a copy of the GNU Lesser General Public
|
|
|
d8307d |
+ License along with the GNU C Library; if not, see
|
|
|
d8307d |
+ <http://www.gnu.org/licenses/>. */
|
|
|
d8307d |
+
|
|
|
d8307d |
+#if defined USE_MULTIARCH && IS_IN (libc) \
|
|
|
d8307d |
+ && ! defined HAVE_S390_MIN_Z13_ZARCH_ASM_SUPPORT
|
|
|
d8307d |
+# define HAVE_WCSPBRK_IFUNC 1
|
|
|
d8307d |
+#else
|
|
|
d8307d |
+# define HAVE_WCSPBRK_IFUNC 0
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
+
|
|
|
d8307d |
+#ifdef HAVE_S390_VX_ASM_SUPPORT
|
|
|
d8307d |
+# define HAVE_WCSPBRK_IFUNC_AND_VX_SUPPORT HAVE_WCSPBRK_IFUNC
|
|
|
d8307d |
+#else
|
|
|
d8307d |
+# define HAVE_WCSPBRK_IFUNC_AND_VX_SUPPORT 0
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
+
|
|
|
d8307d |
+#if defined HAVE_S390_MIN_Z13_ZARCH_ASM_SUPPORT
|
|
|
d8307d |
+# define WCSPBRK_DEFAULT WCSPBRK_Z13
|
|
|
d8307d |
+/* The z13 ifunc variant is using the common code variant as fallback! */
|
|
|
d8307d |
+# define HAVE_WCSPBRK_C 1
|
|
|
d8307d |
+# define HAVE_WCSPBRK_Z13 1
|
|
|
d8307d |
+#else
|
|
|
d8307d |
+# define WCSPBRK_DEFAULT WCSPBRK_C
|
|
|
d8307d |
+# define HAVE_WCSPBRK_C 1
|
|
|
d8307d |
+# define HAVE_WCSPBRK_Z13 HAVE_WCSPBRK_IFUNC_AND_VX_SUPPORT
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
+
|
|
|
d8307d |
+#if HAVE_WCSPBRK_C
|
|
|
d8307d |
+# define WCSPBRK_C __wcspbrk_c
|
|
|
d8307d |
+#else
|
|
|
d8307d |
+# define WCSPBRK_C NULL
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
+
|
|
|
d8307d |
+#if HAVE_WCSPBRK_Z13
|
|
|
d8307d |
+# define WCSPBRK_Z13 __wcspbrk_vx
|
|
|
d8307d |
+#else
|
|
|
d8307d |
+# define WCSPBRK_Z13 NULL
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
diff --git a/sysdeps/s390/multiarch/Makefile b/sysdeps/s390/multiarch/Makefile
|
|
|
d8307d |
index 091f5150847a404a..e1e2d9dc7495ebdc 100644
|
|
|
d8307d |
--- a/sysdeps/s390/multiarch/Makefile
|
|
|
d8307d |
+++ b/sysdeps/s390/multiarch/Makefile
|
|
|
d8307d |
@@ -1,6 +1,5 @@
|
|
|
d8307d |
ifeq ($(subdir),wcsmbs)
|
|
|
d8307d |
-sysdep_routines += wcspbrk wcspbrk-vx wcspbrk-c \
|
|
|
d8307d |
- wcscspn wcscspn-vx wcscspn-c \
|
|
|
d8307d |
+sysdep_routines += wcscspn wcscspn-vx wcscspn-c \
|
|
|
d8307d |
wmemchr wmemchr-vx wmemchr-c \
|
|
|
d8307d |
wmemset wmemset-vx wmemset-c \
|
|
|
d8307d |
wmemcmp wmemcmp-vx wmemcmp-c
|
|
|
d8307d |
diff --git a/sysdeps/s390/multiarch/ifunc-impl-list.c b/sysdeps/s390/multiarch/ifunc-impl-list.c
|
|
|
d8307d |
index 6f4de2845ba0a378..89d6e8ad7e323fec 100644
|
|
|
d8307d |
--- a/sysdeps/s390/multiarch/ifunc-impl-list.c
|
|
|
d8307d |
+++ b/sysdeps/s390/multiarch/ifunc-impl-list.c
|
|
|
d8307d |
@@ -60,6 +60,7 @@
|
|
|
d8307d |
#include <ifunc-wcschrnul.h>
|
|
|
d8307d |
#include <ifunc-wcsrchr.h>
|
|
|
d8307d |
#include <ifunc-wcsspn.h>
|
|
|
d8307d |
+#include <ifunc-wcspbrk.h>
|
|
|
d8307d |
|
|
|
d8307d |
/* Maximum number of IFUNC implementations. */
|
|
|
d8307d |
#define MAX_IFUNC 3
|
|
|
d8307d |
@@ -606,6 +607,18 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
|
|
|
d8307d |
)
|
|
|
d8307d |
#endif /* HAVE_WCSSPN_IFUNC */
|
|
|
d8307d |
|
|
|
d8307d |
+#if HAVE_WCSPBRK_IFUNC
|
|
|
d8307d |
+ IFUNC_IMPL (i, name, wcspbrk,
|
|
|
d8307d |
+# if HAVE_WCSPBRK_Z13
|
|
|
d8307d |
+ IFUNC_IMPL_ADD (array, i, wcspbrk,
|
|
|
d8307d |
+ dl_hwcap & HWCAP_S390_VX, WCSPBRK_Z13)
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
+# if HAVE_WCSPBRK_C
|
|
|
d8307d |
+ IFUNC_IMPL_ADD (array, i, wcspbrk, 1, WCSPBRK_C)
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
+ )
|
|
|
d8307d |
+#endif /* HAVE_WCSPBRK_IFUNC */
|
|
|
d8307d |
+
|
|
|
d8307d |
#ifdef HAVE_S390_VX_ASM_SUPPORT
|
|
|
d8307d |
|
|
|
d8307d |
# define IFUNC_VX_IMPL(FUNC) \
|
|
|
d8307d |
@@ -614,8 +627,6 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
|
|
|
d8307d |
__##FUNC##_vx) \
|
|
|
d8307d |
IFUNC_IMPL_ADD (array, i, FUNC, 1, __##FUNC##_c))
|
|
|
d8307d |
|
|
|
d8307d |
- IFUNC_VX_IMPL (wcspbrk);
|
|
|
d8307d |
-
|
|
|
d8307d |
IFUNC_VX_IMPL (wcscspn);
|
|
|
d8307d |
|
|
|
d8307d |
IFUNC_VX_IMPL (wmemchr);
|
|
|
d8307d |
diff --git a/sysdeps/s390/multiarch/wcspbrk-c.c b/sysdeps/s390/wcspbrk-c.c
|
|
|
d8307d |
similarity index 72%
|
|
|
d8307d |
rename from sysdeps/s390/multiarch/wcspbrk-c.c
|
|
|
d8307d |
rename to sysdeps/s390/wcspbrk-c.c
|
|
|
d8307d |
index 6b6e7aade46942ed..e79c6a85503dc32b 100644
|
|
|
d8307d |
--- a/sysdeps/s390/multiarch/wcspbrk-c.c
|
|
|
d8307d |
+++ b/sysdeps/s390/wcspbrk-c.c
|
|
|
d8307d |
@@ -16,16 +16,22 @@
|
|
|
d8307d |
License along with the GNU C Library; if not, see
|
|
|
d8307d |
<http://www.gnu.org/licenses/>. */
|
|
|
d8307d |
|
|
|
d8307d |
-#if defined HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc)
|
|
|
d8307d |
-# define WCSPBRK __wcspbrk_c
|
|
|
d8307d |
+#include <ifunc-wcspbrk.h>
|
|
|
d8307d |
|
|
|
d8307d |
-# include <wchar.h>
|
|
|
d8307d |
-extern __typeof (wcspbrk) __wcspbrk_c;
|
|
|
d8307d |
-# ifdef SHARED
|
|
|
d8307d |
-# undef libc_hidden_def
|
|
|
d8307d |
-# define libc_hidden_def(name) \
|
|
|
d8307d |
+#if HAVE_WCSPBRK_C
|
|
|
d8307d |
+# if HAVE_WCSPBRK_IFUNC || HAVE_WCSPBRK_Z13
|
|
|
d8307d |
+# define WCSPBRK WCSPBRK_C
|
|
|
d8307d |
+
|
|
|
d8307d |
+# if defined SHARED && IS_IN (libc)
|
|
|
d8307d |
+# undef libc_hidden_def
|
|
|
d8307d |
+# if ! defined HAVE_S390_MIN_Z13_ZARCH_ASM_SUPPORT
|
|
|
d8307d |
+# define libc_hidden_def(name) \
|
|
|
d8307d |
__hidden_ver1 (__wcspbrk_c, __GI_wcspbrk, __wcspbrk_c);
|
|
|
d8307d |
-# endif /* SHARED */
|
|
|
d8307d |
+# else
|
|
|
d8307d |
+# define libc_hidden_def(name)
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
|
|
|
d8307d |
# include <wcsmbs/wcspbrk.c>
|
|
|
d8307d |
-#endif /* HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc) */
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
diff --git a/sysdeps/s390/multiarch/wcspbrk-vx.S b/sysdeps/s390/wcspbrk-vx.S
|
|
|
d8307d |
similarity index 97%
|
|
|
d8307d |
rename from sysdeps/s390/multiarch/wcspbrk-vx.S
|
|
|
d8307d |
rename to sysdeps/s390/wcspbrk-vx.S
|
|
|
d8307d |
index 5c89ec5d336c1acd..5870c4684d140ab0 100644
|
|
|
d8307d |
--- a/sysdeps/s390/multiarch/wcspbrk-vx.S
|
|
|
d8307d |
+++ b/sysdeps/s390/wcspbrk-vx.S
|
|
|
d8307d |
@@ -16,7 +16,8 @@
|
|
|
d8307d |
License along with the GNU C Library; if not, see
|
|
|
d8307d |
<http://www.gnu.org/licenses/>. */
|
|
|
d8307d |
|
|
|
d8307d |
-#if defined HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc)
|
|
|
d8307d |
+#include <ifunc-wcspbrk.h>
|
|
|
d8307d |
+#if HAVE_WCSPBRK_Z13
|
|
|
d8307d |
|
|
|
d8307d |
# include "sysdep.h"
|
|
|
d8307d |
# include "asm-syntax.h"
|
|
|
d8307d |
@@ -59,7 +60,7 @@
|
|
|
d8307d |
otherwise =0;
|
|
|
d8307d |
r9: loaded byte count of vlbb accept-string
|
|
|
d8307d |
*/
|
|
|
d8307d |
-ENTRY(__wcspbrk_vx)
|
|
|
d8307d |
+ENTRY(WCSPBRK_Z13)
|
|
|
d8307d |
.machine "z13"
|
|
|
d8307d |
.machinemode "zarch_nohighgprs"
|
|
|
d8307d |
|
|
|
d8307d |
@@ -310,6 +311,15 @@ ENTRY(__wcspbrk_vx)
|
|
|
d8307d |
lgr %r2,%r1
|
|
|
d8307d |
br %r14
|
|
|
d8307d |
.Lfallback:
|
|
|
d8307d |
- jg __wcspbrk_c
|
|
|
d8307d |
-END(__wcspbrk_vx)
|
|
|
d8307d |
-#endif /* HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc) */
|
|
|
d8307d |
+ jg WCSPBRK_C
|
|
|
d8307d |
+END(WCSPBRK_Z13)
|
|
|
d8307d |
+
|
|
|
d8307d |
+# if ! HAVE_WCSPBRK_IFUNC
|
|
|
d8307d |
+strong_alias (WCSPBRK_Z13, wcspbrk)
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
+
|
|
|
d8307d |
+# if defined HAVE_S390_MIN_Z13_ZARCH_ASM_SUPPORT \
|
|
|
d8307d |
+ && defined SHARED && IS_IN (libc)
|
|
|
d8307d |
+strong_alias (WCSPBRK_Z13, __GI_wcspbrk)
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
diff --git a/sysdeps/s390/multiarch/wcspbrk.c b/sysdeps/s390/wcspbrk.c
|
|
|
d8307d |
similarity index 69%
|
|
|
d8307d |
rename from sysdeps/s390/multiarch/wcspbrk.c
|
|
|
d8307d |
rename to sysdeps/s390/wcspbrk.c
|
|
|
d8307d |
index 97876328b5ad9425..84ab911a24fba3c4 100644
|
|
|
d8307d |
--- a/sysdeps/s390/multiarch/wcspbrk.c
|
|
|
d8307d |
+++ b/sysdeps/s390/wcspbrk.c
|
|
|
d8307d |
@@ -16,14 +16,24 @@
|
|
|
d8307d |
License along with the GNU C Library; if not, see
|
|
|
d8307d |
<http://www.gnu.org/licenses/>. */
|
|
|
d8307d |
|
|
|
d8307d |
-#if defined HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc)
|
|
|
d8307d |
+#include <ifunc-wcspbrk.h>
|
|
|
d8307d |
+
|
|
|
d8307d |
+#if HAVE_WCSPBRK_IFUNC
|
|
|
d8307d |
# define wcspbrk __redirect_wcspbrk
|
|
|
d8307d |
# include <wchar.h>
|
|
|
d8307d |
# undef wcspbrk
|
|
|
d8307d |
# include <ifunc-resolve.h>
|
|
|
d8307d |
+# if HAVE_WCSPBRK_C
|
|
|
d8307d |
+extern __typeof (__redirect_wcspbrk) WCSPBRK_C attribute_hidden;
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
|
|
|
d8307d |
-s390_vx_libc_ifunc2_redirected (__redirect_wcspbrk, __wcspbrk, wcspbrk)
|
|
|
d8307d |
+# if HAVE_WCSPBRK_Z13
|
|
|
d8307d |
+extern __typeof (__redirect_wcspbrk) WCSPBRK_Z13 attribute_hidden;
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
|
|
|
d8307d |
-#else
|
|
|
d8307d |
-# include <wcsmbs/wcspbrk.c>
|
|
|
d8307d |
-#endif /* !(defined HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc)) */
|
|
|
d8307d |
+s390_libc_ifunc_expr (__redirect_wcspbrk, wcspbrk,
|
|
|
d8307d |
+ (HAVE_WCSPBRK_Z13 && (hwcap & HWCAP_S390_VX))
|
|
|
d8307d |
+ ? WCSPBRK_Z13
|
|
|
d8307d |
+ : WCSPBRK_DEFAULT
|
|
|
d8307d |
+ )
|
|
|
d8307d |
+#endif
|