d8307d
commit cdab85fe33b0443a645509cbb5b929a0d3307f18
d8307d
Author: Stefan Liebler <stli@linux.ibm.com>
d8307d
Date:   Tue Dec 18 13:57:13 2018 +0100
d8307d
d8307d
    S390: Refactor strcmp ifunc handling.
d8307d
    
d8307d
    The ifunc handling for strcmp is adjusted in order to omit ifunc
d8307d
    variants if those will never be used as the minimum architecture level
d8307d
    already supports newer CPUs by default.
d8307d
    Glibc internal calls will then also use the "newer" ifunc variant.
d8307d
    
d8307d
    Note: The fallback s390-32/s390-64 ifunc variants with clst instruction
d8307d
    are now moved to the unified strcmp-z900.S file which can be used for
d8307d
    31/64bit. The s390-32/s390-64 files multiarch/strcmp.c and strcmp.S
d8307d
    are deleted.
d8307d
    
d8307d
    ChangeLog:
d8307d
    
d8307d
            * sysdeps/s390/multiarch/Makefile
d8307d
            (sysdep_routines): Remove strcmp variants.
d8307d
            * sysdeps/s390/Makefile (sysdep_routines): Add strcmp variants.
d8307d
            * sysdeps/s390/multiarch/ifunc-impl-list.c
d8307d
            (__libc_ifunc_impl_list): Refactor ifunc handling for strcmp.
d8307d
            * sysdeps/s390/multiarch/strcmp-vx.S: Move to ...
d8307d
            * sysdeps/s390/strcmp-vx.S: ... here and adjust ifunc handling.
d8307d
            * sysdeps/s390/multiarch/strcmp.c: Move to ...
d8307d
            * sysdeps/s390/strcmp.c: ... here and adjust ifunc handling.
d8307d
            * sysdeps/s390/ifunc-strcmp.h: New file.
d8307d
            * sysdeps/s390/s390-64/strcmp.S: Move to ...
d8307d
            * sysdeps/s390/strcmp-z900.S: ... here and adjust to be usable
d8307d
            for 31/64bit and ifunc handling.
d8307d
            * sysdeps/s390/s390-32/multiarch/strcmp.c: Delete file.
d8307d
            * sysdeps/s390/s390-64/multiarch/strcmp.c: Likewise.
d8307d
            * sysdeps/s390/s390-32/strcmp.S: Likewise.
d8307d
d8307d
diff --git a/sysdeps/s390/Makefile b/sysdeps/s390/Makefile
d8307d
index cb5dc1d4f95fd11c..71a4658b43aeb745 100644
d8307d
--- a/sysdeps/s390/Makefile
d8307d
+++ b/sysdeps/s390/Makefile
d8307d
@@ -44,5 +44,6 @@ sysdep_routines += bzero memset memset-z900 \
d8307d
 		   strncpy strncpy-vx strncpy-z900 \
d8307d
 		   stpncpy stpncpy-vx stpncpy-c \
d8307d
 		   strcat strcat-vx strcat-c \
d8307d
-		   strncat strncat-vx strncat-c
d8307d
+		   strncat strncat-vx strncat-c \
d8307d
+		   strcmp strcmp-vx strcmp-z900
d8307d
 endif
d8307d
diff --git a/sysdeps/s390/ifunc-strcmp.h b/sysdeps/s390/ifunc-strcmp.h
d8307d
new file mode 100644
d8307d
index 0000000000000000..86ffe686ade52b64
d8307d
--- /dev/null
d8307d
+++ b/sysdeps/s390/ifunc-strcmp.h
d8307d
@@ -0,0 +1,52 @@
d8307d
+/* strcmp variant information on S/390 version.
d8307d
+   Copyright (C) 2018 Free Software Foundation, Inc.
d8307d
+   This file is part of the GNU C Library.
d8307d
+
d8307d
+   The GNU C Library is free software; you can redistribute it and/or
d8307d
+   modify it under the terms of the GNU Lesser General Public
d8307d
+   License as published by the Free Software Foundation; either
d8307d
+   version 2.1 of the License, or (at your option) any later version.
d8307d
+
d8307d
+   The GNU C Library is distributed in the hope that it will be useful,
d8307d
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
d8307d
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
d8307d
+   Lesser General Public License for more details.
d8307d
+
d8307d
+   You should have received a copy of the GNU Lesser General Public
d8307d
+   License along with the GNU C Library; if not, see
d8307d
+   <http://www.gnu.org/licenses/>.  */
d8307d
+
d8307d
+#if defined USE_MULTIARCH && IS_IN (libc)		\
d8307d
+  && ! defined HAVE_S390_MIN_Z13_ZARCH_ASM_SUPPORT
d8307d
+# define HAVE_STRCMP_IFUNC	1
d8307d
+#else
d8307d
+# define HAVE_STRCMP_IFUNC	0
d8307d
+#endif
d8307d
+
d8307d
+#ifdef HAVE_S390_VX_ASM_SUPPORT
d8307d
+# define HAVE_STRCMP_IFUNC_AND_VX_SUPPORT HAVE_STRCMP_IFUNC
d8307d
+#else
d8307d
+# define HAVE_STRCMP_IFUNC_AND_VX_SUPPORT 0
d8307d
+#endif
d8307d
+
d8307d
+#if defined HAVE_S390_MIN_Z13_ZARCH_ASM_SUPPORT
d8307d
+# define STRCMP_DEFAULT		STRCMP_Z13
d8307d
+# define HAVE_STRCMP_Z900_G5	0
d8307d
+# define HAVE_STRCMP_Z13	1
d8307d
+#else
d8307d
+# define STRCMP_DEFAULT		STRCMP_Z900_G5
d8307d
+# define HAVE_STRCMP_Z900_G5	1
d8307d
+# define HAVE_STRCMP_Z13	HAVE_STRCMP_IFUNC_AND_VX_SUPPORT
d8307d
+#endif
d8307d
+
d8307d
+#if HAVE_STRCMP_Z900_G5
d8307d
+# define STRCMP_Z900_G5		__strcmp_default
d8307d
+#else
d8307d
+# define STRCMP_Z900_G5		NULL
d8307d
+#endif
d8307d
+
d8307d
+#if HAVE_STRCMP_Z13
d8307d
+# define STRCMP_Z13		__strcmp_vx
d8307d
+#else
d8307d
+# define STRCMP_Z13		NULL
d8307d
+#endif
d8307d
diff --git a/sysdeps/s390/multiarch/Makefile b/sysdeps/s390/multiarch/Makefile
d8307d
index 24be3eac5131fd4a..97421a499625c7f2 100644
d8307d
--- a/sysdeps/s390/multiarch/Makefile
d8307d
+++ b/sysdeps/s390/multiarch/Makefile
d8307d
@@ -1,6 +1,5 @@
d8307d
 ifeq ($(subdir),string)
d8307d
-sysdep_routines += strcmp strcmp-vx \
d8307d
-		   strncmp strncmp-vx strncmp-c \
d8307d
+sysdep_routines += strncmp strncmp-vx strncmp-c \
d8307d
 		   strchr strchr-vx strchr-c \
d8307d
 		   strchrnul strchrnul-vx strchrnul-c \
d8307d
 		   strrchr strrchr-vx strrchr-c \
d8307d
diff --git a/sysdeps/s390/multiarch/ifunc-impl-list.c b/sysdeps/s390/multiarch/ifunc-impl-list.c
d8307d
index 3abcaf08e0ccd385..44637c431b144c66 100644
d8307d
--- a/sysdeps/s390/multiarch/ifunc-impl-list.c
d8307d
+++ b/sysdeps/s390/multiarch/ifunc-impl-list.c
d8307d
@@ -34,6 +34,7 @@
d8307d
 #include <ifunc-stpncpy.h>
d8307d
 #include <ifunc-strcat.h>
d8307d
 #include <ifunc-strncat.h>
d8307d
+#include <ifunc-strcmp.h>
d8307d
 
d8307d
 /* Maximum number of IFUNC implementations.  */
d8307d
 #define MAX_IFUNC	3
d8307d
@@ -268,6 +269,18 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
d8307d
 		)
d8307d
 #endif /* HAVE_STRNCAT_IFUNC  */
d8307d
 
d8307d
+#if HAVE_STRCMP_IFUNC
d8307d
+    IFUNC_IMPL (i, name, strcmp,
d8307d
+# if HAVE_STRCMP_Z13
d8307d
+		IFUNC_IMPL_ADD (array, i, strcmp,
d8307d
+				dl_hwcap & HWCAP_S390_VX, STRCMP_Z13)
d8307d
+# endif
d8307d
+# if HAVE_STRCMP_Z900_G5
d8307d
+		IFUNC_IMPL_ADD (array, i, strcmp, 1, STRCMP_Z900_G5)
d8307d
+# endif
d8307d
+		)
d8307d
+#endif /* HAVE_STRCMP_IFUNC  */
d8307d
+
d8307d
 #ifdef HAVE_S390_VX_ASM_SUPPORT
d8307d
 
d8307d
 # define IFUNC_VX_IMPL(FUNC)						\
d8307d
@@ -292,7 +305,6 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
d8307d
 
d8307d
   IFUNC_VX_IMPL (wcsncat);
d8307d
 
d8307d
-  IFUNC_VX_IMPL (strcmp);
d8307d
   IFUNC_VX_IMPL (wcscmp);
d8307d
 
d8307d
   IFUNC_VX_IMPL (strncmp);
d8307d
diff --git a/sysdeps/s390/s390-32/multiarch/strcmp.c b/sysdeps/s390/s390-32/multiarch/strcmp.c
d8307d
deleted file mode 100644
d8307d
index d06b0f3436b2abfd..0000000000000000
d8307d
--- a/sysdeps/s390/s390-32/multiarch/strcmp.c
d8307d
+++ /dev/null
d8307d
@@ -1,21 +0,0 @@
d8307d
-/* Multiple versions of strcmp.
d8307d
-   Copyright (C) 2015-2018 Free Software Foundation, Inc.
d8307d
-   This file is part of the GNU C Library.
d8307d
-
d8307d
-   The GNU C Library is free software; you can redistribute it and/or
d8307d
-   modify it under the terms of the GNU Lesser General Public
d8307d
-   License as published by the Free Software Foundation; either
d8307d
-   version 2.1 of the License, or (at your option) any later version.
d8307d
-
d8307d
-   The GNU C Library is distributed in the hope that it will be useful,
d8307d
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
d8307d
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
d8307d
-   Lesser General Public License for more details.
d8307d
-
d8307d
-   You should have received a copy of the GNU Lesser General Public
d8307d
-   License along with the GNU C Library; if not, see
d8307d
-   <http://www.gnu.org/licenses/>.  */
d8307d
-
d8307d
-/* This wrapper-file is needed, because otherwise file
d8307d
-   sysdeps/s390/s390-[32|64]/strcmp.S will be used.  */
d8307d
-#include <sysdeps/s390/multiarch/strcmp.c>
d8307d
diff --git a/sysdeps/s390/s390-32/strcmp.S b/sysdeps/s390/s390-32/strcmp.S
d8307d
deleted file mode 100644
d8307d
index 3cf3f239fddccce8..0000000000000000
d8307d
--- a/sysdeps/s390/s390-32/strcmp.S
d8307d
+++ /dev/null
d8307d
@@ -1,41 +0,0 @@
d8307d
-/* strcmp - compare two string.  S/390 version.
d8307d
-   This file is part of the GNU C Library.
d8307d
-   Copyright (C) 2001-2018 Free Software Foundation, Inc.
d8307d
-   Contributed by Martin Schwidefsky (schwidefsky@de.ibm.com).
d8307d
-
d8307d
-   The GNU C Library is free software; you can redistribute it and/or
d8307d
-   modify it under the terms of the GNU Lesser General Public
d8307d
-   License as published by the Free Software Foundation; either
d8307d
-   version 2.1 of the License, or (at your option) any later version.
d8307d
-
d8307d
-   The GNU C Library is distributed in the hope that it will be useful,
d8307d
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
d8307d
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
d8307d
-   Lesser General Public License for more details.
d8307d
-
d8307d
-   You should have received a copy of the GNU Lesser General Public
d8307d
-   License along with the GNU C Library; if not, see
d8307d
-   <http://www.gnu.org/licenses/>.  */
d8307d
-
d8307d
-/* INPUT PARAMETERS
d8307d
-     %r2 = address of string 1
d8307d
-     %r3 = address of string 2.  */
d8307d
-
d8307d
-#include "sysdep.h"
d8307d
-#include "asm-syntax.h"
d8307d
-
d8307d
-	.text
d8307d
-ENTRY(strcmp)
d8307d
-        slr   %r0,%r0
d8307d
-0:	clst  %r2,%r3
d8307d
-	jo    0b
d8307d
-	jp    1f
d8307d
-	jm    2f
d8307d
-	slr   %r2,%r2
d8307d
-	br    %r14
d8307d
-1:	lhi   %r2,1
d8307d
-	br    %r14
d8307d
-2:	lhi   %r2,-1
d8307d
-	br    %r14
d8307d
-END(strcmp)
d8307d
-libc_hidden_builtin_def (strcmp)
d8307d
diff --git a/sysdeps/s390/s390-64/multiarch/strcmp.c b/sysdeps/s390/s390-64/multiarch/strcmp.c
d8307d
deleted file mode 100644
d8307d
index d06b0f3436b2abfd..0000000000000000
d8307d
--- a/sysdeps/s390/s390-64/multiarch/strcmp.c
d8307d
+++ /dev/null
d8307d
@@ -1,21 +0,0 @@
d8307d
-/* Multiple versions of strcmp.
d8307d
-   Copyright (C) 2015-2018 Free Software Foundation, Inc.
d8307d
-   This file is part of the GNU C Library.
d8307d
-
d8307d
-   The GNU C Library is free software; you can redistribute it and/or
d8307d
-   modify it under the terms of the GNU Lesser General Public
d8307d
-   License as published by the Free Software Foundation; either
d8307d
-   version 2.1 of the License, or (at your option) any later version.
d8307d
-
d8307d
-   The GNU C Library is distributed in the hope that it will be useful,
d8307d
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
d8307d
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
d8307d
-   Lesser General Public License for more details.
d8307d
-
d8307d
-   You should have received a copy of the GNU Lesser General Public
d8307d
-   License along with the GNU C Library; if not, see
d8307d
-   <http://www.gnu.org/licenses/>.  */
d8307d
-
d8307d
-/* This wrapper-file is needed, because otherwise file
d8307d
-   sysdeps/s390/s390-[32|64]/strcmp.S will be used.  */
d8307d
-#include <sysdeps/s390/multiarch/strcmp.c>
d8307d
diff --git a/sysdeps/s390/multiarch/strcmp-vx.S b/sysdeps/s390/strcmp-vx.S
d8307d
similarity index 90%
d8307d
rename from sysdeps/s390/multiarch/strcmp-vx.S
d8307d
rename to sysdeps/s390/strcmp-vx.S
d8307d
index bcaeb564d47c58ff..801ad9d32bbd76c0 100644
d8307d
--- a/sysdeps/s390/multiarch/strcmp-vx.S
d8307d
+++ b/sysdeps/s390/strcmp-vx.S
d8307d
@@ -16,7 +16,8 @@
d8307d
    License along with the GNU C Library; if not, see
d8307d
    <http://www.gnu.org/licenses/>.  */
d8307d
 
d8307d
-#if defined HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc)
d8307d
+#include <ifunc-strcmp.h>
d8307d
+#if HAVE_STRCMP_Z13
d8307d
 
d8307d
 # include "sysdep.h"
d8307d
 # include "asm-syntax.h"
d8307d
@@ -36,7 +37,7 @@
d8307d
    -v17=part of s2
d8307d
    -v18=index of unequal
d8307d
 */
d8307d
-ENTRY(__strcmp_vx)
d8307d
+ENTRY(STRCMP_Z13)
d8307d
 	.machine "z13"
d8307d
 	.machinemode "zarch_nohighgprs"
d8307d
 
d8307d
@@ -106,11 +107,13 @@ ENTRY(__strcmp_vx)
d8307d
 .Lend_equal:
d8307d
 	lghi	%r2,0
d8307d
 	br	%r14
d8307d
-END(__strcmp_vx)
d8307d
+END(STRCMP_Z13)
d8307d
 
d8307d
-# define strcmp __strcmp_c
d8307d
-# undef libc_hidden_builtin_def
d8307d
-# define libc_hidden_builtin_def(name) strong_alias(__strcmp_c, __GI_strcmp)
d8307d
-#endif /* HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc) */
d8307d
+# if ! HAVE_STRCMP_IFUNC
d8307d
+strong_alias (STRCMP_Z13, strcmp)
d8307d
+# endif
d8307d
 
d8307d
-#include <strcmp.S>
d8307d
+# if ! HAVE_STRCMP_Z900_G5 && defined SHARED && IS_IN (libc)
d8307d
+strong_alias (STRCMP_Z13, __GI_strcmp)
d8307d
+# endif
d8307d
+#endif
d8307d
diff --git a/sysdeps/s390/s390-64/strcmp.S b/sysdeps/s390/strcmp-z900.S
d8307d
similarity index 70%
d8307d
rename from sysdeps/s390/s390-64/strcmp.S
d8307d
rename to sysdeps/s390/strcmp-z900.S
d8307d
index 6cf1addd8bdf1a19..67b3c8b2e5989cd2 100644
d8307d
--- a/sysdeps/s390/s390-64/strcmp.S
d8307d
+++ b/sysdeps/s390/strcmp-z900.S
d8307d
@@ -21,21 +21,39 @@
d8307d
      %r2 = address of string 1
d8307d
      %r3 = address of string 2.  */
d8307d
 
d8307d
+#include <ifunc-strcmp.h>
d8307d
 #include "sysdep.h"
d8307d
 #include "asm-syntax.h"
d8307d
 
d8307d
+#if HAVE_STRCMP_Z900_G5
d8307d
+# if defined __s390x__
d8307d
+#  define SLGR	slgr
d8307d
+#  define LGHI	lghi
d8307d
+# else
d8307d
+#  define SLGR	slr
d8307d
+#  define LGHI	lhi
d8307d
+# endif /* ! defined __s390x__  */
d8307d
+
d8307d
 	.text
d8307d
-ENTRY(strcmp)
d8307d
-        slr   %r0,%r0
d8307d
+ENTRY(STRCMP_Z900_G5)
d8307d
+	SLGR   %r0,%r0
d8307d
 0:	clst  %r2,%r3
d8307d
 	jo    0b
d8307d
 	jp    1f
d8307d
 	jm    2f
d8307d
-	slgr  %r2,%r2
d8307d
+	SLGR  %r2,%r2
d8307d
 	br    %r14
d8307d
-1:	lghi  %r2,1
d8307d
+1:	LGHI  %r2,1
d8307d
 	br    %r14
d8307d
-2:	lghi  %r2,-1
d8307d
+2:	LGHI  %r2,-1
d8307d
 	br    %r14
d8307d
-END(strcmp)
d8307d
-libc_hidden_builtin_def (strcmp)
d8307d
+END(STRCMP_Z900_G5)
d8307d
+
d8307d
+# if ! HAVE_STRCMP_IFUNC
d8307d
+strong_alias (STRCMP_Z900_G5, strcmp)
d8307d
+# endif
d8307d
+
d8307d
+# if defined SHARED && IS_IN (libc)
d8307d
+strong_alias (STRCMP_Z900_G5, __GI_strcmp)
d8307d
+# endif
d8307d
+#endif
d8307d
diff --git a/sysdeps/s390/multiarch/strcmp.c b/sysdeps/s390/strcmp.c
d8307d
similarity index 71%
d8307d
rename from sysdeps/s390/multiarch/strcmp.c
d8307d
rename to sysdeps/s390/strcmp.c
d8307d
index 7c8b17b3041dd549..9efa30acaf21f4e8 100644
d8307d
--- a/sysdeps/s390/multiarch/strcmp.c
d8307d
+++ b/sysdeps/s390/strcmp.c
d8307d
@@ -16,7 +16,9 @@
d8307d
    License along with the GNU C Library; if not, see
d8307d
    <http://www.gnu.org/licenses/>.  */
d8307d
 
d8307d
-#if defined HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc)
d8307d
+#include <ifunc-strcmp.h>
d8307d
+
d8307d
+#if HAVE_STRCMP_IFUNC
d8307d
 # define strcmp __redirect_strcmp
d8307d
 /* Omit the strcmp inline definitions because it would redefine strcmp.  */
d8307d
 # define __NO_STRING_INLINES
d8307d
@@ -24,6 +26,17 @@
d8307d
 # include <ifunc-resolve.h>
d8307d
 # undef strcmp
d8307d
 
d8307d
-s390_vx_libc_ifunc2_redirected (__redirect_strcmp, __strcmp, strcmp)
d8307d
+# if HAVE_STRCMP_Z900_G5
d8307d
+extern __typeof (__redirect_strcmp) STRCMP_Z900_G5 attribute_hidden;
d8307d
+# endif
d8307d
+
d8307d
+# if HAVE_STRCMP_Z13
d8307d
+extern __typeof (__redirect_strcmp) STRCMP_Z13 attribute_hidden;
d8307d
+# endif
d8307d
 
d8307d
+s390_libc_ifunc_expr (__redirect_strcmp, strcmp,
d8307d
+		      (HAVE_STRCMP_Z13 && (hwcap & HWCAP_S390_VX))
d8307d
+		      ? STRCMP_Z13
d8307d
+		      : STRCMP_DEFAULT
d8307d
+		      )
d8307d
 #endif