077c9d
commit cdab85fe33b0443a645509cbb5b929a0d3307f18
077c9d
Author: Stefan Liebler <stli@linux.ibm.com>
077c9d
Date:   Tue Dec 18 13:57:13 2018 +0100
077c9d
077c9d
    S390: Refactor strcmp ifunc handling.
077c9d
    
077c9d
    The ifunc handling for strcmp is adjusted in order to omit ifunc
077c9d
    variants if those will never be used as the minimum architecture level
077c9d
    already supports newer CPUs by default.
077c9d
    Glibc internal calls will then also use the "newer" ifunc variant.
077c9d
    
077c9d
    Note: The fallback s390-32/s390-64 ifunc variants with clst instruction
077c9d
    are now moved to the unified strcmp-z900.S file which can be used for
077c9d
    31/64bit. The s390-32/s390-64 files multiarch/strcmp.c and strcmp.S
077c9d
    are deleted.
077c9d
    
077c9d
    ChangeLog:
077c9d
    
077c9d
            * sysdeps/s390/multiarch/Makefile
077c9d
            (sysdep_routines): Remove strcmp variants.
077c9d
            * sysdeps/s390/Makefile (sysdep_routines): Add strcmp variants.
077c9d
            * sysdeps/s390/multiarch/ifunc-impl-list.c
077c9d
            (__libc_ifunc_impl_list): Refactor ifunc handling for strcmp.
077c9d
            * sysdeps/s390/multiarch/strcmp-vx.S: Move to ...
077c9d
            * sysdeps/s390/strcmp-vx.S: ... here and adjust ifunc handling.
077c9d
            * sysdeps/s390/multiarch/strcmp.c: Move to ...
077c9d
            * sysdeps/s390/strcmp.c: ... here and adjust ifunc handling.
077c9d
            * sysdeps/s390/ifunc-strcmp.h: New file.
077c9d
            * sysdeps/s390/s390-64/strcmp.S: Move to ...
077c9d
            * sysdeps/s390/strcmp-z900.S: ... here and adjust to be usable
077c9d
            for 31/64bit and ifunc handling.
077c9d
            * sysdeps/s390/s390-32/multiarch/strcmp.c: Delete file.
077c9d
            * sysdeps/s390/s390-64/multiarch/strcmp.c: Likewise.
077c9d
            * sysdeps/s390/s390-32/strcmp.S: Likewise.
077c9d
077c9d
diff --git a/sysdeps/s390/Makefile b/sysdeps/s390/Makefile
077c9d
index cb5dc1d4f95fd11c..71a4658b43aeb745 100644
077c9d
--- a/sysdeps/s390/Makefile
077c9d
+++ b/sysdeps/s390/Makefile
077c9d
@@ -44,5 +44,6 @@ sysdep_routines += bzero memset memset-z900 \
077c9d
 		   strncpy strncpy-vx strncpy-z900 \
077c9d
 		   stpncpy stpncpy-vx stpncpy-c \
077c9d
 		   strcat strcat-vx strcat-c \
077c9d
-		   strncat strncat-vx strncat-c
077c9d
+		   strncat strncat-vx strncat-c \
077c9d
+		   strcmp strcmp-vx strcmp-z900
077c9d
 endif
077c9d
diff --git a/sysdeps/s390/ifunc-strcmp.h b/sysdeps/s390/ifunc-strcmp.h
077c9d
new file mode 100644
077c9d
index 0000000000000000..86ffe686ade52b64
077c9d
--- /dev/null
077c9d
+++ b/sysdeps/s390/ifunc-strcmp.h
077c9d
@@ -0,0 +1,52 @@
077c9d
+/* strcmp variant information on S/390 version.
077c9d
+   Copyright (C) 2018 Free Software Foundation, Inc.
077c9d
+   This file is part of the GNU C Library.
077c9d
+
077c9d
+   The GNU C Library is free software; you can redistribute it and/or
077c9d
+   modify it under the terms of the GNU Lesser General Public
077c9d
+   License as published by the Free Software Foundation; either
077c9d
+   version 2.1 of the License, or (at your option) any later version.
077c9d
+
077c9d
+   The GNU C Library is distributed in the hope that it will be useful,
077c9d
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
077c9d
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
077c9d
+   Lesser General Public License for more details.
077c9d
+
077c9d
+   You should have received a copy of the GNU Lesser General Public
077c9d
+   License along with the GNU C Library; if not, see
077c9d
+   <http://www.gnu.org/licenses/>.  */
077c9d
+
077c9d
+#if defined USE_MULTIARCH && IS_IN (libc)		\
077c9d
+  && ! defined HAVE_S390_MIN_Z13_ZARCH_ASM_SUPPORT
077c9d
+# define HAVE_STRCMP_IFUNC	1
077c9d
+#else
077c9d
+# define HAVE_STRCMP_IFUNC	0
077c9d
+#endif
077c9d
+
077c9d
+#ifdef HAVE_S390_VX_ASM_SUPPORT
077c9d
+# define HAVE_STRCMP_IFUNC_AND_VX_SUPPORT HAVE_STRCMP_IFUNC
077c9d
+#else
077c9d
+# define HAVE_STRCMP_IFUNC_AND_VX_SUPPORT 0
077c9d
+#endif
077c9d
+
077c9d
+#if defined HAVE_S390_MIN_Z13_ZARCH_ASM_SUPPORT
077c9d
+# define STRCMP_DEFAULT		STRCMP_Z13
077c9d
+# define HAVE_STRCMP_Z900_G5	0
077c9d
+# define HAVE_STRCMP_Z13	1
077c9d
+#else
077c9d
+# define STRCMP_DEFAULT		STRCMP_Z900_G5
077c9d
+# define HAVE_STRCMP_Z900_G5	1
077c9d
+# define HAVE_STRCMP_Z13	HAVE_STRCMP_IFUNC_AND_VX_SUPPORT
077c9d
+#endif
077c9d
+
077c9d
+#if HAVE_STRCMP_Z900_G5
077c9d
+# define STRCMP_Z900_G5		__strcmp_default
077c9d
+#else
077c9d
+# define STRCMP_Z900_G5		NULL
077c9d
+#endif
077c9d
+
077c9d
+#if HAVE_STRCMP_Z13
077c9d
+# define STRCMP_Z13		__strcmp_vx
077c9d
+#else
077c9d
+# define STRCMP_Z13		NULL
077c9d
+#endif
077c9d
diff --git a/sysdeps/s390/multiarch/Makefile b/sysdeps/s390/multiarch/Makefile
077c9d
index 24be3eac5131fd4a..97421a499625c7f2 100644
077c9d
--- a/sysdeps/s390/multiarch/Makefile
077c9d
+++ b/sysdeps/s390/multiarch/Makefile
077c9d
@@ -1,6 +1,5 @@
077c9d
 ifeq ($(subdir),string)
077c9d
-sysdep_routines += strcmp strcmp-vx \
077c9d
-		   strncmp strncmp-vx strncmp-c \
077c9d
+sysdep_routines += strncmp strncmp-vx strncmp-c \
077c9d
 		   strchr strchr-vx strchr-c \
077c9d
 		   strchrnul strchrnul-vx strchrnul-c \
077c9d
 		   strrchr strrchr-vx strrchr-c \
077c9d
diff --git a/sysdeps/s390/multiarch/ifunc-impl-list.c b/sysdeps/s390/multiarch/ifunc-impl-list.c
077c9d
index 3abcaf08e0ccd385..44637c431b144c66 100644
077c9d
--- a/sysdeps/s390/multiarch/ifunc-impl-list.c
077c9d
+++ b/sysdeps/s390/multiarch/ifunc-impl-list.c
077c9d
@@ -34,6 +34,7 @@
077c9d
 #include <ifunc-stpncpy.h>
077c9d
 #include <ifunc-strcat.h>
077c9d
 #include <ifunc-strncat.h>
077c9d
+#include <ifunc-strcmp.h>
077c9d
 
077c9d
 /* Maximum number of IFUNC implementations.  */
077c9d
 #define MAX_IFUNC	3
077c9d
@@ -268,6 +269,18 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
077c9d
 		)
077c9d
 #endif /* HAVE_STRNCAT_IFUNC  */
077c9d
 
077c9d
+#if HAVE_STRCMP_IFUNC
077c9d
+    IFUNC_IMPL (i, name, strcmp,
077c9d
+# if HAVE_STRCMP_Z13
077c9d
+		IFUNC_IMPL_ADD (array, i, strcmp,
077c9d
+				dl_hwcap & HWCAP_S390_VX, STRCMP_Z13)
077c9d
+# endif
077c9d
+# if HAVE_STRCMP_Z900_G5
077c9d
+		IFUNC_IMPL_ADD (array, i, strcmp, 1, STRCMP_Z900_G5)
077c9d
+# endif
077c9d
+		)
077c9d
+#endif /* HAVE_STRCMP_IFUNC  */
077c9d
+
077c9d
 #ifdef HAVE_S390_VX_ASM_SUPPORT
077c9d
 
077c9d
 # define IFUNC_VX_IMPL(FUNC)						\
077c9d
@@ -292,7 +305,6 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
077c9d
 
077c9d
   IFUNC_VX_IMPL (wcsncat);
077c9d
 
077c9d
-  IFUNC_VX_IMPL (strcmp);
077c9d
   IFUNC_VX_IMPL (wcscmp);
077c9d
 
077c9d
   IFUNC_VX_IMPL (strncmp);
077c9d
diff --git a/sysdeps/s390/s390-32/multiarch/strcmp.c b/sysdeps/s390/s390-32/multiarch/strcmp.c
077c9d
deleted file mode 100644
077c9d
index d06b0f3436b2abfd..0000000000000000
077c9d
--- a/sysdeps/s390/s390-32/multiarch/strcmp.c
077c9d
+++ /dev/null
077c9d
@@ -1,21 +0,0 @@
077c9d
-/* Multiple versions of strcmp.
077c9d
-   Copyright (C) 2015-2018 Free Software Foundation, Inc.
077c9d
-   This file is part of the GNU C Library.
077c9d
-
077c9d
-   The GNU C Library is free software; you can redistribute it and/or
077c9d
-   modify it under the terms of the GNU Lesser General Public
077c9d
-   License as published by the Free Software Foundation; either
077c9d
-   version 2.1 of the License, or (at your option) any later version.
077c9d
-
077c9d
-   The GNU C Library is distributed in the hope that it will be useful,
077c9d
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
077c9d
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
077c9d
-   Lesser General Public License for more details.
077c9d
-
077c9d
-   You should have received a copy of the GNU Lesser General Public
077c9d
-   License along with the GNU C Library; if not, see
077c9d
-   <http://www.gnu.org/licenses/>.  */
077c9d
-
077c9d
-/* This wrapper-file is needed, because otherwise file
077c9d
-   sysdeps/s390/s390-[32|64]/strcmp.S will be used.  */
077c9d
-#include <sysdeps/s390/multiarch/strcmp.c>
077c9d
diff --git a/sysdeps/s390/s390-32/strcmp.S b/sysdeps/s390/s390-32/strcmp.S
077c9d
deleted file mode 100644
077c9d
index 3cf3f239fddccce8..0000000000000000
077c9d
--- a/sysdeps/s390/s390-32/strcmp.S
077c9d
+++ /dev/null
077c9d
@@ -1,41 +0,0 @@
077c9d
-/* strcmp - compare two string.  S/390 version.
077c9d
-   This file is part of the GNU C Library.
077c9d
-   Copyright (C) 2001-2018 Free Software Foundation, Inc.
077c9d
-   Contributed by Martin Schwidefsky (schwidefsky@de.ibm.com).
077c9d
-
077c9d
-   The GNU C Library is free software; you can redistribute it and/or
077c9d
-   modify it under the terms of the GNU Lesser General Public
077c9d
-   License as published by the Free Software Foundation; either
077c9d
-   version 2.1 of the License, or (at your option) any later version.
077c9d
-
077c9d
-   The GNU C Library is distributed in the hope that it will be useful,
077c9d
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
077c9d
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
077c9d
-   Lesser General Public License for more details.
077c9d
-
077c9d
-   You should have received a copy of the GNU Lesser General Public
077c9d
-   License along with the GNU C Library; if not, see
077c9d
-   <http://www.gnu.org/licenses/>.  */
077c9d
-
077c9d
-/* INPUT PARAMETERS
077c9d
-     %r2 = address of string 1
077c9d
-     %r3 = address of string 2.  */
077c9d
-
077c9d
-#include "sysdep.h"
077c9d
-#include "asm-syntax.h"
077c9d
-
077c9d
-	.text
077c9d
-ENTRY(strcmp)
077c9d
-        slr   %r0,%r0
077c9d
-0:	clst  %r2,%r3
077c9d
-	jo    0b
077c9d
-	jp    1f
077c9d
-	jm    2f
077c9d
-	slr   %r2,%r2
077c9d
-	br    %r14
077c9d
-1:	lhi   %r2,1
077c9d
-	br    %r14
077c9d
-2:	lhi   %r2,-1
077c9d
-	br    %r14
077c9d
-END(strcmp)
077c9d
-libc_hidden_builtin_def (strcmp)
077c9d
diff --git a/sysdeps/s390/s390-64/multiarch/strcmp.c b/sysdeps/s390/s390-64/multiarch/strcmp.c
077c9d
deleted file mode 100644
077c9d
index d06b0f3436b2abfd..0000000000000000
077c9d
--- a/sysdeps/s390/s390-64/multiarch/strcmp.c
077c9d
+++ /dev/null
077c9d
@@ -1,21 +0,0 @@
077c9d
-/* Multiple versions of strcmp.
077c9d
-   Copyright (C) 2015-2018 Free Software Foundation, Inc.
077c9d
-   This file is part of the GNU C Library.
077c9d
-
077c9d
-   The GNU C Library is free software; you can redistribute it and/or
077c9d
-   modify it under the terms of the GNU Lesser General Public
077c9d
-   License as published by the Free Software Foundation; either
077c9d
-   version 2.1 of the License, or (at your option) any later version.
077c9d
-
077c9d
-   The GNU C Library is distributed in the hope that it will be useful,
077c9d
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
077c9d
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
077c9d
-   Lesser General Public License for more details.
077c9d
-
077c9d
-   You should have received a copy of the GNU Lesser General Public
077c9d
-   License along with the GNU C Library; if not, see
077c9d
-   <http://www.gnu.org/licenses/>.  */
077c9d
-
077c9d
-/* This wrapper-file is needed, because otherwise file
077c9d
-   sysdeps/s390/s390-[32|64]/strcmp.S will be used.  */
077c9d
-#include <sysdeps/s390/multiarch/strcmp.c>
077c9d
diff --git a/sysdeps/s390/multiarch/strcmp-vx.S b/sysdeps/s390/strcmp-vx.S
077c9d
similarity index 90%
077c9d
rename from sysdeps/s390/multiarch/strcmp-vx.S
077c9d
rename to sysdeps/s390/strcmp-vx.S
077c9d
index bcaeb564d47c58ff..801ad9d32bbd76c0 100644
077c9d
--- a/sysdeps/s390/multiarch/strcmp-vx.S
077c9d
+++ b/sysdeps/s390/strcmp-vx.S
077c9d
@@ -16,7 +16,8 @@
077c9d
    License along with the GNU C Library; if not, see
077c9d
    <http://www.gnu.org/licenses/>.  */
077c9d
 
077c9d
-#if defined HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc)
077c9d
+#include <ifunc-strcmp.h>
077c9d
+#if HAVE_STRCMP_Z13
077c9d
 
077c9d
 # include "sysdep.h"
077c9d
 # include "asm-syntax.h"
077c9d
@@ -36,7 +37,7 @@
077c9d
    -v17=part of s2
077c9d
    -v18=index of unequal
077c9d
 */
077c9d
-ENTRY(__strcmp_vx)
077c9d
+ENTRY(STRCMP_Z13)
077c9d
 	.machine "z13"
077c9d
 	.machinemode "zarch_nohighgprs"
077c9d
 
077c9d
@@ -106,11 +107,13 @@ ENTRY(__strcmp_vx)
077c9d
 .Lend_equal:
077c9d
 	lghi	%r2,0
077c9d
 	br	%r14
077c9d
-END(__strcmp_vx)
077c9d
+END(STRCMP_Z13)
077c9d
 
077c9d
-# define strcmp __strcmp_c
077c9d
-# undef libc_hidden_builtin_def
077c9d
-# define libc_hidden_builtin_def(name) strong_alias(__strcmp_c, __GI_strcmp)
077c9d
-#endif /* HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc) */
077c9d
+# if ! HAVE_STRCMP_IFUNC
077c9d
+strong_alias (STRCMP_Z13, strcmp)
077c9d
+# endif
077c9d
 
077c9d
-#include <strcmp.S>
077c9d
+# if ! HAVE_STRCMP_Z900_G5 && defined SHARED && IS_IN (libc)
077c9d
+strong_alias (STRCMP_Z13, __GI_strcmp)
077c9d
+# endif
077c9d
+#endif
077c9d
diff --git a/sysdeps/s390/s390-64/strcmp.S b/sysdeps/s390/strcmp-z900.S
077c9d
similarity index 70%
077c9d
rename from sysdeps/s390/s390-64/strcmp.S
077c9d
rename to sysdeps/s390/strcmp-z900.S
077c9d
index 6cf1addd8bdf1a19..67b3c8b2e5989cd2 100644
077c9d
--- a/sysdeps/s390/s390-64/strcmp.S
077c9d
+++ b/sysdeps/s390/strcmp-z900.S
077c9d
@@ -21,21 +21,39 @@
077c9d
      %r2 = address of string 1
077c9d
      %r3 = address of string 2.  */
077c9d
 
077c9d
+#include <ifunc-strcmp.h>
077c9d
 #include "sysdep.h"
077c9d
 #include "asm-syntax.h"
077c9d
 
077c9d
+#if HAVE_STRCMP_Z900_G5
077c9d
+# if defined __s390x__
077c9d
+#  define SLGR	slgr
077c9d
+#  define LGHI	lghi
077c9d
+# else
077c9d
+#  define SLGR	slr
077c9d
+#  define LGHI	lhi
077c9d
+# endif /* ! defined __s390x__  */
077c9d
+
077c9d
 	.text
077c9d
-ENTRY(strcmp)
077c9d
-        slr   %r0,%r0
077c9d
+ENTRY(STRCMP_Z900_G5)
077c9d
+	SLGR   %r0,%r0
077c9d
 0:	clst  %r2,%r3
077c9d
 	jo    0b
077c9d
 	jp    1f
077c9d
 	jm    2f
077c9d
-	slgr  %r2,%r2
077c9d
+	SLGR  %r2,%r2
077c9d
 	br    %r14
077c9d
-1:	lghi  %r2,1
077c9d
+1:	LGHI  %r2,1
077c9d
 	br    %r14
077c9d
-2:	lghi  %r2,-1
077c9d
+2:	LGHI  %r2,-1
077c9d
 	br    %r14
077c9d
-END(strcmp)
077c9d
-libc_hidden_builtin_def (strcmp)
077c9d
+END(STRCMP_Z900_G5)
077c9d
+
077c9d
+# if ! HAVE_STRCMP_IFUNC
077c9d
+strong_alias (STRCMP_Z900_G5, strcmp)
077c9d
+# endif
077c9d
+
077c9d
+# if defined SHARED && IS_IN (libc)
077c9d
+strong_alias (STRCMP_Z900_G5, __GI_strcmp)
077c9d
+# endif
077c9d
+#endif
077c9d
diff --git a/sysdeps/s390/multiarch/strcmp.c b/sysdeps/s390/strcmp.c
077c9d
similarity index 71%
077c9d
rename from sysdeps/s390/multiarch/strcmp.c
077c9d
rename to sysdeps/s390/strcmp.c
077c9d
index 7c8b17b3041dd549..9efa30acaf21f4e8 100644
077c9d
--- a/sysdeps/s390/multiarch/strcmp.c
077c9d
+++ b/sysdeps/s390/strcmp.c
077c9d
@@ -16,7 +16,9 @@
077c9d
    License along with the GNU C Library; if not, see
077c9d
    <http://www.gnu.org/licenses/>.  */
077c9d
 
077c9d
-#if defined HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc)
077c9d
+#include <ifunc-strcmp.h>
077c9d
+
077c9d
+#if HAVE_STRCMP_IFUNC
077c9d
 # define strcmp __redirect_strcmp
077c9d
 /* Omit the strcmp inline definitions because it would redefine strcmp.  */
077c9d
 # define __NO_STRING_INLINES
077c9d
@@ -24,6 +26,17 @@
077c9d
 # include <ifunc-resolve.h>
077c9d
 # undef strcmp
077c9d
 
077c9d
-s390_vx_libc_ifunc2_redirected (__redirect_strcmp, __strcmp, strcmp)
077c9d
+# if HAVE_STRCMP_Z900_G5
077c9d
+extern __typeof (__redirect_strcmp) STRCMP_Z900_G5 attribute_hidden;
077c9d
+# endif
077c9d
+
077c9d
+# if HAVE_STRCMP_Z13
077c9d
+extern __typeof (__redirect_strcmp) STRCMP_Z13 attribute_hidden;
077c9d
+# endif
077c9d
 
077c9d
+s390_libc_ifunc_expr (__redirect_strcmp, strcmp,
077c9d
+		      (HAVE_STRCMP_Z13 && (hwcap & HWCAP_S390_VX))
077c9d
+		      ? STRCMP_Z13
077c9d
+		      : STRCMP_DEFAULT
077c9d
+		      )
077c9d
 #endif