|
 |
d8307d |
commit 970449311ded3cacb6058c96143dd4c057900589
|
|
|
d8307d |
Author: Stefan Liebler <stli@linux.ibm.com>
|
|
|
d8307d |
Date: Tue Dec 18 13:57:11 2018 +0100
|
|
|
d8307d |
|
|
|
d8307d |
S390: Refactor stpcpy ifunc handling.
|
|
|
d8307d |
|
|
|
d8307d |
The ifunc handling for stpcpy is adjusted in order to omit ifunc
|
|
|
d8307d |
variants if those will never be used as the minimum architecture level
|
|
|
d8307d |
already supports newer CPUs by default.
|
|
|
d8307d |
Glibc internal calls will then also use the "newer" ifunc variant.
|
|
|
d8307d |
|
|
|
d8307d |
ChangeLog:
|
|
|
d8307d |
|
|
|
d8307d |
* sysdeps/s390/multiarch/Makefile
|
|
|
d8307d |
(sysdep_routines): Remove stpcpy variants.
|
|
|
d8307d |
* sysdeps/s390/Makefile (sysdep_routines): Add stpcpy variants.
|
|
|
d8307d |
* sysdeps/s390/multiarch/ifunc-impl-list.c
|
|
|
d8307d |
(__libc_ifunc_impl_list): Refactor ifunc handling for stpcpy.
|
|
|
d8307d |
* sysdeps/s390/multiarch/stpcpy-c.c: Move to ...
|
|
|
d8307d |
* sysdeps/s390/stpcpy-c.c: ... here and adjust ifunc handling.
|
|
|
d8307d |
* sysdeps/s390/multiarch/stpcpy-vx.S: Move to ...
|
|
|
d8307d |
* sysdeps/s390/stpcpy-vx.S: ... here and adjust ifunc handling.
|
|
|
d8307d |
* sysdeps/s390/multiarch/stpcpy.c: Move to ...
|
|
|
d8307d |
* sysdeps/s390/stpcpy.c: ... here and adjust ifunc handling.
|
|
|
d8307d |
* sysdeps/s390/ifunc-stpcpy.h: New file.
|
|
|
d8307d |
|
|
|
d8307d |
diff --git a/sysdeps/s390/Makefile b/sysdeps/s390/Makefile
|
|
|
d8307d |
index e4191319531ecb01..b7e1bc8aecf2f8c9 100644
|
|
|
d8307d |
--- a/sysdeps/s390/Makefile
|
|
|
d8307d |
+++ b/sysdeps/s390/Makefile
|
|
|
d8307d |
@@ -39,5 +39,6 @@ sysdep_routines += bzero memset memset-z900 \
|
|
|
d8307d |
memmem memmem-vx memmem-c \
|
|
|
d8307d |
strlen strlen-vx strlen-c \
|
|
|
d8307d |
strnlen strnlen-vx strnlen-c \
|
|
|
d8307d |
- strcpy strcpy-vx strcpy-z900
|
|
|
d8307d |
+ strcpy strcpy-vx strcpy-z900 \
|
|
|
d8307d |
+ stpcpy stpcpy-vx stpcpy-c
|
|
|
d8307d |
endif
|
|
|
d8307d |
diff --git a/sysdeps/s390/ifunc-stpcpy.h b/sysdeps/s390/ifunc-stpcpy.h
|
|
|
d8307d |
new file mode 100644
|
|
|
d8307d |
index 0000000000000000..9a70cd7c8c4f4582
|
|
|
d8307d |
--- /dev/null
|
|
|
d8307d |
+++ b/sysdeps/s390/ifunc-stpcpy.h
|
|
|
d8307d |
@@ -0,0 +1,52 @@
|
|
|
d8307d |
+/* stpcpy variant information on S/390 version.
|
|
|
d8307d |
+ Copyright (C) 2018 Free Software Foundation, Inc.
|
|
|
d8307d |
+ This file is part of the GNU C Library.
|
|
|
d8307d |
+
|
|
|
d8307d |
+ The GNU C Library is free software; you can redistribute it and/or
|
|
|
d8307d |
+ modify it under the terms of the GNU Lesser General Public
|
|
|
d8307d |
+ License as published by the Free Software Foundation; either
|
|
|
d8307d |
+ version 2.1 of the License, or (at your option) any later version.
|
|
|
d8307d |
+
|
|
|
d8307d |
+ The GNU C Library is distributed in the hope that it will be useful,
|
|
|
d8307d |
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
d8307d |
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
d8307d |
+ Lesser General Public License for more details.
|
|
|
d8307d |
+
|
|
|
d8307d |
+ You should have received a copy of the GNU Lesser General Public
|
|
|
d8307d |
+ License along with the GNU C Library; if not, see
|
|
|
d8307d |
+ <http://www.gnu.org/licenses/>. */
|
|
|
d8307d |
+
|
|
|
d8307d |
+#if defined USE_MULTIARCH && IS_IN (libc) \
|
|
|
d8307d |
+ && ! defined HAVE_S390_MIN_Z13_ZARCH_ASM_SUPPORT
|
|
|
d8307d |
+# define HAVE_STPCPY_IFUNC 1
|
|
|
d8307d |
+#else
|
|
|
d8307d |
+# define HAVE_STPCPY_IFUNC 0
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
+
|
|
|
d8307d |
+#ifdef HAVE_S390_VX_ASM_SUPPORT
|
|
|
d8307d |
+# define HAVE_STPCPY_IFUNC_AND_VX_SUPPORT HAVE_STPCPY_IFUNC
|
|
|
d8307d |
+#else
|
|
|
d8307d |
+# define HAVE_STPCPY_IFUNC_AND_VX_SUPPORT 0
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
+
|
|
|
d8307d |
+#if defined HAVE_S390_MIN_Z13_ZARCH_ASM_SUPPORT
|
|
|
d8307d |
+# define STPCPY_DEFAULT STPCPY_Z13
|
|
|
d8307d |
+# define HAVE_STPCPY_C 0
|
|
|
d8307d |
+# define HAVE_STPCPY_Z13 1
|
|
|
d8307d |
+#else
|
|
|
d8307d |
+# define STPCPY_DEFAULT STPCPY_C
|
|
|
d8307d |
+# define HAVE_STPCPY_C 1
|
|
|
d8307d |
+# define HAVE_STPCPY_Z13 HAVE_STPCPY_IFUNC_AND_VX_SUPPORT
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
+
|
|
|
d8307d |
+#if HAVE_STPCPY_C
|
|
|
d8307d |
+# define STPCPY_C __stpcpy_c
|
|
|
d8307d |
+#else
|
|
|
d8307d |
+# define STPCPY_C NULL
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
+
|
|
|
d8307d |
+#if HAVE_STPCPY_Z13
|
|
|
d8307d |
+# define STPCPY_Z13 __stpcpy_vx
|
|
|
d8307d |
+#else
|
|
|
d8307d |
+# define STPCPY_Z13 NULL
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
diff --git a/sysdeps/s390/multiarch/Makefile b/sysdeps/s390/multiarch/Makefile
|
|
|
d8307d |
index 50f7f0b78df723bb..9517417dcbe1c701 100644
|
|
|
d8307d |
--- a/sysdeps/s390/multiarch/Makefile
|
|
|
d8307d |
+++ b/sysdeps/s390/multiarch/Makefile
|
|
|
d8307d |
@@ -1,6 +1,5 @@
|
|
|
d8307d |
ifeq ($(subdir),string)
|
|
|
d8307d |
-sysdep_routines += stpcpy stpcpy-vx stpcpy-c \
|
|
|
d8307d |
- strncpy strncpy-vx \
|
|
|
d8307d |
+sysdep_routines += strncpy strncpy-vx \
|
|
|
d8307d |
stpncpy stpncpy-vx stpncpy-c \
|
|
|
d8307d |
strcat strcat-vx strcat-c \
|
|
|
d8307d |
strncat strncat-vx strncat-c \
|
|
|
d8307d |
diff --git a/sysdeps/s390/multiarch/ifunc-impl-list.c b/sysdeps/s390/multiarch/ifunc-impl-list.c
|
|
|
d8307d |
index 1784372db9828463..678ed13833332f11 100644
|
|
|
d8307d |
--- a/sysdeps/s390/multiarch/ifunc-impl-list.c
|
|
|
d8307d |
+++ b/sysdeps/s390/multiarch/ifunc-impl-list.c
|
|
|
d8307d |
@@ -29,6 +29,7 @@
|
|
|
d8307d |
#include <ifunc-strlen.h>
|
|
|
d8307d |
#include <ifunc-strnlen.h>
|
|
|
d8307d |
#include <ifunc-strcpy.h>
|
|
|
d8307d |
+#include <ifunc-stpcpy.h>
|
|
|
d8307d |
|
|
|
d8307d |
/* Maximum number of IFUNC implementations. */
|
|
|
d8307d |
#define MAX_IFUNC 3
|
|
|
d8307d |
@@ -203,6 +204,18 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
|
|
|
d8307d |
)
|
|
|
d8307d |
#endif /* HAVE_STRCPY_IFUNC */
|
|
|
d8307d |
|
|
|
d8307d |
+#if HAVE_STPCPY_IFUNC
|
|
|
d8307d |
+ IFUNC_IMPL (i, name, stpcpy,
|
|
|
d8307d |
+# if HAVE_STPCPY_Z13
|
|
|
d8307d |
+ IFUNC_IMPL_ADD (array, i, stpcpy,
|
|
|
d8307d |
+ dl_hwcap & HWCAP_S390_VX, STPCPY_Z13)
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
+# if HAVE_STPCPY_C
|
|
|
d8307d |
+ IFUNC_IMPL_ADD (array, i, stpcpy, 1, STPCPY_C)
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
+ )
|
|
|
d8307d |
+#endif /* HAVE_STPCPY_IFUNC */
|
|
|
d8307d |
+
|
|
|
d8307d |
#ifdef HAVE_S390_VX_ASM_SUPPORT
|
|
|
d8307d |
|
|
|
d8307d |
# define IFUNC_VX_IMPL(FUNC) \
|
|
|
d8307d |
@@ -217,7 +230,6 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
|
|
|
d8307d |
|
|
|
d8307d |
IFUNC_VX_IMPL (wcscpy);
|
|
|
d8307d |
|
|
|
d8307d |
- IFUNC_VX_IMPL (stpcpy);
|
|
|
d8307d |
IFUNC_VX_IMPL (wcpcpy);
|
|
|
d8307d |
|
|
|
d8307d |
IFUNC_VX_IMPL (strncpy);
|
|
|
d8307d |
diff --git a/sysdeps/s390/multiarch/stpcpy-c.c b/sysdeps/s390/stpcpy-c.c
|
|
|
d8307d |
similarity index 74%
|
|
|
d8307d |
rename from sysdeps/s390/multiarch/stpcpy-c.c
|
|
|
d8307d |
rename to sysdeps/s390/stpcpy-c.c
|
|
|
d8307d |
index 4a1c3e5832c9b544..76ec88462717799c 100644
|
|
|
d8307d |
--- a/sysdeps/s390/multiarch/stpcpy-c.c
|
|
|
d8307d |
+++ b/sysdeps/s390/stpcpy-c.c
|
|
|
d8307d |
@@ -16,20 +16,25 @@
|
|
|
d8307d |
License along with the GNU C Library; if not, see
|
|
|
d8307d |
<http://www.gnu.org/licenses/>. */
|
|
|
d8307d |
|
|
|
d8307d |
-#if defined HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc)
|
|
|
d8307d |
-# define STPCPY __stpcpy_c
|
|
|
d8307d |
-# undef weak_alias
|
|
|
d8307d |
-# define weak_alias(a, b)
|
|
|
d8307d |
-# ifdef SHARED
|
|
|
d8307d |
-# undef libc_hidden_def
|
|
|
d8307d |
-# define libc_hidden_def(name) \
|
|
|
d8307d |
+#include <ifunc-stpcpy.h>
|
|
|
d8307d |
+
|
|
|
d8307d |
+#if HAVE_STPCPY_C
|
|
|
d8307d |
+# if HAVE_STPCPY_IFUNC
|
|
|
d8307d |
+# define STPCPY STPCPY_C
|
|
|
d8307d |
+
|
|
|
d8307d |
+# undef weak_alias
|
|
|
d8307d |
+# define weak_alias(a, b)
|
|
|
d8307d |
+
|
|
|
d8307d |
+# if defined SHARED && IS_IN (libc)
|
|
|
d8307d |
+# undef libc_hidden_def
|
|
|
d8307d |
+# define libc_hidden_def(name) \
|
|
|
d8307d |
__hidden_ver1 (__stpcpy_c, __GI___stpcpy, __stpcpy_c);
|
|
|
d8307d |
-# undef libc_hidden_builtin_def
|
|
|
d8307d |
-# define libc_hidden_builtin_def(name) \
|
|
|
d8307d |
+# undef libc_hidden_builtin_def
|
|
|
d8307d |
+# define libc_hidden_builtin_def(name) \
|
|
|
d8307d |
strong_alias (__stpcpy_c, __stpcpy_c_1); \
|
|
|
d8307d |
__hidden_ver1 (__stpcpy_c_1, __GI_stpcpy, __stpcpy_c_1);
|
|
|
d8307d |
-# endif /* SHARED */
|
|
|
d8307d |
-
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
|
|
|
d8307d |
# include <string/stpcpy.c>
|
|
|
d8307d |
-#endif /* HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc) */
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
diff --git a/sysdeps/s390/multiarch/stpcpy-vx.S b/sysdeps/s390/stpcpy-vx.S
|
|
|
d8307d |
similarity index 90%
|
|
|
d8307d |
rename from sysdeps/s390/multiarch/stpcpy-vx.S
|
|
|
d8307d |
rename to sysdeps/s390/stpcpy-vx.S
|
|
|
d8307d |
index 6c17def0fc35d60d..d2db02d0cd714d27 100644
|
|
|
d8307d |
--- a/sysdeps/s390/multiarch/stpcpy-vx.S
|
|
|
d8307d |
+++ b/sysdeps/s390/stpcpy-vx.S
|
|
|
d8307d |
@@ -16,7 +16,9 @@
|
|
|
d8307d |
License along with the GNU C Library; if not, see
|
|
|
d8307d |
<http://www.gnu.org/licenses/>. */
|
|
|
d8307d |
|
|
|
d8307d |
-#if defined HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc)
|
|
|
d8307d |
+#include <ifunc-stpcpy.h>
|
|
|
d8307d |
+
|
|
|
d8307d |
+#if HAVE_STPCPY_Z13
|
|
|
d8307d |
|
|
|
d8307d |
# include "sysdep.h"
|
|
|
d8307d |
# include "asm-syntax.h"
|
|
|
d8307d |
@@ -36,7 +38,7 @@
|
|
|
d8307d |
-v17=index of zero
|
|
|
d8307d |
-v18=part of src
|
|
|
d8307d |
*/
|
|
|
d8307d |
-ENTRY(__stpcpy_vx)
|
|
|
d8307d |
+ENTRY(STPCPY_Z13)
|
|
|
d8307d |
.machine "z13"
|
|
|
d8307d |
.machinemode "zarch_nohighgprs"
|
|
|
d8307d |
|
|
|
d8307d |
@@ -100,5 +102,15 @@ ENTRY(__stpcpy_vx)
|
|
|
d8307d |
vstl %v16,%r5,0(%r2) /* Copy characters including zero. */
|
|
|
d8307d |
la %r2,0(%r5,%r2) /* Return pointer to zero. */
|
|
|
d8307d |
br %r14
|
|
|
d8307d |
-END(__stpcpy_vx)
|
|
|
d8307d |
-#endif /* HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc) */
|
|
|
d8307d |
+END(STPCPY_Z13)
|
|
|
d8307d |
+
|
|
|
d8307d |
+# if ! HAVE_STPCPY_IFUNC
|
|
|
d8307d |
+strong_alias (STPCPY_Z13, __stpcpy)
|
|
|
d8307d |
+weak_alias (__stpcpy, stpcpy)
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
+
|
|
|
d8307d |
+# if ! HAVE_STPCPY_C && defined SHARED && IS_IN (libc)
|
|
|
d8307d |
+strong_alias (STPCPY_Z13, __GI_stpcpy)
|
|
|
d8307d |
+strong_alias (STPCPY_Z13, __GI___stpcpy)
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
+#endif
|
|
|
d8307d |
diff --git a/sysdeps/s390/multiarch/stpcpy.c b/sysdeps/s390/stpcpy.c
|
|
|
d8307d |
similarity index 74%
|
|
|
d8307d |
rename from sysdeps/s390/multiarch/stpcpy.c
|
|
|
d8307d |
rename to sysdeps/s390/stpcpy.c
|
|
|
d8307d |
index 654f9dfbef512e34..670604e2de3806b7 100644
|
|
|
d8307d |
--- a/sysdeps/s390/multiarch/stpcpy.c
|
|
|
d8307d |
+++ b/sysdeps/s390/stpcpy.c
|
|
|
d8307d |
@@ -16,7 +16,9 @@
|
|
|
d8307d |
License along with the GNU C Library; if not, see
|
|
|
d8307d |
<http://www.gnu.org/licenses/>. */
|
|
|
d8307d |
|
|
|
d8307d |
-#if defined HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc)
|
|
|
d8307d |
+#include <ifunc-stpcpy.h>
|
|
|
d8307d |
+
|
|
|
d8307d |
+#if HAVE_STPCPY_IFUNC
|
|
|
d8307d |
# define stpcpy __redirect_stpcpy
|
|
|
d8307d |
# define __stpcpy __redirect___stpcpy
|
|
|
d8307d |
/* Omit the stpcpy inline definitions because it would redefine stpcpy. */
|
|
|
d8307d |
@@ -27,9 +29,18 @@
|
|
|
d8307d |
# undef __stpcpy
|
|
|
d8307d |
# include <ifunc-resolve.h>
|
|
|
d8307d |
|
|
|
d8307d |
-s390_vx_libc_ifunc_redirected (__redirect___stpcpy, __stpcpy);
|
|
|
d8307d |
-weak_alias (__stpcpy, stpcpy)
|
|
|
d8307d |
+# if HAVE_STPCPY_C
|
|
|
d8307d |
+extern __typeof (__redirect_stpcpy) STPCPY_C attribute_hidden;
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
|
|
|
d8307d |
-#else
|
|
|
d8307d |
-# include <string/stpcpy.c>
|
|
|
d8307d |
-#endif /* !(defined HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc)) */
|
|
|
d8307d |
+# if HAVE_STPCPY_Z13
|
|
|
d8307d |
+extern __typeof (__redirect_stpcpy) STPCPY_Z13 attribute_hidden;
|
|
|
d8307d |
+# endif
|
|
|
d8307d |
+
|
|
|
d8307d |
+s390_libc_ifunc_expr (__redirect___stpcpy, __stpcpy,
|
|
|
d8307d |
+ (HAVE_STPCPY_Z13 && (hwcap & HWCAP_S390_VX))
|
|
|
d8307d |
+ ? STPCPY_Z13
|
|
|
d8307d |
+ : STPCPY_DEFAULT
|
|
|
d8307d |
+ )
|
|
|
d8307d |
+weak_alias (__stpcpy, stpcpy)
|
|
|
d8307d |
+#endif
|