077c9d
commit 914a4e05572e108201d71dcd3e47da8aeeecd70d
077c9d
Author: Stefan Liebler <stli@linux.ibm.com>
077c9d
Date:   Tue Dec 18 13:57:10 2018 +0100
077c9d
077c9d
    S390: Refactor strcpy ifunc handling.
077c9d
    
077c9d
    The ifunc handling for strcpy is adjusted in order to omit ifunc
077c9d
    variants if those will never be used as the minimum architecture level
077c9d
    already supports newer CPUs by default.
077c9d
    Glibc internal calls will then also use the "newer" ifunc variant.
077c9d
    
077c9d
    Note: The fallback s390-32/s390-64 ifunc variants with mvst instruction
077c9d
    are now moved to the unified strcpy-z900.S file which can be used for
077c9d
    31/64bit. The s390-32/s390-64 files multiarch/strcpy.c and strcpy.S
077c9d
    are deleted.
077c9d
    
077c9d
    ChangeLog:
077c9d
    
077c9d
            * sysdeps/s390/multiarch/Makefile
077c9d
            (sysdep_routines): Remove strcpy variants.
077c9d
            * sysdeps/s390/Makefile (sysdep_routines): Add strcpy variants.
077c9d
            * sysdeps/s390/multiarch/ifunc-impl-list.c
077c9d
            (__libc_ifunc_impl_list): Refactor ifunc handling for strcpy.
077c9d
            * sysdeps/s390/multiarch/strcpy-vx.S: Move to ...
077c9d
            * sysdeps/s390/strcpy-vx.S: ... here and adjust ifunc handling.
077c9d
            * sysdeps/s390/multiarch/strcpy.c: Move to ...
077c9d
            * sysdeps/s390/strcpy.c: ... here and adjust ifunc handling.
077c9d
            * sysdeps/s390/ifunc-strcpy.h: New file.
077c9d
            * sysdeps/s390/s390-64/strcpy.S: Move to ...
077c9d
            * sysdeps/s390/strcpy-z900.S: ... here and adjust to be usable
077c9d
            for 31/64bit and ifunc handling.
077c9d
            * sysdeps/s390/s390-32/multiarch/strcpy.c: Delete file.
077c9d
            * sysdeps/s390/s390-64/multiarch/strcpy.c: Likewise.
077c9d
            * sysdeps/s390/s390-32/strcpy.S: Likewise.
077c9d
077c9d
diff --git a/sysdeps/s390/Makefile b/sysdeps/s390/Makefile
077c9d
index f092355743e3908f..e4191319531ecb01 100644
077c9d
--- a/sysdeps/s390/Makefile
077c9d
+++ b/sysdeps/s390/Makefile
077c9d
@@ -38,5 +38,6 @@ sysdep_routines += bzero memset memset-z900 \
077c9d
 		   strstr strstr-vx strstr-c \
077c9d
 		   memmem memmem-vx memmem-c \
077c9d
 		   strlen strlen-vx strlen-c \
077c9d
-		   strnlen strnlen-vx strnlen-c
077c9d
+		   strnlen strnlen-vx strnlen-c \
077c9d
+		   strcpy strcpy-vx strcpy-z900
077c9d
 endif
077c9d
diff --git a/sysdeps/s390/ifunc-strcpy.h b/sysdeps/s390/ifunc-strcpy.h
077c9d
new file mode 100644
077c9d
index 0000000000000000..85e45556e6a61dd5
077c9d
--- /dev/null
077c9d
+++ b/sysdeps/s390/ifunc-strcpy.h
077c9d
@@ -0,0 +1,52 @@
077c9d
+/* strcpy variant information on S/390 version.
077c9d
+   Copyright (C) 2018 Free Software Foundation, Inc.
077c9d
+   This file is part of the GNU C Library.
077c9d
+
077c9d
+   The GNU C Library is free software; you can redistribute it and/or
077c9d
+   modify it under the terms of the GNU Lesser General Public
077c9d
+   License as published by the Free Software Foundation; either
077c9d
+   version 2.1 of the License, or (at your option) any later version.
077c9d
+
077c9d
+   The GNU C Library is distributed in the hope that it will be useful,
077c9d
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
077c9d
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
077c9d
+   Lesser General Public License for more details.
077c9d
+
077c9d
+   You should have received a copy of the GNU Lesser General Public
077c9d
+   License along with the GNU C Library; if not, see
077c9d
+   <http://www.gnu.org/licenses/>.  */
077c9d
+
077c9d
+#if defined USE_MULTIARCH && IS_IN (libc)		\
077c9d
+  && ! defined HAVE_S390_MIN_Z13_ZARCH_ASM_SUPPORT
077c9d
+# define HAVE_STRCPY_IFUNC	1
077c9d
+#else
077c9d
+# define HAVE_STRCPY_IFUNC	0
077c9d
+#endif
077c9d
+
077c9d
+#ifdef HAVE_S390_VX_ASM_SUPPORT
077c9d
+# define HAVE_STRCPY_IFUNC_AND_VX_SUPPORT HAVE_STRCPY_IFUNC
077c9d
+#else
077c9d
+# define HAVE_STRCPY_IFUNC_AND_VX_SUPPORT 0
077c9d
+#endif
077c9d
+
077c9d
+#if defined HAVE_S390_MIN_Z13_ZARCH_ASM_SUPPORT
077c9d
+# define STRCPY_DEFAULT		STRCPY_Z13
077c9d
+# define HAVE_STRCPY_Z900_G5	0
077c9d
+# define HAVE_STRCPY_Z13	1
077c9d
+#else
077c9d
+# define STRCPY_DEFAULT		STRCPY_Z900_G5
077c9d
+# define HAVE_STRCPY_Z900_G5	1
077c9d
+# define HAVE_STRCPY_Z13	HAVE_STRCPY_IFUNC_AND_VX_SUPPORT
077c9d
+#endif
077c9d
+
077c9d
+#if HAVE_STRCPY_Z900_G5
077c9d
+# define STRCPY_Z900_G5		__strcpy_default
077c9d
+#else
077c9d
+# define STRCPY_Z900_G5		NULL
077c9d
+#endif
077c9d
+
077c9d
+#if HAVE_STRCPY_Z13
077c9d
+# define STRCPY_Z13		__strcpy_vx
077c9d
+#else
077c9d
+# define STRCPY_Z13		NULL
077c9d
+#endif
077c9d
diff --git a/sysdeps/s390/multiarch/Makefile b/sysdeps/s390/multiarch/Makefile
077c9d
index 35ba223c5d4fb52f..50f7f0b78df723bb 100644
077c9d
--- a/sysdeps/s390/multiarch/Makefile
077c9d
+++ b/sysdeps/s390/multiarch/Makefile
077c9d
@@ -1,6 +1,5 @@
077c9d
 ifeq ($(subdir),string)
077c9d
-sysdep_routines += strcpy strcpy-vx \
077c9d
-		   stpcpy stpcpy-vx stpcpy-c \
077c9d
+sysdep_routines += stpcpy stpcpy-vx stpcpy-c \
077c9d
 		   strncpy strncpy-vx \
077c9d
 		   stpncpy stpncpy-vx stpncpy-c \
077c9d
 		   strcat strcat-vx strcat-c \
077c9d
diff --git a/sysdeps/s390/multiarch/ifunc-impl-list.c b/sysdeps/s390/multiarch/ifunc-impl-list.c
077c9d
index 680e5b738bfb7f32..1784372db9828463 100644
077c9d
--- a/sysdeps/s390/multiarch/ifunc-impl-list.c
077c9d
+++ b/sysdeps/s390/multiarch/ifunc-impl-list.c
077c9d
@@ -28,6 +28,7 @@
077c9d
 #include <ifunc-memmem.h>
077c9d
 #include <ifunc-strlen.h>
077c9d
 #include <ifunc-strnlen.h>
077c9d
+#include <ifunc-strcpy.h>
077c9d
 
077c9d
 /* Maximum number of IFUNC implementations.  */
077c9d
 #define MAX_IFUNC	3
077c9d
@@ -190,6 +191,18 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
077c9d
 		)
077c9d
 #endif /* HAVE_STRNLEN_IFUNC  */
077c9d
 
077c9d
+#if HAVE_STRCPY_IFUNC
077c9d
+    IFUNC_IMPL (i, name, strcpy,
077c9d
+# if HAVE_STRCPY_Z13
077c9d
+		IFUNC_IMPL_ADD (array, i, strcpy,
077c9d
+				dl_hwcap & HWCAP_S390_VX, STRCPY_Z13)
077c9d
+# endif
077c9d
+# if HAVE_STRCPY_Z900_G5
077c9d
+		IFUNC_IMPL_ADD (array, i, strcpy, 1, STRCPY_Z900_G5)
077c9d
+# endif
077c9d
+		)
077c9d
+#endif /* HAVE_STRCPY_IFUNC  */
077c9d
+
077c9d
 #ifdef HAVE_S390_VX_ASM_SUPPORT
077c9d
 
077c9d
 # define IFUNC_VX_IMPL(FUNC)						\
077c9d
@@ -202,7 +215,6 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
077c9d
 
077c9d
   IFUNC_VX_IMPL (wcsnlen);
077c9d
 
077c9d
-  IFUNC_VX_IMPL (strcpy);
077c9d
   IFUNC_VX_IMPL (wcscpy);
077c9d
 
077c9d
   IFUNC_VX_IMPL (stpcpy);
077c9d
diff --git a/sysdeps/s390/s390-32/multiarch/strcpy.c b/sysdeps/s390/s390-32/multiarch/strcpy.c
077c9d
deleted file mode 100644
077c9d
index 6a22e31a03c8c1c4..0000000000000000
077c9d
--- a/sysdeps/s390/s390-32/multiarch/strcpy.c
077c9d
+++ /dev/null
077c9d
@@ -1,21 +0,0 @@
077c9d
-/* Multiple versions of strcpy.
077c9d
-   Copyright (C) 2015-2018 Free Software Foundation, Inc.
077c9d
-   This file is part of the GNU C Library.
077c9d
-
077c9d
-   The GNU C Library is free software; you can redistribute it and/or
077c9d
-   modify it under the terms of the GNU Lesser General Public
077c9d
-   License as published by the Free Software Foundation; either
077c9d
-   version 2.1 of the License, or (at your option) any later version.
077c9d
-
077c9d
-   The GNU C Library is distributed in the hope that it will be useful,
077c9d
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
077c9d
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
077c9d
-   Lesser General Public License for more details.
077c9d
-
077c9d
-   You should have received a copy of the GNU Lesser General Public
077c9d
-   License along with the GNU C Library; if not, see
077c9d
-   <http://www.gnu.org/licenses/>.  */
077c9d
-
077c9d
-/* This wrapper-file is needed, because otherwise file
077c9d
-   sysdeps/s390/s390-[32|64]/strcpy.S will be used.  */
077c9d
-#include <sysdeps/s390/multiarch/strcpy.c>
077c9d
diff --git a/sysdeps/s390/s390-32/strcpy.S b/sysdeps/s390/s390-32/strcpy.S
077c9d
deleted file mode 100644
077c9d
index d49136ee92b83378..0000000000000000
077c9d
--- a/sysdeps/s390/s390-32/strcpy.S
077c9d
+++ /dev/null
077c9d
@@ -1,36 +0,0 @@
077c9d
-/* strcpy - copy a string from source to destination. For IBM S390
077c9d
-   This file is part of the GNU C Library.
077c9d
-   Copyright (C) 2000-2018 Free Software Foundation, Inc.
077c9d
-   Contributed by Martin Schwidefsky (schwidefsky@de.ibm.com).
077c9d
-
077c9d
-   The GNU C Library is free software; you can redistribute it and/or
077c9d
-   modify it under the terms of the GNU Lesser General Public
077c9d
-   License as published by the Free Software Foundation; either
077c9d
-   version 2.1 of the License, or (at your option) any later version.
077c9d
-
077c9d
-   The GNU C Library is distributed in the hope that it will be useful,
077c9d
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
077c9d
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
077c9d
-   Lesser General Public License for more details.
077c9d
-
077c9d
-   You should have received a copy of the GNU Lesser General Public
077c9d
-   License along with the GNU C Library; if not, see
077c9d
-   <http://www.gnu.org/licenses/>.  */
077c9d
-
077c9d
-/*
077c9d
- * R2 = address of destination
077c9d
- * R3 = address of source
077c9d
- */
077c9d
-
077c9d
-#include "sysdep.h"
077c9d
-#include "asm-syntax.h"
077c9d
-
077c9d
-	.text
077c9d
-ENTRY(strcpy)
077c9d
-	slr   %r0,%r0
077c9d
-	lr    %r1,%r2
077c9d
-0:      mvst  %r1,%r3
077c9d
-	jo    0b
077c9d
-	br    %r14
077c9d
-END(strcpy)
077c9d
-libc_hidden_builtin_def (strcpy)
077c9d
diff --git a/sysdeps/s390/s390-64/multiarch/strcpy.c b/sysdeps/s390/s390-64/multiarch/strcpy.c
077c9d
deleted file mode 100644
077c9d
index 6a22e31a03c8c1c4..0000000000000000
077c9d
--- a/sysdeps/s390/s390-64/multiarch/strcpy.c
077c9d
+++ /dev/null
077c9d
@@ -1,21 +0,0 @@
077c9d
-/* Multiple versions of strcpy.
077c9d
-   Copyright (C) 2015-2018 Free Software Foundation, Inc.
077c9d
-   This file is part of the GNU C Library.
077c9d
-
077c9d
-   The GNU C Library is free software; you can redistribute it and/or
077c9d
-   modify it under the terms of the GNU Lesser General Public
077c9d
-   License as published by the Free Software Foundation; either
077c9d
-   version 2.1 of the License, or (at your option) any later version.
077c9d
-
077c9d
-   The GNU C Library is distributed in the hope that it will be useful,
077c9d
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
077c9d
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
077c9d
-   Lesser General Public License for more details.
077c9d
-
077c9d
-   You should have received a copy of the GNU Lesser General Public
077c9d
-   License along with the GNU C Library; if not, see
077c9d
-   <http://www.gnu.org/licenses/>.  */
077c9d
-
077c9d
-/* This wrapper-file is needed, because otherwise file
077c9d
-   sysdeps/s390/s390-[32|64]/strcpy.S will be used.  */
077c9d
-#include <sysdeps/s390/multiarch/strcpy.c>
077c9d
diff --git a/sysdeps/s390/multiarch/strcpy-vx.S b/sysdeps/s390/strcpy-vx.S
077c9d
similarity index 85%
077c9d
rename from sysdeps/s390/multiarch/strcpy-vx.S
077c9d
rename to sysdeps/s390/strcpy-vx.S
077c9d
index 52197f57f7b5d5cf..844d23e4fee32c9b 100644
077c9d
--- a/sysdeps/s390/multiarch/strcpy-vx.S
077c9d
+++ b/sysdeps/s390/strcpy-vx.S
077c9d
@@ -16,13 +16,13 @@
077c9d
    License along with the GNU C Library; if not, see
077c9d
    <http://www.gnu.org/licenses/>.  */
077c9d
 
077c9d
-#if defined HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc)
077c9d
-
077c9d
-# include "sysdep.h"
077c9d
-# include "asm-syntax.h"
077c9d
+#include <ifunc-strcpy.h>
077c9d
+#include "sysdep.h"
077c9d
+#include "asm-syntax.h"
077c9d
 
077c9d
 	.text
077c9d
 
077c9d
+#if HAVE_STRCPY_Z13
077c9d
 /* char * strcpy (const char *dest, const char *src)
077c9d
    Copy string src to dest.
077c9d
 
077c9d
@@ -36,7 +36,7 @@
077c9d
    -v17=index of zero
077c9d
    -v18=part of src
077c9d
 */
077c9d
-ENTRY(__strcpy_vx)
077c9d
+ENTRY(STRCPY_Z13)
077c9d
 	.machine "z13"
077c9d
 	.machinemode "zarch_nohighgprs"
077c9d
 
077c9d
@@ -97,13 +97,13 @@ ENTRY(__strcpy_vx)
077c9d
 .Lfound_align:
077c9d
 	vstl	%v16,%r5,0(%r2)	/* Copy characters including zero.  */
077c9d
 	br	%r14
077c9d
-END(__strcpy_vx)
077c9d
+END(STRCPY_Z13)
077c9d
 
077c9d
-/* Use mvst-strcpy-implementation as default implementation.  */
077c9d
-# define strcpy __strcpy_c
077c9d
-# undef libc_hidden_builtin_def
077c9d
-# define libc_hidden_builtin_def(name) strong_alias(__strcpy_c, __GI_strcpy)
077c9d
-#endif /* HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc) */
077c9d
+# if ! HAVE_STRCPY_IFUNC
077c9d
+strong_alias (STRCPY_Z13, strcpy)
077c9d
+# endif
077c9d
 
077c9d
-/* Include mvst-strcpy-implementation in s390-32/s390-64 subdirectory.  */
077c9d
-#include <strcpy.S>
077c9d
+# if ! HAVE_STRCPY_Z900_G5 && defined SHARED && IS_IN (libc)
077c9d
+strong_alias (STRCPY_Z13, __GI_strcpy)
077c9d
+# endif
077c9d
+#endif
077c9d
diff --git a/sysdeps/s390/s390-64/strcpy.S b/sysdeps/s390/strcpy-z900.S
077c9d
similarity index 66%
077c9d
rename from sysdeps/s390/s390-64/strcpy.S
077c9d
rename to sysdeps/s390/strcpy-z900.S
077c9d
index 203c73c905d0d86c..42798b1fd5c51187 100644
077c9d
--- a/sysdeps/s390/s390-64/strcpy.S
077c9d
+++ b/sysdeps/s390/strcpy-z900.S
077c9d
@@ -1,4 +1,4 @@
077c9d
-/* strcpy - copy a string from source to destination.  64 bit S/390 version.
077c9d
+/* strcpy - copy a string from source to destination.  64/31 bit S/390 version.
077c9d
    Copyright (C) 2001-2018 Free Software Foundation, Inc.
077c9d
    Contributed by Martin Schwidefsky (schwidefsky@de.ibm.com).
077c9d
    This file is part of the GNU C Library.
077c9d
@@ -21,15 +21,36 @@
077c9d
      %r2 = address of destination
077c9d
      %r3 = address of source.  */
077c9d
 
077c9d
+#include <ifunc-strcpy.h>
077c9d
 #include "sysdep.h"
077c9d
 #include "asm-syntax.h"
077c9d
 
077c9d
+#if HAVE_STRCPY_Z900_G5
077c9d
+# if defined __s390x__
077c9d
+#  define SLGR	slgr
077c9d
+#  define LGR	lgr
077c9d
+# else
077c9d
+#  define SLGR	slr
077c9d
+#  define LGR	lr
077c9d
+# endif /* ! defined __s390x__  */
077c9d
+
077c9d
         .text
077c9d
-ENTRY(strcpy)
077c9d
-	slgr  %r0,%r0
077c9d
-	lgr   %r1,%r2
077c9d
+ENTRY(STRCPY_Z900_G5)
077c9d
+	SLGR  %r0,%r0
077c9d
+	LGR   %r1,%r2
077c9d
 0:	mvst  %r1,%r3
077c9d
 	jo    0b
077c9d
 	br    %r14
077c9d
-END(strcpy)
077c9d
-libc_hidden_builtin_def (strcpy)
077c9d
+END(STRCPY_Z900_G5)
077c9d
+
077c9d
+# undef SLGR
077c9d
+# undef LGR
077c9d
+
077c9d
+# if ! HAVE_STRCPY_IFUNC
077c9d
+strong_alias (STRCPY_Z900_G5, strcpy)
077c9d
+# endif
077c9d
+
077c9d
+# if defined SHARED && IS_IN (libc)
077c9d
+strong_alias (STRCPY_Z900_G5, __GI_strcpy)
077c9d
+# endif
077c9d
+#endif
077c9d
diff --git a/sysdeps/s390/multiarch/strcpy.c b/sysdeps/s390/strcpy.c
077c9d
similarity index 69%
077c9d
rename from sysdeps/s390/multiarch/strcpy.c
077c9d
rename to sysdeps/s390/strcpy.c
077c9d
index 8f32a13f6730c427..f4e28e24c85b7162 100644
077c9d
--- a/sysdeps/s390/multiarch/strcpy.c
077c9d
+++ b/sysdeps/s390/strcpy.c
077c9d
@@ -16,12 +16,25 @@
077c9d
    License along with the GNU C Library; if not, see
077c9d
    <http://www.gnu.org/licenses/>.  */
077c9d
 
077c9d
-#if defined HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc)
077c9d
+#include <ifunc-strcpy.h>
077c9d
+
077c9d
+#if HAVE_STRCPY_IFUNC
077c9d
 # define strcpy __redirect_strcpy
077c9d
 # include <string.h>
077c9d
 # undef strcpy
077c9d
 # include <ifunc-resolve.h>
077c9d
 
077c9d
-s390_vx_libc_ifunc2_redirected (__redirect_strcpy, __strcpy, strcpy)
077c9d
+# if HAVE_STRCPY_Z900_G5
077c9d
+extern __typeof (__redirect_strcpy) STRCPY_Z900_G5 attribute_hidden;
077c9d
+# endif
077c9d
+
077c9d
+# if HAVE_STRCPY_Z13
077c9d
+extern __typeof (__redirect_strcpy) STRCPY_Z13 attribute_hidden;
077c9d
+# endif
077c9d
 
077c9d
+s390_libc_ifunc_expr (__redirect_strcpy, strcpy,
077c9d
+		      (HAVE_STRCPY_Z13 && (hwcap & HWCAP_S390_VX))
077c9d
+		      ? STRCPY_Z13
077c9d
+		      : STRCPY_DEFAULT
077c9d
+		      )
077c9d
 #endif