bdc76f
commit 914a4e05572e108201d71dcd3e47da8aeeecd70d
bdc76f
Author: Stefan Liebler <stli@linux.ibm.com>
bdc76f
Date:   Tue Dec 18 13:57:10 2018 +0100
bdc76f
bdc76f
    S390: Refactor strcpy ifunc handling.
bdc76f
    
bdc76f
    The ifunc handling for strcpy is adjusted in order to omit ifunc
bdc76f
    variants if those will never be used as the minimum architecture level
bdc76f
    already supports newer CPUs by default.
bdc76f
    Glibc internal calls will then also use the "newer" ifunc variant.
bdc76f
    
bdc76f
    Note: The fallback s390-32/s390-64 ifunc variants with mvst instruction
bdc76f
    are now moved to the unified strcpy-z900.S file which can be used for
bdc76f
    31/64bit. The s390-32/s390-64 files multiarch/strcpy.c and strcpy.S
bdc76f
    are deleted.
bdc76f
    
bdc76f
    ChangeLog:
bdc76f
    
bdc76f
            * sysdeps/s390/multiarch/Makefile
bdc76f
            (sysdep_routines): Remove strcpy variants.
bdc76f
            * sysdeps/s390/Makefile (sysdep_routines): Add strcpy variants.
bdc76f
            * sysdeps/s390/multiarch/ifunc-impl-list.c
bdc76f
            (__libc_ifunc_impl_list): Refactor ifunc handling for strcpy.
bdc76f
            * sysdeps/s390/multiarch/strcpy-vx.S: Move to ...
bdc76f
            * sysdeps/s390/strcpy-vx.S: ... here and adjust ifunc handling.
bdc76f
            * sysdeps/s390/multiarch/strcpy.c: Move to ...
bdc76f
            * sysdeps/s390/strcpy.c: ... here and adjust ifunc handling.
bdc76f
            * sysdeps/s390/ifunc-strcpy.h: New file.
bdc76f
            * sysdeps/s390/s390-64/strcpy.S: Move to ...
bdc76f
            * sysdeps/s390/strcpy-z900.S: ... here and adjust to be usable
bdc76f
            for 31/64bit and ifunc handling.
bdc76f
            * sysdeps/s390/s390-32/multiarch/strcpy.c: Delete file.
bdc76f
            * sysdeps/s390/s390-64/multiarch/strcpy.c: Likewise.
bdc76f
            * sysdeps/s390/s390-32/strcpy.S: Likewise.
bdc76f
bdc76f
diff --git a/sysdeps/s390/Makefile b/sysdeps/s390/Makefile
bdc76f
index f092355743e3908f..e4191319531ecb01 100644
bdc76f
--- a/sysdeps/s390/Makefile
bdc76f
+++ b/sysdeps/s390/Makefile
bdc76f
@@ -38,5 +38,6 @@ sysdep_routines += bzero memset memset-z900 \
bdc76f
 		   strstr strstr-vx strstr-c \
bdc76f
 		   memmem memmem-vx memmem-c \
bdc76f
 		   strlen strlen-vx strlen-c \
bdc76f
-		   strnlen strnlen-vx strnlen-c
bdc76f
+		   strnlen strnlen-vx strnlen-c \
bdc76f
+		   strcpy strcpy-vx strcpy-z900
bdc76f
 endif
bdc76f
diff --git a/sysdeps/s390/ifunc-strcpy.h b/sysdeps/s390/ifunc-strcpy.h
bdc76f
new file mode 100644
bdc76f
index 0000000000000000..85e45556e6a61dd5
bdc76f
--- /dev/null
bdc76f
+++ b/sysdeps/s390/ifunc-strcpy.h
bdc76f
@@ -0,0 +1,52 @@
bdc76f
+/* strcpy variant information on S/390 version.
bdc76f
+   Copyright (C) 2018 Free Software Foundation, Inc.
bdc76f
+   This file is part of the GNU C Library.
bdc76f
+
bdc76f
+   The GNU C Library is free software; you can redistribute it and/or
bdc76f
+   modify it under the terms of the GNU Lesser General Public
bdc76f
+   License as published by the Free Software Foundation; either
bdc76f
+   version 2.1 of the License, or (at your option) any later version.
bdc76f
+
bdc76f
+   The GNU C Library is distributed in the hope that it will be useful,
bdc76f
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
bdc76f
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
bdc76f
+   Lesser General Public License for more details.
bdc76f
+
bdc76f
+   You should have received a copy of the GNU Lesser General Public
bdc76f
+   License along with the GNU C Library; if not, see
bdc76f
+   <http://www.gnu.org/licenses/>.  */
bdc76f
+
bdc76f
+#if defined USE_MULTIARCH && IS_IN (libc)		\
bdc76f
+  && ! defined HAVE_S390_MIN_Z13_ZARCH_ASM_SUPPORT
bdc76f
+# define HAVE_STRCPY_IFUNC	1
bdc76f
+#else
bdc76f
+# define HAVE_STRCPY_IFUNC	0
bdc76f
+#endif
bdc76f
+
bdc76f
+#ifdef HAVE_S390_VX_ASM_SUPPORT
bdc76f
+# define HAVE_STRCPY_IFUNC_AND_VX_SUPPORT HAVE_STRCPY_IFUNC
bdc76f
+#else
bdc76f
+# define HAVE_STRCPY_IFUNC_AND_VX_SUPPORT 0
bdc76f
+#endif
bdc76f
+
bdc76f
+#if defined HAVE_S390_MIN_Z13_ZARCH_ASM_SUPPORT
bdc76f
+# define STRCPY_DEFAULT		STRCPY_Z13
bdc76f
+# define HAVE_STRCPY_Z900_G5	0
bdc76f
+# define HAVE_STRCPY_Z13	1
bdc76f
+#else
bdc76f
+# define STRCPY_DEFAULT		STRCPY_Z900_G5
bdc76f
+# define HAVE_STRCPY_Z900_G5	1
bdc76f
+# define HAVE_STRCPY_Z13	HAVE_STRCPY_IFUNC_AND_VX_SUPPORT
bdc76f
+#endif
bdc76f
+
bdc76f
+#if HAVE_STRCPY_Z900_G5
bdc76f
+# define STRCPY_Z900_G5		__strcpy_default
bdc76f
+#else
bdc76f
+# define STRCPY_Z900_G5		NULL
bdc76f
+#endif
bdc76f
+
bdc76f
+#if HAVE_STRCPY_Z13
bdc76f
+# define STRCPY_Z13		__strcpy_vx
bdc76f
+#else
bdc76f
+# define STRCPY_Z13		NULL
bdc76f
+#endif
bdc76f
diff --git a/sysdeps/s390/multiarch/Makefile b/sysdeps/s390/multiarch/Makefile
bdc76f
index 35ba223c5d4fb52f..50f7f0b78df723bb 100644
bdc76f
--- a/sysdeps/s390/multiarch/Makefile
bdc76f
+++ b/sysdeps/s390/multiarch/Makefile
bdc76f
@@ -1,6 +1,5 @@
bdc76f
 ifeq ($(subdir),string)
bdc76f
-sysdep_routines += strcpy strcpy-vx \
bdc76f
-		   stpcpy stpcpy-vx stpcpy-c \
bdc76f
+sysdep_routines += stpcpy stpcpy-vx stpcpy-c \
bdc76f
 		   strncpy strncpy-vx \
bdc76f
 		   stpncpy stpncpy-vx stpncpy-c \
bdc76f
 		   strcat strcat-vx strcat-c \
bdc76f
diff --git a/sysdeps/s390/multiarch/ifunc-impl-list.c b/sysdeps/s390/multiarch/ifunc-impl-list.c
bdc76f
index 680e5b738bfb7f32..1784372db9828463 100644
bdc76f
--- a/sysdeps/s390/multiarch/ifunc-impl-list.c
bdc76f
+++ b/sysdeps/s390/multiarch/ifunc-impl-list.c
bdc76f
@@ -28,6 +28,7 @@
bdc76f
 #include <ifunc-memmem.h>
bdc76f
 #include <ifunc-strlen.h>
bdc76f
 #include <ifunc-strnlen.h>
bdc76f
+#include <ifunc-strcpy.h>
bdc76f
 
bdc76f
 /* Maximum number of IFUNC implementations.  */
bdc76f
 #define MAX_IFUNC	3
bdc76f
@@ -190,6 +191,18 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
bdc76f
 		)
bdc76f
 #endif /* HAVE_STRNLEN_IFUNC  */
bdc76f
 
bdc76f
+#if HAVE_STRCPY_IFUNC
bdc76f
+    IFUNC_IMPL (i, name, strcpy,
bdc76f
+# if HAVE_STRCPY_Z13
bdc76f
+		IFUNC_IMPL_ADD (array, i, strcpy,
bdc76f
+				dl_hwcap & HWCAP_S390_VX, STRCPY_Z13)
bdc76f
+# endif
bdc76f
+# if HAVE_STRCPY_Z900_G5
bdc76f
+		IFUNC_IMPL_ADD (array, i, strcpy, 1, STRCPY_Z900_G5)
bdc76f
+# endif
bdc76f
+		)
bdc76f
+#endif /* HAVE_STRCPY_IFUNC  */
bdc76f
+
bdc76f
 #ifdef HAVE_S390_VX_ASM_SUPPORT
bdc76f
 
bdc76f
 # define IFUNC_VX_IMPL(FUNC)						\
bdc76f
@@ -202,7 +215,6 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
bdc76f
 
bdc76f
   IFUNC_VX_IMPL (wcsnlen);
bdc76f
 
bdc76f
-  IFUNC_VX_IMPL (strcpy);
bdc76f
   IFUNC_VX_IMPL (wcscpy);
bdc76f
 
bdc76f
   IFUNC_VX_IMPL (stpcpy);
bdc76f
diff --git a/sysdeps/s390/s390-32/multiarch/strcpy.c b/sysdeps/s390/s390-32/multiarch/strcpy.c
bdc76f
deleted file mode 100644
bdc76f
index 6a22e31a03c8c1c4..0000000000000000
bdc76f
--- a/sysdeps/s390/s390-32/multiarch/strcpy.c
bdc76f
+++ /dev/null
bdc76f
@@ -1,21 +0,0 @@
bdc76f
-/* Multiple versions of strcpy.
bdc76f
-   Copyright (C) 2015-2018 Free Software Foundation, Inc.
bdc76f
-   This file is part of the GNU C Library.
bdc76f
-
bdc76f
-   The GNU C Library is free software; you can redistribute it and/or
bdc76f
-   modify it under the terms of the GNU Lesser General Public
bdc76f
-   License as published by the Free Software Foundation; either
bdc76f
-   version 2.1 of the License, or (at your option) any later version.
bdc76f
-
bdc76f
-   The GNU C Library is distributed in the hope that it will be useful,
bdc76f
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
bdc76f
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
bdc76f
-   Lesser General Public License for more details.
bdc76f
-
bdc76f
-   You should have received a copy of the GNU Lesser General Public
bdc76f
-   License along with the GNU C Library; if not, see
bdc76f
-   <http://www.gnu.org/licenses/>.  */
bdc76f
-
bdc76f
-/* This wrapper-file is needed, because otherwise file
bdc76f
-   sysdeps/s390/s390-[32|64]/strcpy.S will be used.  */
bdc76f
-#include <sysdeps/s390/multiarch/strcpy.c>
bdc76f
diff --git a/sysdeps/s390/s390-32/strcpy.S b/sysdeps/s390/s390-32/strcpy.S
bdc76f
deleted file mode 100644
bdc76f
index d49136ee92b83378..0000000000000000
bdc76f
--- a/sysdeps/s390/s390-32/strcpy.S
bdc76f
+++ /dev/null
bdc76f
@@ -1,36 +0,0 @@
bdc76f
-/* strcpy - copy a string from source to destination. For IBM S390
bdc76f
-   This file is part of the GNU C Library.
bdc76f
-   Copyright (C) 2000-2018 Free Software Foundation, Inc.
bdc76f
-   Contributed by Martin Schwidefsky (schwidefsky@de.ibm.com).
bdc76f
-
bdc76f
-   The GNU C Library is free software; you can redistribute it and/or
bdc76f
-   modify it under the terms of the GNU Lesser General Public
bdc76f
-   License as published by the Free Software Foundation; either
bdc76f
-   version 2.1 of the License, or (at your option) any later version.
bdc76f
-
bdc76f
-   The GNU C Library is distributed in the hope that it will be useful,
bdc76f
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
bdc76f
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
bdc76f
-   Lesser General Public License for more details.
bdc76f
-
bdc76f
-   You should have received a copy of the GNU Lesser General Public
bdc76f
-   License along with the GNU C Library; if not, see
bdc76f
-   <http://www.gnu.org/licenses/>.  */
bdc76f
-
bdc76f
-/*
bdc76f
- * R2 = address of destination
bdc76f
- * R3 = address of source
bdc76f
- */
bdc76f
-
bdc76f
-#include "sysdep.h"
bdc76f
-#include "asm-syntax.h"
bdc76f
-
bdc76f
-	.text
bdc76f
-ENTRY(strcpy)
bdc76f
-	slr   %r0,%r0
bdc76f
-	lr    %r1,%r2
bdc76f
-0:      mvst  %r1,%r3
bdc76f
-	jo    0b
bdc76f
-	br    %r14
bdc76f
-END(strcpy)
bdc76f
-libc_hidden_builtin_def (strcpy)
bdc76f
diff --git a/sysdeps/s390/s390-64/multiarch/strcpy.c b/sysdeps/s390/s390-64/multiarch/strcpy.c
bdc76f
deleted file mode 100644
bdc76f
index 6a22e31a03c8c1c4..0000000000000000
bdc76f
--- a/sysdeps/s390/s390-64/multiarch/strcpy.c
bdc76f
+++ /dev/null
bdc76f
@@ -1,21 +0,0 @@
bdc76f
-/* Multiple versions of strcpy.
bdc76f
-   Copyright (C) 2015-2018 Free Software Foundation, Inc.
bdc76f
-   This file is part of the GNU C Library.
bdc76f
-
bdc76f
-   The GNU C Library is free software; you can redistribute it and/or
bdc76f
-   modify it under the terms of the GNU Lesser General Public
bdc76f
-   License as published by the Free Software Foundation; either
bdc76f
-   version 2.1 of the License, or (at your option) any later version.
bdc76f
-
bdc76f
-   The GNU C Library is distributed in the hope that it will be useful,
bdc76f
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
bdc76f
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
bdc76f
-   Lesser General Public License for more details.
bdc76f
-
bdc76f
-   You should have received a copy of the GNU Lesser General Public
bdc76f
-   License along with the GNU C Library; if not, see
bdc76f
-   <http://www.gnu.org/licenses/>.  */
bdc76f
-
bdc76f
-/* This wrapper-file is needed, because otherwise file
bdc76f
-   sysdeps/s390/s390-[32|64]/strcpy.S will be used.  */
bdc76f
-#include <sysdeps/s390/multiarch/strcpy.c>
bdc76f
diff --git a/sysdeps/s390/multiarch/strcpy-vx.S b/sysdeps/s390/strcpy-vx.S
bdc76f
similarity index 85%
bdc76f
rename from sysdeps/s390/multiarch/strcpy-vx.S
bdc76f
rename to sysdeps/s390/strcpy-vx.S
bdc76f
index 52197f57f7b5d5cf..844d23e4fee32c9b 100644
bdc76f
--- a/sysdeps/s390/multiarch/strcpy-vx.S
bdc76f
+++ b/sysdeps/s390/strcpy-vx.S
bdc76f
@@ -16,13 +16,13 @@
bdc76f
    License along with the GNU C Library; if not, see
bdc76f
    <http://www.gnu.org/licenses/>.  */
bdc76f
 
bdc76f
-#if defined HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc)
bdc76f
-
bdc76f
-# include "sysdep.h"
bdc76f
-# include "asm-syntax.h"
bdc76f
+#include <ifunc-strcpy.h>
bdc76f
+#include "sysdep.h"
bdc76f
+#include "asm-syntax.h"
bdc76f
 
bdc76f
 	.text
bdc76f
 
bdc76f
+#if HAVE_STRCPY_Z13
bdc76f
 /* char * strcpy (const char *dest, const char *src)
bdc76f
    Copy string src to dest.
bdc76f
 
bdc76f
@@ -36,7 +36,7 @@
bdc76f
    -v17=index of zero
bdc76f
    -v18=part of src
bdc76f
 */
bdc76f
-ENTRY(__strcpy_vx)
bdc76f
+ENTRY(STRCPY_Z13)
bdc76f
 	.machine "z13"
bdc76f
 	.machinemode "zarch_nohighgprs"
bdc76f
 
bdc76f
@@ -97,13 +97,13 @@ ENTRY(__strcpy_vx)
bdc76f
 .Lfound_align:
bdc76f
 	vstl	%v16,%r5,0(%r2)	/* Copy characters including zero.  */
bdc76f
 	br	%r14
bdc76f
-END(__strcpy_vx)
bdc76f
+END(STRCPY_Z13)
bdc76f
 
bdc76f
-/* Use mvst-strcpy-implementation as default implementation.  */
bdc76f
-# define strcpy __strcpy_c
bdc76f
-# undef libc_hidden_builtin_def
bdc76f
-# define libc_hidden_builtin_def(name) strong_alias(__strcpy_c, __GI_strcpy)
bdc76f
-#endif /* HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc) */
bdc76f
+# if ! HAVE_STRCPY_IFUNC
bdc76f
+strong_alias (STRCPY_Z13, strcpy)
bdc76f
+# endif
bdc76f
 
bdc76f
-/* Include mvst-strcpy-implementation in s390-32/s390-64 subdirectory.  */
bdc76f
-#include <strcpy.S>
bdc76f
+# if ! HAVE_STRCPY_Z900_G5 && defined SHARED && IS_IN (libc)
bdc76f
+strong_alias (STRCPY_Z13, __GI_strcpy)
bdc76f
+# endif
bdc76f
+#endif
bdc76f
diff --git a/sysdeps/s390/s390-64/strcpy.S b/sysdeps/s390/strcpy-z900.S
bdc76f
similarity index 66%
bdc76f
rename from sysdeps/s390/s390-64/strcpy.S
bdc76f
rename to sysdeps/s390/strcpy-z900.S
bdc76f
index 203c73c905d0d86c..42798b1fd5c51187 100644
bdc76f
--- a/sysdeps/s390/s390-64/strcpy.S
bdc76f
+++ b/sysdeps/s390/strcpy-z900.S
bdc76f
@@ -1,4 +1,4 @@
bdc76f
-/* strcpy - copy a string from source to destination.  64 bit S/390 version.
bdc76f
+/* strcpy - copy a string from source to destination.  64/31 bit S/390 version.
bdc76f
    Copyright (C) 2001-2018 Free Software Foundation, Inc.
bdc76f
    Contributed by Martin Schwidefsky (schwidefsky@de.ibm.com).
bdc76f
    This file is part of the GNU C Library.
bdc76f
@@ -21,15 +21,36 @@
bdc76f
      %r2 = address of destination
bdc76f
      %r3 = address of source.  */
bdc76f
 
bdc76f
+#include <ifunc-strcpy.h>
bdc76f
 #include "sysdep.h"
bdc76f
 #include "asm-syntax.h"
bdc76f
 
bdc76f
+#if HAVE_STRCPY_Z900_G5
bdc76f
+# if defined __s390x__
bdc76f
+#  define SLGR	slgr
bdc76f
+#  define LGR	lgr
bdc76f
+# else
bdc76f
+#  define SLGR	slr
bdc76f
+#  define LGR	lr
bdc76f
+# endif /* ! defined __s390x__  */
bdc76f
+
bdc76f
         .text
bdc76f
-ENTRY(strcpy)
bdc76f
-	slgr  %r0,%r0
bdc76f
-	lgr   %r1,%r2
bdc76f
+ENTRY(STRCPY_Z900_G5)
bdc76f
+	SLGR  %r0,%r0
bdc76f
+	LGR   %r1,%r2
bdc76f
 0:	mvst  %r1,%r3
bdc76f
 	jo    0b
bdc76f
 	br    %r14
bdc76f
-END(strcpy)
bdc76f
-libc_hidden_builtin_def (strcpy)
bdc76f
+END(STRCPY_Z900_G5)
bdc76f
+
bdc76f
+# undef SLGR
bdc76f
+# undef LGR
bdc76f
+
bdc76f
+# if ! HAVE_STRCPY_IFUNC
bdc76f
+strong_alias (STRCPY_Z900_G5, strcpy)
bdc76f
+# endif
bdc76f
+
bdc76f
+# if defined SHARED && IS_IN (libc)
bdc76f
+strong_alias (STRCPY_Z900_G5, __GI_strcpy)
bdc76f
+# endif
bdc76f
+#endif
bdc76f
diff --git a/sysdeps/s390/multiarch/strcpy.c b/sysdeps/s390/strcpy.c
bdc76f
similarity index 69%
bdc76f
rename from sysdeps/s390/multiarch/strcpy.c
bdc76f
rename to sysdeps/s390/strcpy.c
bdc76f
index 8f32a13f6730c427..f4e28e24c85b7162 100644
bdc76f
--- a/sysdeps/s390/multiarch/strcpy.c
bdc76f
+++ b/sysdeps/s390/strcpy.c
bdc76f
@@ -16,12 +16,25 @@
bdc76f
    License along with the GNU C Library; if not, see
bdc76f
    <http://www.gnu.org/licenses/>.  */
bdc76f
 
bdc76f
-#if defined HAVE_S390_VX_ASM_SUPPORT && IS_IN (libc)
bdc76f
+#include <ifunc-strcpy.h>
bdc76f
+
bdc76f
+#if HAVE_STRCPY_IFUNC
bdc76f
 # define strcpy __redirect_strcpy
bdc76f
 # include <string.h>
bdc76f
 # undef strcpy
bdc76f
 # include <ifunc-resolve.h>
bdc76f
 
bdc76f
-s390_vx_libc_ifunc2_redirected (__redirect_strcpy, __strcpy, strcpy)
bdc76f
+# if HAVE_STRCPY_Z900_G5
bdc76f
+extern __typeof (__redirect_strcpy) STRCPY_Z900_G5 attribute_hidden;
bdc76f
+# endif
bdc76f
+
bdc76f
+# if HAVE_STRCPY_Z13
bdc76f
+extern __typeof (__redirect_strcpy) STRCPY_Z13 attribute_hidden;
bdc76f
+# endif
bdc76f
 
bdc76f
+s390_libc_ifunc_expr (__redirect_strcpy, strcpy,
bdc76f
+		      (HAVE_STRCPY_Z13 && (hwcap & HWCAP_S390_VX))
bdc76f
+		      ? STRCPY_Z13
bdc76f
+		      : STRCPY_DEFAULT
bdc76f
+		      )
bdc76f
 #endif