d8307d
commit bfcfa22589f2b4277a65e60c6b736b6bbfbd87d0
d8307d
Author: Florian Weimer <fweimer@redhat.com>
d8307d
Date:   Tue Aug 14 10:51:07 2018 +0200
d8307d
d8307d
    nscd: Deallocate existing user names in file parser
d8307d
    
d8307d
    This avoids a theoretical memory leak (theoretical because it depends on
d8307d
    multiple server-user/stat-user directives in the configuration file).
d8307d
    
d8307d
    (cherry picked from commit 2d7acfac3ebf266dcbc82d0d6cc576f626953a03)
d8307d
d8307d
diff --git a/nscd/nscd_conf.c b/nscd/nscd_conf.c
d8307d
index 265a02434dd26c29..7293b795b6bcf71e 100644
d8307d
--- a/nscd/nscd_conf.c
d8307d
+++ b/nscd/nscd_conf.c
d8307d
@@ -190,7 +190,10 @@ nscd_parse_file (const char *fname, struct database_dyn dbs[lastdb])
d8307d
 	  if (!arg1)
d8307d
 	    error (0, 0, _("Must specify user name for server-user option"));
d8307d
 	  else
d8307d
-	    server_user = xstrdup (arg1);
d8307d
+	    {
d8307d
+	      free ((char *) server_user);
d8307d
+	      server_user = xstrdup (arg1);
d8307d
+	    }
d8307d
 	}
d8307d
       else if (strcmp (entry, "stat-user") == 0)
d8307d
 	{
d8307d
@@ -198,6 +201,7 @@ nscd_parse_file (const char *fname, struct database_dyn dbs[lastdb])
d8307d
 	    error (0, 0, _("Must specify user name for stat-user option"));
d8307d
 	  else
d8307d
 	    {
d8307d
+	      free ((char *) stat_user);
d8307d
 	      stat_user = xstrdup (arg1);
d8307d
 
d8307d
 	      struct passwd *pw = getpwnam (stat_user);