|
 |
c6d234 |
commit ed159672eb3cd650a32b7e5cb4d5ec1fe0e63802
|
|
|
c6d234 |
Author: Florian Weimer <fweimer@redhat.com>
|
|
|
c6d234 |
Date: Fri Apr 24 11:10:24 2015 +0200
|
|
|
c6d234 |
|
|
|
c6d234 |
Do not build with -Winline
|
|
|
c6d234 |
|
|
|
c6d234 |
-Winline causes architecture- and optimization-dependent build failures
|
|
|
c6d234 |
due to -Werror. -Winline warns about inlining decisions based on
|
|
|
c6d234 |
branch hints, in effect preventing the use of inline functions in
|
|
|
c6d234 |
header files (because they might be called on unlikely branches, leading
|
|
|
c6d234 |
to a decision not to inline).
|
|
|
c6d234 |
|
|
|
c6d234 |
The option was apparently added to the glibc build at a time when GCC
|
|
|
c6d234 |
did not support the always_inline attribute. With current GCC versions,
|
|
|
c6d234 |
inlining failure for functions declared always_inline will receive a
|
|
|
c6d234 |
warning under -Wattributes, which is enabled by default, so -Winline
|
|
|
c6d234 |
appears unnecessary.
|
|
|
c6d234 |
|
|
|
c6d234 |
diff --git a/Makeconfig b/Makeconfig
|
|
|
c6d234 |
index 6f61e4835c0a7770..b1bf7f24b6154e3d 100644
|
|
|
c6d234 |
--- a/Makeconfig
|
|
|
c6d234 |
+++ b/Makeconfig
|
|
|
c6d234 |
@@ -639,9 +639,9 @@ endif
|
|
|
c6d234 |
|
|
|
c6d234 |
# Extra flags to pass to GCC.
|
|
|
c6d234 |
ifeq ($(all-warnings),yes)
|
|
|
c6d234 |
-+gccwarn := -Wall -Wwrite-strings -Winline -Wcast-qual -Wbad-function-cast -Wmissing-noreturn -Wmissing-prototypes -Wmissing-declarations -Wcomment -Wcomments -Wtrigraphs -Wsign-compare -Wfloat-equal -Wmultichar
|
|
|
c6d234 |
++gccwarn := -Wall -Wwrite-strings -Wcast-qual -Wbad-function-cast -Wmissing-noreturn -Wmissing-prototypes -Wmissing-declarations -Wcomment -Wcomments -Wtrigraphs -Wsign-compare -Wfloat-equal -Wmultichar
|
|
|
c6d234 |
else
|
|
|
c6d234 |
-+gccwarn := -Wall -Wwrite-strings -Winline
|
|
|
c6d234 |
++gccwarn := -Wall -Wwrite-strings
|
|
|
c6d234 |
endif
|
|
|
c6d234 |
+gccwarn += -Wundef
|
|
|
c6d234 |
ifeq ($(enable-werror),yes)
|