fa3bfd
From 17f487b7afa7cd6c316040f3e6c86dc96b2eec30 Mon Sep 17 00:00:00 2001
fa3bfd
From: DJ Delorie <dj@delorie.com>
fa3bfd
Date: Fri, 17 Mar 2017 15:31:38 -0400
fa3bfd
Subject: [PATCH] Further harden glibc malloc metadata against 1-byte
fa3bfd
 overflows.
fa3bfd
fa3bfd
Additional check for chunk_size == next->prev->chunk_size in unlink()
fa3bfd
fa3bfd
2017-03-17  Chris Evans  <scarybeasts@gmail.com>
fa3bfd
fa3bfd
	* malloc/malloc.c (unlink): Add consistency check between size and
fa3bfd
	next->prev->size, to further harden against 1-byte overflows.
fa3bfd
fa3bfd
diff -rup a/malloc/malloc.c b/malloc/malloc.c
fa3bfd
--- a/malloc/malloc.c	2017-08-01 18:11:00.000000000 -0400
fa3bfd
+++ b/malloc/malloc.c	2017-08-01 18:13:07.907438098 -0400
fa3bfd
@@ -1429,6 +1429,8 @@ typedef struct malloc_chunk* mbinptr;
fa3bfd
 
fa3bfd
 /* Take a chunk off a bin list */
fa3bfd
 #define unlink(AV, P, BK, FD) {					       \
fa3bfd
+   if (__builtin_expect (chunksize(P) != next_chunk(P)->prev_size, 0))      \
fa3bfd
+     malloc_printerr (check_action, "corrupted size vs. prev_size", P, AV);  \
fa3bfd
   FD = P->fd;                                                          \
fa3bfd
   BK = P->bk;                                                          \
fa3bfd
   if (__builtin_expect (FD->bk != P || BK->fd != P, 0)) {	       \