00db10
commit 130ac68ca25c9aa65e027e3e37337bc048205c69
00db10
Author: Siddhesh Poyarekar <siddhesh@redhat.com>
00db10
Date:   Wed Nov 19 12:16:00 2014 +0530
00db10
00db10
    Auto-generate libc-modules.h
00db10
    
00db10
    Remove libc-modules.h from the tree and auto-generate it from
00db10
    soversions.i and the list of modules in the built-modules variable
00db10
    defined in Makeconfig.  Macros generated have increasing numbered
00db10
    values, with built-modules having lower values starting from 1,
00db10
    following which a separator value LIBS_BEGIN is added and then finally
00db10
    the library names from soversions.i are appended to the list.  This
00db10
    allows us to conveniently differentiate between the versioned
00db10
    libraries and other built modules, which is needed in errno.h and
00db10
    netdb.h to decide whether to use an internal symbol or an external
00db10
    one.
00db10
    
00db10
    Verified that generated code remains unchanged on x86_64.
00db10
    
00db10
    	* Makeconfig (built-modules): List non-library modules to be
00db10
    	built.
00db10
    	(module-cppflags): Include libc-modules.h for
00db10
    	everything except shlib-versions.v.i.
00db10
    	(CPPFLAGS): Use it.
00db10
    	(before-compile): Add libc-modules.h.
00db10
    	($(common-objpfx)libc-modules.h,
00db10
    	$(common-objpfx)libc-modules.stmp): New targets.
00db10
    	(common-generated): Add libc-modules.h and libc-modules.stmp.
00db10
    	($(common-objpfx)Versions.v.i): Depend on libc-modules.h.
00db10
    	* include/libc-symbols.h: Don't include libc-modules.h.
00db10
    	* include/libc-modules.h: Remove file.
00db10
    	* scripts/gen-libc-modules.awk: New script to generate
00db10
    	libc-modules.h.
00db10
    	* sysdeps/unix/Makefile ($(common-objpfx)sysd-syscalls):
00db10
    	Depend on libc-modules.stmp.
00db10
00db10
commit 8a257e2cb50cd8e8e3e2368d80bf325ea4086cf9
00db10
Author: Roland McGrath <roland@hack.frob.com>
00db10
Date:   Thu Apr 9 14:42:29 2015 -0700
00db10
00db10
    Omit libc-modules.h for all .v.i files.
00db10
00db10
Index: glibc-2.17-c758a686/Makeconfig
00db10
===================================================================
00db10
--- glibc-2.17-c758a686.orig/Makeconfig
00db10
+++ glibc-2.17-c758a686/Makeconfig
00db10
@@ -730,19 +730,34 @@ endif	# $(+cflags) == ""
00db10
 # of many little headers in the include directory.
00db10
 libio-include = -I$(..)libio
00db10
 
00db10
+# List of non-library modules that we build.
00db10
+built-modules = iconvprogs iconvdata ldconfig lddlibc4 libmemusage \
00db10
+		libSegFault libpcprofile librpcsvc locale-programs \
00db10
+		memusagestat nonlib nscd extramodules libnldbl
00db10
+
00db10
 in-module = $(subst -,_,$(firstword $(libof-$(basename $(@F))) \
00db10
 				    $(libof-$(
00db10
 				    $(libof-$(@F)) \
00db10
 				    libc))
00db10
 
00db10
+module-cppflags-real = -include $(common-objpfx)libc-modules.h \
00db10
+		       -DIN_MODULE=MODULE_$(in-module)
00db10
+
00db10
+# We don't need libc-modules.h and the MODULE_NAME definition for .v.i
00db10
+# files.  These targets don't (and will likely never need to) use the IS_IN
00db10
+# facility.  In fact, shlib-versions should not use it because that will
00db10
+# create a circular dependency as libc-modules.h is generated from
00db10
+# shlib-versions.
00db10
+module-cppflags = $(if $(filter %.v.i,$(@F)),,$(module-cppflags-real))
00db10
+
00db10
 # These are the variables that the implicit compilation rules use.
00db10
 # Note that we can't use -std=* in CPPFLAGS, because it overrides
00db10
 # the implicit -lang-asm and breaks cpp behavior for .S files--notably
00db10
 # it causes cpp to stop predefining __ASSEMBLER__.
00db10
 CPPFLAGS = $(CPPUNDEFS) $(CPPFLAGS-config) $($(subdir)-CPPFLAGS) \
00db10
-	   $(+includes) $(defines) \
00db10
+	   $(+includes) $(defines) $(module-cppflags) \
00db10
 	   -include $(..)include/libc-symbols.h $(sysdep-CPPFLAGS) \
00db10
-	   $(CPPFLAGS-$(suffix $@)) -DIN_MODULE=MODULE_$(in-module) \
00db10
+	   $(CPPFLAGS-$(suffix $@)) \
00db10
 	   $(foreach lib,$(libof-$(basename $(@F))) \
00db10
 			 $(libof-$(
00db10
 	   $(CPPFLAGS-$(
00db10
@@ -922,6 +937,23 @@ endif
00db10
 postclean-generated += soversions.mk soversions.i \
00db10
 		       shlib-versions.v shlib-versions.v.i
00db10
 
00db10
+before-compile += $(common-objpfx)libc-modules.h
00db10
+ifeq ($(soversions.mk-done),t)
00db10
+# Generate a header with macro definitions for use with the IS_IN macro.
00db10
+# These are the possible values for the IN_MODULE macro defined when building
00db10
+# sources, to identify which module the translation unit is going to be built
00db10
+# into.
00db10
+$(common-objpfx)libc-modules.h: $(common-objpfx)libc-modules.stmp; @:
00db10
+$(common-objpfx)libc-modules.stmp: $(..)scripts/gen-libc-modules.awk \
00db10
+				   $(common-objpfx)soversions.i
00db10
+	$(AWK) -v buildlist="$(subst -,_,$(built-modules))" -f $^ > ${@:stmp=T}
00db10
+	$(move-if-change) ${@:stmp=T} ${@:stmp=h}
00db10
+	touch $@
00db10
+
00db10
+endif
00db10
+
00db10
+common-generated += libc-modules.h libc-modules.stmp
00db10
+
00db10
 # Generate the header containing the names of all shared libraries.
00db10
 # We use a stamp file to avoid unnecessary recompilations.
00db10
 before-compile += $(common-objpfx)gnu/lib-names.h
00db10
Index: glibc-2.17-c758a686/include/libc-modules.h
00db10
===================================================================
00db10
--- glibc-2.17-c758a686.orig/include/libc-modules.h
00db10
+++ /dev/null
00db10
@@ -1,41 +0,0 @@
00db10
-/* Valid values for the IN_MODULE macro, which is defined for each source file
00db10
-   during compilation to indicate which module it is to be built into.
00db10
-
00db10
-   TODO: This file should eventually be auto-generated.  */
00db10
-#define MODULE_libc		1
00db10
-#define MODULE_libpthread	2
00db10
-#define MODULE_rtld		3
00db10
-#define MODULE_libdl		4
00db10
-#define MODULE_libm		5
00db10
-#define MODULE_iconvprogs	6
00db10
-#define MODULE_iconvdata	7
00db10
-#define MODULE_lddlibc4		8
00db10
-#define MODULE_locale_programs	9
00db10
-#define MODULE_memusagestat	10
00db10
-#define MODULE_libutil		12
00db10
-#define MODULE_libBrokenLocale	13
00db10
-#define MODULE_libmemusage	15
00db10
-#define MODULE_libresolv	16
00db10
-#define MODULE_libnss_db	17
00db10
-#define MODULE_libnss_files	18
00db10
-#define	MODULE_libnss_dns	19
00db10
-#define MODULE_libnss_compat	20
00db10
-#define MODULE_libnss_hesiod	21
00db10
-#define MODULE_libnss_nis	22
00db10
-#define MODULE_libnss_nisplus	23
00db10
-#define MODULE_libanl		24
00db10
-#define MODULE_librt		25
00db10
-#define MODULE_libSegFault	26
00db10
-#define MODULE_libthread_db	27
00db10
-#define MODULE_libcidn		28
00db10
-#define MODULE_libcrypt		29
00db10
-#define MODULE_libnsl		30
00db10
-#define MODULE_libpcprofile	31
00db10
-#define MODULE_librpcsvc	32
00db10
-#define MODULE_nscd		33
00db10
-#define MODULE_ldconfig 	34
00db10
-#define MODULE_libnldbl 	35
00db10
-
00db10
-/* Catch-all for test modules and other binaries.  */
00db10
-#define MODULE_nonlib		98
00db10
-#define MODULE_extramodules	99
00db10
Index: glibc-2.17-c758a686/include/libc-symbols.h
00db10
===================================================================
00db10
--- glibc-2.17-c758a686.orig/include/libc-symbols.h
00db10
+++ glibc-2.17-c758a686/include/libc-symbols.h
00db10
@@ -20,9 +20,6 @@
00db10
 #ifndef _LIBC_SYMBOLS_H
00db10
 #define _LIBC_SYMBOLS_H	1
00db10
 
00db10
-/* Pull in definitions for the MODULE_* macros.  */
00db10
-#include <libc-modules.h>
00db10
-
00db10
 #define IS_IN(lib) (IN_MODULE == MODULE_##lib)
00db10
 
00db10
 /* This file's macros are included implicitly in the compilation of every
00db10
Index: glibc-2.17-c758a686/scripts/gen-libc-modules.awk
00db10
===================================================================
00db10
--- /dev/null
00db10
+++ glibc-2.17-c758a686/scripts/gen-libc-modules.awk
00db10
@@ -0,0 +1,34 @@
00db10
+# Generate a header file that defines the MODULE_* macros for each library and
00db10
+# module we build in glibc.  The library names are pulled in from soversions.i
00db10
+# and the additional modules are passed in the BUILDLIST variable.
00db10
+BEGIN {
00db10
+  # BUILDLIST is set from the build-list variable in Makeconfig and is a space
00db10
+  # separated list of non-library modules that we build in glibc.
00db10
+  num = split (buildlist, libs, " ")
00db10
+  # Separate the built modules from the libraries.
00db10
+  libs[++num] = "LIBS_BEGIN"
00db10
+}
00db10
+
00db10
+# Skip over comments.
00db10
+$1 == "#" {
00db10
+  next
00db10
+}
00db10
+
00db10
+# We have only one special case in soversions.i parsing, which is to replace ld
00db10
+# with rtld since that's what we call it throughout the sources.
00db10
+match (FILENAME, ".*soversions.i") {
00db10
+  name = $2
00db10
+  if (name == "ld")
00db10
+    name = "rtld"
00db10
+
00db10
+  # Library names are not duplicated in soversions.i.
00db10
+  libs[++num] = name
00db10
+}
00db10
+
00db10
+# Finally, print out the header file.
00db10
+END {
00db10
+  printf ("/* AUTOGENERATED BY gen-libc-modules.awk, DO NOT EDIT.  */\n\n")
00db10
+  for (l in libs) {
00db10
+    printf ("#define MODULE_%s %d\n", libs[l], l)
00db10
+  }
00db10
+}
00db10
Index: glibc-2.17-c758a686/sysdeps/unix/Makefile
00db10
===================================================================
00db10
--- glibc-2.17-c758a686.orig/sysdeps/unix/Makefile
00db10
+++ glibc-2.17-c758a686/sysdeps/unix/Makefile
00db10
@@ -77,7 +77,8 @@ compile-syscall = $(COMPILE.S) -o $@ -x
00db10
 
00db10
 ifndef avoid-generated
00db10
 $(common-objpfx)sysd-syscalls: $(..)sysdeps/unix/make-syscalls.sh \
00db10
-			       $(wildcard $(+sysdep_dirs:%=%/syscalls.list))
00db10
+			       $(wildcard $(+sysdep_dirs:%=%/syscalls.list)) \
00db10
+			       $(common-objpfx)libc-modules.stmp
00db10
 	for dir in $(+sysdep_dirs); do \
00db10
 	  test -f $$dir/syscalls.list && \
00db10
 	  { sysdirs='$(sysdirs)' \