645344
From 32ed752130bcbccc008819a7f1ea27651c601ee2 Mon Sep 17 00:00:00 2001
645344
From: Matthias Clasen <mclasen@redhat.com>
645344
Date: Tue, 22 Jan 2019 13:26:31 -0500
645344
Subject: [PATCH 9/9] keyfile settings: Use tighter permissions
645344
645344
When creating directories, create them with 700 permissions,
645344
instead of 777.
645344
645344
Closes: #1658
645344
---
645344
 gio/gkeyfilesettingsbackend.c | 5 +++--
645344
 1 file changed, 3 insertions(+), 2 deletions(-)
645344
645344
diff --git a/gio/gkeyfilesettingsbackend.c b/gio/gkeyfilesettingsbackend.c
645344
index f5358818e..3d793f5a8 100644
645344
--- a/gio/gkeyfilesettingsbackend.c
645344
+++ b/gio/gkeyfilesettingsbackend.c
645344
@@ -113,7 +113,8 @@ g_keyfile_settings_backend_keyfile_write (GKeyfileSettingsBackend *kfsb)
645344
 
645344
   contents = g_key_file_to_data (kfsb->keyfile, &length, NULL);
645344
   g_file_replace_contents (kfsb->file, contents, length, NULL, FALSE,
645344
-                           G_FILE_CREATE_REPLACE_DESTINATION,
645344
+                           G_FILE_CREATE_REPLACE_DESTINATION |
645344
+                           G_FILE_CREATE_PRIVATE,
645344
                            NULL, NULL, NULL);
645344
 
645344
   compute_checksum (kfsb->digest, contents, length);
645344
@@ -708,7 +709,7 @@ g_keyfile_settings_backend_constructed (GObject *object)
645344
   kfsb->permission = g_simple_permission_new (TRUE);
645344
 
645344
   kfsb->dir = g_file_get_parent (kfsb->file);
645344
-  g_file_make_directory_with_parents (kfsb->dir, NULL, NULL);
645344
+  g_mkdir_with_parents (g_file_peek_path (kfsb->dir), 0700);
645344
 
645344
   kfsb->file_monitor = g_file_monitor (kfsb->file, G_FILE_MONITOR_NONE, NULL, NULL);
645344
   kfsb->dir_monitor = g_file_monitor (kfsb->dir, G_FILE_MONITOR_NONE, NULL, NULL);
645344
-- 
645344
2.28.0