f706a9
diff --git a/contrib/gdevdj9.c b/contrib/gdevdj9.c
f706a9
index eec1c77..a4e8e9c 100644
f706a9
--- a/contrib/gdevdj9.c
f706a9
+++ b/contrib/gdevdj9.c
f706a9
@@ -575,26 +575,55 @@ static int cdj_set_bpp(gx_device *, int, int);
f706a9
 static int
f706a9
 hp_colour_open(gx_device * pdev)
f706a9
 {
f706a9
-    int retCode;
f706a9
+    int retCode = 0;
f706a9
+
f706a9
+    /* Change the margins if necessary. */
f706a9
+    static const float dj_a4[4] = {
f706a9
+        DESKJET_MARGINS_A4
f706a9
+    };
f706a9
+
f706a9
+    static const float dj_letter[4] = {
f706a9
+        DESKJET_MARGINS_LETTER
f706a9
+    };
f706a9
+    const float *m = (float *)0;
f706a9
 
f706a9
     cdj970->PageCtr = 0;
f706a9
 
f706a9
+    /* quality setup */
f706a9
+    if (cdj970->quality == DRAFT) {
f706a9
+        gx_device_set_resolution((gx_device *) pdev, 300.0, 300.0);
f706a9
+        cdj970->xscal = 0;
f706a9
+        cdj970->yscal = 0;
f706a9
+        cdj970->intensities = 2;
f706a9
+    } else if (cdj970->quality == NORMAL) {
f706a9
+        gx_device_set_resolution((gx_device *) pdev, 600.0, 600.0);
f706a9
+        cdj970->xscal = 1;
f706a9
+        cdj970->yscal = 1;
f706a9
+        /* intensities = 4 from initialization */
f706a9
+    } else {                    /* quality == PRESENTATION */
f706a9
+        gx_device_set_resolution((gx_device *) pdev, 600.0, 600.0);
f706a9
+        cdj970->xscal = 0;
f706a9
+        cdj970->yscal = 0;
f706a9
+        /* intensities = 4 from initialization */
f706a9
+    }
f706a9
+
f706a9
+    m = (gdev_pcl_paper_size((gx_device *) pdev) ==
f706a9
+         PAPER_SIZE_A4 ? dj_a4 : dj_letter);
f706a9
+
f706a9
+    gx_device_set_margins((gx_device *) pdev, m, true);
f706a9
+
f706a9
     /* Set up colour params if put_params has not already done so */
f706a9
     if (pdev->color_info.num_components == 0) {
f706a9
-        int code = cdj_set_bpp(pdev, pdev->color_info.depth,
f706a9
+        retCode = cdj_set_bpp(pdev, pdev->color_info.depth,
f706a9
                                pdev->color_info.num_components);
f706a9
 
f706a9
-        if (code < 0)
f706a9
-            return code;
f706a9
+        if (retCode < 0)
f706a9
+            return retCode;
f706a9
     }
f706a9
 
f706a9
     retCode = gdev_prn_open(pdev);
f706a9
-    if (retCode < 0)
f706a9
-        return (retCode);
f706a9
-    else {
f706a9
+    if (retCode >= 0) {
f706a9
         retCode = gdev_prn_open_printer(pdev, true);
f706a9
-        if (retCode < 0)
f706a9
-            return (retCode);
f706a9
     }
f706a9
 
f706a9
     return 0;
f706a9
@@ -648,26 +677,25 @@ cdj970_put_params(gx_device * pdev, gs_param_list * plist)
f706a9
     int bpp = 0;
f706a9
     int code = 0;
f706a9
 
f706a9
-    code = cdj_put_param_int(plist, "BitsPerPixel", &bpp, 1, 32, code);
f706a9
-    code = cdj_put_param_int(plist, "Quality", &quality, 0, 2, code);
f706a9
-    code = cdj_put_param_int(plist, "Papertype", &papertype, 0, 4, code);
f706a9
-    code = cdj_put_param_int(plist, "Duplex", &duplex, 0, 2, code);
f706a9
-    code =
f706a9
-        cdj_put_param_float(plist, "MasterGamma", &mastergamma, 0.1, 9.0,
f706a9
-                            code);
f706a9
-    code =
f706a9
-        cdj_put_param_float(plist, "GammaValC", &gammavalc, 0.0, 9.0, code);
f706a9
-    code =
f706a9
-        cdj_put_param_float(plist, "GammaValM", &gammavalm, 0.0, 9.0, code);
f706a9
-    code =
f706a9
-        cdj_put_param_float(plist, "GammaValY", &gammavaly, 0.0, 9.0, code);
f706a9
-    code =
f706a9
-        cdj_put_param_float(plist, "GammaValK", &gammavalk, 0.0, 9.0, code);
f706a9
-    code =
f706a9
-        cdj_put_param_float(plist, "BlackCorrect", &blackcorrect, 0.0, 9.0,
f706a9
-                            code);
f706a9
-
f706a9
-    if (code < 0)
f706a9
+    if ((code = cdj_put_param_int(plist, "BitsPerPixel", &bpp, 1, 32, code)) < 0)
f706a9
+        return code;
f706a9
+    if ((code = cdj_put_param_int(plist, "Quality", &quality, 0, 2, code)) < 0)
f706a9
+        return code;
f706a9
+    if ((code = cdj_put_param_int(plist, "Papertype", &papertype, 0, 4, code)) < 0)
f706a9
+        return code;
f706a9
+    if ((code = cdj_put_param_int(plist, "Duplex", &duplex, 0, 2, code)) < 0)
f706a9
+        return code;
f706a9
+    if ((code = cdj_put_param_float(plist, "MasterGamma", &mastergamma, 0.1, 9.0, code)) < 0)
f706a9
+        return code;
f706a9
+    if ((code = cdj_put_param_float(plist, "GammaValC", &gammavalc, 0.0, 9.0, code)) < 0)
f706a9
+        return code;
f706a9
+    if ((code = cdj_put_param_float(plist, "GammaValM", &gammavalm, 0.0, 9.0, code)) < 0)
f706a9
+        return code;
f706a9
+    if ((code = cdj_put_param_float(plist, "GammaValY", &gammavaly, 0.0, 9.0, code)) < 0)
f706a9
+        return code;
f706a9
+    if ((code = cdj_put_param_float(plist, "GammaValK", &gammavalk, 0.0, 9.0, code)) < 0)
f706a9
+        return code;
f706a9
+    if ((code = cdj_put_param_float(plist, "BlackCorrect", &blackcorrect, 0.0, 9.0, code)) < 0)
f706a9
         return code;
f706a9
 
f706a9
     code = cdj_put_param_bpp(pdev, plist, bpp, bpp, 0);
f706a9
@@ -676,6 +704,12 @@ cdj970_put_params(gx_device * pdev, gs_param_list * plist)
f706a9
         return code;
f706a9
 
f706a9
     cdj970->quality = quality;
f706a9
+    if (cdj970->quality != quality) {
f706a9
+        if (pdev->is_open)
f706a9
+            gs_closedevice(pdev);      /* quality can change resolution, force re-open */
f706a9
+        cdj970->quality = quality;
f706a9
+    }
f706a9
+
f706a9
     cdj970->papertype = papertype;
f706a9
     cdj970->duplex = duplex;
f706a9
     cdj970->mastergamma = mastergamma;
f706a9
@@ -685,7 +719,7 @@ cdj970_put_params(gx_device * pdev, gs_param_list * plist)
f706a9
     cdj970->gammavalk = gammavalk;
f706a9
     cdj970->blackcorrect = blackcorrect;
f706a9
 
f706a9
-    return 0;
f706a9
+    return code;
f706a9
 }
f706a9
 
f706a9
 /**********************************************************************************/
f706a9
@@ -784,47 +818,6 @@ cdj970_terminate_page(gx_device_printer * pdev, FILE * prn_stream)
f706a9
     fputs("\033*rC\f\033&l-2H", prn_stream);    /* End Graphics, Reset */
f706a9
 }
f706a9
 
f706a9
-/* cdj970_one_time_initialisation:
f706a9
-----------------------------------------------------------------------------------*/
f706a9
-static void
f706a9
-cdj970_one_time_initialisation(gx_device_printer * pdev)
f706a9
-{
f706a9
-    /* Change the margins if necessary. */
f706a9
-    static const float dj_a4[4] = {
f706a9
-        DESKJET_MARGINS_A4
f706a9
-    };
f706a9
-
f706a9
-    static const float dj_letter[4] = {
f706a9
-        DESKJET_MARGINS_LETTER
f706a9
-    };
f706a9
-    const float *m = (float *)0;
f706a9
-
f706a9
-    /* quality setup */
f706a9
-    if (cdj970->quality == DRAFT) {
f706a9
-        gx_device_set_resolution((gx_device *) pdev, 300.0, 300.0);
f706a9
-        cdj970->xscal = 0;
f706a9
-        cdj970->yscal = 0;
f706a9
-        cdj970->intensities = 2;
f706a9
-    } else if (cdj970->quality == NORMAL) {
f706a9
-        gx_device_set_resolution((gx_device *) pdev, 600.0, 600.0);
f706a9
-        cdj970->xscal = 1;
f706a9
-        cdj970->yscal = 1;
f706a9
-        /* intensities = 4 from initialization */
f706a9
-    } else {                    /* quality == PRESENTATION */
f706a9
-        gx_device_set_resolution((gx_device *) pdev, 600.0, 600.0);
f706a9
-        cdj970->xscal = 0;
f706a9
-        cdj970->yscal = 0;
f706a9
-        /* intensities = 4 from initialization */
f706a9
-    }
f706a9
-
f706a9
-    m = (gdev_pcl_paper_size((gx_device *) pdev) ==
f706a9
-         PAPER_SIZE_A4 ? dj_a4 : dj_letter);
f706a9
-
f706a9
-    gx_device_set_margins((gx_device *) pdev, m, true);
f706a9
-
f706a9
-    cdj970_write_header((gx_device *) pdev, pdev->file);
f706a9
-}
f706a9
-
f706a9
 /* cdj970_print_page: Here comes the hp970 output routine
f706a9
 ----------------------------------------------------------------------------------*/
f706a9
 static int
f706a9
@@ -837,7 +830,7 @@ cdj970_print_page(gx_device_printer * pdev, FILE * prn_stream)
f706a9
     Gamma gamma;
f706a9
 
f706a9
     if (cdj970->PageCtr == 0 && cdj970->ptype == DJ970C) {
f706a9
-        cdj970_one_time_initialisation(pdev);
f706a9
+        cdj970_write_header((gx_device *)pdev, prn_stream);
f706a9
     }
f706a9
 
f706a9
     /* make a local writable copy of the Gamma tables */
f706a9
@@ -2280,6 +2273,11 @@ cdj_set_bpp(gx_device * pdev, int bpp, int ccomps)
f706a9
         ci->dither_colors = (bpp >= 8 ? 5 : bpp > 1 ? 2 : 0);
f706a9
     }
f706a9
 
f706a9
+    if (ci->depth != ((bpp > 1) && (bpp < 8) ? 8 : bpp)) {
f706a9
+        if (pdev->is_open)
f706a9
+            gs_closedevice(pdev);  /* depth changed, make sure we re-open */
f706a9
+    }
f706a9
+
f706a9
     ci->depth = ((bpp > 1) && (bpp < 8) ? 8 : bpp);
f706a9
 
f706a9
     return (0);
f706a9
@@ -2598,16 +2596,15 @@ cdj_put_param_bpp(gx_device * pdev,
f706a9
                   gs_param_list * plist,
f706a9
                   int new_bpp, int real_bpp, int ccomps)
f706a9
 {
f706a9
-    if (new_bpp == 0 && ccomps == 0)
f706a9
-        return gdev_prn_put_params(pdev, plist);
f706a9
-    else {
f706a9
-        gx_device_color_info save_info;
f706a9
-        int save_bpp;
f706a9
-        int code;
f706a9
-
f706a9
-        save_info = pdev->color_info;
f706a9
-        save_bpp = save_info.depth;
f706a9
+    int code = 0;
f706a9
+    int save_bpp;
f706a9
+    gx_device_color_info save_info;
f706a9
+    save_info = pdev->color_info;
f706a9
+    save_bpp = save_info.depth;
f706a9
 
f706a9
+    if (new_bpp == 0 && ccomps == 0) {
f706a9
+       code = gdev_prn_put_params(pdev, plist);
f706a9
+    } else {
f706a9
         if (save_bpp == 8 && save_ccomps == 3 && !cprn_device->cmyk)
f706a9
             save_bpp = 3;
f706a9
 
f706a9
@@ -2631,12 +2628,22 @@ cdj_put_param_bpp(gx_device * pdev,
f706a9
         if ((cdj970->color_info.depth != save_bpp
f706a9
              || (ccomps != 0 && ccomps != save_ccomps))
f706a9
             && pdev->is_open)
f706a9
-            return (gs_closedevice(pdev));
f706a9
+            gs_closedevice(pdev);
f706a9
+    }
f706a9
+
f706a9
+    /* check for valid resolutions */
f706a9
+    if (pdev->HWResolution[0] != pdev->HWResolution[1] ||
f706a9
+        (pdev->HWResolution[0] != 300.0 && pdev->HWResolution[0] != 600.0) ) {
f706a9
+        param_signal_error(plist, "HWResolution", gs_error_rangecheck);
f706a9
+        emprintf1(pdev->memory, "\ncdj970: Invalid resolution: '%f'. Only 300 or 600 supported.\n\n",
f706a9
+                  pdev->HWResolution[0]);
f706a9
+        cdj_set_bpp(pdev, save_bpp, save_ccomps);
f706a9
+        return gs_error_rangecheck;
f706a9
+    }
f706a9
+    return code;
f706a9
 
f706a9
-        return (0);
f706a9
 
f706a9
 #undef save_ccomps
f706a9
-    }
f706a9
 }
f706a9
 
f706a9
 /* cdj970_write_header: