Blame SOURCES/gdb-runtest-pie-override.patch

190f2a
From FEDORA_PATCHES Mon Sep 17 00:00:00 2001
190f2a
From: Fedora GDB patches <invalid@email.com>
190f2a
Date: Fri, 27 Oct 2017 21:07:50 +0200
190f2a
Subject: gdb-runtest-pie-override.patch
190f2a
190f2a
;; Hack for proper PIE run of the testsuite.
190f2a
;;=fedoratest
190f2a
190f2a
make check//unix/-fPIE/-pie RUNTESTFLAGS=solib-display.exp
190f2a
190f2a
gcc -fpic -c  -fPIE -pie -o x.o x.c
190f2a
/usr/lib/gcc/x86_64-redhat-linux/4.6.1/../../../../lib64/Scrt1.o: In function `_start':
190f2a
(.text+0x20): undefined reference to `main'
190f2a
190f2a
=> Change the order for overrides.
190f2a
190f2a
One has to also use -fPIC rather than -fPIE, -fPIC is stronger.
190f2a
190f2a
The correct way would be:
190f2a
make check//unix RUNTESTFLAGS='CC_FOR_TARGET=gcc\ -fPIC\ -pie CXX_FOR_TARGET=g++\ -fPIC\ -pie solib-display.exp'
190f2a
190f2a
But there is a problem with testsuite.unix non-unique subdir name and also
190f2a
a problem with make -j parallelization of the testsuite.
190f2a
190f2a
diff --git a/gdb/testsuite/lib/future.exp b/gdb/testsuite/lib/future.exp
190f2a
--- a/gdb/testsuite/lib/future.exp
190f2a
+++ b/gdb/testsuite/lib/future.exp
190f2a
@@ -185,6 +185,10 @@ proc gdb_default_target_compile {source destfile type options} {
190f2a
     set ldflags ""
190f2a
     set dest [target_info name]
190f2a
 
190f2a
+    if {[board_info $dest exists multilib_flags]} {
190f2a
+	append add_flags " [board_info $dest multilib_flags]"
190f2a
+    }
190f2a
+
190f2a
     if {[info exists CFLAGS_FOR_TARGET]} {
190f2a
 	append add_flags " $CFLAGS_FOR_TARGET"
190f2a
     }
190f2a
@@ -519,10 +523,6 @@ proc gdb_default_target_compile {source destfile type options} {
190f2a
 	}
190f2a
     }
190f2a
 
190f2a
-    if {[board_info $dest exists multilib_flags]} {
190f2a
-	append add_flags " [board_info $dest multilib_flags]"
190f2a
-    }
190f2a
-
190f2a
     verbose "doing compile"
190f2a
 
190f2a
     set sources ""