Blame SOURCES/gdb-runtest-pie-override.patch

405ea9
From FEDORA_PATCHES Mon Sep 17 00:00:00 2001
405ea9
From: Fedora GDB patches <invalid@email.com>
405ea9
Date: Fri, 27 Oct 2017 21:07:50 +0200
405ea9
Subject: gdb-runtest-pie-override.patch
405ea9
405ea9
;; Hack for proper PIE run of the testsuite.
405ea9
;;=fedoratest
405ea9
405ea9
make check//unix/-fPIE/-pie RUNTESTFLAGS=solib-display.exp
405ea9
405ea9
gcc -fpic -c  -fPIE -pie -o x.o x.c
405ea9
/usr/lib/gcc/x86_64-redhat-linux/4.6.1/../../../../lib64/Scrt1.o: In function `_start':
405ea9
(.text+0x20): undefined reference to `main'
405ea9
405ea9
=> Change the order for overrides.
405ea9
405ea9
One has to also use -fPIC rather than -fPIE, -fPIC is stronger.
405ea9
405ea9
The correct way would be:
405ea9
make check//unix RUNTESTFLAGS='CC_FOR_TARGET=gcc\ -fPIC\ -pie CXX_FOR_TARGET=g++\ -fPIC\ -pie solib-display.exp'
405ea9
405ea9
But there is a problem with testsuite.unix non-unique subdir name and also
405ea9
a problem with make -j parallelization of the testsuite.
405ea9
405ea9
diff --git a/gdb/testsuite/lib/future.exp b/gdb/testsuite/lib/future.exp
405ea9
--- a/gdb/testsuite/lib/future.exp
405ea9
+++ b/gdb/testsuite/lib/future.exp
405ea9
@@ -197,6 +197,10 @@ proc gdb_default_target_compile_1 {source destfile type options} {
405ea9
     set ldflags ""
405ea9
     set dest [target_info name]
405ea9
 
405ea9
+    if {[board_info $dest exists multilib_flags]} {
405ea9
+	append add_flags " [board_info $dest multilib_flags]"
405ea9
+    }
405ea9
+
405ea9
     if {[info exists CFLAGS_FOR_TARGET]} {
405ea9
 	append add_flags " $CFLAGS_FOR_TARGET"
405ea9
     }
405ea9
@@ -531,10 +535,6 @@ proc gdb_default_target_compile_1 {source destfile type options} {
405ea9
 	}
405ea9
     }
405ea9
 
405ea9
-    if {[board_info $dest exists multilib_flags]} {
405ea9
-	append add_flags " [board_info $dest multilib_flags]"
405ea9
-    }
405ea9
-
405ea9
     verbose "doing compile"
405ea9
 
405ea9
     set sources ""