Blame SOURCES/gdb-rhbz1903374-s390x-store-on-condition.patch

0d202d
From FEDORA_PATCHES Mon Sep 17 00:00:00 2001
0d202d
From: Andreas Arnez <arnez@linux.ibm.com>
0d202d
Date: Thu, 19 Nov 2020 19:10:58 +0100
0d202d
Subject: gdb-rhbz1903374-s390x-store-on-condition.patch
0d202d
0d202d
;; Backport of "Correct recording of 'store on condition' insns"
0d202d
;; Andreas Arnaz (RH BZ 1903374)
0d202d
0d202d
gdb/s390: Correct recording of "store on condition" insns
0d202d
0d202d
The "store on condition" instructions STOC, STOCG, and STOCFH are recorded
0d202d
as if their instruction formats resembled that of STG.  This is wrong,
0d202d
usually resulting in "failed to record execution log" errors when trying
0d202d
to record code with any of these instructions.
0d202d
0d202d
This patch fixes the recording of these instructions.
0d202d
0d202d
gdb/ChangeLog:
0d202d
0d202d
	PR tdep/26916
0d202d
	* s390-tdep.c (s390_process_record): Fix recording of STOC, STOCG,
0d202d
	and STOCFH.
0d202d
0d202d
diff --git a/gdb/s390-tdep.c b/gdb/s390-tdep.c
0d202d
--- a/gdb/s390-tdep.c
0d202d
+++ b/gdb/s390-tdep.c
0d202d
@@ -5332,7 +5332,6 @@ ex:
0d202d
 	case 0xe325: /* NTSTG - nontransactional store */
0d202d
 	case 0xe326: /* CVDY - convert to decimal */
0d202d
 	case 0xe32f: /* STRVG - store reversed */
0d202d
-	case 0xebe3: /* STOCG - store on condition */
0d202d
 	case 0xed67: /* STDY - store */
0d202d
 	  oaddr = s390_record_calc_disp (gdbarch, regcache, inib[3], insn[1], ibyte[4]);
0d202d
 	  if (record_full_arch_list_add_mem (oaddr, 8))
0d202d
@@ -5361,8 +5360,6 @@ ex:
0d202d
 	case 0xe33e: /* STRV - store reversed */
0d202d
 	case 0xe350: /* STY - store */
0d202d
 	case 0xe3cb: /* STFH - store high */
0d202d
-	case 0xebe1: /* STOCFH - store high on condition */
0d202d
-	case 0xebf3: /* STOC - store on condition */
0d202d
 	case 0xed66: /* STEY - store */
0d202d
 	  oaddr = s390_record_calc_disp (gdbarch, regcache, inib[3], insn[1], ibyte[4]);
0d202d
 	  if (record_full_arch_list_add_mem (oaddr, 4))
0d202d
@@ -6075,6 +6072,20 @@ ex:
0d202d
 
0d202d
 	/* 0xeb9c-0xebbf undefined */
0d202d
 	/* 0xebc1-0xebdb undefined */
0d202d
+
0d202d
+	case 0xebe1: /* STOCFH - store high on condition */
0d202d
+	case 0xebf3: /* STOC - store on condition */
0d202d
+	  oaddr = s390_record_calc_disp (gdbarch, regcache, 0, insn[1], ibyte[4]);
0d202d
+	  if (record_full_arch_list_add_mem (oaddr, 4))
0d202d
+	    return -1;
0d202d
+	  break;
0d202d
+
0d202d
+	case 0xebe3: /* STOCG - store on condition */
0d202d
+	  oaddr = s390_record_calc_disp (gdbarch, regcache, 0, insn[1], ibyte[4]);
0d202d
+	  if (record_full_arch_list_add_mem (oaddr, 8))
0d202d
+	    return -1;
0d202d
+	  break;
0d202d
+
0d202d
 	/* 0xebe5 undefined */
0d202d
 	/* 0xebe9 undefined */
0d202d
 	/* 0xebeb-0xebf1 undefined */