Message-ID: <549C48EA.9060206@gmail.com>

  Date: Fri, 26 Dec 2014 01:27:06 +0800

  From: Wei-cheng Wang <cole945 at gmail dot com>

  To: Ulrich Weigand <uweigand at de dot ibm dot com>

  CC: gdb-patches at sourceware dot org

  Subject: Re: [PATCH 2/3 v4] Process record support for PowerPC

  On 12/18/2014 2:41 AM, Ulrich Weigand wrote:

  > you seem to have removed all the 32-bit struct sizes here.  Your last

  > iteration had different values for many of those structs for wordsize 4

  > vs. wordsize 8, and I think we need to keep them.

     Oops, this is a mistake.  I'm sorry.

     Fixed now :)

  Thanks,

  Wei-cheng

  --

  2014-12-06  Wei-cheng Wang  <cole945@gmail.com>

		  Ulrich Weigand  <uweigand@de.ibm.com>

		  * configure.tgt (powerpc*-*-linux): Add linux-record.o to

		  gdb_target_obs.

		  (ppc_linux_record_tdep, ppc64_linux_record_tdep): New for linux syscall

		  record.

		  (ppc_canonicalize_syscall, ppc_linux_syscall_record,

		  ppc_linux_record_signal, ppc_init_linux_record_tdep): New functions.

		  (ppc_linux_init_abi): Set process_record, process_record_signal.

		  * ppc-tdep.h (struct gdbarch_tdep): Add ppc_syscall_record and

		  ppc_linux_record_tdep to gdbarch_tdep.

		  (ppc_process_record): New declaration.

		  * rs6000-tdep.c (ppc_record_vsr, ppc_process_record_op4,

		  ppc_process_record_op19, ppc_process_record_op31,

		  ppc_process_record_op59, ppc_process_record_op60,

		  ppc_process_record_op63, ppc_process_record): New functions.

  changelog for testsuite

  2014-12-06  Wei-cheng Wang  <cole945@gmail.com>

	      * lib/gdb.exp (supports_process_record): Return true for

	      powerpc*-*-linux*.

	      (supports_reverse): Likewise.

commit b4cdae6fe51e532e0b1069c6960b14a610182d14

Author: Wei-cheng Wang <cole945@gmail.com>

Date:   Sat Jan 17 14:30:33 2015 +0800

    Reverse debugging for PowerPC.

Index: gdb-7.6.1/gdb/configure.tgt

===================================================================

--- gdb-7.6.1.orig/gdb/configure.tgt

+++ gdb-7.6.1/gdb/configure.tgt

@@ -428,7 +428,8 @@ powerpc*-*-linux*)

 			ppc64-tdep.o solib-svr4.o solib-spu.o \

 			spu-multiarch.o \

 			glibc-tdep.o symfile-mem.o linux-tdep.o \

-			ravenscar-thread.o ppc-ravenscar-thread.o"

+			ravenscar-thread.o ppc-ravenscar-thread.o \

+			linux-record.o "

 	gdb_sim=../sim/ppc/libsim.a

 	build_gdbserver=yes

 	;;

Index: gdb-7.6.1/gdb/ppc-linux-tdep.c

===================================================================

--- gdb-7.6.1.orig/gdb/ppc-linux-tdep.c

+++ gdb-7.6.1/gdb/ppc-linux-tdep.c

@@ -50,6 +50,8 @@

 #include "spu-tdep.h"

 #include "xml-syscall.h"

 #include "linux-tdep.h"

+#include "linux-record.h"

+#include "record-full.h"

 #include "stap-probe.h"

 #include "ax.h"

@@ -812,6 +814,167 @@ ppc_linux_get_syscall_number (struct gdb

   return ret;

 }

+/* PPC process record-replay */

+

+static struct linux_record_tdep ppc_linux_record_tdep;

+static struct linux_record_tdep ppc64_linux_record_tdep;

+

+static enum gdb_syscall

+ppc_canonicalize_syscall (int syscall)

+{

+  /* See arch/powerpc/include/uapi/asm/unistd.h */

+

+  if (syscall <= 165)

+    return syscall;

+  else if (syscall >= 167 && syscall <= 190)	/* Skip query_module 166 */

+    return syscall + 1;

+  else if (syscall >= 192 && syscall <= 197)	/* mmap2 */

+    return syscall;

+  else if (syscall == 208)			/* tkill */

+    return gdb_sys_tkill;

+  else if (syscall >= 207 && syscall <= 220)	/* gettid */

+    return syscall + 224 - 207;

+  else if (syscall >= 234 && syscall <= 239)	/* exit_group */

+    return syscall + 252 - 234;

+  else if (syscall >= 240 && syscall <=248)	/* timer_create */

+    return syscall += 259 - 240;

+  else if (syscall >= 250 && syscall <=251)	/* tgkill */

+    return syscall + 270 - 250;

+  else if (syscall == 336)

+    return gdb_sys_recv;

+  else if (syscall == 337)

+    return gdb_sys_recvfrom;

+  else if (syscall == 342)

+    return gdb_sys_recvmsg;

+  return -1;

+}

+

+static int

+ppc_linux_syscall_record (struct regcache *regcache)

+{

+  struct gdbarch *gdbarch = get_regcache_arch (regcache);

+  struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);

+  ULONGEST scnum;

+  enum gdb_syscall syscall_gdb;

+  int ret;

+  int i;

+

+  regcache_raw_read_unsigned (regcache, tdep->ppc_gp0_regnum, &scnum);

+  syscall_gdb = ppc_canonicalize_syscall (scnum);

+

+  if (syscall_gdb < 0)

+    {

+      printf_unfiltered (_("Process record and replay target doesn't "

+			   "support syscall number %d\n"), (int) scnum);

+      return 0;

+    }

+

+  if (syscall_gdb == gdb_sys_sigreturn

+      || syscall_gdb == gdb_sys_rt_sigreturn)

+   {

+     int i, j;

+     int regsets[] = { tdep->ppc_gp0_regnum,

+		       tdep->ppc_fp0_regnum,

+		       tdep->ppc_vr0_regnum,

+		       tdep->ppc_vsr0_upper_regnum };

+

+     for (j = 0; j < 4; j++)

+       {

+	 if (regsets[j] == -1)

+	   continue;

+	 for (i = 0; i < 32; i++)

+	   {

+	     if (record_full_arch_list_add_reg (regcache, regsets[j] + i))

+	       return -1;

+	   }

+       }

+

+     if (record_full_arch_list_add_reg (regcache, tdep->ppc_cr_regnum))

+       return -1;

+     if (record_full_arch_list_add_reg (regcache, tdep->ppc_ctr_regnum))

+       return -1;

+     if (record_full_arch_list_add_reg (regcache, tdep->ppc_lr_regnum))

+       return -1;

+     if (record_full_arch_list_add_reg (regcache, tdep->ppc_xer_regnum))

+       return -1;

+

+     return 0;

+   }

+

+  if (tdep->wordsize == 8)

+    ret = record_linux_system_call (syscall_gdb, regcache,

+				    &ppc64_linux_record_tdep);

+  else

+    ret = record_linux_system_call (syscall_gdb, regcache,

+				    &ppc_linux_record_tdep);

+

+  if (ret != 0)

+    return ret;

+

+  /* Record registers clobbered during syscall.  */

+  for (i = 3; i <= 12; i++)

+    {

+      if (record_full_arch_list_add_reg (regcache, tdep->ppc_gp0_regnum + i))

+	return -1;

+    }

+  if (record_full_arch_list_add_reg (regcache, tdep->ppc_gp0_regnum + 0))

+    return -1;

+  if (record_full_arch_list_add_reg (regcache, tdep->ppc_cr_regnum))

+    return -1;

+  if (record_full_arch_list_add_reg (regcache, tdep->ppc_ctr_regnum))

+    return -1;

+  if (record_full_arch_list_add_reg (regcache, tdep->ppc_lr_regnum))

+    return -1;

+

+  return 0;

+}

+

+static int

+ppc_linux_record_signal (struct gdbarch *gdbarch, struct regcache *regcache,

+			 enum gdb_signal signal)

+{

+  /* See handle_rt_signal64 in arch/powerpc/kernel/signal_64.c

+	 handle_rt_signal32 in arch/powerpc/kernel/signal_32.c

+	 arch/powerpc/include/asm/ptrace.h

+     for details.  */

+  const int SIGNAL_FRAMESIZE = 128;

+  const int sizeof_rt_sigframe = 1440 * 2 + 8 * 2 + 4 * 6 + 8 + 8 + 128 + 512;

+  ULONGEST sp;

+  struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);

+  int i;

+

+  for (i = 3; i <= 12; i++)

+    {

+      if (record_full_arch_list_add_reg (regcache, tdep->ppc_gp0_regnum + i))

+	return -1;

+    }

+

+  if (record_full_arch_list_add_reg (regcache, tdep->ppc_lr_regnum))

+    return -1;

+  if (record_full_arch_list_add_reg (regcache, tdep->ppc_cr_regnum))

+    return -1;

+  if (record_full_arch_list_add_reg (regcache, tdep->ppc_ctr_regnum))

+    return -1;

+  if (record_full_arch_list_add_reg (regcache, gdbarch_pc_regnum (gdbarch)))

+    return -1;

+  if (record_full_arch_list_add_reg (regcache, gdbarch_sp_regnum (gdbarch)))

+    return -1;

+

+  /* Record the change in the stack.

+     frame-size = sizeof (struct rt_sigframe) + SIGNAL_FRAMESIZE  */

+  regcache_raw_read_unsigned (regcache, gdbarch_sp_regnum (gdbarch), &sp);

+  sp -= SIGNAL_FRAMESIZE;

+  sp -= sizeof_rt_sigframe;

+

+  if (record_full_arch_list_add_mem (sp, SIGNAL_FRAMESIZE + sizeof_rt_sigframe))

+    return -1;

+

+  if (record_full_arch_list_add_end ())

+    return -1;

+

+  return 0;

+}

+

 static void

 ppc_linux_write_pc (struct regcache *regcache, CORE_ADDR pc)

 {

@@ -1287,6 +1450,234 @@ static const struct frame_unwind ppu2spu

   ppu2spu_prev_arch,

 };

+/* Initialize linux_record_tdep if not initialized yet.  */

+

+static void

+ppc_init_linux_record_tdep (struct linux_record_tdep *record_tdep,

+			    int wordsize)

+{

+  /* Simply return if it had been initialized.  */

+  if (record_tdep->size_pointer != 0)

+    return;

+

+  /* These values are the size of the type that will be used in a system

+     call.  They are obtained from Linux Kernel source.  */

+

+  if (wordsize == 8)

+    {

+      record_tdep->size_pointer = 8;

+      record_tdep->size__old_kernel_stat = 32;

+      record_tdep->size_tms = 32;

+      record_tdep->size_loff_t = 8;

+      record_tdep->size_flock = 32;

+      record_tdep->size_oldold_utsname = 45;

+      record_tdep->size_ustat = 32;

+      record_tdep->size_old_sigaction = 152;

+      record_tdep->size_old_sigset_t = 128;

+      record_tdep->size_rlimit = 16;

+      record_tdep->size_rusage = 144;

+      record_tdep->size_timeval = 16;

+      record_tdep->size_timezone = 8;

+      record_tdep->size_old_gid_t = 4;

+      record_tdep->size_old_uid_t = 4;

+      record_tdep->size_fd_set = 128;

+      record_tdep->size_dirent = 280;

+      record_tdep->size_dirent64 = 280;

+      record_tdep->size_statfs = 120;

+      record_tdep->size_statfs64 = 120;

+      record_tdep->size_sockaddr = 16;

+      record_tdep->size_int = 4;

+      record_tdep->size_long = 8;

+      record_tdep->size_ulong = 8;

+      record_tdep->size_msghdr = 56;

+      record_tdep->size_itimerval = 32;

+      record_tdep->size_stat = 144;

+      record_tdep->size_old_utsname = 325;

+      record_tdep->size_sysinfo = 112;

+      record_tdep->size_msqid_ds = 120;

+      record_tdep->size_shmid_ds = 112;

+      record_tdep->size_new_utsname = 390;

+      record_tdep->size_timex = 208;

+      record_tdep->size_mem_dqinfo = 24;

+      record_tdep->size_if_dqblk = 72;

+      record_tdep->size_fs_quota_stat = 80;

+      record_tdep->size_timespec = 16;

+      record_tdep->size_pollfd = 8;

+      record_tdep->size_NFS_FHSIZE = 32;

+      record_tdep->size_knfsd_fh = 132;

+      record_tdep->size_TASK_COMM_LEN = 32;

+      record_tdep->size_sigaction = 152;

+      record_tdep->size_sigset_t = 128;

+      record_tdep->size_siginfo_t = 128;

+      record_tdep->size_cap_user_data_t = 8;

+      record_tdep->size_stack_t = 24;

+      record_tdep->size_off_t = 8;

+      record_tdep->size_stat64 = 104;

+      record_tdep->size_gid_t = 4;

+      record_tdep->size_uid_t = 4;

+      record_tdep->size_PAGE_SIZE = 0x10000;	/* 64KB */

+      record_tdep->size_flock64 = 32;

+      record_tdep->size_io_event = 32;

+      record_tdep->size_iocb = 64;

+      record_tdep->size_epoll_event = 16;

+      record_tdep->size_itimerspec = 32;

+      record_tdep->size_mq_attr = 64;

+      record_tdep->size_siginfo = 128;

+      record_tdep->size_termios = 44;

+      record_tdep->size_pid_t = 4;

+      record_tdep->size_winsize = 8;

+      record_tdep->size_serial_struct = 72;

+      record_tdep->size_serial_icounter_struct = 80;

+      record_tdep->size_size_t = 8;

+      record_tdep->size_iovec = 16;

+    }

+  else if (wordsize == 4)

+    {

+      record_tdep->size_pointer = 4;

+      record_tdep->size__old_kernel_stat = 32;

+      record_tdep->size_tms = 16;

+      record_tdep->size_loff_t = 8;

+      record_tdep->size_flock = 16;

+      record_tdep->size_oldold_utsname = 45;

+      record_tdep->size_ustat = 20;

+      record_tdep->size_old_sigaction = 152;

+      record_tdep->size_old_sigset_t = 128;

+      record_tdep->size_rlimit = 8;

+      record_tdep->size_rusage = 72;

+      record_tdep->size_timeval = 8;

+      record_tdep->size_timezone = 8;

+      record_tdep->size_old_gid_t = 4;

+      record_tdep->size_old_uid_t = 4;

+      record_tdep->size_fd_set = 128;

+      record_tdep->size_dirent = 268;

+      record_tdep->size_dirent64 = 280;

+      record_tdep->size_statfs = 64;

+      record_tdep->size_statfs64 = 88;

+      record_tdep->size_sockaddr = 16;

+      record_tdep->size_int = 4;

+      record_tdep->size_long = 4;

+      record_tdep->size_ulong = 4;

+      record_tdep->size_msghdr = 28;

+      record_tdep->size_itimerval = 16;

+      record_tdep->size_stat = 88;

+      record_tdep->size_old_utsname = 325;

+      record_tdep->size_sysinfo = 64;

+      record_tdep->size_msqid_ds = 68;

+      record_tdep->size_shmid_ds = 60;

+      record_tdep->size_new_utsname = 390;

+      record_tdep->size_timex = 128;

+      record_tdep->size_mem_dqinfo = 24;

+      record_tdep->size_if_dqblk = 72;

+      record_tdep->size_fs_quota_stat = 80;

+      record_tdep->size_timespec = 8;

+      record_tdep->size_pollfd = 8;

+      record_tdep->size_NFS_FHSIZE = 32;

+      record_tdep->size_knfsd_fh = 132;

+      record_tdep->size_TASK_COMM_LEN = 32;

+      record_tdep->size_sigaction = 140;

+      record_tdep->size_sigset_t = 128;

+      record_tdep->size_siginfo_t = 128;

+      record_tdep->size_cap_user_data_t = 4;

+      record_tdep->size_stack_t = 12;

+      record_tdep->size_off_t = 4;

+      record_tdep->size_stat64 = 104;

+      record_tdep->size_gid_t = 4;

+      record_tdep->size_uid_t = 4;

+      record_tdep->size_PAGE_SIZE = 0x10000;	/* 64KB */

+      record_tdep->size_flock64 = 32;

+      record_tdep->size_io_event = 32;

+      record_tdep->size_iocb = 64;

+      record_tdep->size_epoll_event = 16;

+      record_tdep->size_itimerspec = 16;

+      record_tdep->size_mq_attr = 32;

+      record_tdep->size_siginfo = 128;

+      record_tdep->size_termios = 44;

+      record_tdep->size_pid_t = 4;

+      record_tdep->size_winsize = 8;

+      record_tdep->size_serial_struct = 60;

+      record_tdep->size_serial_icounter_struct = 80;

+      record_tdep->size_size_t = 4;

+      record_tdep->size_iovec = 8;

+    }

+  else

+    internal_error (__FILE__, __LINE__, _("unexpected wordsize"));

+

+  /* These values are the second argument of system call "sys_fcntl"

+     and "sys_fcntl64".  They are obtained from Linux Kernel source.  */

+  record_tdep->fcntl_F_GETLK = 5;

+  record_tdep->fcntl_F_GETLK64 = 12;

+  record_tdep->fcntl_F_SETLK64 = 13;

+  record_tdep->fcntl_F_SETLKW64 = 14;

+

+  record_tdep->arg1 = PPC_R0_REGNUM + 3;

+  record_tdep->arg2 = PPC_R0_REGNUM + 4;

+  record_tdep->arg3 = PPC_R0_REGNUM + 5;

+  record_tdep->arg4 = PPC_R0_REGNUM + 6;

+  record_tdep->arg5 = PPC_R0_REGNUM + 7;

+  record_tdep->arg6 = PPC_R0_REGNUM + 8;

+

+  /* These values are the second argument of system call "sys_ioctl".

+     They are obtained from Linux Kernel source.

+     See arch/powerpc/include/uapi/asm/ioctls.h.  */

+  record_tdep->ioctl_TCGETS = 0x403c7413;

+  record_tdep->ioctl_TCSETS = 0x803c7414;

+  record_tdep->ioctl_TCSETSW = 0x803c7415;

+  record_tdep->ioctl_TCSETSF = 0x803c7416;

+  record_tdep->ioctl_TCGETA = 0x40147417;

+  record_tdep->ioctl_TCSETA = 0x80147418;

+  record_tdep->ioctl_TCSETAW = 0x80147419;

+  record_tdep->ioctl_TCSETAF = 0x8014741c;

+  record_tdep->ioctl_TCSBRK = 0x2000741d;

+  record_tdep->ioctl_TCXONC = 0x2000741e;

+  record_tdep->ioctl_TCFLSH = 0x2000741f;

+  record_tdep->ioctl_TIOCEXCL = 0x540c;

+  record_tdep->ioctl_TIOCNXCL = 0x540d;

+  record_tdep->ioctl_TIOCSCTTY = 0x540e;

+  record_tdep->ioctl_TIOCGPGRP = 0x40047477;

+  record_tdep->ioctl_TIOCSPGRP = 0x80047476;

+  record_tdep->ioctl_TIOCOUTQ = 0x40047473;

+  record_tdep->ioctl_TIOCSTI = 0x5412;

+  record_tdep->ioctl_TIOCGWINSZ = 0x40087468;

+  record_tdep->ioctl_TIOCSWINSZ = 0x80087467;

+  record_tdep->ioctl_TIOCMGET = 0x5415;

+  record_tdep->ioctl_TIOCMBIS = 0x5416;

+  record_tdep->ioctl_TIOCMBIC = 0x5417;

+  record_tdep->ioctl_TIOCMSET = 0x5418;

+  record_tdep->ioctl_TIOCGSOFTCAR = 0x5419;

+  record_tdep->ioctl_TIOCSSOFTCAR = 0x541a;

+  record_tdep->ioctl_FIONREAD = 0x4004667f;

+  record_tdep->ioctl_TIOCINQ = 0x4004667f;

+  record_tdep->ioctl_TIOCLINUX = 0x541c;

+  record_tdep->ioctl_TIOCCONS = 0x541d;

+  record_tdep->ioctl_TIOCGSERIAL = 0x541e;

+  record_tdep->ioctl_TIOCSSERIAL = 0x541f;

+  record_tdep->ioctl_TIOCPKT = 0x5420;

+  record_tdep->ioctl_FIONBIO = 0x8004667e;

+  record_tdep->ioctl_TIOCNOTTY = 0x5422;

+  record_tdep->ioctl_TIOCSETD = 0x5423;

+  record_tdep->ioctl_TIOCGETD = 0x5424;

+  record_tdep->ioctl_TCSBRKP = 0x5425;

+  record_tdep->ioctl_TIOCSBRK = 0x5427;

+  record_tdep->ioctl_TIOCCBRK = 0x5428;

+  record_tdep->ioctl_TIOCGSID = 0x5429;

+  record_tdep->ioctl_TIOCGPTN = 0x40045430;

+  record_tdep->ioctl_TIOCSPTLCK = 0x80045431;

+  record_tdep->ioctl_FIONCLEX = 0x20006602;

+  record_tdep->ioctl_FIOCLEX = 0x20006601;

+  record_tdep->ioctl_FIOASYNC = 0x8004667d;

+  record_tdep->ioctl_TIOCSERCONFIG = 0x5453;

+  record_tdep->ioctl_TIOCSERGWILD = 0x5454;

+  record_tdep->ioctl_TIOCSERSWILD = 0x5455;

+  record_tdep->ioctl_TIOCGLCKTRMIOS = 0x5456;

+  record_tdep->ioctl_TIOCSLCKTRMIOS = 0x5457;

+  record_tdep->ioctl_TIOCSERGSTRUCT = 0x5458;

+  record_tdep->ioctl_TIOCSERGETLSR = 0x5459;

+  record_tdep->ioctl_TIOCSERGETMULTI = 0x545a;

+  record_tdep->ioctl_TIOCSERSETMULTI = 0x545b;

+  record_tdep->ioctl_TIOCMIWAIT = 0x545c;

+  record_tdep->ioctl_TIOCGICOUNT = 0x545d;

+  record_tdep->ioctl_FIOQSIZE = 0x40086680;

+}

 static void

 ppc_linux_init_abi (struct gdbarch_info info,

@@ -1486,6 +1877,14 @@ ppc_linux_init_abi (struct gdbarch_info

     }

   set_gdbarch_get_siginfo_type (gdbarch, linux_get_siginfo_type);

+

+  /* Support reverse debugging.  */

+  set_gdbarch_process_record (gdbarch, ppc_process_record);

+  set_gdbarch_process_record_signal (gdbarch, ppc_linux_record_signal);

+  tdep->ppc_syscall_record = ppc_linux_syscall_record;

+

+  ppc_init_linux_record_tdep (&ppc_linux_record_tdep, 4);

+  ppc_init_linux_record_tdep (&ppc64_linux_record_tdep, 8);

 }

 /* Provide a prototype to silence -Wmissing-prototypes.  */

Index: gdb-7.6.1/gdb/ppc-tdep.h

===================================================================

--- gdb-7.6.1.orig/gdb/ppc-tdep.h

+++ gdb-7.6.1/gdb/ppc-tdep.h

@@ -259,6 +259,8 @@ struct gdbarch_tdep

     /* ISA-specific types.  */

     struct type *ppc_builtin_type_vec64;

     struct type *ppc_builtin_type_vec128;

+

+    int (*ppc_syscall_record) (struct regcache *regcache);

 };

@@ -318,6 +320,9 @@ extern CORE_ADDR ppc_insn_d_field (unsig

 extern CORE_ADDR ppc_insn_ds_field (unsigned int insn);

+extern int ppc_process_record (struct gdbarch *gdbarch,

+			       struct regcache *regcache, CORE_ADDR addr);

+

 /* Instruction size.  */

 #define PPC_INSN_SIZE 4

Index: gdb-7.6.1/gdb/rs6000-tdep.c

===================================================================

--- gdb-7.6.1.orig/gdb/rs6000-tdep.c

+++ gdb-7.6.1/gdb/rs6000-tdep.c

@@ -39,6 +39,8 @@

 #include "dwarf2-frame.h"

 #include "target-descriptions.h"

 #include "user-regs.h"

+#include "record-full.h"

+#include "auxv.h"

 #include "libbfd.h"		/* for bfd_default_set_arch_mach */

 #include "coff/internal.h"	/* for libcoff.h */

@@ -3682,6 +3684,1689 @@ bfd_uses_spe_extensions (bfd *abfd)

   return success;

 }

+/* These are macros for parsing instruction fields (I.1.6.28)  */

+

+#define PPC_FIELD(value, from, len) \

+	(((value) >> (32 - (from) - (len))) & ((1 << (len)) - 1))

+#define PPC_SEXT(v, bs) \

+	((((CORE_ADDR) (v) & (((CORE_ADDR) 1 << (bs)) - 1)) \

+	  ^ ((CORE_ADDR) 1 << ((bs) - 1))) \

+	 - ((CORE_ADDR) 1 << ((bs) - 1)))

+#define PPC_OP6(insn)	PPC_FIELD (insn, 0, 6)

+#define PPC_EXTOP(insn)	PPC_FIELD (insn, 21, 10)

+#define PPC_RT(insn)	PPC_FIELD (insn, 6, 5)

+#define PPC_RS(insn)	PPC_FIELD (insn, 6, 5)

+#define PPC_RA(insn)	PPC_FIELD (insn, 11, 5)

+#define PPC_RB(insn)	PPC_FIELD (insn, 16, 5)

+#define PPC_NB(insn)	PPC_FIELD (insn, 16, 5)

+#define PPC_VRT(insn)	PPC_FIELD (insn, 6, 5)

+#define PPC_FRT(insn)	PPC_FIELD (insn, 6, 5)

+#define PPC_SPR(insn)	(PPC_FIELD (insn, 11, 5) \

+			| (PPC_FIELD (insn, 16, 5) << 5))

+#define PPC_BO(insn)	PPC_FIELD (insn, 6, 5)

+#define PPC_T(insn)	PPC_FIELD (insn, 6, 5)

+#define PPC_D(insn)	PPC_SEXT (PPC_FIELD (insn, 16, 16), 16)

+#define PPC_DS(insn)	PPC_SEXT (PPC_FIELD (insn, 16, 14), 14)

+#define PPC_BIT(insn,n)	((insn & (1 << (31 - (n)))) ? 1 : 0)

+#define PPC_OE(insn)	PPC_BIT (insn, 21)

+#define PPC_RC(insn)	PPC_BIT (insn, 31)

+#define PPC_Rc(insn)	PPC_BIT (insn, 21)

+#define PPC_LK(insn)	PPC_BIT (insn, 31)

+#define PPC_TX(insn)	PPC_BIT (insn, 31)

+#define PPC_LEV(insn)	PPC_FIELD (insn, 20, 7)

+

+#define PPC_XT(insn)	((PPC_TX (insn) << 5) | PPC_T (insn))

+#define PPC_XER_NB(xer)	(xer & 0x7f)

+

+/* Record Vector-Scalar Registers.  */

+

+static int

+ppc_record_vsr (struct regcache *regcache, struct gdbarch_tdep *tdep, int vsr)

+{

+  if (vsr < 0 || vsr >= 64)

+    return -1;

+

+  if (vsr >= 32)

+    {

+      if (tdep->ppc_vr0_regnum >= 0)

+	record_full_arch_list_add_reg (regcache, tdep->ppc_vr0_regnum + vsr - 32);

+    }

+  else

+    {

+      if (tdep->ppc_fp0_regnum >= 0)

+	record_full_arch_list_add_reg (regcache, tdep->ppc_fp0_regnum + vsr);

+      if (tdep->ppc_vsr0_upper_regnum >= 0)

+	record_full_arch_list_add_reg (regcache,

+				       tdep->ppc_vsr0_upper_regnum + vsr);

+    }

+

+  return 0;

+}

+

+/* Parse instructions of primary opcode-4.  */

+

+static int

+ppc_process_record_op4 (struct gdbarch *gdbarch, struct regcache *regcache,

+			   CORE_ADDR addr, uint32_t insn)

+{

+  struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);

+  int ext = PPC_FIELD (insn, 21, 11);

+

+  switch (ext & 0x3f)

+    {

+    case 32:		/* Vector Multiply-High-Add Signed Halfword Saturate */

+    case 33:		/* Vector Multiply-High-Round-Add Signed Halfword Saturate */

+    case 39:		/* Vector Multiply-Sum Unsigned Halfword Saturate */

+    case 41:		/* Vector Multiply-Sum Signed Halfword Saturate */

+      record_full_arch_list_add_reg (regcache, PPC_VSCR_REGNUM);

+      /* FALL-THROUGH */

+    case 42:		/* Vector Select */

+    case 43:		/* Vector Permute */

+    case 44:		/* Vector Shift Left Double by Octet Immediate */

+    case 45:		/* Vector Permute and Exclusive-OR */

+    case 60:		/* Vector Add Extended Unsigned Quadword Modulo */

+    case 61:		/* Vector Add Extended & write Carry Unsigned Quadword */

+    case 62:		/* Vector Subtract Extended Unsigned Quadword Modulo */

+    case 63:		/* Vector Subtract Extended & write Carry Unsigned Quadword */

+    case 34:		/* Vector Multiply-Low-Add Unsigned Halfword Modulo */

+    case 36:		/* Vector Multiply-Sum Unsigned Byte Modulo */

+    case 37:		/* Vector Multiply-Sum Mixed Byte Modulo */

+    case 38:		/* Vector Multiply-Sum Unsigned Halfword Modulo */

+    case 40:		/* Vector Multiply-Sum Signed Halfword Modulo */

+    case 46:		/* Vector Multiply-Add Single-Precision */

+    case 47:		/* Vector Negative Multiply-Subtract Single-Precision */

+      record_full_arch_list_add_reg (regcache,

+				     tdep->ppc_vr0_regnum + PPC_VRT (insn));

+      return 0;

+    }

+

+  switch ((ext & 0x1ff))

+    {

+			/* 5.16 Decimal Integer Arithmetic Instructions */

+    case 1:		/* Decimal Add Modulo */

+    case 65:		/* Decimal Subtract Modulo */

+

+      /* Bit-21 should be set.  */

+      if (!PPC_BIT (insn, 21))

+	break;

+

+      record_full_arch_list_add_reg (regcache,

+				     tdep->ppc_vr0_regnum + PPC_VRT (insn));

+      record_full_arch_list_add_reg (regcache, tdep->ppc_cr_regnum);

+      return 0;

+    }

+

+  /* Bit-21 is used for RC */

+  switch (ext & 0x3ff)

+    {

+    case 6:		/* Vector Compare Equal To Unsigned Byte */

+    case 70:		/* Vector Compare Equal To Unsigned Halfword */

+    case 134:		/* Vector Compare Equal To Unsigned Word */

+    case 199:		/* Vector Compare Equal To Unsigned Doubleword */

+    case 774:		/* Vector Compare Greater Than Signed Byte */

+    case 838:		/* Vector Compare Greater Than Signed Halfword */

+    case 902:		/* Vector Compare Greater Than Signed Word */

+    case 967:		/* Vector Compare Greater Than Signed Doubleword */

+    case 518:		/* Vector Compare Greater Than Unsigned Byte */

+    case 646:		/* Vector Compare Greater Than Unsigned Word */

+    case 582:		/* Vector Compare Greater Than Unsigned Halfword */

+    case 711:		/* Vector Compare Greater Than Unsigned Doubleword */

+    case 966:		/* Vector Compare Bounds Single-Precision */

+    case 198:		/* Vector Compare Equal To Single-Precision */

+    case 454:		/* Vector Compare Greater Than or Equal To Single-Precision */

+    case 710:		/* Vector Compare Greater Than Single-Precision */

+      if (PPC_Rc (insn))

+	record_full_arch_list_add_reg (regcache, tdep->ppc_cr_regnum);

+      record_full_arch_list_add_reg (regcache,

+				     tdep->ppc_vr0_regnum + PPC_VRT (insn));

+      return 0;

+    }

+

+  switch (ext)

+    {

+    case 142:		/* Vector Pack Unsigned Halfword Unsigned Saturate */

+    case 206:		/* Vector Pack Unsigned Word Unsigned Saturate */

+    case 270:		/* Vector Pack Signed Halfword Unsigned Saturate */

+    case 334:		/* Vector Pack Signed Word Unsigned Saturate */

+    case 398:		/* Vector Pack Signed Halfword Signed Saturate */

+    case 462:		/* Vector Pack Signed Word Signed Saturate */

+    case 1230:		/* Vector Pack Unsigned Doubleword Unsigned Saturate */

+    case 1358:		/* Vector Pack Signed Doubleword Unsigned Saturate */

+    case 1486:		/* Vector Pack Signed Doubleword Signed Saturate */

+    case 512:		/* Vector Add Unsigned Byte Saturate */

+    case 576:		/* Vector Add Unsigned Halfword Saturate */

+    case 640:		/* Vector Add Unsigned Word Saturate */

+    case 768:		/* Vector Add Signed Byte Saturate */

+    case 832:		/* Vector Add Signed Halfword Saturate */

+    case 896:		/* Vector Add Signed Word Saturate */

+    case 1536:		/* Vector Subtract Unsigned Byte Saturate */

+    case 1600:		/* Vector Subtract Unsigned Halfword Saturate */

+    case 1664:		/* Vector Subtract Unsigned Word Saturate */

+    case 1792:		/* Vector Subtract Signed Byte Saturate */

+    case 1856:		/* Vector Subtract Signed Halfword Saturate */

+    case 1920:		/* Vector Subtract Signed Word Saturate */

+

+    case 1544:		/* Vector Sum across Quarter Unsigned Byte Saturate */

+    case 1800:		/* Vector Sum across Quarter Signed Byte Saturate */

+    case 1608:		/* Vector Sum across Quarter Signed Halfword Saturate */

+    case 1672:		/* Vector Sum across Half Signed Word Saturate */

+    case 1928:		/* Vector Sum across Signed Word Saturate */

+    case 970:		/* Vector Convert To Signed Fixed-Point Word Saturate */

+    case 906:		/* Vector Convert To Unsigned Fixed-Point Word Saturate */

+      record_full_arch_list_add_reg (regcache, PPC_VSCR_REGNUM);

+      /* FALL-THROUGH */

+    case 12:		/* Vector Merge High Byte */

+    case 14:		/* Vector Pack Unsigned Halfword Unsigned Modulo */

+    case 76:		/* Vector Merge High Halfword */

+    case 78:		/* Vector Pack Unsigned Word Unsigned Modulo */

+    case 140:		/* Vector Merge High Word */

+    case 268:		/* Vector Merge Low Byte */

+    case 332:		/* Vector Merge Low Halfword */

+    case 396:		/* Vector Merge Low Word */

+    case 526:		/* Vector Unpack High Signed Byte */

+    case 590:		/* Vector Unpack High Signed Halfword */