Blame SOURCES/gdb-rhbz1186476-internal-error-unqualified-name-re-set-test.patch

689258
From FEDORA_PATCHES Mon Sep 17 00:00:00 2001
689258
From: Fedora GDB patches <invalid@email.com>
689258
Date: Fri, 27 Oct 2017 21:07:50 +0200
689258
Subject: gdb-rhbz1186476-internal-error-unqualified-name-re-set-test.patch
689258
689258
;; Fix 'backport GDB 7.4 fix to RHEL 6.6 GDB' [Original Sourceware bug
689258
;; description: 'C++ (and objc): Internal error on unqualified name
689258
;; re-set', PR 11657] (RH BZ 1186476).
689258
;;=fedoratest
689258
689258
Comments from Sergio Durigan Junior:
689258
689258
  The "proper" fix for this whole problem would be to backport the
689258
  "ambiguous linespec" patch series.  However, it is really not
689258
  recommended to do that for RHEL GDB, because the patch series is too
689258
  big and could introduce unwanted regressions.  Instead, what we
689258
  chose to do was to replace the gdb_assert call by a warning (which
689258
  allows the user to continue the debugging session), and tell the
689258
  user that, although more than one location was found for his/her
689258
  breakpoint, only one will be used.
689258
689258
diff --git a/gdb/testsuite/gdb.cp/gdb-rhbz1186476-internal-error-unqualified-name-re-set-main.cc b/gdb/testsuite/gdb.cp/gdb-rhbz1186476-internal-error-unqualified-name-re-set-main.cc
689258
new file mode 100644
689258
--- /dev/null
689258
+++ b/gdb/testsuite/gdb.cp/gdb-rhbz1186476-internal-error-unqualified-name-re-set-main.cc
689258
@@ -0,0 +1,22 @@
689258
+/* This testcase is part of GDB, the GNU debugger.
689258
+
689258
+   Copyright 2015 Free Software Foundation, Inc.
689258
+
689258
+   This program is free software; you can redistribute it and/or modify
689258
+   it under the terms of the GNU General Public License as published by
689258
+   the Free Software Foundation; either version 3 of the License, or
689258
+   (at your option) any later version.
689258
+
689258
+   This program is distributed in the hope that it will be useful,
689258
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
689258
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
689258
+   GNU General Public License for more details.
689258
+
689258
+   You should have received a copy of the GNU General Public License
689258
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
689258
+
689258
+int
689258
+main (int argc, char *argv[])
689258
+{
689258
+  return 0;
689258
+}
689258
diff --git a/gdb/testsuite/gdb.cp/gdb-rhbz1186476-internal-error-unqualified-name-re-set.cc b/gdb/testsuite/gdb.cp/gdb-rhbz1186476-internal-error-unqualified-name-re-set.cc
689258
new file mode 100644
689258
--- /dev/null
689258
+++ b/gdb/testsuite/gdb.cp/gdb-rhbz1186476-internal-error-unqualified-name-re-set.cc
689258
@@ -0,0 +1,26 @@
689258
+/* This testcase is part of GDB, the GNU debugger.
689258
+
689258
+   Copyright 2015 Free Software Foundation, Inc.
689258
+
689258
+   This program is free software; you can redistribute it and/or modify
689258
+   it under the terms of the GNU General Public License as published by
689258
+   the Free Software Foundation; either version 3 of the License, or
689258
+   (at your option) any later version.
689258
+
689258
+   This program is distributed in the hope that it will be useful,
689258
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
689258
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
689258
+   GNU General Public License for more details.
689258
+
689258
+   You should have received a copy of the GNU General Public License
689258
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
689258
+
689258
+class C
689258
+  {
689258
+    public:
689258
+      C () {}
689258
+      C (int x) {}
689258
+  };
689258
+
689258
+C a;
689258
+C b (1);
689258
diff --git a/gdb/testsuite/gdb.cp/gdb-rhbz1186476-internal-error-unqualified-name-re-set.exp b/gdb/testsuite/gdb.cp/gdb-rhbz1186476-internal-error-unqualified-name-re-set.exp
689258
new file mode 100644
689258
--- /dev/null
689258
+++ b/gdb/testsuite/gdb.cp/gdb-rhbz1186476-internal-error-unqualified-name-re-set.exp
689258
@@ -0,0 +1,51 @@
689258
+# Copyright 2015 Free Software Foundation, Inc.
689258
+
689258
+# This program is free software; you can redistribute it and/or modify
689258
+# it under the terms of the GNU General Public License as published by
689258
+# the Free Software Foundation; either version 3 of the License, or
689258
+# (at your option) any later version.
689258
+#
689258
+# This program is distributed in the hope that it will be useful,
689258
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
689258
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
689258
+# GNU General Public License for more details.
689258
+#
689258
+# You should have received a copy of the GNU General Public License
689258
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
689258
+
689258
+if { [skip_cplus_tests] } { continue }
689258
+if { [skip_shlib_tests] } { continue }
689258
+if { [is_remote target] } { continue }
689258
+if { [target_info exists use_gdb_stub] } { continue }
689258
+
689258
+set testfile gdb-rhbz1186476-internal-error-unqualified-name-re-set-main
689258
+set srcfile $testfile.cc
689258
+set executable $testfile
689258
+set binfile [standard_output_file $executable]
689258
+
689258
+set libtestfile gdb-rhbz1186476-internal-error-unqualified-name-re-set
689258
+set libsrcfile $libtestfile.cc
689258
+set sofile [standard_output_file lib$libtestfile.so]
689258
+
689258
+# Create and source the file that provides information about the compiler
689258
+# used to compile the test case.
689258
+if [get_compiler_info "c++"] {
689258
+    return -1
689258
+}
689258
+
689258
+if { [gdb_compile_shlib $srcdir/$subdir/$libsrcfile $sofile {debug c++ "additional_flags=-fPIC"}] != ""
689258
+     || [gdb_compile $srcdir/$subdir/$srcfile $binfile executable [list additional_flags=-Wl,-rpath,[file dirname ${sofile}] "c++" shlib=${sofile} ]] != ""} {
689258
+    untested $libtestfile.exp
689258
+    return -1
689258
+}
689258
+
689258
+clean_restart $executable
689258
+
689258
+gdb_test_no_output "set breakpoint pending on"
689258
+# gdb_breakpoint would print a failure because of some warning messages
689258
+gdb_test "break C::C" "Breakpoint $decimal \\(C::C\\) pending."
689258
+
689258
+#gdb_test "run" "warning: Found more than one location for breakpoint #$decimal; only the first location will be used.(\r\n)+Breakpoint $decimal, C::C.*"
689258
+gdb_test "run"
689258
+
689258
+gdb_test "info break" " in C::C\\(\\) at .* in C::C\\(int\\) at .*"