|
 |
2c2fa1 |
From gdb-patches-return-123876-listarch-gdb-patches=sources dot redhat dot com at sourceware dot org Mon Jun 29 16:37:14 2015
|
|
|
2c2fa1 |
Return-Path: <gdb-patches-return-123876-listarch-gdb-patches=sources dot redhat dot com at sourceware dot org>
|
|
|
2c2fa1 |
Delivered-To: listarch-gdb-patches at sources dot redhat dot com
|
|
|
2c2fa1 |
Received: (qmail 98411 invoked by alias); 29 Jun 2015 16:37:14 -0000
|
|
|
2c2fa1 |
Mailing-List: contact gdb-patches-help at sourceware dot org; run by ezmlm
|
|
|
2c2fa1 |
Precedence: bulk
|
|
|
2c2fa1 |
List-Id: <gdb-patches.sourceware.org>
|
|
|
2c2fa1 |
List-Subscribe: <mailto:gdb-patches-subscribe at sourceware dot org>
|
|
|
2c2fa1 |
List-Archive: <http://sourceware.org/ml/gdb-patches/>
|
|
|
2c2fa1 |
List-Post: <mailto:gdb-patches at sourceware dot org>
|
|
|
2c2fa1 |
List-Help: <mailto:gdb-patches-help at sourceware dot org>, <http://sourceware dot org/ml/#faqs>
|
|
|
2c2fa1 |
Sender: gdb-patches-owner at sourceware dot org
|
|
|
2c2fa1 |
Delivered-To: mailing list gdb-patches at sourceware dot org
|
|
|
2c2fa1 |
Received: (qmail 98402 invoked by uid 89); 29 Jun 2015 16:37:13 -0000
|
|
|
2c2fa1 |
Authentication-Results: sourceware.org; auth=none
|
|
|
2c2fa1 |
X-Virus-Found: No
|
|
|
2c2fa1 |
X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2
|
|
|
2c2fa1 |
X-HELO: mx1.redhat.com
|
|
|
2c2fa1 |
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 29 Jun 2015 16:37:13 +0000
|
|
|
2c2fa1 |
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id DF7D48EA29 for <gdb-patches@sourceware.org>; Mon, 29 Jun 2015 16:37:11 +0000 (UTC)
|
|
|
2c2fa1 |
Received: from host1.jankratochvil.net (ovpn-116-41.ams2.redhat.com [10.36.116.41]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5TGb8I0022607 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for <gdb-patches@sourceware.org>; Mon, 29 Jun 2015 12:37:11 -0400
|
|
|
2c2fa1 |
Date: Mon, 29 Jun 2015 18:37:08 +0200
|
|
|
2c2fa1 |
From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
|
|
|
2c2fa1 |
To: gdb-patches at sourceware dot org
|
|
|
2c2fa1 |
Subject: [testsuite patch] Fix testsuite regression by: Do not skip prologue for asm (.S) files
|
|
|
2c2fa1 |
Message-ID: <20150629163708.GA28795@host1.jankratochvil.net>
|
|
|
2c2fa1 |
MIME-Version: 1.0
|
|
|
2c2fa1 |
Content-Type: multipart/mixed; boundary="wac7ysb48OaltWcw"
|
|
|
2c2fa1 |
Content-Disposition: inline
|
|
|
2c2fa1 |
User-Agent: Mutt/1.5.23 (2014-03-12)
|
|
|
2c2fa1 |
X-IsSubscribed: yes
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
--wac7ysb48OaltWcw
|
|
|
2c2fa1 |
Content-Type: text/plain; charset=us-ascii
|
|
|
2c2fa1 |
Content-Disposition: inline
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
Hi,
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
I have somehow missed gdb.asm/asm-source.exp PASS->FAIL even on x86_64.
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
It has no longer valid assumption that "break" breaks after the prologue even
|
|
|
2c2fa1 |
in assembler. So I have changed this assumption of the testfile.
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
Tested it FAIL->PASSes on x86_64, ppc64 and s390x.
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
OK for check-in?
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
Jan
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
--wac7ysb48OaltWcw
|
|
|
2c2fa1 |
Content-Type: text/plain; charset=us-ascii
|
|
|
2c2fa1 |
Content-Disposition: inline; filename=2
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
gdb/testsuite/
|
|
|
2c2fa1 |
2015-06-29 Jan Kratochvil <jan.kratochvil@redhat.com>
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
* gdb.asm/asm-source.exp (f at main): Stop at gdbasm_enter.
|
|
|
2c2fa1 |
(n at main): New.
|
|
|
2c2fa1 |
* gdb.asm/asmsrc1.s: Add comment "mark: main enter".
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
Index: gdb-7.6.1/gdb/testsuite/gdb.asm/asm-source.exp
|
|
|
2c2fa1 |
===================================================================
|
|
|
2c2fa1 |
--- gdb-7.6.1.orig/gdb/testsuite/gdb.asm/asm-source.exp
|
|
|
2c2fa1 |
+++ gdb-7.6.1/gdb/testsuite/gdb.asm/asm-source.exp
|
|
|
2c2fa1 |
@@ -272,6 +272,7 @@ if { [istarget "m6811-*-*"] || [istarget
|
|
|
2c2fa1 |
}
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
# Collect some line numbers.
|
|
|
2c2fa1 |
+set line_enter [expr [gdb_get_line_number "main enter" "asmsrc1.s"] + 1]
|
|
|
2c2fa1 |
set line_main [expr [gdb_get_line_number "main start" "asmsrc1.s"] + 1]
|
|
|
2c2fa1 |
set line_call_foo2 [expr [gdb_get_line_number "call foo2" "asmsrc1.s"] + 1]
|
|
|
2c2fa1 |
set line_search_comment [expr [gdb_get_line_number "search" "asmsrc1.s"] + 1]
|
|
|
2c2fa1 |
@@ -295,7 +296,10 @@ if ![runto_main] then {
|
|
|
2c2fa1 |
}
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
# Execute the `f' command and see if the result includes source info.
|
|
|
2c2fa1 |
-gdb_test "f" "asmsrc1\[.\]s:$line_main.*several_nops" "f at main"
|
|
|
2c2fa1 |
+gdb_test "f" "asmsrc1\[.\]s:$line_enter.*gdbasm_enter" "f at main"
|
|
|
2c2fa1 |
+
|
|
|
2c2fa1 |
+# Execute the `n' command.
|
|
|
2c2fa1 |
+gdb_test "n" "$line_main\[ \]*.*several_nops" "n at main"
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
# See if we properly `next' over a macro with several insns.
|
|
|
2c2fa1 |
gdb_test "n" "$line_call_foo2\[ \]*.*foo2" "next over macro"
|
|
|
2c2fa1 |
Index: gdb-7.6.1/gdb/testsuite/gdb.asm/asmsrc1.s
|
|
|
2c2fa1 |
===================================================================
|
|
|
2c2fa1 |
--- gdb-7.6.1.orig/gdb/testsuite/gdb.asm/asmsrc1.s
|
|
|
2c2fa1 |
+++ gdb-7.6.1/gdb/testsuite/gdb.asm/asmsrc1.s
|
|
|
2c2fa1 |
@@ -34,6 +34,7 @@
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
.global main
|
|
|
2c2fa1 |
gdbasm_declare main
|
|
|
2c2fa1 |
+ comment "mark: main enter"
|
|
|
2c2fa1 |
gdbasm_enter
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
comment "Call a macro that consists of several lines of assembler code."
|