Blame SOURCES/gcc8-libgfortran-default-values.patch

d8f365
diff --git a/gcc/fortran/io.c b/gcc/fortran/io.c
d8f365
index d93dcfa..f47565c 100644
d8f365
--- a/gcc/fortran/io.c
d8f365
+++ b/gcc/fortran/io.c
d8f365
@@ -909,6 +909,13 @@ data_desc:
d8f365
 
d8f365
       if (u != FMT_POSINT)
d8f365
 	{
d8f365
+	  if (flag_dec)
d8f365
+	    {
d8f365
+	      /* Assume a default width based on the variable size.  */
d8f365
+	      saved_token = u;
d8f365
+	      break;
d8f365
+	    }
d8f365
+
d8f365
 	  format_locus.nextc += format_string_pos;
d8f365
 	  gfc_error ("Positive width required in format "
d8f365
 			 "specifier %s at %L", token_to_string (t),
d8f365
@@ -1030,6 +1037,13 @@ data_desc:
d8f365
 	goto fail;
d8f365
       if (t != FMT_ZERO && t != FMT_POSINT)
d8f365
 	{
d8f365
+	  if (flag_dec)
d8f365
+	    {
d8f365
+	      /* Assume the default width is expected here and continue lexing.  */
d8f365
+	      value = 0; /* It doesn't matter what we set the value to here.  */
d8f365
+	      saved_token = t;
d8f365
+	      break;
d8f365
+	    }
d8f365
 	  error = nonneg_required;
d8f365
 	  goto syntax;
d8f365
 	}
d8f365
@@ -1099,8 +1113,17 @@ data_desc:
d8f365
 	goto fail;
d8f365
       if (t != FMT_ZERO && t != FMT_POSINT)
d8f365
 	{
d8f365
-	  error = nonneg_required;
d8f365
-	  goto syntax;
d8f365
+	  if (flag_dec)
d8f365
+	    {
d8f365
+	      /* Assume the default width is expected here and continue lexing.  */
d8f365
+	      value = 0; /* It doesn't matter what we set the value to here.  */
d8f365
+	      saved_token = t;
d8f365
+	    }
d8f365
+	  else
d8f365
+	    {
d8f365
+	      error = nonneg_required;
d8f365
+	      goto syntax;
d8f365
+	    }
d8f365
 	}
d8f365
       else if (is_input && t == FMT_ZERO)
d8f365
 	{
d8f365
diff --git a/gcc/testsuite/gfortran.dg/fmt_f_default_field_width.f90 b/gcc/testsuite/gfortran.dg/fmt_f_default_field_width.f90
d8f365
new file mode 100644
d8f365
index 0000000..b087b8f
d8f365
--- /dev/null
d8f365
+++ b/gcc/testsuite/gfortran.dg/fmt_f_default_field_width.f90
d8f365
@@ -0,0 +1,43 @@
d8f365
+! { dg-do run }
d8f365
+! { dg-options -fdec }
d8f365
+!
d8f365
+! Test case for the default field widths enabled by the -fdec-format-defaults flag.
d8f365
+!
d8f365
+! This feature is not part of any Fortran standard, but it is supported by the
d8f365
+! Oracle Fortran compiler and others.
d8f365
+!
d8f365
+! libgfortran uses printf() internally to implement FORMAT. If you print float
d8f365
+! values to a higher precision than the type can actually store, the results
d8f365
+! are implementation dependent: some platforms print zeros, others print random
d8f365
+! numbers. Don't depend on this behaviour in tests because they will not be
d8f365
+! portable.
d8f365
+
d8f365
+    character(50) :: buffer
d8f365
+
d8f365
+    real*4 :: real_4
d8f365
+    real*8 :: real_8
d8f365
+    real*16 :: real_16
d8f365
+    integer :: len
d8f365
+
d8f365
+    real_4 = 4.18
d8f365
+    write(buffer, '(A, F, A)') ':',real_4,':'
d8f365
+    print *,buffer
d8f365
+    if (buffer.ne.":      4.1799998:") call abort
d8f365
+
d8f365
+    real_4 = 0.00000018
d8f365
+    write(buffer, '(A, F, A)') ':',real_4,':'
d8f365
+    print *,buffer
d8f365
+    if (buffer.ne.":      0.0000002:") call abort
d8f365
+
d8f365
+    real_8 = 4.18
d8f365
+    write(buffer, '(A, F, A)') ':',real_8,':'
d8f365
+    print *,buffer
d8f365
+    len = len_trim(buffer)
d8f365
+    if (len /= 27) call abort
d8f365
+
d8f365
+    real_16 = 4.18
d8f365
+    write(buffer, '(A, F, A)') ':',real_16,':'
d8f365
+    print *,buffer
d8f365
+    len = len_trim(buffer)
d8f365
+    if (len /= 44) call abort
d8f365
+end
d8f365
diff --git a/gcc/testsuite/gfortran.dg/fmt_g_default_field_width.f90 b/gcc/testsuite/gfortran.dg/fmt_g_default_field_width.f90
d8f365
new file mode 100644
d8f365
index 0000000..3d3a476
d8f365
--- /dev/null
d8f365
+++ b/gcc/testsuite/gfortran.dg/fmt_g_default_field_width.f90
d8f365
@@ -0,0 +1,48 @@
d8f365
+! { dg-do run }
d8f365
+! { dg-options -fdec }
d8f365
+!
d8f365
+! Test case for the default field widths enabled by the -fdec-format-defaults flag.
d8f365
+!
d8f365
+! This feature is not part of any Fortran standard, but it is supported by the
d8f365
+! Oracle Fortran compiler and others.
d8f365
+!
d8f365
+! libgfortran uses printf() internally to implement FORMAT. If you print float
d8f365
+! values to a higher precision than the type can actually store, the results
d8f365
+! are implementation dependent: some platforms print zeros, others print random
d8f365
+! numbers. Don't depend on this behaviour in tests because they will not be
d8f365
+! portable.
d8f365
+
d8f365
+    character(50) :: buffer
d8f365
+
d8f365
+    real*4 :: real_4
d8f365
+    real*8 :: real_8
d8f365
+    real*16 :: real_16
d8f365
+    integer :: len
d8f365
+
d8f365
+    real_4 = 4.18
d8f365
+    write(buffer, '(A, G, A)') ':',real_4,':'
d8f365
+    print *,buffer
d8f365
+    if (buffer.ne.":   4.180000    :") call abort
d8f365
+
d8f365
+    real_4 = 0.00000018
d8f365
+    write(buffer, '(A, G, A)') ':',real_4,':'
d8f365
+    print *,buffer
d8f365
+    if (buffer.ne.":  0.1800000E-06:") call abort
d8f365
+
d8f365
+    real_4 = 18000000.4
d8f365
+    write(buffer, '(A, G, A)') ':',real_4,':'
d8f365
+    print *,buffer
d8f365
+    if (buffer.ne.":  0.1800000E+08:") call abort
d8f365
+
d8f365
+    real_8 = 4.18
d8f365
+    write(buffer, '(A, G, A)') ':',real_8,':'
d8f365
+    print *,buffer
d8f365
+    len = len_trim(buffer)
d8f365
+    if (len /= 27) call abort
d8f365
+
d8f365
+    real_16 = 4.18
d8f365
+    write(buffer, '(A, G, A)') ':',real_16,':'
d8f365
+    print *,buffer
d8f365
+    len = len_trim(buffer)
d8f365
+    if (len /= 44) call abort
d8f365
+end
d8f365
diff --git a/gcc/testsuite/gfortran.dg/fmt_i_default_field_width.f90 b/gcc/testsuite/gfortran.dg/fmt_i_default_field_width.f90
d8f365
new file mode 100644
d8f365
index 0000000..ac4e165
d8f365
--- /dev/null
d8f365
+++ b/gcc/testsuite/gfortran.dg/fmt_i_default_field_width.f90
d8f365
@@ -0,0 +1,38 @@
d8f365
+! { dg-do run }
d8f365
+! { dg-options -fdec }
d8f365
+!
d8f365
+! Test case for the default field widths enabled by the -fdec-format-defaults flag.
d8f365
+!
d8f365
+! This feature is not part of any Fortran standard, but it is supported by the
d8f365
+! Oracle Fortran compiler and others.
d8f365
+
d8f365
+    character(50) :: buffer
d8f365
+    character(1) :: colon
d8f365
+
d8f365
+    integer*2 :: integer_2
d8f365
+    integer*4 :: integer_4
d8f365
+    integer*8 :: integer_8
d8f365
+
d8f365
+    write(buffer, '(A, I, A)') ':',12340,':'
d8f365
+    print *,buffer
d8f365
+    if (buffer.ne.":       12340:") call abort
d8f365
+
d8f365
+    read(buffer, '(A1, I, A1)') colon, integer_4, colon
d8f365
+    if (integer_4.ne.12340) call abort
d8f365
+
d8f365
+    integer_2 = -99
d8f365
+    write(buffer, '(A, I, A)') ':',integer_2,':'
d8f365
+    print *,buffer
d8f365
+    if (buffer.ne.":    -99:") call abort
d8f365
+
d8f365
+    integer_8 = -11112222
d8f365
+    write(buffer, '(A, I, A)') ':',integer_8,':'
d8f365
+    print *,buffer
d8f365
+    if (buffer.ne.":              -11112222:") call abort
d8f365
+
d8f365
+! If the width is 7 and there are 7 leading zeroes, the result should be zero.
d8f365
+    integer_2 = 789
d8f365
+    buffer = '0000000789'
d8f365
+    read(buffer, '(I)') integer_2
d8f365
+    if (integer_2.ne.0) call abort
d8f365
+end
d8f365
diff --git a/libgfortran/io/format.c b/libgfortran/io/format.c
d8f365
index c2abdd7..692b1ff 100644
d8f365
--- a/libgfortran/io/format.c
d8f365
+++ b/libgfortran/io/format.c
d8f365
@@ -956,12 +956,33 @@ parse_format_list (st_parameter_dt *dtp, bool *seen_dd)
d8f365
 	  *seen_dd = true;
d8f365
 	  if (u != FMT_POSINT && u != FMT_ZERO)
d8f365
 	    {
d8f365
+	      if (dtp->common.flags & IOPARM_DT_DEC_EXT)
d8f365
+		{
d8f365
+		  tail->u.real.w = DEFAULT_WIDTH;
d8f365
+		  tail->u.real.d = 0;
d8f365
+		  tail->u.real.e = -1;
d8f365
+		  fmt->saved_token = u;
d8f365
+		  break;
d8f365
+		}
d8f365
 	      fmt->error = nonneg_required;
d8f365
 	      goto finished;
d8f365
 	    }
d8f365
 	}
d8f365
+      else if (u == FMT_ZERO)
d8f365
+	{
d8f365
+	  fmt->error = posint_required;
d8f365
+	  goto finished;
d8f365
+	}
d8f365
       else if (u != FMT_POSINT)
d8f365
 	{
d8f365
+	  if (dtp->common.flags & IOPARM_DT_DEC_EXT)
d8f365
+	    {
d8f365
+	      tail->u.real.w = DEFAULT_WIDTH;
d8f365
+	      tail->u.real.d = 0;
d8f365
+	      tail->u.real.e = -1;
d8f365
+	      fmt->saved_token = u;
d8f365
+	      break;
d8f365
+	    }
d8f365
 	  fmt->error = posint_required;
d8f365
 	  goto finished;
d8f365
 	}
d8f365
@@ -1099,6 +1120,13 @@ parse_format_list (st_parameter_dt *dtp, bool *seen_dd)
d8f365
 	{
d8f365
 	  if (t != FMT_POSINT)
d8f365
 	    {
d8f365
+	      if (dtp->common.flags & IOPARM_DT_DEC_EXT)
d8f365
+		{
d8f365
+		  tail->u.integer.w = DEFAULT_WIDTH;
d8f365
+		  tail->u.integer.m = -1;
d8f365
+		  fmt->saved_token = t;
d8f365
+		  break;
d8f365
+		}
d8f365
 	      fmt->error = posint_required;
d8f365
 	      goto finished;
d8f365
 	    }
d8f365
@@ -1107,6 +1135,13 @@ parse_format_list (st_parameter_dt *dtp, bool *seen_dd)
d8f365
 	{
d8f365
 	  if (t != FMT_ZERO && t != FMT_POSINT)
d8f365
 	    {
d8f365
+	      if (dtp->common.flags & IOPARM_DT_DEC_EXT)
d8f365
+		{
d8f365
+		  tail->u.integer.w = DEFAULT_WIDTH;
d8f365
+		  tail->u.integer.m = -1;
d8f365
+		  fmt->saved_token = t;
d8f365
+		  break;
d8f365
+		}
d8f365
 	      fmt->error = nonneg_required;
d8f365
 	      goto finished;
d8f365
 	    }
d8f365
diff --git a/libgfortran/io/io.h b/libgfortran/io/io.h
d8f365
index 5583183..d1d08e8 100644
d8f365
--- a/libgfortran/io/io.h
d8f365
+++ b/libgfortran/io/io.h
d8f365
@@ -981,5 +981,55 @@ memset4 (gfc_char4_t *p, gfc_char4_t c, int k)
d8f365
     *p++ = c;
d8f365
 }
d8f365
 
d8f365
+/* Used in width fields to indicate that the default should be used */
d8f365
+#define DEFAULT_WIDTH -1
d8f365
+
d8f365
+/* Defaults for certain format field descriptors. These are decided based on
d8f365
+ * the type of the value being formatted.
d8f365
+ *
d8f365
+ * The behaviour here is modelled on the Oracle Fortran compiler. At the time
d8f365
+ * of writing, the details were available at this URL:
d8f365
+ *
d8f365
+ *   https://docs.oracle.com/cd/E19957-01/805-4939/6j4m0vnc3/index.html#z4000743746d
d8f365
+ */
d8f365
+
d8f365
+static inline int
d8f365
+default_width_for_integer (int kind)
d8f365
+{
d8f365
+  switch (kind)
d8f365
+    {
d8f365
+    case 1:
d8f365
+    case 2:  return  7;
d8f365
+    case 4:  return 12;
d8f365
+    case 8:  return 23;
d8f365
+    case 16: return 44;
d8f365
+    default: return  0;
d8f365
+    }
d8f365
+}
d8f365
+
d8f365
+static inline int
d8f365
+default_width_for_float (int kind)
d8f365
+{
d8f365
+  switch (kind)
d8f365
+    {
d8f365
+    case 4:  return 15;
d8f365
+    case 8:  return 25;
d8f365
+    case 16: return 42;
d8f365
+    default: return  0;
d8f365
+    }
d8f365
+}
d8f365
+
d8f365
+static inline int
d8f365
+default_precision_for_float (int kind)
d8f365
+{
d8f365
+  switch (kind)
d8f365
+    {
d8f365
+    case 4:  return 7;
d8f365
+    case 8:  return 16;
d8f365
+    case 16: return 33;
d8f365
+    default: return 0;
d8f365
+    }
d8f365
+}
d8f365
+
d8f365
 #endif
d8f365
 
d8f365
diff --git a/libgfortran/io/read.c b/libgfortran/io/read.c
d8f365
index 2c9de48..e911e35 100644
d8f365
--- a/libgfortran/io/read.c
d8f365
+++ b/libgfortran/io/read.c
d8f365
@@ -629,6 +629,12 @@ read_decimal (st_parameter_dt *dtp, const fnode *f, char *dest, int length)
d8f365
 
d8f365
   w = f->u.w;
d8f365
 
d8f365
+  /* This is a legacy extension, and the frontend will only allow such cases
d8f365
+   * through when -fdec-format-defaults is passed.
d8f365
+   */
d8f365
+  if (w == DEFAULT_WIDTH)
d8f365
+    w = default_width_for_integer (length);
d8f365
+
d8f365
   p = read_block_form (dtp, &w);
d8f365
 
d8f365
   if (p == NULL)
d8f365
diff --git a/libgfortran/io/write.c b/libgfortran/io/write.c
d8f365
index a7307a8..c8e52fb 100644
d8f365
--- a/libgfortran/io/write.c
d8f365
+++ b/libgfortran/io/write.c
d8f365
@@ -684,9 +684,8 @@ write_l (st_parameter_dt *dtp, const fnode *f, char *source, int len)
d8f365
   p[wlen - 1] = (n) ? 'T' : 'F';
d8f365
 }
d8f365
 
d8f365
-
d8f365
 static void
d8f365
-write_boz (st_parameter_dt *dtp, const fnode *f, const char *q, int n)
d8f365
+write_boz (st_parameter_dt *dtp, const fnode *f, const char *q, int n, int len)
d8f365
 {
d8f365
   int w, m, digits, nzero, nblank;
d8f365
   char *p;
d8f365
@@ -719,6 +718,9 @@ write_boz (st_parameter_dt *dtp, const fnode *f, const char *q, int n)
d8f365
   /* Select a width if none was specified.  The idea here is to always
d8f365
      print something.  */
d8f365
 
d8f365
+  if (w == DEFAULT_WIDTH)
d8f365
+    w = default_width_for_integer (len);
d8f365
+
d8f365
   if (w == 0)
d8f365
     w = ((digits < m) ? m : digits);
d8f365
 
d8f365
@@ -845,6 +847,8 @@ write_decimal (st_parameter_dt *dtp, const fnode *f, const char *source,
d8f365
 
d8f365
   /* Select a width if none was specified.  The idea here is to always
d8f365
      print something.  */
d8f365
+  if (w == DEFAULT_WIDTH)
d8f365
+    w = default_width_for_integer (len);
d8f365
 
d8f365
   if (w == 0)
d8f365
     w = ((digits < m) ? m : digits) + nsign;
d8f365
@@ -1187,13 +1191,13 @@ write_b (st_parameter_dt *dtp, const fnode *f, const char *source, int len)
d8f365
   if (len > (int) sizeof (GFC_UINTEGER_LARGEST))
d8f365
     {
d8f365
       p = btoa_big (source, itoa_buf, len, &n);
d8f365
-      write_boz (dtp, f, p, n);
d8f365
+      write_boz (dtp, f, p, n, len);
d8f365
     }
d8f365
   else
d8f365
     {
d8f365
       n = extract_uint (source, len);
d8f365
       p = btoa (n, itoa_buf, sizeof (itoa_buf));
d8f365
-      write_boz (dtp, f, p, n);
d8f365
+      write_boz (dtp, f, p, n, len);
d8f365
     }
d8f365
 }
d8f365
 
d8f365
@@ -1208,13 +1212,13 @@ write_o (st_parameter_dt *dtp, const fnode *f, const char *source, int len)
d8f365
   if (len > (int) sizeof (GFC_UINTEGER_LARGEST))
d8f365
     {
d8f365
       p = otoa_big (source, itoa_buf, len, &n);
d8f365
-      write_boz (dtp, f, p, n);
d8f365
+      write_boz (dtp, f, p, n, len);
d8f365
     }
d8f365
   else
d8f365
     {
d8f365
       n = extract_uint (source, len);
d8f365
       p = otoa (n, itoa_buf, sizeof (itoa_buf));
d8f365
-      write_boz (dtp, f, p, n);
d8f365
+      write_boz (dtp, f, p, n, len);
d8f365
     }
d8f365
 }
d8f365
 
d8f365
@@ -1228,13 +1232,13 @@ write_z (st_parameter_dt *dtp, const fnode *f, const char *source, int len)
d8f365
   if (len > (int) sizeof (GFC_UINTEGER_LARGEST))
d8f365
     {
d8f365
       p = ztoa_big (source, itoa_buf, len, &n);
d8f365
-      write_boz (dtp, f, p, n);
d8f365
+      write_boz (dtp, f, p, n, len);
d8f365
     }
d8f365
   else
d8f365
     {
d8f365
       n = extract_uint (source, len);
d8f365
       p = gfc_xtoa (n, itoa_buf, sizeof (itoa_buf));
d8f365
-      write_boz (dtp, f, p, n);
d8f365
+      write_boz (dtp, f, p, n, len);
d8f365
     }
d8f365
 }
d8f365
 
d8f365
@@ -1504,7 +1508,7 @@ size_from_kind (st_parameter_dt *dtp, const fnode *f, int kind)
d8f365
 {
d8f365
   int size;
d8f365
 
d8f365
-  if (f->format == FMT_F && f->u.real.w == 0)
d8f365
+  if ((f->format == FMT_F && f->u.real.w == 0) || f->u.real.w == DEFAULT_WIDTH)
d8f365
     {
d8f365
       switch (kind)
d8f365
       {
d8f365
diff --git a/libgfortran/io/write_float.def b/libgfortran/io/write_float.def
d8f365
index 7f0aa1d..73dc910 100644
d8f365
--- a/libgfortran/io/write_float.def
d8f365
+++ b/libgfortran/io/write_float.def
d8f365
@@ -113,7 +113,8 @@ determine_precision (st_parameter_dt * d
d8f365
 static void
d8f365
 build_float_string (st_parameter_dt *dtp, const fnode *f, char *buffer,
d8f365
 		    size_t size, int nprinted, int precision, int sign_bit,
d8f365
-		    bool zero_flag, int npad, char *result, size_t *len)
d8f365
+		    bool zero_flag, int npad, int default_width, char *result,
d8f365
+                    size_t *len)
d8f365
 {
d8f365
   char *put;
d8f365
   char *digits;
d8f365
@@ -132,8 +133,17 @@ build_float_string (st_parameter_dt *dtp
d8f365
   sign_t sign;
d8f365
 
d8f365
   ft = f->format;
d8f365
-  w = f->u.real.w;
d8f365
-  d = f->u.real.d;
d8f365
+  if (f->u.real.w == DEFAULT_WIDTH)
d8f365
+    /* This codepath can only be reached with -fdec-format-defaults. */
d8f365
+    {
d8f365
+      w = default_width;
d8f365
+      d = precision;
d8f365
+    }
d8f365
+  else
d8f365
+    {
d8f365
+      w = f->u.real.w;
d8f365
+      d = f->u.real.d;
d8f365
+    }
d8f365
   p = dtp->u.p.scale_factor;
d8f365
   *len = 0;
d8f365
 
d8f365
@@ -959,6 +969,11 @@ determine_en_precision (st_parameter_dt
d8f365
       int save_scale_factor;\
d8f365
       volatile GFC_REAL_ ## x temp;\
d8f365
       save_scale_factor = dtp->u.p.scale_factor;\
d8f365
+      if (w == DEFAULT_WIDTH)\
d8f365
+	{\
d8f365
+	  w = default_width;\
d8f365
+	  d = precision;\
d8f365
+	}\
d8f365
       switch (dtp->u.p.current_unit->round_status)\
d8f365
 	{\
d8f365
 	  case ROUND_ZERO:\
d8f365
@@ -1034,7 +1049,8 @@ determine_en_precision (st_parameter_dt
d8f365
 	  nprinted = FDTOA(y,precision,m);\
d8f365
 	}\
d8f365
       build_float_string (dtp, &newf, buffer, size, nprinted, precision,\
d8f365
-				   sign_bit, zero_flag, npad, result, res_len);\
d8f365
+				   sign_bit, zero_flag, npad, default_width,\
d8f365
+				   result, res_len);\
d8f365
       dtp->u.p.scale_factor = save_scale_factor;\
d8f365
     }\
d8f365
   else\
d8f365
@@ -1044,7 +1060,8 @@ determine_en_precision (st_parameter_dt
d8f365
       else\
d8f365
 	nprinted = DTOA(y,precision,m);\
d8f365
       build_float_string (dtp, f, buffer, size, nprinted, precision,\
d8f365
-				   sign_bit, zero_flag, npad, result, res_len);\
d8f365
+				   sign_bit, zero_flag, npad, default_width,\
d8f365
+				   result, res_len);\
d8f365
     }\
d8f365
 }\
d8f365
 
d8f365
@@ -1058,6 +1075,16 @@ get_float_string (st_parameter_dt *dtp,
d8f365
 {
d8f365
   int sign_bit, nprinted;
d8f365
   bool zero_flag;
d8f365
+  int default_width = 0;
d8f365
+
d8f365
+  if (f->u.real.w == DEFAULT_WIDTH)
d8f365
+    /* This codepath can only be reached with -fdec-format-defaults. The default
d8f365
+     * values are based on those used in the Oracle Fortran compiler.
d8f365
+     */
d8f365
+    {
d8f365
+      default_width = default_width_for_float (kind);
d8f365
+      precision = default_precision_for_float (kind);
d8f365
+    }
d8f365
 
d8f365
   switch (kind)
d8f365
     {