Blame SOURCES/gcc48-rh1469697-22.patch

56d343
diff -Nrup a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
56d343
--- a/gcc/config/i386/i386.c	2018-01-03 16:10:46.278171086 -0700
56d343
+++ b/gcc/config/i386/i386.c	2018-01-03 16:12:32.022220166 -0700
56d343
@@ -9862,14 +9862,13 @@ static void
56d343
 ix86_adjust_stack_and_probe_stack_clash (const HOST_WIDE_INT size)
56d343
 {
56d343
   struct machine_function *m = cfun->machine;
56d343
+  struct ix86_frame frame;
56d343
+  ix86_compute_frame_layout (&frame);
56d343
 
56d343
   /* If this function does not statically allocate stack space, then
56d343
      no probes are needed.  */
56d343
   if (!size)
56d343
     {
56d343
-      struct ix86_frame frame;
56d343
-      ix86_compute_frame_layout (&frame);
56d343
-
56d343
       /* However, the allocation of space via pushes for register
56d343
 	 saves could be viewed as allocating space, but without the
56d343
 	 need to probe.  */
56d343
@@ -9888,21 +9887,40 @@ ix86_adjust_stack_and_probe_stack_clash
56d343
      pointer could be anywhere in the guard page.  The safe thing
56d343
      to do is emit a probe now.
56d343
 
56d343
+     The probe can be avoided if we have already emitted any callee
56d343
+     register saves into the stack or have a frame pointer (which will
56d343
+     have been saved as well).  Those saves will function as implicit
56d343
+     probes.
56d343
+
56d343
      ?!? This should be revamped to work like aarch64 and s390 where
56d343
      we track the offset from the most recent probe.  Normally that
56d343
      offset would be zero.  For a non-return function we would reset
56d343
      it to PROBE_INTERVAL - (STACK_BOUNDARY / BITS_PER_UNIT).   Then
56d343
      we just probe when we cross PROBE_INTERVAL.  */
56d343
-  if (TREE_THIS_VOLATILE (cfun->decl))
56d343
+  if (TREE_THIS_VOLATILE (cfun->decl)
56d343
+      && !(frame.nregs || frame.nsseregs || frame_pointer_needed))
56d343
+
56d343
     {
56d343
       /* We can safely use any register here since we're just going to push
56d343
 	 its value and immediately pop it back.  But we do try and avoid
56d343
 	 argument passing registers so as not to introduce dependencies in
56d343
 	 the pipeline.  For 32 bit we use %esi and for 64 bit we use %rax.  */
56d343
       rtx dummy_reg = gen_rtx_REG (word_mode, TARGET_64BIT ? AX_REG : SI_REG);
56d343
-      rtx insn = emit_insn (gen_push (dummy_reg));
56d343
-      RTX_FRAME_RELATED_P (insn) = 1;
56d343
-      ix86_emit_restore_reg_using_pop (dummy_reg);
56d343
+      rtx insn_push = emit_insn (gen_push (dummy_reg));
56d343
+      rtx insn_pop = emit_insn (gen_pop (dummy_reg));
56d343
+      m->fs.sp_offset -= UNITS_PER_WORD;
56d343
+      if (m->fs.cfa_reg == stack_pointer_rtx)
56d343
+	{
56d343
+	  m->fs.cfa_offset -= UNITS_PER_WORD;
56d343
+	  rtx x = plus_constant (Pmode, stack_pointer_rtx, -UNITS_PER_WORD);
56d343
+	  x = gen_rtx_SET (VOIDmode, stack_pointer_rtx, x);
56d343
+	  add_reg_note (insn_push, REG_CFA_ADJUST_CFA, x);
56d343
+	  RTX_FRAME_RELATED_P (insn_push) = 1;
56d343
+	  x = plus_constant (Pmode, stack_pointer_rtx, UNITS_PER_WORD);
56d343
+	  x = gen_rtx_SET (VOIDmode, stack_pointer_rtx, x);
56d343
+	  add_reg_note (insn_pop, REG_CFA_ADJUST_CFA, x);
56d343
+	  RTX_FRAME_RELATED_P (insn_pop) = 1;
56d343
+	}
56d343
       emit_insn (gen_blockage ());
56d343
     }
56d343
 
56d343
 
56d343
diff -Nrup a/gcc-4.8.5-20150702/gcc/testsuite/gcc.target/i386/stack-check-12.c b/gcc-4.8.5-20150702/gcc/testsuite/gcc.target/i386/stack-check-12.c
56d343
--- gcc-4.8.5-20150702/gcc/testsuite/gcc.target/i386/stack-check-12.c	2018-01-03 15:42:40.849530670 -0700
56d343
+++ gcc-4.8.5-20150702/gcc/testsuite/gcc.target/i386/stack-check-12.c	2018-01-03 15:36:12.528488596 -0700
56d343
@@ -7,7 +7,6 @@ __attribute__ ((noreturn)) void exit (in
56d343
 __attribute__ ((noreturn)) void
56d343
 f (void)
56d343
 {
56d343
-  asm volatile ("nop" ::: "edi");
56d343
   exit (1);
56d343
 }
56d343
 
56d343
diff -Nrup a/gcc-4.8.5-20150702/gcc/testsuite/gcc.target/i386/stack-check-17.c b/gcc-4.8.5-20150702/gcc/testsuite/gcc.target/i386/stack-check-17.c
56d343
--- gcc-4.8.5-20150702/gcc/testsuite/gcc.target/i386/stack-check-17.c	1969-12-31 17:00:00.000000000 -0700
56d343
+++ gcc-4.8.5-20150702/gcc/testsuite/gcc.target/i386/stack-check-17.c	2018-01-03 15:36:12.528488596 -0700
56d343
@@ -0,0 +1,37 @@
56d343
+/* { dg-do compile } */
56d343
+/* { dg-options "-O2 -fstack-clash-protection -mtune=generic -fomit-frame-pointer" } */
56d343
+/* { dg-require-effective-target supports_stack_clash_protection } */
56d343
+
56d343
+
56d343
+int x0, x1;
56d343
+void f1 (void);
56d343
+void f2 (int, int);
56d343
+
56d343
+__attribute__ ((noreturn))
56d343
+void
56d343
+f3 (void)
56d343
+{ 
56d343
+  int y0 = x0;
56d343
+  int y1 = x1;
56d343
+  f1 ();
56d343
+  f2 (y0, y1);
56d343
+  while (1);
56d343
+}
56d343
+
56d343
+/* Verify no explicit probes.  */
56d343
+/* { dg-final { scan-assembler-not "or\[ql\]" } } */
56d343
+
56d343
+/* We also want to verify we did not use a push/pop sequence
56d343
+   to probe *sp as the callee register saves are sufficient
56d343
+   to probe *sp.
56d343
+
56d343
+   y0/y1 are live across the call and thus must be allocated
56d343
+   into either a stack slot or callee saved register.  The former
56d343
+   would be rather dumb.  So assume it does not happen.
56d343
+
56d343
+   So search for two/four pushes for the callee register saves/argument
56d343
+   pushes and no pops (since the function has no reachable epilogue).  */
56d343
+/* { dg-final { scan-assembler-times "push\[ql\]" 2 { target { ! ia32 } } } }  */
56d343
+/* { dg-final { scan-assembler-times "push\[ql\]" 4 { target { ia32 } } } }  */
56d343
+/* { dg-final { scan-assembler-not "pop" } } */
56d343
+