Blame SOURCES/gcc48-rh1469697-22.patch

13f101
diff -Nrup a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
13f101
--- a/gcc/config/i386/i386.c	2018-01-03 16:10:46.278171086 -0700
13f101
+++ b/gcc/config/i386/i386.c	2018-01-03 16:12:32.022220166 -0700
13f101
@@ -9862,14 +9862,13 @@ static void
13f101
 ix86_adjust_stack_and_probe_stack_clash (const HOST_WIDE_INT size)
13f101
 {
13f101
   struct machine_function *m = cfun->machine;
13f101
+  struct ix86_frame frame;
13f101
+  ix86_compute_frame_layout (&frame);
13f101
 
13f101
   /* If this function does not statically allocate stack space, then
13f101
      no probes are needed.  */
13f101
   if (!size)
13f101
     {
13f101
-      struct ix86_frame frame;
13f101
-      ix86_compute_frame_layout (&frame);
13f101
-
13f101
       /* However, the allocation of space via pushes for register
13f101
 	 saves could be viewed as allocating space, but without the
13f101
 	 need to probe.  */
13f101
@@ -9888,21 +9887,40 @@ ix86_adjust_stack_and_probe_stack_clash
13f101
      pointer could be anywhere in the guard page.  The safe thing
13f101
      to do is emit a probe now.
13f101
 
13f101
+     The probe can be avoided if we have already emitted any callee
13f101
+     register saves into the stack or have a frame pointer (which will
13f101
+     have been saved as well).  Those saves will function as implicit
13f101
+     probes.
13f101
+
13f101
      ?!? This should be revamped to work like aarch64 and s390 where
13f101
      we track the offset from the most recent probe.  Normally that
13f101
      offset would be zero.  For a non-return function we would reset
13f101
      it to PROBE_INTERVAL - (STACK_BOUNDARY / BITS_PER_UNIT).   Then
13f101
      we just probe when we cross PROBE_INTERVAL.  */
13f101
-  if (TREE_THIS_VOLATILE (cfun->decl))
13f101
+  if (TREE_THIS_VOLATILE (cfun->decl)
13f101
+      && !(frame.nregs || frame.nsseregs || frame_pointer_needed))
13f101
+
13f101
     {
13f101
       /* We can safely use any register here since we're just going to push
13f101
 	 its value and immediately pop it back.  But we do try and avoid
13f101
 	 argument passing registers so as not to introduce dependencies in
13f101
 	 the pipeline.  For 32 bit we use %esi and for 64 bit we use %rax.  */
13f101
       rtx dummy_reg = gen_rtx_REG (word_mode, TARGET_64BIT ? AX_REG : SI_REG);
13f101
-      rtx insn = emit_insn (gen_push (dummy_reg));
13f101
-      RTX_FRAME_RELATED_P (insn) = 1;
13f101
-      ix86_emit_restore_reg_using_pop (dummy_reg);
13f101
+      rtx insn_push = emit_insn (gen_push (dummy_reg));
13f101
+      rtx insn_pop = emit_insn (gen_pop (dummy_reg));
13f101
+      m->fs.sp_offset -= UNITS_PER_WORD;
13f101
+      if (m->fs.cfa_reg == stack_pointer_rtx)
13f101
+	{
13f101
+	  m->fs.cfa_offset -= UNITS_PER_WORD;
13f101
+	  rtx x = plus_constant (Pmode, stack_pointer_rtx, -UNITS_PER_WORD);
13f101
+	  x = gen_rtx_SET (VOIDmode, stack_pointer_rtx, x);
13f101
+	  add_reg_note (insn_push, REG_CFA_ADJUST_CFA, x);
13f101
+	  RTX_FRAME_RELATED_P (insn_push) = 1;
13f101
+	  x = plus_constant (Pmode, stack_pointer_rtx, UNITS_PER_WORD);
13f101
+	  x = gen_rtx_SET (VOIDmode, stack_pointer_rtx, x);
13f101
+	  add_reg_note (insn_pop, REG_CFA_ADJUST_CFA, x);
13f101
+	  RTX_FRAME_RELATED_P (insn_pop) = 1;
13f101
+	}
13f101
       emit_insn (gen_blockage ());
13f101
     }
13f101
 
13f101
 
13f101
diff -Nrup a/gcc-4.8.5-20150702/gcc/testsuite/gcc.target/i386/stack-check-12.c b/gcc-4.8.5-20150702/gcc/testsuite/gcc.target/i386/stack-check-12.c
13f101
--- gcc-4.8.5-20150702/gcc/testsuite/gcc.target/i386/stack-check-12.c	2018-01-03 15:42:40.849530670 -0700
13f101
+++ gcc-4.8.5-20150702/gcc/testsuite/gcc.target/i386/stack-check-12.c	2018-01-03 15:36:12.528488596 -0700
13f101
@@ -7,7 +7,6 @@ __attribute__ ((noreturn)) void exit (in
13f101
 __attribute__ ((noreturn)) void
13f101
 f (void)
13f101
 {
13f101
-  asm volatile ("nop" ::: "edi");
13f101
   exit (1);
13f101
 }
13f101
 
13f101
diff -Nrup a/gcc-4.8.5-20150702/gcc/testsuite/gcc.target/i386/stack-check-17.c b/gcc-4.8.5-20150702/gcc/testsuite/gcc.target/i386/stack-check-17.c
13f101
--- gcc-4.8.5-20150702/gcc/testsuite/gcc.target/i386/stack-check-17.c	1969-12-31 17:00:00.000000000 -0700
13f101
+++ gcc-4.8.5-20150702/gcc/testsuite/gcc.target/i386/stack-check-17.c	2018-01-03 15:36:12.528488596 -0700
13f101
@@ -0,0 +1,37 @@
13f101
+/* { dg-do compile } */
13f101
+/* { dg-options "-O2 -fstack-clash-protection -mtune=generic -fomit-frame-pointer" } */
13f101
+/* { dg-require-effective-target supports_stack_clash_protection } */
13f101
+
13f101
+
13f101
+int x0, x1;
13f101
+void f1 (void);
13f101
+void f2 (int, int);
13f101
+
13f101
+__attribute__ ((noreturn))
13f101
+void
13f101
+f3 (void)
13f101
+{ 
13f101
+  int y0 = x0;
13f101
+  int y1 = x1;
13f101
+  f1 ();
13f101
+  f2 (y0, y1);
13f101
+  while (1);
13f101
+}
13f101
+
13f101
+/* Verify no explicit probes.  */
13f101
+/* { dg-final { scan-assembler-not "or\[ql\]" } } */
13f101
+
13f101
+/* We also want to verify we did not use a push/pop sequence
13f101
+   to probe *sp as the callee register saves are sufficient
13f101
+   to probe *sp.
13f101
+
13f101
+   y0/y1 are live across the call and thus must be allocated
13f101
+   into either a stack slot or callee saved register.  The former
13f101
+   would be rather dumb.  So assume it does not happen.
13f101
+
13f101
+   So search for two/four pushes for the callee register saves/argument
13f101
+   pushes and no pops (since the function has no reachable epilogue).  */
13f101
+/* { dg-final { scan-assembler-times "push\[ql\]" 2 { target { ! ia32 } } } }  */
13f101
+/* { dg-final { scan-assembler-times "push\[ql\]" 4 { target { ia32 } } } }  */
13f101
+/* { dg-final { scan-assembler-not "pop" } } */
13f101
+