Blame SOURCES/gdb-runtest-pie-override.patch

6240d7
From FEDORA_PATCHES Mon Sep 17 00:00:00 2001
6240d7
From: Fedora GDB patches <invalid@email.com>
6240d7
Date: Fri, 27 Oct 2017 21:07:50 +0200
6240d7
Subject: gdb-runtest-pie-override.patch
6240d7
6240d7
;; Hack for proper PIE run of the testsuite.
6240d7
;;=fedoratest
6240d7
6240d7
make check//unix/-fPIE/-pie RUNTESTFLAGS=solib-display.exp
6240d7
6240d7
gcc -fpic -c  -fPIE -pie -o x.o x.c
6240d7
/usr/lib/gcc/x86_64-redhat-linux/4.6.1/../../../../lib64/Scrt1.o: In function `_start':
6240d7
(.text+0x20): undefined reference to `main'
6240d7
6240d7
=> Change the order for overrides.
6240d7
6240d7
One has to also use -fPIC rather than -fPIE, -fPIC is stronger.
6240d7
6240d7
The correct way would be:
6240d7
make check//unix RUNTESTFLAGS='CC_FOR_TARGET=gcc\ -fPIC\ -pie CXX_FOR_TARGET=g++\ -fPIC\ -pie solib-display.exp'
6240d7
6240d7
But there is a problem with testsuite.unix non-unique subdir name and also
6240d7
a problem with make -j parallelization of the testsuite.
6240d7
6240d7
diff --git a/gdb/testsuite/lib/future.exp b/gdb/testsuite/lib/future.exp
6240d7
--- a/gdb/testsuite/lib/future.exp
6240d7
+++ b/gdb/testsuite/lib/future.exp
6240d7
@@ -185,6 +185,10 @@ proc gdb_default_target_compile {source destfile type options} {
6240d7
     set ldflags ""
6240d7
     set dest [target_info name]
6240d7
 
6240d7
+    if {[board_info $dest exists multilib_flags]} {
6240d7
+	append add_flags " [board_info $dest multilib_flags]"
6240d7
+    }
6240d7
+
6240d7
     if {[info exists CFLAGS_FOR_TARGET]} {
6240d7
 	append add_flags " $CFLAGS_FOR_TARGET"
6240d7
     }
6240d7
@@ -519,10 +523,6 @@ proc gdb_default_target_compile {source destfile type options} {
6240d7
 	}
6240d7
     }
6240d7
 
6240d7
-    if {[board_info $dest exists multilib_flags]} {
6240d7
-	append add_flags " [board_info $dest multilib_flags]"
6240d7
-    }
6240d7
-
6240d7
     verbose "doing compile"
6240d7
 
6240d7
     set sources ""