Blame SOURCES/gdb-6.6-buildid-locate-rpm-scl.patch

2f9ed3
From FEDORA_PATCHES Mon Sep 17 00:00:00 2001
2f9ed3
From: Fedora GDB patches <invalid@email.com>
2f9ed3
Date: Fri, 27 Oct 2017 21:07:50 +0200
2f9ed3
Subject: gdb-6.6-buildid-locate-rpm-scl.patch
2f9ed3
2f9ed3
;; [SCL] Skip deprecated .gdb_index warning for Red Hat built files (BZ 953585).
2f9ed3
;;=push+jan
2f9ed3
2f9ed3
warning: Skipping deprecated .gdb_index section
2f9ed3
https://bugzilla.redhat.com/show_bug.cgi?id=953585
2f9ed3
2f9ed3
diff --git a/gdb/build-id.c b/gdb/build-id.c
2f9ed3
--- a/gdb/build-id.c
2f9ed3
+++ b/gdb/build-id.c
2f9ed3
@@ -746,7 +746,11 @@ static int missing_rpm_list_entries;
2f9ed3
 /* Returns the count of newly added rpms.  */
2f9ed3
 
2f9ed3
 static int
2f9ed3
+#ifndef GDB_INDEX_VERIFY_VENDOR
2f9ed3
 missing_rpm_enlist (const char *filename)
2f9ed3
+#else
2f9ed3
+missing_rpm_enlist_1 (const char *filename, int verify_vendor)
2f9ed3
+#endif
2f9ed3
 {
2f9ed3
   static int rpm_init_done = 0;
2f9ed3
   rpmts ts;
2f9ed3
@@ -853,7 +857,11 @@ missing_rpm_enlist (const char *filename)
2f9ed3
   mi = rpmtsInitIterator_p (ts, RPMTAG_BASENAMES, filename, 0);
2f9ed3
   if (mi != NULL)
2f9ed3
     {
2f9ed3
+#ifndef GDB_INDEX_VERIFY_VENDOR
2f9ed3
       for (;;)
2f9ed3
+#else
2f9ed3
+      if (!verify_vendor) for (;;)
2f9ed3
+#endif
2f9ed3
 	{
2f9ed3
 	  Header h;
2f9ed3
 	  char *debuginfo, **slot, *s, *s2;
2f9ed3
@@ -971,6 +979,37 @@ missing_rpm_enlist (const char *filename)
2f9ed3
 	    xfree (debuginfo);
2f9ed3
 	  count++;
2f9ed3
 	}
2f9ed3
+#ifdef GDB_INDEX_VERIFY_VENDOR
2f9ed3
+      else /* verify_vendor */
2f9ed3
+	{
2f9ed3
+	  int vendor_pass = 0, vendor_fail = 0;
2f9ed3
+
2f9ed3
+	  for (;;)
2f9ed3
+	    {
2f9ed3
+	      Header h;
2f9ed3
+	      errmsg_t err;
2f9ed3
+	      char *vendor;
2f9ed3
+
2f9ed3
+	      h = rpmdbNextIterator_p (mi);
2f9ed3
+	      if (h == NULL)
2f9ed3
+		break;
2f9ed3
+
2f9ed3
+	      vendor = headerFormat_p (h, "%{vendor}", &err;;
2f9ed3
+	      if (!vendor)
2f9ed3
+		{
2f9ed3
+		  warning (_("Error querying the rpm file `%s': %s"), filename,
2f9ed3
+			   err);
2f9ed3
+		  continue;
2f9ed3
+		}
2f9ed3
+	      if (strcmp (vendor, "Red Hat, Inc.") == 0)
2f9ed3
+		vendor_pass = 1;
2f9ed3
+	      else
2f9ed3
+		vendor_fail = 1;
2f9ed3
+	      xfree (vendor);
2f9ed3
+	    }
2f9ed3
+	  count = vendor_pass != 0 && vendor_fail == 0;
2f9ed3
+	}
2f9ed3
+#endif
2f9ed3
 
2f9ed3
       rpmdbFreeIterator_p (mi);
2f9ed3
     }
2f9ed3
@@ -981,6 +1020,21 @@ missing_rpm_enlist (const char *filename)
2f9ed3
 }
2f9ed3
 
2f9ed3
 static int
2f9ed3
+#ifdef GDB_INDEX_VERIFY_VENDOR
2f9ed3
+missing_rpm_enlist (const char *filename)
2f9ed3
+{
2f9ed3
+  return missing_rpm_enlist_1 (filename, 0);
2f9ed3
+}
2f9ed3
+
2f9ed3
+extern int rpm_verify_vendor (const char *filename);
2f9ed3
+int
2f9ed3
+rpm_verify_vendor (const char *filename)
2f9ed3
+{
2f9ed3
+  return missing_rpm_enlist_1 (filename, 1);
2f9ed3
+}
2f9ed3
+
2f9ed3
+static int
2f9ed3
+#endif
2f9ed3
 missing_rpm_list_compar (const char *const *ap, const char *const *bp)
2f9ed3
 {
2f9ed3
   return strcoll (*ap, *bp);
2f9ed3
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
2f9ed3
--- a/gdb/dwarf2read.c
2f9ed3
+++ b/gdb/dwarf2read.c
2f9ed3
@@ -3501,6 +3501,16 @@ read_gdb_index_from_buffer (struct objfile *objfile,
2f9ed3
      "set use-deprecated-index-sections on".  */
2f9ed3
   if (version < 6 && !deprecated_ok)
2f9ed3
     {
2f9ed3
+#ifdef GDB_INDEX_VERIFY_VENDOR
2f9ed3
+      extern int rpm_verify_vendor (const char *filename);
2f9ed3
+
2f9ed3
+      /* Red Hat Developer Toolset exception.  */
2f9ed3
+      if (rpm_verify_vendor (filename))
2f9ed3
+	{}
2f9ed3
+      else
2f9ed3
+      {
2f9ed3
+
2f9ed3
+#endif
2f9ed3
       static int warning_printed = 0;
2f9ed3
       if (!warning_printed)
2f9ed3
 	{
2f9ed3
@@ -3512,6 +3522,10 @@ to use the section anyway."),
2f9ed3
 	  warning_printed = 1;
2f9ed3
 	}
2f9ed3
       return 0;
2f9ed3
+#ifdef GDB_INDEX_VERIFY_VENDOR
2f9ed3
+
2f9ed3
+      }
2f9ed3
+#endif
2f9ed3
     }
2f9ed3
   /* Version 7 indices generated by gold refer to the CU for a symbol instead
2f9ed3
      of the TU (for symbols coming from TUs),