|
 |
5af789 |
commit f326d68d762edf4b0e9604daa446b6f8ca25725a
|
|
|
5af789 |
Author: Mark Wielaard <mark@klomp.org>
|
|
|
5af789 |
Date: Sun Jul 26 22:40:22 2020 +0200
|
|
|
5af789 |
|
|
|
5af789 |
epoll_ctl warns for uninitialized padding on non-amd64 64bit arches
|
|
|
5af789 |
|
|
|
5af789 |
struct vki_epoll_event is packed on x86_64, but not on other 64bit
|
|
|
5af789 |
arches. This means that on 64bit arches there can be padding in the
|
|
|
5af789 |
epoll_event struct. Seperately the data field is only used by user
|
|
|
5af789 |
space (which might not set the data field if it doesn't need to).
|
|
|
5af789 |
|
|
|
5af789 |
Only check the events field on epoll_ctl. But assume both events
|
|
|
5af789 |
and data are both written to by epoll_[p]wait (exclude padding).
|
|
|
5af789 |
|
|
|
5af789 |
https://bugs.kde.org/show_bug.cgi?id=422623
|
|
|
5af789 |
|
|
|
5af789 |
diff --git a/coregrind/m_syswrap/syswrap-linux.c b/coregrind/m_syswrap/syswrap-linux.c
|
|
|
5af789 |
index 5b5b7eee6..929a4d9af 100644
|
|
|
5af789 |
--- a/coregrind/m_syswrap/syswrap-linux.c
|
|
|
5af789 |
+++ b/coregrind/m_syswrap/syswrap-linux.c
|
|
|
5af789 |
@@ -2099,8 +2099,29 @@ PRE(sys_epoll_ctl)
|
|
|
5af789 |
SARG1, ( ARG2<3 ? epoll_ctl_s[ARG2] : "?" ), SARG3, ARG4);
|
|
|
5af789 |
PRE_REG_READ4(long, "epoll_ctl",
|
|
|
5af789 |
int, epfd, int, op, int, fd, struct vki_epoll_event *, event);
|
|
|
5af789 |
- if (ARG2 != VKI_EPOLL_CTL_DEL)
|
|
|
5af789 |
- PRE_MEM_READ( "epoll_ctl(event)", ARG4, sizeof(struct vki_epoll_event) );
|
|
|
5af789 |
+ if (ARG2 != VKI_EPOLL_CTL_DEL) {
|
|
|
5af789 |
+ /* Just check the events field, the data field is for user space and
|
|
|
5af789 |
+ unused by the kernel. */
|
|
|
5af789 |
+ struct vki_epoll_event *event = (struct vki_epoll_event *) ARG4;
|
|
|
5af789 |
+ PRE_MEM_READ( "epoll_ctl(event)", (Addr) &event->events,
|
|
|
5af789 |
+ sizeof(__vki_u32) );
|
|
|
5af789 |
+ }
|
|
|
5af789 |
+}
|
|
|
5af789 |
+
|
|
|
5af789 |
+/* RES event records have been written (exclude padding). */
|
|
|
5af789 |
+static void epoll_post_helper ( ThreadId tid, SyscallArgs* arrghs,
|
|
|
5af789 |
+ SyscallStatus* status )
|
|
|
5af789 |
+{
|
|
|
5af789 |
+ vg_assert(SUCCESS);
|
|
|
5af789 |
+ if (RES > 0) {
|
|
|
5af789 |
+ Int i;
|
|
|
5af789 |
+ struct vki_epoll_event **events = (struct vki_epoll_event**)(Addr)ARG2;
|
|
|
5af789 |
+ for (i = 0; i < RES; i++) {
|
|
|
5af789 |
+ /* Assume both events and data are set (data is user space only). */
|
|
|
5af789 |
+ POST_FIELD_WRITE(events[i]->events);
|
|
|
5af789 |
+ POST_FIELD_WRITE(events[i]->data);
|
|
|
5af789 |
+ }
|
|
|
5af789 |
+ }
|
|
|
5af789 |
}
|
|
|
5af789 |
|
|
|
5af789 |
PRE(sys_epoll_wait)
|
|
|
5af789 |
@@ -2111,13 +2132,12 @@ PRE(sys_epoll_wait)
|
|
|
5af789 |
PRE_REG_READ4(long, "epoll_wait",
|
|
|
5af789 |
int, epfd, struct vki_epoll_event *, events,
|
|
|
5af789 |
int, maxevents, int, timeout);
|
|
|
5af789 |
+ /* Assume all (maxevents) events records should be (fully) writable. */
|
|
|
5af789 |
PRE_MEM_WRITE( "epoll_wait(events)", ARG2, sizeof(struct vki_epoll_event)*ARG3);
|
|
|
5af789 |
}
|
|
|
5af789 |
POST(sys_epoll_wait)
|
|
|
5af789 |
{
|
|
|
5af789 |
- vg_assert(SUCCESS);
|
|
|
5af789 |
- if (RES > 0)
|
|
|
5af789 |
- POST_MEM_WRITE( ARG2, sizeof(struct vki_epoll_event)*RES ) ;
|
|
|
5af789 |
+ epoll_post_helper (tid, arrghs, status);
|
|
|
5af789 |
}
|
|
|
5af789 |
|
|
|
5af789 |
PRE(sys_epoll_pwait)
|
|
|
5af789 |
@@ -2130,15 +2150,14 @@ PRE(sys_epoll_pwait)
|
|
|
5af789 |
int, epfd, struct vki_epoll_event *, events,
|
|
|
5af789 |
int, maxevents, int, timeout, vki_sigset_t *, sigmask,
|
|
|
5af789 |
vki_size_t, sigsetsize);
|
|
|
5af789 |
+ /* Assume all (maxevents) events records should be (fully) writable. */
|
|
|
5af789 |
PRE_MEM_WRITE( "epoll_pwait(events)", ARG2, sizeof(struct vki_epoll_event)*ARG3);
|
|
|
5af789 |
if (ARG5)
|
|
|
5af789 |
PRE_MEM_READ( "epoll_pwait(sigmask)", ARG5, sizeof(vki_sigset_t) );
|
|
|
5af789 |
}
|
|
|
5af789 |
POST(sys_epoll_pwait)
|
|
|
5af789 |
{
|
|
|
5af789 |
- vg_assert(SUCCESS);
|
|
|
5af789 |
- if (RES > 0)
|
|
|
5af789 |
- POST_MEM_WRITE( ARG2, sizeof(struct vki_epoll_event)*RES ) ;
|
|
|
5af789 |
+ epoll_post_helper (tid, arrghs, status);
|
|
|
5af789 |
}
|
|
|
5af789 |
|
|
|
5af789 |
PRE(sys_eventfd)
|
|
|
5af789 |
commit b74f9f23c8758c77367f18368ea95baa858544cb
|
|
|
5af789 |
Author: Mark Wielaard <mark@klomp.org>
|
|
|
5af789 |
Date: Tue Aug 18 23:58:55 2020 +0200
|
|
|
5af789 |
|
|
|
5af789 |
Fix epoll_ctl setting of array event and data fields.
|
|
|
5af789 |
|
|
|
5af789 |
Fix for https://bugs.kde.org/show_bug.cgi?id=422623 in commit ecf5ba119
|
|
|
5af789 |
epoll_ctl warns for uninitialized padding on non-amd64 64bit arches
|
|
|
5af789 |
contained a bug. A pointer to an array is not a pointer to a pointer to
|
|
|
5af789 |
an array. Found by a Fedora user:
|
|
|
5af789 |
https://bugzilla.redhat.com/show_bug.cgi?id=1844778#c10
|
|
|
5af789 |
|
|
|
5af789 |
diff --git a/coregrind/m_syswrap/syswrap-linux.c b/coregrind/m_syswrap/syswrap-linux.c
|
|
|
5af789 |
index 0850487e9..3f488795a 100644
|
|
|
5af789 |
--- a/coregrind/m_syswrap/syswrap-linux.c
|
|
|
5af789 |
+++ b/coregrind/m_syswrap/syswrap-linux.c
|
|
|
5af789 |
@@ -2115,11 +2115,11 @@ static void epoll_post_helper ( ThreadId tid, SyscallArgs* arrghs,
|
|
|
5af789 |
vg_assert(SUCCESS);
|
|
|
5af789 |
if (RES > 0) {
|
|
|
5af789 |
Int i;
|
|
|
5af789 |
- struct vki_epoll_event **events = (struct vki_epoll_event**)(Addr)ARG2;
|
|
|
5af789 |
+ struct vki_epoll_event *events = (struct vki_epoll_event*)(Addr)ARG2;
|
|
|
5af789 |
for (i = 0; i < RES; i++) {
|
|
|
5af789 |
/* Assume both events and data are set (data is user space only). */
|
|
|
5af789 |
- POST_FIELD_WRITE(events[i]->events);
|
|
|
5af789 |
- POST_FIELD_WRITE(events[i]->data);
|
|
|
5af789 |
+ POST_FIELD_WRITE(events[i].events);
|
|
|
5af789 |
+ POST_FIELD_WRITE(events[i].data);
|
|
|
5af789 |
}
|
|
|
5af789 |
}
|
|
|
5af789 |
}
|