Blame SOURCES/gdb-rhbz1350436-type-printers-error.patch

5ad05e
From FEDORA_PATCHES Mon Sep 17 00:00:00 2001
5ad05e
From: Fedora GDB patches <invalid@email.com>
5ad05e
Date: Fri, 27 Oct 2017 21:07:50 +0200
5ad05e
Subject: gdb-rhbz1350436-type-printers-error.patch
5ad05e
5ad05e
;; Test 'info type-printers' Python error (RH BZ 1350436).
5ad05e
;;=fedoratest
5ad05e
5ad05e
Typo in Python support breaks info type-printers command
5ad05e
https://bugzilla.redhat.com/show_bug.cgi?id=1350436
5ad05e
5ad05e
[testsuite patch] PR python/17136: 'info type-printers' causes an exception when there are per-objfile printers
5ad05e
https://sourceware.org/ml/gdb-patches/2016-06/msg00455.html
5ad05e
5ad05e
diff --git a/gdb/testsuite/gdb.python/py-typeprint.cc b/gdb/testsuite/gdb.python/py-typeprint.cc
5ad05e
--- a/gdb/testsuite/gdb.python/py-typeprint.cc
5ad05e
+++ b/gdb/testsuite/gdb.python/py-typeprint.cc
5ad05e
@@ -31,6 +31,12 @@ templ<basic_string> s;
5ad05e
 
5ad05e
 basic_string bs;
5ad05e
 
5ad05e
+class Other
5ad05e
+{
5ad05e
+};
5ad05e
+
5ad05e
+Other ovar;
5ad05e
+
5ad05e
 int main()
5ad05e
 {
5ad05e
   return 0;
5ad05e
diff --git a/gdb/testsuite/gdb.python/py-typeprint.exp b/gdb/testsuite/gdb.python/py-typeprint.exp
5ad05e
--- a/gdb/testsuite/gdb.python/py-typeprint.exp
5ad05e
+++ b/gdb/testsuite/gdb.python/py-typeprint.exp
5ad05e
@@ -50,3 +50,7 @@ gdb_test_no_output "enable type-printer string"
5ad05e
 gdb_test "whatis bs" "string" "whatis with enabled printer"
5ad05e
 
5ad05e
 gdb_test "whatis s" "templ<string>"
5ad05e
+
5ad05e
+gdb_test "info type-printers" "Type printers for \[^\r\n\]*/py-typeprint:\r\n *other\r\n.*" \
5ad05e
+	 "info type-printers for other"
5ad05e
+gdb_test "whatis ovar" "type = Another"
5ad05e
diff --git a/gdb/testsuite/gdb.python/py-typeprint.py b/gdb/testsuite/gdb.python/py-typeprint.py
5ad05e
--- a/gdb/testsuite/gdb.python/py-typeprint.py
5ad05e
+++ b/gdb/testsuite/gdb.python/py-typeprint.py
5ad05e
@@ -15,7 +15,7 @@
5ad05e
 
5ad05e
 import gdb
5ad05e
 
5ad05e
-class Recognizer(object):
5ad05e
+class StringRecognizer(object):
5ad05e
     def __init__(self):
5ad05e
         self.enabled = True
5ad05e
 
5ad05e
@@ -30,6 +30,26 @@ class StringTypePrinter(object):
5ad05e
         self.enabled = True
5ad05e
 
5ad05e
     def instantiate(self):
5ad05e
-        return Recognizer()
5ad05e
+        return StringRecognizer()
5ad05e
 
5ad05e
 gdb.type_printers.append(StringTypePrinter())
5ad05e
+
5ad05e
+class OtherRecognizer(object):
5ad05e
+    def __init__(self):
5ad05e
+        self.enabled = True
5ad05e
+
5ad05e
+    def recognize(self, type_obj):
5ad05e
+        if type_obj.tag == 'Other':
5ad05e
+            return 'Another'
5ad05e
+        return None
5ad05e
+
5ad05e
+class OtherTypePrinter(object):
5ad05e
+    def __init__(self):
5ad05e
+        self.name = 'other'
5ad05e
+        self.enabled = True
5ad05e
+
5ad05e
+    def instantiate(self):
5ad05e
+        return OtherRecognizer()
5ad05e
+
5ad05e
+import gdb.types
5ad05e
+gdb.types.register_type_printer(gdb.objfiles()[0], OtherTypePrinter())