Blame SOURCES/gdb-6.7-testsuite-stable-results.patch

5ad05e
From FEDORA_PATCHES Mon Sep 17 00:00:00 2001
5ad05e
From: Jan Kratochvil <jan.kratochvil@redhat.com>
5ad05e
Date: Fri, 27 Oct 2017 21:07:50 +0200
5ad05e
Subject: gdb-6.7-testsuite-stable-results.patch
5ad05e
5ad05e
;; Testsuite fixes for more stable/comparable results.
5ad05e
;;=fedoratest
5ad05e
5ad05e
gdb/testsuite/gdb.base/fileio.c:
5ad05e
gdb/testsuite/gdb.base/fileio.exp:
5ad05e
2007-12-08  Jan Kratochvil  <jan.kratochvil@redhat.com>
5ad05e
5ad05e
	* gdb.base/fileio.c (ROOTSUBDIR): New macro.
5ad05e
	(main): CHDIR into ROOTSUBDIR.  CHOWN ROOTSUBDIR and CHDIR into
5ad05e
	ROOTSUBDIR if we are being run as root.
5ad05e
	* gdb.base/fileio.exp: Change the startup and finish cleanup.
5ad05e
	Change the test file reference to be into the `fileio.dir' directory.
5ad05e
5ad05e
sources/gdb/testsuite/gdb.base/dump.exp:
5ad05e
Found on RHEL-5.s390x.
5ad05e
5ad05e
gdb-6.8.50.20090209/gdb/testsuite/gdb.base/auxv.exp:
5ad05e
random FAIL: gdb.base/auxv.exp: matching auxv data from live and gcore
5ad05e
5ad05e
gdb-6.8.50.20090209/gdb/testsuite/gdb.base/annota1.exp:
5ad05e
frames-invalid can happen asynchronously.
5ad05e
5ad05e
diff --git a/gdb/testsuite/gdb.base/fileio.c b/gdb/testsuite/gdb.base/fileio.c
5ad05e
--- a/gdb/testsuite/gdb.base/fileio.c
5ad05e
+++ b/gdb/testsuite/gdb.base/fileio.c
5ad05e
@@ -560,6 +560,28 @@ strerrno (int err)
5ad05e
 int
5ad05e
 main ()
5ad05e
 {
5ad05e
+  /* These tests
5ad05e
+       Open for write but no write permission returns EACCES
5ad05e
+       Unlinking a file in a directory w/o write access returns EACCES
5ad05e
+     fail if we are being run as root - drop the privileges here.  */
5ad05e
+
5ad05e
+  if (geteuid () == 0)
5ad05e
+    {
5ad05e
+      uid_t uid = 99;
5ad05e
+
5ad05e
+      if (chown (OUTDIR, uid, uid) != 0)
5ad05e
+	{
5ad05e
+	  printf ("chown %d.%d %s: %s\n", (int) uid, (int) uid,
5ad05e
+		  OUTDIR, strerror (errno));
5ad05e
+	  exit (1);
5ad05e
+	}
5ad05e
+      if (setuid (uid) || geteuid () == 0)
5ad05e
+	{
5ad05e
+	  printf ("setuid %d: %s\n", (int) uid, strerror (errno));
5ad05e
+	  exit (1);
5ad05e
+	}
5ad05e
+    }
5ad05e
+
5ad05e
   /* Don't change the order of the calls.  They partly depend on each other */
5ad05e
   test_open ();
5ad05e
   test_write ();
5ad05e
diff --git a/gdb/testsuite/gdb.base/fileio.exp b/gdb/testsuite/gdb.base/fileio.exp
5ad05e
--- a/gdb/testsuite/gdb.base/fileio.exp
5ad05e
+++ b/gdb/testsuite/gdb.base/fileio.exp
5ad05e
@@ -24,9 +24,9 @@ if [target_info exists gdb,nofileio] {
5ad05e
 standard_testfile
5ad05e
 
5ad05e
 if {[is_remote host]} {
5ad05e
-    set outdir .
5ad05e
+    set outdir "fileio.dir"
5ad05e
 } else {
5ad05e
-    set outdir [standard_output_file {}]
5ad05e
+    set outdir [standard_output_file "fileio.dir"]
5ad05e
 }
5ad05e
 
5ad05e
 if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" \
5ad05e
@@ -47,7 +47,8 @@ set dir2 [standard_output_file dir2.fileio.test]
5ad05e
 if {[file exists $dir2] && ![file writable $dir2]} {
5ad05e
     system "chmod +w $dir2"
5ad05e
 }
5ad05e
-system "rm -rf [standard_output_file *.fileio.test]"
5ad05e
+system "rm -rf [standard_output_file fileio.dir]"
5ad05e
+system "mkdir -m777 [standard_output_file fileio.dir]"
5ad05e
 
5ad05e
 set oldtimeout $timeout
5ad05e
 set timeout [expr "$timeout + 60"]
5ad05e
@@ -89,7 +90,7 @@ gdb_test continue \
5ad05e
 
5ad05e
 gdb_test "continue" ".*" ""
5ad05e
 
5ad05e
-catch "system \"chmod -f -w [standard_output_file nowrt.fileio.test]\""
5ad05e
+catch "system \"chmod -f -w [standard_output_file fileio.dir/nowrt.fileio.test]\""
5ad05e
 
5ad05e
 gdb_test continue \
5ad05e
 "Continuing\\..*open 5:.*EACCES$stop_msg" \
5ad05e
@@ -276,9 +277,7 @@ gdb_test continue \
5ad05e
 gdb_exit
5ad05e
 
5ad05e
 # Make dir2 writable again so rm -rf of a build tree Just Works.
5ad05e
-if {[file exists $dir2] && ![file writable $dir2]} {
5ad05e
-    system "chmod +w $dir2"
5ad05e
-}
5ad05e
+system "chmod -R +w $outdir"
5ad05e
 
5ad05e
 set timeout $oldtimeout
5ad05e
 return 0