Blame SOURCES/gdb-6.6-buildid-locate-rpm-scl.patch

5ad05e
From FEDORA_PATCHES Mon Sep 17 00:00:00 2001
5ad05e
From: Fedora GDB patches <invalid@email.com>
5ad05e
Date: Fri, 27 Oct 2017 21:07:50 +0200
5ad05e
Subject: gdb-6.6-buildid-locate-rpm-scl.patch
5ad05e
5ad05e
;; [SCL] Skip deprecated .gdb_index warning for Red Hat built files (BZ 953585).
5ad05e
;;=push+jan
5ad05e
5ad05e
warning: Skipping deprecated .gdb_index section
5ad05e
https://bugzilla.redhat.com/show_bug.cgi?id=953585
5ad05e
5ad05e
diff --git a/gdb/build-id.c b/gdb/build-id.c
5ad05e
--- a/gdb/build-id.c
5ad05e
+++ b/gdb/build-id.c
5ad05e
@@ -743,7 +743,11 @@ static int missing_rpm_list_entries;
5ad05e
 /* Returns the count of newly added rpms.  */
5ad05e
 
5ad05e
 static int
5ad05e
+#ifndef GDB_INDEX_VERIFY_VENDOR
5ad05e
 missing_rpm_enlist (const char *filename)
5ad05e
+#else
5ad05e
+missing_rpm_enlist_1 (const char *filename, int verify_vendor)
5ad05e
+#endif
5ad05e
 {
5ad05e
   static int rpm_init_done = 0;
5ad05e
   rpmts ts;
5ad05e
@@ -850,7 +854,11 @@ missing_rpm_enlist (const char *filename)
5ad05e
   mi = rpmtsInitIterator_p (ts, RPMTAG_BASENAMES, filename, 0);
5ad05e
   if (mi != NULL)
5ad05e
     {
5ad05e
+#ifndef GDB_INDEX_VERIFY_VENDOR
5ad05e
       for (;;)
5ad05e
+#else
5ad05e
+      if (!verify_vendor) for (;;)
5ad05e
+#endif
5ad05e
 	{
5ad05e
 	  Header h;
5ad05e
 	  char *debuginfo, **slot, *s, *s2;
5ad05e
@@ -968,6 +976,37 @@ missing_rpm_enlist (const char *filename)
5ad05e
 	    xfree (debuginfo);
5ad05e
 	  count++;
5ad05e
 	}
5ad05e
+#ifdef GDB_INDEX_VERIFY_VENDOR
5ad05e
+      else /* verify_vendor */
5ad05e
+	{
5ad05e
+	  int vendor_pass = 0, vendor_fail = 0;
5ad05e
+
5ad05e
+	  for (;;)
5ad05e
+	    {
5ad05e
+	      Header h;
5ad05e
+	      errmsg_t err;
5ad05e
+	      char *vendor;
5ad05e
+
5ad05e
+	      h = rpmdbNextIterator_p (mi);
5ad05e
+	      if (h == NULL)
5ad05e
+		break;
5ad05e
+
5ad05e
+	      vendor = headerFormat_p (h, "%{vendor}", &err;;
5ad05e
+	      if (!vendor)
5ad05e
+		{
5ad05e
+		  warning (_("Error querying the rpm file `%s': %s"), filename,
5ad05e
+			   err);
5ad05e
+		  continue;
5ad05e
+		}
5ad05e
+	      if (strcmp (vendor, "Red Hat, Inc.") == 0)
5ad05e
+		vendor_pass = 1;
5ad05e
+	      else
5ad05e
+		vendor_fail = 1;
5ad05e
+	      xfree (vendor);
5ad05e
+	    }
5ad05e
+	  count = vendor_pass != 0 && vendor_fail == 0;
5ad05e
+	}
5ad05e
+#endif
5ad05e
 
5ad05e
       rpmdbFreeIterator_p (mi);
5ad05e
     }
5ad05e
@@ -977,6 +1016,20 @@ missing_rpm_enlist (const char *filename)
5ad05e
   return count;
5ad05e
 }
5ad05e
 
5ad05e
+#ifdef GDB_INDEX_VERIFY_VENDOR
5ad05e
+missing_rpm_enlist (const char *filename)
5ad05e
+{
5ad05e
+  return missing_rpm_enlist_1 (filename, 0);
5ad05e
+}
5ad05e
+
5ad05e
+extern int rpm_verify_vendor (const char *filename);
5ad05e
+int
5ad05e
+rpm_verify_vendor (const char *filename)
5ad05e
+{
5ad05e
+  return missing_rpm_enlist_1 (filename, 1);
5ad05e
+}
5ad05e
+#endif
5ad05e
+
5ad05e
 static bool
5ad05e
 missing_rpm_list_compar (const char *ap, const char *bp)
5ad05e
 {
5ad05e
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
5ad05e
--- a/gdb/dwarf2read.c
5ad05e
+++ b/gdb/dwarf2read.c
5ad05e
@@ -3497,6 +3497,16 @@ read_gdb_index_from_buffer (struct objfile *objfile,
5ad05e
      "set use-deprecated-index-sections on".  */
5ad05e
   if (version < 6 && !deprecated_ok)
5ad05e
     {
5ad05e
+#ifdef GDB_INDEX_VERIFY_VENDOR
5ad05e
+      extern int rpm_verify_vendor (const char *filename);
5ad05e
+
5ad05e
+      /* Red Hat Developer Toolset exception.  */
5ad05e
+      if (rpm_verify_vendor (filename))
5ad05e
+	{}
5ad05e
+      else
5ad05e
+      {
5ad05e
+
5ad05e
+#endif
5ad05e
       static int warning_printed = 0;
5ad05e
       if (!warning_printed)
5ad05e
 	{
5ad05e
@@ -3508,6 +3518,10 @@ to use the section anyway."),
5ad05e
 	  warning_printed = 1;
5ad05e
 	}
5ad05e
       return 0;
5ad05e
+#ifdef GDB_INDEX_VERIFY_VENDOR
5ad05e
+
5ad05e
+      }
5ad05e
+#endif
5ad05e
     }
5ad05e
   /* Version 7 indices generated by gold refer to the CU for a symbol instead
5ad05e
      of the TU (for symbols coming from TUs),