Blame SOURCES/gdb-6.6-buildid-locate-rpm-scl.patch

b2f73e
From FEDORA_PATCHES Mon Sep 17 00:00:00 2001
b2f73e
From: Fedora GDB patches <invalid@email.com>
b2f73e
Date: Fri, 27 Oct 2017 21:07:50 +0200
b2f73e
Subject: gdb-6.6-buildid-locate-rpm-scl.patch
b2f73e
b2f73e
;; [SCL] Skip deprecated .gdb_index warning for Red Hat built files (BZ 953585).
b2f73e
;;=push+jan
b2f73e
b2f73e
warning: Skipping deprecated .gdb_index section
b2f73e
https://bugzilla.redhat.com/show_bug.cgi?id=953585
b2f73e
b2f73e
diff --git a/gdb/build-id.c b/gdb/build-id.c
b2f73e
--- a/gdb/build-id.c
b2f73e
+++ b/gdb/build-id.c
b2f73e
@@ -743,7 +743,11 @@ static int missing_rpm_list_entries;
b2f73e
 /* Returns the count of newly added rpms.  */
b2f73e
 
b2f73e
 static int
b2f73e
+#ifndef GDB_INDEX_VERIFY_VENDOR
b2f73e
 missing_rpm_enlist (const char *filename)
b2f73e
+#else
b2f73e
+missing_rpm_enlist_1 (const char *filename, int verify_vendor)
b2f73e
+#endif
b2f73e
 {
b2f73e
   static int rpm_init_done = 0;
b2f73e
   rpmts ts;
b2f73e
@@ -850,7 +854,11 @@ missing_rpm_enlist (const char *filename)
b2f73e
   mi = rpmtsInitIterator_p (ts, RPMTAG_BASENAMES, filename, 0);
b2f73e
   if (mi != NULL)
b2f73e
     {
b2f73e
+#ifndef GDB_INDEX_VERIFY_VENDOR
b2f73e
       for (;;)
b2f73e
+#else
b2f73e
+      if (!verify_vendor) for (;;)
b2f73e
+#endif
b2f73e
 	{
b2f73e
 	  Header h;
b2f73e
 	  char *debuginfo, **slot, *s, *s2;
b2f73e
@@ -968,6 +976,37 @@ missing_rpm_enlist (const char *filename)
b2f73e
 	    xfree (debuginfo);
b2f73e
 	  count++;
b2f73e
 	}
b2f73e
+#ifdef GDB_INDEX_VERIFY_VENDOR
b2f73e
+      else /* verify_vendor */
b2f73e
+	{
b2f73e
+	  int vendor_pass = 0, vendor_fail = 0;
b2f73e
+
b2f73e
+	  for (;;)
b2f73e
+	    {
b2f73e
+	      Header h;
b2f73e
+	      errmsg_t err;
b2f73e
+	      char *vendor;
b2f73e
+
b2f73e
+	      h = rpmdbNextIterator_p (mi);
b2f73e
+	      if (h == NULL)
b2f73e
+		break;
b2f73e
+
b2f73e
+	      vendor = headerFormat_p (h, "%{vendor}", &err;;
b2f73e
+	      if (!vendor)
b2f73e
+		{
b2f73e
+		  warning (_("Error querying the rpm file `%s': %s"), filename,
b2f73e
+			   err);
b2f73e
+		  continue;
b2f73e
+		}
b2f73e
+	      if (strcmp (vendor, "Red Hat, Inc.") == 0)
b2f73e
+		vendor_pass = 1;
b2f73e
+	      else
b2f73e
+		vendor_fail = 1;
b2f73e
+	      xfree (vendor);
b2f73e
+	    }
b2f73e
+	  count = vendor_pass != 0 && vendor_fail == 0;
b2f73e
+	}
b2f73e
+#endif
b2f73e
 
b2f73e
       rpmdbFreeIterator_p (mi);
b2f73e
     }
b2f73e
@@ -977,6 +1016,20 @@ missing_rpm_enlist (const char *filename)
b2f73e
   return count;
b2f73e
 }
b2f73e
 
b2f73e
+#ifdef GDB_INDEX_VERIFY_VENDOR
b2f73e
+missing_rpm_enlist (const char *filename)
b2f73e
+{
b2f73e
+  return missing_rpm_enlist_1 (filename, 0);
b2f73e
+}
b2f73e
+
b2f73e
+extern int rpm_verify_vendor (const char *filename);
b2f73e
+int
b2f73e
+rpm_verify_vendor (const char *filename)
b2f73e
+{
b2f73e
+  return missing_rpm_enlist_1 (filename, 1);
b2f73e
+}
b2f73e
+#endif
b2f73e
+
b2f73e
 static bool
b2f73e
 missing_rpm_list_compar (const char *ap, const char *bp)
b2f73e
 {
b2f73e
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
b2f73e
--- a/gdb/dwarf2read.c
b2f73e
+++ b/gdb/dwarf2read.c
b2f73e
@@ -3497,6 +3497,16 @@ read_gdb_index_from_buffer (struct objfile *objfile,
b2f73e
      "set use-deprecated-index-sections on".  */
b2f73e
   if (version < 6 && !deprecated_ok)
b2f73e
     {
b2f73e
+#ifdef GDB_INDEX_VERIFY_VENDOR
b2f73e
+      extern int rpm_verify_vendor (const char *filename);
b2f73e
+
b2f73e
+      /* Red Hat Developer Toolset exception.  */
b2f73e
+      if (rpm_verify_vendor (filename))
b2f73e
+	{}
b2f73e
+      else
b2f73e
+      {
b2f73e
+
b2f73e
+#endif
b2f73e
       static int warning_printed = 0;
b2f73e
       if (!warning_printed)
b2f73e
 	{
b2f73e
@@ -3508,6 +3518,10 @@ to use the section anyway."),
b2f73e
 	  warning_printed = 1;
b2f73e
 	}
b2f73e
       return 0;
b2f73e
+#ifdef GDB_INDEX_VERIFY_VENDOR
b2f73e
+
b2f73e
+      }
b2f73e
+#endif
b2f73e
     }
b2f73e
   /* Version 7 indices generated by gold refer to the CU for a symbol instead
b2f73e
      of the TU (for symbols coming from TUs),