Blame SOURCES/binutils-aarch64-STO_AARCH64_VARIANT_PCS.patch

38fe89
diff -rup binutils.orig/bfd/elfnn-aarch64.c binutils-2.32/bfd/elfnn-aarch64.c
38fe89
--- binutils.orig/bfd/elfnn-aarch64.c	2019-07-02 17:30:19.407892712 +0100
38fe89
+++ binutils-2.32/bfd/elfnn-aarch64.c	2019-07-02 17:35:21.874749884 +0100
38fe89
@@ -2579,6 +2579,9 @@ struct elf_aarch64_link_hash_table
38fe89
   unsigned int top_index;
38fe89
   asection **input_list;
38fe89
 
38fe89
+  /* JUMP_SLOT relocs for variant PCS symbols may be present.  */
38fe89
+  int variant_pcs;
38fe89
+
38fe89
   /* The offset into splt of the PLT entry for the TLS descriptor
38fe89
      resolver.  Special values are 0, if not necessary (or not found
38fe89
      to be necessary yet), and -1 if needed but not determined
38fe89
@@ -2790,6 +2793,31 @@ elfNN_aarch64_copy_indirect_symbol (stru
38fe89
   _bfd_elf_link_hash_copy_indirect (info, dir, ind);
38fe89
 }
38fe89
 
38fe89
+/* Merge non-visibility st_other attributes.  */
38fe89
+
38fe89
+static void
38fe89
+elfNN_aarch64_merge_symbol_attribute (struct elf_link_hash_entry *h,
38fe89
+				      const Elf_Internal_Sym *isym,
38fe89
+				      bfd_boolean definition ATTRIBUTE_UNUSED,
38fe89
+				      bfd_boolean dynamic ATTRIBUTE_UNUSED)
38fe89
+{
38fe89
+  unsigned int isym_sto = isym->st_other & ~ELF_ST_VISIBILITY (-1);
38fe89
+  unsigned int h_sto = h->other & ~ELF_ST_VISIBILITY (-1);
38fe89
+
38fe89
+  if (isym_sto == h_sto)
38fe89
+    return;
38fe89
+
38fe89
+  if (isym_sto & ~STO_AARCH64_VARIANT_PCS)
38fe89
+    /* Not fatal, this callback cannot fail.  */
38fe89
+    _bfd_error_handler (_("unknown attribute for symbol `%s': 0x%02x"),
38fe89
+			h->root.root.string, isym_sto);
38fe89
+
38fe89
+  /* Note: Ideally we would warn about any attribute mismatch, but
38fe89
+     this api does not allow that without substantial changes.  */
38fe89
+  if (isym_sto & STO_AARCH64_VARIANT_PCS)
38fe89
+    h->other |= STO_AARCH64_VARIANT_PCS;
38fe89
+}
38fe89
+
38fe89
 /* Destroy an AArch64 elf linker hash table.  */
38fe89
 
38fe89
 static void
38fe89
@@ -8370,6 +8398,12 @@ elfNN_aarch64_allocate_dynrelocs (struct
38fe89
 	     updated.  */
38fe89
 
38fe89
 	  htab->root.srelplt->reloc_count++;
38fe89
+
38fe89
+	  /* Mark the DSO in case R_<CLS>_JUMP_SLOT relocs against
38fe89
+	     variant PCS symbols are present.  */
38fe89
+	  if (h->other & STO_AARCH64_VARIANT_PCS)
38fe89
+	    htab->variant_pcs = 1;
38fe89
+
38fe89
 	}
38fe89
       else
38fe89
 	{
38fe89
@@ -8958,6 +8992,10 @@ elfNN_aarch64_size_dynamic_sections (bfd
38fe89
 	      || !add_dynamic_entry (DT_JMPREL, 0))
38fe89
 	    return FALSE;
38fe89
 
38fe89
+	  if (htab->variant_pcs
38fe89
+	      && !add_dynamic_entry (DT_AARCH64_VARIANT_PCS, 0))
38fe89
+	    return FALSE;
38fe89
+
38fe89
 	  if (htab->tlsdesc_plt
38fe89
 	      && (!add_dynamic_entry (DT_TLSDESC_PLT, 0)
38fe89
 		  || !add_dynamic_entry (DT_TLSDESC_GOT, 0)))
38fe89
@@ -9708,6 +9746,9 @@ const struct elf_size_info elfNN_aarch64
38fe89
 #define elf_backend_copy_indirect_symbol	\
38fe89
   elfNN_aarch64_copy_indirect_symbol
38fe89
 
38fe89
+#define elf_backend_merge_symbol_attribute	\
38fe89
+  elfNN_aarch64_merge_symbol_attribute
38fe89
+
38fe89
 /* Create .dynbss, and .rela.bss sections in DYNOBJ, and set up shortcuts
38fe89
    to them in our hash.  */
38fe89
 #define elf_backend_create_dynamic_sections	\
38fe89
diff -rup binutils.orig/binutils/readelf.c binutils-2.32/binutils/readelf.c
38fe89
--- binutils.orig/binutils/readelf.c	2019-07-02 17:30:18.890896375 +0100
38fe89
+++ binutils-2.32/binutils/readelf.c	2019-07-02 17:32:25.008002901 +0100
38fe89
@@ -1797,6 +1797,19 @@ dump_relocations (Filedata *          fi
38fe89
 }
38fe89
 
38fe89
 static const char *
38fe89
+get_aarch64_dynamic_type (unsigned long type)
38fe89
+{
38fe89
+  switch (type)
38fe89
+    {
38fe89
+    case DT_AARCH64_BTI_PLT:  return "AARCH64_BTI_PLT";
38fe89
+    case DT_AARCH64_PAC_PLT:  return "AARCH64_PAC_PLT";
38fe89
+    case DT_AARCH64_VARIANT_PCS:  return "AARCH64_VARIANT_PCS";
38fe89
+    default:
38fe89
+      return NULL;
38fe89
+    }
38fe89
+}
38fe89
+
38fe89
+static const char *
38fe89
 get_mips_dynamic_type (unsigned long type)
38fe89
 {
38fe89
   switch (type)
38fe89
@@ -2169,6 +2182,9 @@ get_dynamic_type (Filedata * filedata, u
38fe89
 
38fe89
 	  switch (filedata->file_header.e_machine)
38fe89
 	    {
38fe89
+	    case EM_AARCH64:
38fe89
+	      result = get_aarch64_dynamic_type (type);
38fe89
+	      break;
38fe89
 	    case EM_MIPS:
38fe89
 	    case EM_MIPS_RS3_LE:
38fe89
 	      result = get_mips_dynamic_type (type);
38fe89
@@ -11054,6 +11070,22 @@ get_solaris_symbol_visibility (unsigned
38fe89
 }
38fe89
 
38fe89
 static const char *
38fe89
+get_aarch64_symbol_other (unsigned int other)
38fe89
+{
38fe89
+  static char buf[32];
38fe89
+
38fe89
+  if (other & STO_AARCH64_VARIANT_PCS)
38fe89
+    {
38fe89
+      other &= ~STO_AARCH64_VARIANT_PCS;
38fe89
+      if (other == 0)
38fe89
+	return "VARIANT_PCS";
38fe89
+      snprintf (buf, sizeof buf, "VARIANT_PCS | %x", other);
38fe89
+      return buf;
38fe89
+    }
38fe89
+  return NULL;
38fe89
+}
38fe89
+
38fe89
+static const char *
38fe89
 get_mips_symbol_other (unsigned int other)
38fe89
 {
38fe89
   switch (other)
38fe89
@@ -11164,6 +11196,9 @@ get_symbol_other (Filedata * filedata, u
38fe89
 
38fe89
   switch (filedata->file_header.e_machine)
38fe89
     {
38fe89
+    case EM_AARCH64:
38fe89
+      result = get_aarch64_symbol_other (other);
38fe89
+      break;
38fe89
     case EM_MIPS:
38fe89
       result = get_mips_symbol_other (other);
38fe89
       break;
38fe89
diff -rup binutils.orig/gas/config/tc-aarch64.c binutils-2.32/gas/config/tc-aarch64.c
38fe89
--- binutils.orig/gas/config/tc-aarch64.c	2019-07-02 17:30:19.131894667 +0100
38fe89
+++ binutils-2.32/gas/config/tc-aarch64.c	2019-07-02 17:35:45.202584620 +0100
38fe89
@@ -1938,6 +1938,28 @@ s_aarch64_elf_cons (int nbytes)
38fe89
   demand_empty_rest_of_line ();
38fe89
 }
38fe89
 
38fe89
+/* Mark symbol that it follows a variant PCS convention.  */
38fe89
+
38fe89
+static void
38fe89
+s_variant_pcs (int ignored ATTRIBUTE_UNUSED)
38fe89
+{
38fe89
+  char *name;
38fe89
+  char c;
38fe89
+  symbolS *sym;
38fe89
+  asymbol *bfdsym;
38fe89
+  elf_symbol_type *elfsym;
38fe89
+
38fe89
+  c = get_symbol_name (&name);
38fe89
+  if (!*name)
38fe89
+    as_bad (_("Missing symbol name in directive"));
38fe89
+  sym = symbol_find_or_make (name);
38fe89
+  restore_line_pointer (c);
38fe89
+  demand_empty_rest_of_line ();
38fe89
+  bfdsym = symbol_get_bfdsym (sym);
38fe89
+  elfsym = elf_symbol_from (bfd_asymbol_bfd (bfdsym), bfdsym);
38fe89
+  gas_assert (elfsym);
38fe89
+  elfsym->internal_elf_sym.st_other |= STO_AARCH64_VARIANT_PCS;
38fe89
+}
38fe89
 #endif /* OBJ_ELF */
38fe89
 
38fe89
 /* Output a 32-bit word, but mark as an instruction.  */
38fe89
@@ -2084,6 +2106,7 @@ const pseudo_typeS md_pseudo_table[] = {
38fe89
   {"long", s_aarch64_elf_cons, 4},
38fe89
   {"xword", s_aarch64_elf_cons, 8},
38fe89
   {"dword", s_aarch64_elf_cons, 8},
38fe89
+  {"variant_pcs", s_variant_pcs, 0},
38fe89
 #endif
38fe89
   {0, 0, 0}
38fe89
 };
38fe89
@@ -9320,3 +9343,35 @@ aarch64_copy_symbol_attributes (symbolS
38fe89
 {
38fe89
   AARCH64_GET_FLAG (dest) = AARCH64_GET_FLAG (src);
38fe89
 }
38fe89
+
38fe89
+#ifdef OBJ_ELF
38fe89
+/* Same as elf_copy_symbol_attributes, but without copying st_other.
38fe89
+   This is needed so AArch64 specific st_other values can be independently
38fe89
+   specified for an IFUNC resolver (that is called by the dynamic linker)
38fe89
+   and the symbol it resolves (aliased to the resolver).  In particular,
38fe89
+   if a function symbol has special st_other value set via directives,
38fe89
+   then attaching an IFUNC resolver to that symbol should not override
38fe89
+   the st_other setting.  Requiring the directive on the IFUNC resolver
38fe89
+   symbol would be unexpected and problematic in C code, where the two
38fe89
+   symbols appear as two independent function declarations.  */
38fe89
+
38fe89
+void
38fe89
+aarch64_elf_copy_symbol_attributes (symbolS *dest, symbolS *src)
38fe89
+{
38fe89
+  struct elf_obj_sy *srcelf = symbol_get_obj (src);
38fe89
+  struct elf_obj_sy *destelf = symbol_get_obj (dest);
38fe89
+  if (srcelf->size)
38fe89
+    {
38fe89
+      if (destelf->size == NULL)
38fe89
+	destelf->size = XNEW (expressionS);
38fe89
+      *destelf->size = *srcelf->size;
38fe89
+    }
38fe89
+  else
38fe89
+    {
38fe89
+      if (destelf->size != NULL)
38fe89
+	free (destelf->size);
38fe89
+      destelf->size = NULL;
38fe89
+    }
38fe89
+  S_SET_SIZE (dest, S_GET_SIZE (src));
38fe89
+}
38fe89
+#endif
38fe89
diff -rup binutils.orig/gas/config/tc-aarch64.h binutils-2.32/gas/config/tc-aarch64.h
38fe89
--- binutils.orig/gas/config/tc-aarch64.h	2019-07-02 17:30:19.136894632 +0100
38fe89
+++ binutils-2.32/gas/config/tc-aarch64.h	2019-07-02 17:35:45.202584620 +0100
38fe89
@@ -130,6 +130,12 @@ void aarch64_copy_symbol_attributes (sym
38fe89
   (aarch64_copy_symbol_attributes (DEST, SRC))
38fe89
 #endif
38fe89
 
38fe89
+#ifdef OBJ_ELF
38fe89
+void aarch64_elf_copy_symbol_attributes (symbolS *, symbolS *);
38fe89
+#define OBJ_COPY_SYMBOL_ATTRIBUTES(DEST, SRC) \
38fe89
+  aarch64_elf_copy_symbol_attributes (DEST, SRC)
38fe89
+#endif
38fe89
+
38fe89
 #define TC_START_LABEL(STR, NUL_CHAR, NEXT_CHAR)			\
38fe89
   (NEXT_CHAR == ':' || (NEXT_CHAR == '/' && aarch64_data_in_code ()))
38fe89
 #define tc_canonicalize_symbol_name(str) aarch64_canonicalize_symbol_name (str);
38fe89
diff -rup binutils.orig/gas/doc/c-aarch64.texi binutils-2.32/gas/doc/c-aarch64.texi
38fe89
--- binutils.orig/gas/doc/c-aarch64.texi	2019-07-02 17:30:19.125894710 +0100
38fe89
+++ binutils-2.32/gas/doc/c-aarch64.texi	2019-07-02 17:35:11.362824354 +0100
38fe89
@@ -425,6 +425,12 @@ should only be done if it is really nece
38fe89
 
38fe89
 @c VVVVVVVVVVVVVVVVVVVVVVVVVV
38fe89
 
38fe89
+@cindex @code{.variant_pcs} directive, AArch64
38fe89
+@item .variant_pcs @var{symbol}
38fe89
+This directive marks @var{symbol} referencing a function that may
38fe89
+follow a variant procedure call standard with different register
38fe89
+usage convention from the base procedure call standard.
38fe89
+
38fe89
 @c WWWWWWWWWWWWWWWWWWWWWWWWWW
38fe89
 @c XXXXXXXXXXXXXXXXXXXXXXXXXX
38fe89
 
38fe89
diff -rup binutils.orig/include/elf/aarch64.h binutils-2.32/include/elf/aarch64.h
38fe89
--- binutils.orig/include/elf/aarch64.h	2019-07-02 17:30:18.850896658 +0100
38fe89
+++ binutils-2.32/include/elf/aarch64.h	2019-07-02 17:32:55.678785616 +0100
38fe89
@@ -36,6 +36,15 @@
38fe89
 #define SHF_COMDEF		0x80000000   /* Section may be multiply defined
38fe89
 						in the input to a link step.  */
38fe89
 
38fe89
+/* Processor specific dynamic array tags.  */
38fe89
+#define DT_AARCH64_BTI_PLT	(DT_LOPROC + 1)
38fe89
+#define DT_AARCH64_PAC_PLT	(DT_LOPROC + 3)
38fe89
+#define DT_AARCH64_VARIANT_PCS	(DT_LOPROC + 5)
38fe89
+
38fe89
+/* AArch64-specific values for st_other.  */
38fe89
+#define STO_AARCH64_VARIANT_PCS	0x80  /* Symbol may follow different call
38fe89
+					 convention from the base PCS.  */
38fe89
+
38fe89
 /* Relocation types.  */
38fe89
 
38fe89
 START_RELOC_NUMBERS (elf_aarch64_reloc_type)
38fe89
diff -rup binutils.orig/ld/testsuite/ld-aarch64/aarch64-elf.exp binutils-2.32/ld/testsuite/ld-aarch64/aarch64-elf.exp
38fe89
--- binutils.orig/ld/testsuite/ld-aarch64/aarch64-elf.exp	2019-07-02 17:30:18.922896148 +0100
38fe89
+++ binutils-2.32/ld/testsuite/ld-aarch64/aarch64-elf.exp	2019-07-02 17:35:21.875749878 +0100
38fe89
@@ -371,6 +371,10 @@ run_dump_test_lp64 "rela-abs-relative-op
38fe89
 
38fe89
 run_dump_test_lp64 "pie-bind-locally"
38fe89
 
38fe89
+run_dump_test_lp64 "variant_pcs-r"
38fe89
+run_dump_test_lp64 "variant_pcs-shared"
38fe89
+run_dump_test_lp64 "variant_pcs-now"
38fe89
+
38fe89
 set aarch64elflinktests {
38fe89
   {"ld-aarch64/so with global symbol" "-shared" "" "" {copy-reloc-so.s}
38fe89
     {} "copy-reloc-so.so"}
38fe89
--- /dev/null	2019-07-02 08:01:33.386842704 +0100
38fe89
+++ binutils-2.32/gas/testsuite/gas/aarch64/symbol-variant_pcs-1.d	2019-07-02 17:35:11.362824354 +0100
38fe89
@@ -0,0 +1,10 @@
38fe89
+#objdump: -t
38fe89
+
38fe89
+.*:     file format .*
38fe89
+
38fe89
+SYMBOL TABLE:
38fe89
+0+ l    d  \.text	0+ \.text
38fe89
+0+ l    d  \.data	0+ \.data
38fe89
+0+ l    d  \.bss	0+ \.bss
38fe89
+0+ l       \.text	0+ func
38fe89
+0+         \*UND\*	0+ 0x80 foobar
38fe89
--- /dev/null	2019-07-02 08:01:33.386842704 +0100
38fe89
+++ binutils-2.32/gas/testsuite/gas/aarch64/symbol-variant_pcs-1.s	2019-07-02 17:35:11.362824354 +0100
38fe89
@@ -0,0 +1,8 @@
38fe89
+.text
38fe89
+.variant_pcs foobar
38fe89
+func:
38fe89
+	bl	foobar
38fe89
+	b	foobar
38fe89
+
38fe89
+.data
38fe89
+.xword	foobar
38fe89
--- /dev/null	2019-07-02 08:01:33.386842704 +0100
38fe89
+++ binutils-2.32/gas/testsuite/gas/aarch64/symbol-variant_pcs-2.d	2019-07-02 17:35:11.362824354 +0100
38fe89
@@ -0,0 +1,9 @@
38fe89
+#objdump: -t
38fe89
+
38fe89
+.*:     file format .*
38fe89
+
38fe89
+SYMBOL TABLE:
38fe89
+0+ l    d  \.text	0+ \.text
38fe89
+0+ l    d  \.data	0+ \.data
38fe89
+0+ l    d  \.bss	0+ \.bss
38fe89
+0+ l       \.text	0+ 0x80 foo
38fe89
--- /dev/null	2019-07-02 08:01:33.386842704 +0100
38fe89
+++ binutils-2.32/gas/testsuite/gas/aarch64/symbol-variant_pcs-2.s	2019-07-02 17:35:11.362824354 +0100
38fe89
@@ -0,0 +1,4 @@
38fe89
+.text
38fe89
+.variant_pcs foo
38fe89
+foo:
38fe89
+	ret
38fe89
--- /dev/null	2019-07-02 08:01:33.386842704 +0100
38fe89
+++ binutils-2.32/gas/testsuite/gas/aarch64/symbol-variant_pcs-3.s	2019-07-02 17:35:45.202584620 +0100
38fe89
@@ -0,0 +1,20 @@
38fe89
+.text
38fe89
+.global foo_vpcs
38fe89
+.global foo_base
38fe89
+.global alias_vpcs
38fe89
+.global alias_base
38fe89
+
38fe89
+.variant_pcs foo_vpcs
38fe89
+.variant_pcs alias_vpcs
38fe89
+
38fe89
+foo_vpcs:
38fe89
+foo_base:
38fe89
+	bl foo_vpcs
38fe89
+	bl foo_base
38fe89
+	bl alias_vpcs
38fe89
+	bl alias_base
38fe89
+
38fe89
+/* Check that the STO_AARCH64_VARIANT_PCS is not affected by .set.  */
38fe89
+
38fe89
+.set alias_base, foo_vpcs
38fe89
+.set alias_vpcs, foo_base
38fe89
--- /dev/null	2019-07-02 08:01:33.386842704 +0100
38fe89
+++ binutils-2.32/gas/testsuite/gas/aarch64/symbol-variant_pcs-3.d	2019-07-02 17:35:45.202584620 +0100
38fe89
@@ -0,0 +1,12 @@
38fe89
+#objdump: -t
38fe89
+
38fe89
+.*:     file format .*
38fe89
+
38fe89
+SYMBOL TABLE:
38fe89
+0+ l    d  \.text	0+ \.text
38fe89
+0+ l    d  \.data	0+ \.data
38fe89
+0+ l    d  \.bss	0+ \.bss
38fe89
+0+ g       \.text	0+ 0x80 foo_vpcs
38fe89
+0+ g       \.text	0+ foo_base
38fe89
+0+ g       \.text	0+ 0x80 alias_vpcs
38fe89
+0+ g       \.text	0+ alias_base
38fe89
--- /dev/null	2019-07-02 08:01:33.386842704 +0100
38fe89
+++ binutils-2.32/ld/testsuite/ld-aarch64/variant_pcs-1.s	2019-07-02 17:35:21.875749878 +0100
38fe89
@@ -0,0 +1,59 @@
38fe89
+.text
38fe89
+
38fe89
+.variant_pcs f_spec_global_default_def
38fe89
+.variant_pcs f_spec_global_default_undef
38fe89
+.variant_pcs f_spec_global_hidden_def
38fe89
+.variant_pcs f_spec_local
38fe89
+.variant_pcs f_spec_global_default_ifunc
38fe89
+.variant_pcs f_spec_global_hidden_ifunc
38fe89
+.variant_pcs f_spec_local_ifunc
38fe89
+
38fe89
+.global f_spec_global_default_def
38fe89
+.global f_spec_global_default_undef
38fe89
+.global f_spec_global_hidden_def
38fe89
+.global f_spec_global_default_ifunc
38fe89
+.global f_spec_global_hidden_ifunc
38fe89
+.global f_base_global_default_def
38fe89
+.global f_base_global_default_undef
38fe89
+.global f_base_global_hidden_def
38fe89
+.global f_base_global_default_ifunc
38fe89
+.global f_base_global_hidden_ifunc
38fe89
+
38fe89
+.hidden f_spec_global_hidden_def
38fe89
+.hidden f_spec_global_hidden_ifunc
38fe89
+.hidden f_base_global_hidden_def
38fe89
+.hidden f_base_global_hidden_ifunc
38fe89
+
38fe89
+.type f_spec_global_default_ifunc, %gnu_indirect_function
38fe89
+.type f_spec_global_hidden_ifunc, %gnu_indirect_function
38fe89
+.type f_spec_local_ifunc, %gnu_indirect_function
38fe89
+.type f_base_global_default_ifunc, %gnu_indirect_function
38fe89
+.type f_base_global_hidden_ifunc, %gnu_indirect_function
38fe89
+.type f_base_local_ifunc, %gnu_indirect_function
38fe89
+
38fe89
+f_spec_global_default_def:
38fe89
+f_spec_global_hidden_def:
38fe89
+f_spec_local:
38fe89
+f_base_global_default_def:
38fe89
+f_base_global_hidden_def:
38fe89
+f_base_local:
38fe89
+f_spec_global_default_ifunc:
38fe89
+f_spec_global_hidden_ifunc:
38fe89
+f_spec_local_ifunc:
38fe89
+f_base_global_default_ifunc:
38fe89
+f_base_global_hidden_ifunc:
38fe89
+f_base_local_ifunc:
38fe89
+	bl f_spec_global_default_def
38fe89
+	bl f_spec_global_default_undef
38fe89
+	bl f_spec_global_hidden_def
38fe89
+	bl f_spec_local
38fe89
+	bl f_base_global_default_def
38fe89
+	bl f_base_global_default_undef
38fe89
+	bl f_base_global_hidden_def
38fe89
+	bl f_base_local
38fe89
+	bl f_spec_global_default_ifunc
38fe89
+	bl f_spec_global_hidden_ifunc
38fe89
+	bl f_spec_local_ifunc
38fe89
+	bl f_base_global_default_ifunc
38fe89
+	bl f_base_global_hidden_ifunc
38fe89
+	bl f_base_local_ifunc
38fe89
--- /dev/null	2019-07-02 08:01:33.386842704 +0100
38fe89
+++ binutils-2.32/ld/testsuite/ld-aarch64/variant_pcs-2.s	2019-07-02 17:35:21.875749878 +0100
38fe89
@@ -0,0 +1,47 @@
38fe89
+.text
38fe89
+
38fe89
+.variant_pcs f_spec_global_default_def
38fe89
+.variant_pcs f_spec_global_default_undef
38fe89
+.variant_pcs f_spec_global_hidden_def
38fe89
+.variant_pcs f_spec_local2
38fe89
+.variant_pcs f_spec_global_default_ifunc
38fe89
+.variant_pcs f_spec_global_hidden_ifunc
38fe89
+.variant_pcs f_spec_local2_ifunc
38fe89
+
38fe89
+.global f_spec_global_default_def
38fe89
+.global f_spec_global_default_undef
38fe89
+.global f_spec_global_hidden_def
38fe89
+.global f_spec_global_default_ifunc
38fe89
+.global f_spec_global_hidden_ifunc
38fe89
+.global f_base_global_default_def
38fe89
+.global f_base_global_default_undef
38fe89
+.global f_base_global_hidden_def
38fe89
+.global f_base_global_default_ifunc
38fe89
+.global f_base_global_hidden_ifunc
38fe89
+
38fe89
+.hidden f_spec_global_hidden_def
38fe89
+.hidden f_spec_global_hidden_ifunc
38fe89
+.hidden f_base_global_hidden_def
38fe89
+.hidden f_base_global_hidden_ifunc
38fe89
+
38fe89
+.type f_spec_local2_ifunc, %gnu_indirect_function
38fe89
+.type f_base_local2_ifunc, %gnu_indirect_function
38fe89
+
38fe89
+f_spec_local2:
38fe89
+f_base_local2:
38fe89
+f_spec_local2_ifunc:
38fe89
+f_base_local2_ifunc:
38fe89
+	bl f_spec_global_default_def
38fe89
+	bl f_spec_global_default_undef
38fe89
+	bl f_spec_global_hidden_def
38fe89
+	bl f_spec_local2
38fe89
+	bl f_base_global_default_def
38fe89
+	bl f_base_global_default_undef
38fe89
+	bl f_base_global_hidden_def
38fe89
+	bl f_base_local2
38fe89
+	bl f_spec_global_default_ifunc
38fe89
+	bl f_spec_global_hidden_ifunc
38fe89
+	bl f_spec_local2_ifunc
38fe89
+	bl f_base_global_default_ifunc
38fe89
+	bl f_base_global_hidden_ifunc
38fe89
+	bl f_base_local2_ifunc
38fe89
--- /dev/null	2019-07-02 08:01:33.386842704 +0100
38fe89
+++ binutils-2.32/ld/testsuite/ld-aarch64/variant_pcs.ld	2019-07-02 17:35:37.100642017 +0100
38fe89
@@ -0,0 +1,23 @@
38fe89
+/* Script for .variant_pcs symbol tests.  */
38fe89
+OUTPUT_ARCH(aarch64)
38fe89
+ENTRY(_start)
38fe89
+SECTIONS
38fe89
+{
38fe89
+  /* Read-only sections, merged into text segment: */
38fe89
+  PROVIDE (__executable_start = 0x8000); . = 0x8000;
38fe89
+  .text           :
38fe89
+  {
38fe89
+    *(.before)
38fe89
+    *(.text)
38fe89
+    *(.after)
38fe89
+  } =0
38fe89
+  . = 0x9000;
38fe89
+  .got            : { *(.got) *(.got.plt)}
38fe89
+  . = 0x10000;
38fe89
+  .rela.dyn       : { *(.rela.ifunc) }
38fe89
+  . = 0x11000;
38fe89
+  .rela.plt       : { *(.rela.plt) *(.rela.iplt) }
38fe89
+  . = 0x12340000;
38fe89
+  .far : { *(.far) }
38fe89
+  .ARM.attributes 0 : { *(.ARM.atttributes) }
38fe89
+}
38fe89
--- /dev/null	2019-07-02 08:01:33.386842704 +0100
38fe89
+++ binutils-2.32/ld/testsuite/ld-aarch64/variant_pcs-now.d	2019-07-02 17:34:37.557063849 +0100
38fe89
@@ -0,0 +1,67 @@
38fe89
+#source: variant_pcs-1.s
38fe89
+#source: variant_pcs-2.s
38fe89
+#ld: -shared --hash-style=sysv -T variant_pcs.ld -z now
38fe89
+#readelf: -rsW
38fe89
+
38fe89
+Relocation section '\.rela\.plt' at offset 0x11000 contains 12 entries:
38fe89
+    Offset             Info             Type               Symbol's Value  Symbol's Name \+ Addend
38fe89
+0000000000009020  0000000100000402 R_AARCH64_JUMP_SLOT    0000000000000000 f_base_global_default_undef \+ 0
38fe89
+0000000000009028  0000000200000402 R_AARCH64_JUMP_SLOT    0000000000000000 f_spec_global_default_undef \+ 0
38fe89
+0000000000009030  0000000400000402 R_AARCH64_JUMP_SLOT    0000000000008000 f_base_global_default_def \+ 0
38fe89
+0000000000009038  0000000500000402 R_AARCH64_JUMP_SLOT    0000000000008000 f_spec_global_default_def \+ 0
38fe89
+0000000000009040  0000000000000408 R_AARCH64_IRELATIVE                       8000
38fe89
+0000000000009048  0000000300000402 R_AARCH64_JUMP_SLOT    f_spec_global_default_ifunc\(\) f_spec_global_default_ifunc \+ 0
38fe89
+0000000000009050  0000000000000408 R_AARCH64_IRELATIVE                       8000
38fe89
+0000000000009058  0000000600000402 R_AARCH64_JUMP_SLOT    f_base_global_default_ifunc\(\) f_base_global_default_ifunc \+ 0
38fe89
+0000000000009060  0000000000000408 R_AARCH64_IRELATIVE                       8038
38fe89
+0000000000009068  0000000000000408 R_AARCH64_IRELATIVE                       8000
38fe89
+0000000000009070  0000000000000408 R_AARCH64_IRELATIVE                       8000
38fe89
+0000000000009078  0000000000000408 R_AARCH64_IRELATIVE                       8038
38fe89
+
38fe89
+Symbol table '\.dynsym' contains 7 entries:
38fe89
+   Num:    Value          Size Type    Bind   Vis      Ndx Name
38fe89
+     0: 0000000000000000     0 NOTYPE  LOCAL  DEFAULT  UND 
38fe89
+     1: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT  UND f_base_global_default_undef
38fe89
+     2: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT \[VARIANT_PCS\]   UND f_spec_global_default_undef
38fe89
+     3: 0000000000008000     0 IFUNC   GLOBAL DEFAULT \[VARIANT_PCS\]     1 f_spec_global_default_ifunc
38fe89
+     4: 0000000000008000     0 NOTYPE  GLOBAL DEFAULT    1 f_base_global_default_def
38fe89
+     5: 0000000000008000     0 NOTYPE  GLOBAL DEFAULT \[VARIANT_PCS\]     1 f_spec_global_default_def
38fe89
+     6: 0000000000008000     0 IFUNC   GLOBAL DEFAULT    1 f_base_global_default_ifunc
38fe89
+
38fe89
+Symbol table '\.symtab' contains 35 entries:
38fe89
+   Num:    Value          Size Type    Bind   Vis      Ndx Name
38fe89
+     0: 0000000000000000     0 NOTYPE  LOCAL  DEFAULT  UND 
38fe89
+     1: 0000000000008000     0 SECTION LOCAL  DEFAULT    1 
38fe89
+     2: 0000000000008070     0 SECTION LOCAL  DEFAULT    2 
38fe89
+     3: 0000000000009000     0 SECTION LOCAL  DEFAULT    3 
38fe89
+     4: 0000000000009080     0 SECTION LOCAL  DEFAULT    4 
38fe89
+     5: 0000000000011000     0 SECTION LOCAL  DEFAULT    5 
38fe89
+     6: 0000000000011120     0 SECTION LOCAL  DEFAULT    6 
38fe89
+     7: 00000000000111c8     0 SECTION LOCAL  DEFAULT    7 
38fe89
+     8: 0000000000011270     0 SECTION LOCAL  DEFAULT    8 
38fe89
+     9: 0000000000000000     0 FILE    LOCAL  DEFAULT  ABS .*variant_pcs-1\.o
38fe89
+    10: 0000000000008000     0 NOTYPE  LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_local
38fe89
+    11: 0000000000008000     0 IFUNC   LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_local_ifunc
38fe89
+    12: 0000000000008000     0 IFUNC   LOCAL  DEFAULT    1 f_base_local_ifunc
38fe89
+    13: 0000000000008000     0 NOTYPE  LOCAL  DEFAULT    1 f_base_local
38fe89
+    14: 0000000000008000     0 NOTYPE  LOCAL  DEFAULT    1 \$x
38fe89
+    15: 0000000000000000     0 FILE    LOCAL  DEFAULT  ABS .*variant_pcs-2\.o
38fe89
+    16: 0000000000008038     0 NOTYPE  LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_local2
38fe89
+    17: 0000000000008038     0 IFUNC   LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_local2_ifunc
38fe89
+    18: 0000000000008038     0 IFUNC   LOCAL  DEFAULT    1 f_base_local2_ifunc
38fe89
+    19: 0000000000008038     0 NOTYPE  LOCAL  DEFAULT    1 f_base_local2
38fe89
+    20: 0000000000008038     0 NOTYPE  LOCAL  DEFAULT    1 \$x
38fe89
+    21: 0000000000000000     0 FILE    LOCAL  DEFAULT  ABS 
38fe89
+    22: 0000000000009080     0 OBJECT  LOCAL  DEFAULT  ABS _DYNAMIC
38fe89
+    23: 0000000000008000     0 NOTYPE  LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_global_hidden_def
38fe89
+    24: 0000000000008000     0 IFUNC   LOCAL  DEFAULT    1 f_base_global_hidden_ifunc
38fe89
+    25: 0000000000008000     0 NOTYPE  LOCAL  DEFAULT    1 f_base_global_hidden_def
38fe89
+    26: 0000000000009000     0 OBJECT  LOCAL  DEFAULT  ABS _GLOBAL_OFFSET_TABLE_
38fe89
+    27: 0000000000008000     0 IFUNC   LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_global_hidden_ifunc
38fe89
+    28: 0000000000008070     0 NOTYPE  LOCAL  DEFAULT    2 \$x
38fe89
+    29: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT  UND f_base_global_default_undef
38fe89
+    30: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT \[VARIANT_PCS\]   UND f_spec_global_default_undef
38fe89
+    31: 0000000000008000     0 IFUNC   GLOBAL DEFAULT \[VARIANT_PCS\]     1 f_spec_global_default_ifunc
38fe89
+    32: 0000000000008000     0 NOTYPE  GLOBAL DEFAULT    1 f_base_global_default_def
38fe89
+    33: 0000000000008000     0 NOTYPE  GLOBAL DEFAULT \[VARIANT_PCS\]     1 f_spec_global_default_def
38fe89
+    34: 0000000000008000     0 IFUNC   GLOBAL DEFAULT    1 f_base_global_default_ifunc
38fe89
--- /dev/null	2019-07-02 08:01:33.386842704 +0100
38fe89
+++ binutils-2.32/ld/testsuite/ld-aarch64/variant_pcs-r.d	2019-07-02 17:35:35.244655166 +0100
38fe89
@@ -0,0 +1,60 @@
38fe89
+#source: variant_pcs-1.s
38fe89
+#source: variant_pcs-2.s
38fe89
+#ld: -r
38fe89
+#readelf: -rsW
38fe89
+
38fe89
+Relocation section '\.rela\.text' at offset .* contains 24 entries:
38fe89
+    Offset             Info             Type               Symbol's Value  Symbol's Name \+ Addend
38fe89
+0000000000000000  000000180000011b R_AARCH64_CALL26       0000000000000000 f_spec_global_default_def \+ 0
38fe89
+0000000000000004  000000110000011b R_AARCH64_CALL26       0000000000000000 f_spec_global_default_undef \+ 0
38fe89
+0000000000000008  000000120000011b R_AARCH64_CALL26       0000000000000000 f_spec_global_hidden_def \+ 0
38fe89
+0000000000000010  000000170000011b R_AARCH64_CALL26       0000000000000000 f_base_global_default_def \+ 0
38fe89
+0000000000000014  000000100000011b R_AARCH64_CALL26       0000000000000000 f_base_global_default_undef \+ 0
38fe89
+0000000000000018  000000150000011b R_AARCH64_CALL26       0000000000000000 f_base_global_hidden_def \+ 0
38fe89
+0000000000000020  000000140000011b R_AARCH64_CALL26       f_spec_global_default_ifunc\(\) f_spec_global_default_ifunc \+ 0
38fe89
+0000000000000024  000000160000011b R_AARCH64_CALL26       f_spec_global_hidden_ifunc\(\) f_spec_global_hidden_ifunc \+ 0
38fe89
+0000000000000028  000000060000011b R_AARCH64_CALL26       f_spec_local_ifunc\(\) f_spec_local_ifunc \+ 0
38fe89
+000000000000002c  000000190000011b R_AARCH64_CALL26       f_base_global_default_ifunc\(\) f_base_global_default_ifunc \+ 0
38fe89
+0000000000000030  000000130000011b R_AARCH64_CALL26       f_base_global_hidden_ifunc\(\) f_base_global_hidden_ifunc \+ 0
38fe89
+0000000000000034  000000070000011b R_AARCH64_CALL26       f_base_local_ifunc\(\) f_base_local_ifunc \+ 0
38fe89
+0000000000000038  000000180000011b R_AARCH64_CALL26       0000000000000000 f_spec_global_default_def \+ 0
38fe89
+000000000000003c  000000110000011b R_AARCH64_CALL26       0000000000000000 f_spec_global_default_undef \+ 0
38fe89
+0000000000000040  000000120000011b R_AARCH64_CALL26       0000000000000000 f_spec_global_hidden_def \+ 0
38fe89
+0000000000000048  000000170000011b R_AARCH64_CALL26       0000000000000000 f_base_global_default_def \+ 0
38fe89
+000000000000004c  000000100000011b R_AARCH64_CALL26       0000000000000000 f_base_global_default_undef \+ 0
38fe89
+0000000000000050  000000150000011b R_AARCH64_CALL26       0000000000000000 f_base_global_hidden_def \+ 0
38fe89
+0000000000000058  000000140000011b R_AARCH64_CALL26       f_spec_global_default_ifunc\(\) f_spec_global_default_ifunc \+ 0
38fe89
+000000000000005c  000000160000011b R_AARCH64_CALL26       f_spec_global_hidden_ifunc\(\) f_spec_global_hidden_ifunc \+ 0
38fe89
+0000000000000060  0000000c0000011b R_AARCH64_CALL26       f_spec_local2_ifunc\(\) f_spec_local2_ifunc \+ 0
38fe89
+0000000000000064  000000190000011b R_AARCH64_CALL26       f_base_global_default_ifunc\(\) f_base_global_default_ifunc \+ 0
38fe89
+0000000000000068  000000130000011b R_AARCH64_CALL26       f_base_global_hidden_ifunc\(\) f_base_global_hidden_ifunc \+ 0
38fe89
+000000000000006c  0000000d0000011b R_AARCH64_CALL26       f_base_local2_ifunc\(\) f_base_local2_ifunc \+ 0
38fe89
+
38fe89
+Symbol table '\.symtab' contains 26 entries:
38fe89
+   Num:    Value          Size Type    Bind   Vis      Ndx Name
38fe89
+     0: 0000000000000000     0 NOTYPE  LOCAL  DEFAULT  UND 
38fe89
+     1: 0000000000000000     0 SECTION LOCAL  DEFAULT    1 
38fe89
+     2: 0000000000000000     0 SECTION LOCAL  DEFAULT    3 
38fe89
+     3: 0000000000000000     0 SECTION LOCAL  DEFAULT    4 
38fe89
+     4: 0000000000000000     0 FILE    LOCAL  DEFAULT  ABS .*variant_pcs-1\.o
38fe89
+     5: 0000000000000000     0 NOTYPE  LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_local
38fe89
+     6: 0000000000000000     0 IFUNC   LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_local_ifunc
38fe89
+     7: 0000000000000000     0 IFUNC   LOCAL  DEFAULT    1 f_base_local_ifunc
38fe89
+     8: 0000000000000000     0 NOTYPE  LOCAL  DEFAULT    1 f_base_local
38fe89
+     9: 0000000000000000     0 NOTYPE  LOCAL  DEFAULT    1 \$x
38fe89
+    10: 0000000000000000     0 FILE    LOCAL  DEFAULT  ABS .*variant_pcs-2\.o
38fe89
+    11: 0000000000000038     0 NOTYPE  LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_local2
38fe89
+    12: 0000000000000038     0 IFUNC   LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_local2_ifunc
38fe89
+    13: 0000000000000038     0 IFUNC   LOCAL  DEFAULT    1 f_base_local2_ifunc
38fe89
+    14: 0000000000000038     0 NOTYPE  LOCAL  DEFAULT    1 f_base_local2
38fe89
+    15: 0000000000000038     0 NOTYPE  LOCAL  DEFAULT    1 \$x
38fe89
+    16: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT  UND f_base_global_default_undef
38fe89
+    17: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT \[VARIANT_PCS\]   UND f_spec_global_default_undef
38fe89
+    18: 0000000000000000     0 NOTYPE  GLOBAL HIDDEN  \[VARIANT_PCS\]     1 f_spec_global_hidden_def
38fe89
+    19: 0000000000000000     0 IFUNC   GLOBAL HIDDEN     1 f_base_global_hidden_ifunc
38fe89
+    20: 0000000000000000     0 IFUNC   GLOBAL DEFAULT \[VARIANT_PCS\]     1 f_spec_global_default_ifunc
38fe89
+    21: 0000000000000000     0 NOTYPE  GLOBAL HIDDEN     1 f_base_global_hidden_def
38fe89
+    22: 0000000000000000     0 IFUNC   GLOBAL HIDDEN  \[VARIANT_PCS\]     1 f_spec_global_hidden_ifunc
38fe89
+    23: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT    1 f_base_global_default_def
38fe89
+    24: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT \[VARIANT_PCS\]     1 f_spec_global_default_def
38fe89
+    25: 0000000000000000     0 IFUNC   GLOBAL DEFAULT    1 f_base_global_default_ifunc
38fe89
--- /dev/null	2019-07-02 08:01:33.386842704 +0100
38fe89
+++ binutils-2.32/ld/testsuite/ld-aarch64/variant_pcs-shared.d	2019-07-02 17:34:45.635006622 +0100
38fe89
@@ -0,0 +1,67 @@
38fe89
+#source: variant_pcs-1.s
38fe89
+#source: variant_pcs-2.s
38fe89
+#ld: -shared --hash-style=sysv -T variant_pcs.ld
38fe89
+#readelf: -rsW
38fe89
+
38fe89
+Relocation section '\.rela\.plt' at offset 0x11000 contains 12 entries:
38fe89
+    Offset             Info             Type               Symbol's Value  Symbol's Name \+ Addend
38fe89
+0000000000009020  0000000100000402 R_AARCH64_JUMP_SLOT    0000000000000000 f_base_global_default_undef \+ 0
38fe89
+0000000000009028  0000000200000402 R_AARCH64_JUMP_SLOT    0000000000000000 f_spec_global_default_undef \+ 0
38fe89
+0000000000009030  0000000400000402 R_AARCH64_JUMP_SLOT    0000000000008000 f_base_global_default_def \+ 0
38fe89
+0000000000009038  0000000500000402 R_AARCH64_JUMP_SLOT    0000000000008000 f_spec_global_default_def \+ 0
38fe89
+0000000000009040  0000000000000408 R_AARCH64_IRELATIVE                       8000
38fe89
+0000000000009048  0000000300000402 R_AARCH64_JUMP_SLOT    f_spec_global_default_ifunc\(\) f_spec_global_default_ifunc \+ 0
38fe89
+0000000000009050  0000000000000408 R_AARCH64_IRELATIVE                       8000
38fe89
+0000000000009058  0000000600000402 R_AARCH64_JUMP_SLOT    f_base_global_default_ifunc\(\) f_base_global_default_ifunc \+ 0
38fe89
+0000000000009060  0000000000000408 R_AARCH64_IRELATIVE                       8038
38fe89
+0000000000009068  0000000000000408 R_AARCH64_IRELATIVE                       8000
38fe89
+0000000000009070  0000000000000408 R_AARCH64_IRELATIVE                       8000
38fe89
+0000000000009078  0000000000000408 R_AARCH64_IRELATIVE                       8038
38fe89
+
38fe89
+Symbol table '\.dynsym' contains 7 entries:
38fe89
+   Num:    Value          Size Type    Bind   Vis      Ndx Name
38fe89
+     0: 0000000000000000     0 NOTYPE  LOCAL  DEFAULT  UND 
38fe89
+     1: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT  UND f_base_global_default_undef
38fe89
+     2: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT \[VARIANT_PCS\]   UND f_spec_global_default_undef
38fe89
+     3: 0000000000008000     0 IFUNC   GLOBAL DEFAULT \[VARIANT_PCS\]     1 f_spec_global_default_ifunc
38fe89
+     4: 0000000000008000     0 NOTYPE  GLOBAL DEFAULT    1 f_base_global_default_def
38fe89
+     5: 0000000000008000     0 NOTYPE  GLOBAL DEFAULT \[VARIANT_PCS\]     1 f_spec_global_default_def
38fe89
+     6: 0000000000008000     0 IFUNC   GLOBAL DEFAULT    1 f_base_global_default_ifunc
38fe89
+
38fe89
+Symbol table '\.symtab' contains 35 entries:
38fe89
+   Num:    Value          Size Type    Bind   Vis      Ndx Name
38fe89
+     0: 0000000000000000     0 NOTYPE  LOCAL  DEFAULT  UND 
38fe89
+     1: 0000000000008000     0 SECTION LOCAL  DEFAULT    1 
38fe89
+     2: 0000000000008070     0 SECTION LOCAL  DEFAULT    2 
38fe89
+     3: 0000000000009000     0 SECTION LOCAL  DEFAULT    3 
38fe89
+     4: 0000000000009080     0 SECTION LOCAL  DEFAULT    4 
38fe89
+     5: 0000000000011000     0 SECTION LOCAL  DEFAULT    5 
38fe89
+     6: 0000000000011120     0 SECTION LOCAL  DEFAULT    6 
38fe89
+     7: 00000000000111c8     0 SECTION LOCAL  DEFAULT    7 
38fe89
+     8: 0000000000011270     0 SECTION LOCAL  DEFAULT    8 
38fe89
+     9: 0000000000000000     0 FILE    LOCAL  DEFAULT  ABS .*variant_pcs-1\.o
38fe89
+    10: 0000000000008000     0 NOTYPE  LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_local
38fe89
+    11: 0000000000008000     0 IFUNC   LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_local_ifunc
38fe89
+    12: 0000000000008000     0 IFUNC   LOCAL  DEFAULT    1 f_base_local_ifunc
38fe89
+    13: 0000000000008000     0 NOTYPE  LOCAL  DEFAULT    1 f_base_local
38fe89
+    14: 0000000000008000     0 NOTYPE  LOCAL  DEFAULT    1 \$x
38fe89
+    15: 0000000000000000     0 FILE    LOCAL  DEFAULT  ABS .*variant_pcs-2\.o
38fe89
+    16: 0000000000008038     0 NOTYPE  LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_local2
38fe89
+    17: 0000000000008038     0 IFUNC   LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_local2_ifunc
38fe89
+    18: 0000000000008038     0 IFUNC   LOCAL  DEFAULT    1 f_base_local2_ifunc
38fe89
+    19: 0000000000008038     0 NOTYPE  LOCAL  DEFAULT    1 f_base_local2
38fe89
+    20: 0000000000008038     0 NOTYPE  LOCAL  DEFAULT    1 \$x
38fe89
+    21: 0000000000000000     0 FILE    LOCAL  DEFAULT  ABS 
38fe89
+    22: 0000000000009080     0 OBJECT  LOCAL  DEFAULT  ABS _DYNAMIC
38fe89
+    23: 0000000000008000     0 NOTYPE  LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_global_hidden_def
38fe89
+    24: 0000000000008000     0 IFUNC   LOCAL  DEFAULT    1 f_base_global_hidden_ifunc
38fe89
+    25: 0000000000008000     0 NOTYPE  LOCAL  DEFAULT    1 f_base_global_hidden_def
38fe89
+    26: 0000000000009000     0 OBJECT  LOCAL  DEFAULT  ABS _GLOBAL_OFFSET_TABLE_
38fe89
+    27: 0000000000008000     0 IFUNC   LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_global_hidden_ifunc
38fe89
+    28: 0000000000008070     0 NOTYPE  LOCAL  DEFAULT    2 \$x
38fe89
+    29: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT  UND f_base_global_default_undef
38fe89
+    30: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT \[VARIANT_PCS\]   UND f_spec_global_default_undef
38fe89
+    31: 0000000000008000     0 IFUNC   GLOBAL DEFAULT \[VARIANT_PCS\]     1 f_spec_global_default_ifunc
38fe89
+    32: 0000000000008000     0 NOTYPE  GLOBAL DEFAULT    1 f_base_global_default_def
38fe89
+    33: 0000000000008000     0 NOTYPE  GLOBAL DEFAULT \[VARIANT_PCS\]     1 f_spec_global_default_def
38fe89
+    34: 0000000000008000     0 IFUNC   GLOBAL DEFAULT    1 f_base_global_default_ifunc
38fe89
--- binutils.orig/bfd/archive.c	2019-07-03 10:06:20.527408416 +0100
38fe89
+++ binutils-2.32/bfd/archive.c	2019-07-03 10:06:57.887142988 +0100
38fe89
@@ -1076,8 +1076,6 @@ do_slurp_coff_armap (bfd *abfd)
38fe89
   *stringend = 0;
38fe89
   for (i = 0; i < nsymz; i++)
38fe89
     {
38fe89
-      bfd_size_type len;
38fe89
-
38fe89
       rawptr = raw_armap + i;
38fe89
       carsyms->file_offset = swap ((bfd_byte *) rawptr);
38fe89
       carsyms->name = stringbase;
38fe89
diff -rup binutils.orig/ld/testsuite/ld-aarch64/variant_pcs-now.d binutils-2.32/ld/testsuite/ld-aarch64/variant_pcs-now.d
38fe89
--- binutils.orig/ld/testsuite/ld-aarch64/variant_pcs-now.d	2019-07-03 10:06:20.012412075 +0100
38fe89
+++ binutils-2.32/ld/testsuite/ld-aarch64/variant_pcs-now.d	2019-07-03 10:20:51.959203582 +0100
38fe89
@@ -22,10 +22,10 @@ Symbol table '\.dynsym' contains 7 entri
38fe89
    Num:    Value          Size Type    Bind   Vis      Ndx Name
38fe89
      0: 0000000000000000     0 NOTYPE  LOCAL  DEFAULT  UND 
38fe89
      1: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT  UND f_base_global_default_undef
38fe89
-     2: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT \[VARIANT_PCS\]   UND f_spec_global_default_undef
38fe89
-     3: 0000000000008000     0 IFUNC   GLOBAL DEFAULT \[VARIANT_PCS\]     1 f_spec_global_default_ifunc
38fe89
+     2: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT  UND f_spec_global_default_undef 	\[VARIANT_PCS\] 
38fe89
+     3: 0000000000008000     0 IFUNC   GLOBAL DEFAULT    1 f_spec_global_default_ifunc 	\[VARIANT_PCS\] 
38fe89
      4: 0000000000008000     0 NOTYPE  GLOBAL DEFAULT    1 f_base_global_default_def
38fe89
-     5: 0000000000008000     0 NOTYPE  GLOBAL DEFAULT \[VARIANT_PCS\]     1 f_spec_global_default_def
38fe89
+     5: 0000000000008000     0 NOTYPE  GLOBAL DEFAULT    1 f_spec_global_default_def 	\[VARIANT_PCS\] 
38fe89
      6: 0000000000008000     0 IFUNC   GLOBAL DEFAULT    1 f_base_global_default_ifunc
38fe89
 
38fe89
 Symbol table '\.symtab' contains 35 entries:
38fe89
@@ -40,28 +40,28 @@ Symbol table '\.symtab' contains 35 entr
38fe89
      7: 00000000000111c8     0 SECTION LOCAL  DEFAULT    7 
38fe89
      8: 0000000000011270     0 SECTION LOCAL  DEFAULT    8 
38fe89
      9: 0000000000000000     0 FILE    LOCAL  DEFAULT  ABS .*variant_pcs-1\.o
38fe89
-    10: 0000000000008000     0 NOTYPE  LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_local
38fe89
-    11: 0000000000008000     0 IFUNC   LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_local_ifunc
38fe89
+    10: 0000000000008000     0 NOTYPE  LOCAL  DEFAULT    1 f_spec_local 	\[VARIANT_PCS\] 
38fe89
+    11: 0000000000008000     0 IFUNC   LOCAL  DEFAULT    1 f_spec_local_ifunc 	\[VARIANT_PCS\] 
38fe89
     12: 0000000000008000     0 IFUNC   LOCAL  DEFAULT    1 f_base_local_ifunc
38fe89
     13: 0000000000008000     0 NOTYPE  LOCAL  DEFAULT    1 f_base_local
38fe89
     14: 0000000000008000     0 NOTYPE  LOCAL  DEFAULT    1 \$x
38fe89
     15: 0000000000000000     0 FILE    LOCAL  DEFAULT  ABS .*variant_pcs-2\.o
38fe89
-    16: 0000000000008038     0 NOTYPE  LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_local2
38fe89
-    17: 0000000000008038     0 IFUNC   LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_local2_ifunc
38fe89
+    16: 0000000000008038     0 NOTYPE  LOCAL  DEFAULT    1 f_spec_local2 	\[VARIANT_PCS\] 
38fe89
+    17: 0000000000008038     0 IFUNC   LOCAL  DEFAULT    1 f_spec_local2_ifunc 	\[VARIANT_PCS\] 
38fe89
     18: 0000000000008038     0 IFUNC   LOCAL  DEFAULT    1 f_base_local2_ifunc
38fe89
     19: 0000000000008038     0 NOTYPE  LOCAL  DEFAULT    1 f_base_local2
38fe89
     20: 0000000000008038     0 NOTYPE  LOCAL  DEFAULT    1 \$x
38fe89
     21: 0000000000000000     0 FILE    LOCAL  DEFAULT  ABS 
38fe89
     22: 0000000000009080     0 OBJECT  LOCAL  DEFAULT  ABS _DYNAMIC
38fe89
-    23: 0000000000008000     0 NOTYPE  LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_global_hidden_def
38fe89
+    23: 0000000000008000     0 NOTYPE  LOCAL  DEFAULT    1 f_spec_global_hidden_def 	\[VARIANT_PCS\] 
38fe89
     24: 0000000000008000     0 IFUNC   LOCAL  DEFAULT    1 f_base_global_hidden_ifunc
38fe89
     25: 0000000000008000     0 NOTYPE  LOCAL  DEFAULT    1 f_base_global_hidden_def
38fe89
     26: 0000000000009000     0 OBJECT  LOCAL  DEFAULT  ABS _GLOBAL_OFFSET_TABLE_
38fe89
-    27: 0000000000008000     0 IFUNC   LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_global_hidden_ifunc
38fe89
+    27: 0000000000008000     0 IFUNC   LOCAL  DEFAULT    1 f_spec_global_hidden_ifunc 	\[VARIANT_PCS\] 
38fe89
     28: 0000000000008070     0 NOTYPE  LOCAL  DEFAULT    2 \$x
38fe89
     29: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT  UND f_base_global_default_undef
38fe89
-    30: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT \[VARIANT_PCS\]   UND f_spec_global_default_undef
38fe89
-    31: 0000000000008000     0 IFUNC   GLOBAL DEFAULT \[VARIANT_PCS\]     1 f_spec_global_default_ifunc
38fe89
+    30: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT  UND f_spec_global_default_undef 	\[VARIANT_PCS\] 
38fe89
+    31: 0000000000008000     0 IFUNC   GLOBAL DEFAULT    1 f_spec_global_default_ifunc 	\[VARIANT_PCS\] 
38fe89
     32: 0000000000008000     0 NOTYPE  GLOBAL DEFAULT    1 f_base_global_default_def
38fe89
-    33: 0000000000008000     0 NOTYPE  GLOBAL DEFAULT \[VARIANT_PCS\]     1 f_spec_global_default_def
38fe89
+    33: 0000000000008000     0 NOTYPE  GLOBAL DEFAULT    1 f_spec_global_default_def 	\[VARIANT_PCS\] 
38fe89
     34: 0000000000008000     0 IFUNC   GLOBAL DEFAULT    1 f_base_global_default_ifunc
38fe89
diff -rup binutils.orig/ld/testsuite/ld-aarch64/variant_pcs-r.d binutils-2.32/ld/testsuite/ld-aarch64/variant_pcs-r.d
38fe89
--- binutils.orig/ld/testsuite/ld-aarch64/variant_pcs-r.d	2019-07-03 10:06:20.012412075 +0100
38fe89
+++ binutils-2.32/ld/testsuite/ld-aarch64/variant_pcs-r.d	2019-07-03 10:14:28.152933189 +0100
38fe89
@@ -37,24 +37,24 @@ Symbol table '\.symtab' contains 26 entr
38fe89
      2: 0000000000000000     0 SECTION LOCAL  DEFAULT    3 
38fe89
      3: 0000000000000000     0 SECTION LOCAL  DEFAULT    4 
38fe89
      4: 0000000000000000     0 FILE    LOCAL  DEFAULT  ABS .*variant_pcs-1\.o
38fe89
-     5: 0000000000000000     0 NOTYPE  LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_local
38fe89
-     6: 0000000000000000     0 IFUNC   LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_local_ifunc
38fe89
+     5: 0000000000000000     0 NOTYPE  LOCAL  DEFAULT    1 f_spec_local 	\[VARIANT_PCS\] 
38fe89
+     6: 0000000000000000     0 IFUNC   LOCAL  DEFAULT    1 f_spec_local_ifunc 	\[VARIANT_PCS\] 
38fe89
      7: 0000000000000000     0 IFUNC   LOCAL  DEFAULT    1 f_base_local_ifunc
38fe89
      8: 0000000000000000     0 NOTYPE  LOCAL  DEFAULT    1 f_base_local
38fe89
      9: 0000000000000000     0 NOTYPE  LOCAL  DEFAULT    1 \$x
38fe89
     10: 0000000000000000     0 FILE    LOCAL  DEFAULT  ABS .*variant_pcs-2\.o
38fe89
-    11: 0000000000000038     0 NOTYPE  LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_local2
38fe89
-    12: 0000000000000038     0 IFUNC   LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_local2_ifunc
38fe89
+    11: 0000000000000038     0 NOTYPE  LOCAL  DEFAULT    1 f_spec_local2 	\[VARIANT_PCS\] 
38fe89
+    12: 0000000000000038     0 IFUNC   LOCAL  DEFAULT    1 f_spec_local2_ifunc 	\[VARIANT_PCS\] 
38fe89
     13: 0000000000000038     0 IFUNC   LOCAL  DEFAULT    1 f_base_local2_ifunc
38fe89
     14: 0000000000000038     0 NOTYPE  LOCAL  DEFAULT    1 f_base_local2
38fe89
     15: 0000000000000038     0 NOTYPE  LOCAL  DEFAULT    1 \$x
38fe89
     16: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT  UND f_base_global_default_undef
38fe89
-    17: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT \[VARIANT_PCS\]   UND f_spec_global_default_undef
38fe89
-    18: 0000000000000000     0 NOTYPE  GLOBAL HIDDEN  \[VARIANT_PCS\]     1 f_spec_global_hidden_def
38fe89
+    17: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT  UND f_spec_global_default_undef 	\[VARIANT_PCS\] 
38fe89
+    18: 0000000000000000     0 NOTYPE  GLOBAL HIDDEN     1 f_spec_global_hidden_def 	\[VARIANT_PCS\] 
38fe89
     19: 0000000000000000     0 IFUNC   GLOBAL HIDDEN     1 f_base_global_hidden_ifunc
38fe89
-    20: 0000000000000000     0 IFUNC   GLOBAL DEFAULT \[VARIANT_PCS\]     1 f_spec_global_default_ifunc
38fe89
+    20: 0000000000000000     0 IFUNC   GLOBAL DEFAULT    1 f_spec_global_default_ifunc 	\[VARIANT_PCS\] 
38fe89
     21: 0000000000000000     0 NOTYPE  GLOBAL HIDDEN     1 f_base_global_hidden_def
38fe89
-    22: 0000000000000000     0 IFUNC   GLOBAL HIDDEN  \[VARIANT_PCS\]     1 f_spec_global_hidden_ifunc
38fe89
+    22: 0000000000000000     0 IFUNC   GLOBAL HIDDEN     1 f_spec_global_hidden_ifunc 	\[VARIANT_PCS\] 
38fe89
     23: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT    1 f_base_global_default_def
38fe89
-    24: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT \[VARIANT_PCS\]     1 f_spec_global_default_def
38fe89
+    24: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT    1 f_spec_global_default_def 	\[VARIANT_PCS\] 
38fe89
     25: 0000000000000000     0 IFUNC   GLOBAL DEFAULT    1 f_base_global_default_ifunc
38fe89
diff -rup binutils.orig/ld/testsuite/ld-aarch64/variant_pcs-shared.d binutils-2.32/ld/testsuite/ld-aarch64/variant_pcs-shared.d
38fe89
--- binutils.orig/ld/testsuite/ld-aarch64/variant_pcs-shared.d	2019-07-03 10:06:20.012412075 +0100
38fe89
+++ binutils-2.32/ld/testsuite/ld-aarch64/variant_pcs-shared.d	2019-07-03 10:19:00.760994532 +0100
38fe89
@@ -22,10 +22,10 @@ Symbol table '\.dynsym' contains 7 entri
38fe89
    Num:    Value          Size Type    Bind   Vis      Ndx Name
38fe89
      0: 0000000000000000     0 NOTYPE  LOCAL  DEFAULT  UND 
38fe89
      1: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT  UND f_base_global_default_undef
38fe89
-     2: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT \[VARIANT_PCS\]   UND f_spec_global_default_undef
38fe89
-     3: 0000000000008000     0 IFUNC   GLOBAL DEFAULT \[VARIANT_PCS\]     1 f_spec_global_default_ifunc
38fe89
+     2: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT  UND f_spec_global_default_undef 	\[VARIANT_PCS\] 
38fe89
+     3: 0000000000008000     0 IFUNC   GLOBAL DEFAULT    1 f_spec_global_default_ifunc 	\[VARIANT_PCS\] 
38fe89
      4: 0000000000008000     0 NOTYPE  GLOBAL DEFAULT    1 f_base_global_default_def
38fe89
-     5: 0000000000008000     0 NOTYPE  GLOBAL DEFAULT \[VARIANT_PCS\]     1 f_spec_global_default_def
38fe89
+     5: 0000000000008000     0 NOTYPE  GLOBAL DEFAULT    1 f_spec_global_default_def 	\[VARIANT_PCS\] 
38fe89
      6: 0000000000008000     0 IFUNC   GLOBAL DEFAULT    1 f_base_global_default_ifunc
38fe89
 
38fe89
 Symbol table '\.symtab' contains 35 entries:
38fe89
@@ -40,28 +40,28 @@ Symbol table '\.symtab' contains 35 entr
38fe89
      7: 00000000000111c8     0 SECTION LOCAL  DEFAULT    7 
38fe89
      8: 0000000000011270     0 SECTION LOCAL  DEFAULT    8 
38fe89
      9: 0000000000000000     0 FILE    LOCAL  DEFAULT  ABS .*variant_pcs-1\.o
38fe89
-    10: 0000000000008000     0 NOTYPE  LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_local
38fe89
-    11: 0000000000008000     0 IFUNC   LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_local_ifunc
38fe89
+    10: 0000000000008000     0 NOTYPE  LOCAL  DEFAULT    1 f_spec_local 	\[VARIANT_PCS\] 
38fe89
+    11: 0000000000008000     0 IFUNC   LOCAL  DEFAULT    1 f_spec_local_ifunc 	\[VARIANT_PCS\] 
38fe89
     12: 0000000000008000     0 IFUNC   LOCAL  DEFAULT    1 f_base_local_ifunc
38fe89
     13: 0000000000008000     0 NOTYPE  LOCAL  DEFAULT    1 f_base_local
38fe89
     14: 0000000000008000     0 NOTYPE  LOCAL  DEFAULT    1 \$x
38fe89
     15: 0000000000000000     0 FILE    LOCAL  DEFAULT  ABS .*variant_pcs-2\.o
38fe89
-    16: 0000000000008038     0 NOTYPE  LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_local2
38fe89
-    17: 0000000000008038     0 IFUNC   LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_local2_ifunc
38fe89
+    16: 0000000000008038     0 NOTYPE  LOCAL  DEFAULT    1 f_spec_local2 	\[VARIANT_PCS\] 
38fe89
+    17: 0000000000008038     0 IFUNC   LOCAL  DEFAULT    1 f_spec_local2_ifunc 	\[VARIANT_PCS\] 
38fe89
     18: 0000000000008038     0 IFUNC   LOCAL  DEFAULT    1 f_base_local2_ifunc
38fe89
     19: 0000000000008038     0 NOTYPE  LOCAL  DEFAULT    1 f_base_local2
38fe89
     20: 0000000000008038     0 NOTYPE  LOCAL  DEFAULT    1 \$x
38fe89
     21: 0000000000000000     0 FILE    LOCAL  DEFAULT  ABS 
38fe89
     22: 0000000000009080     0 OBJECT  LOCAL  DEFAULT  ABS _DYNAMIC
38fe89
-    23: 0000000000008000     0 NOTYPE  LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_global_hidden_def
38fe89
+    23: 0000000000008000     0 NOTYPE  LOCAL  DEFAULT    1 f_spec_global_hidden_def 	\[VARIANT_PCS\] 
38fe89
     24: 0000000000008000     0 IFUNC   LOCAL  DEFAULT    1 f_base_global_hidden_ifunc
38fe89
     25: 0000000000008000     0 NOTYPE  LOCAL  DEFAULT    1 f_base_global_hidden_def
38fe89
     26: 0000000000009000     0 OBJECT  LOCAL  DEFAULT  ABS _GLOBAL_OFFSET_TABLE_
38fe89
-    27: 0000000000008000     0 IFUNC   LOCAL  DEFAULT \[VARIANT_PCS\]     1 f_spec_global_hidden_ifunc
38fe89
+    27: 0000000000008000     0 IFUNC   LOCAL  DEFAULT    1 f_spec_global_hidden_ifunc 	\[VARIANT_PCS\] 
38fe89
     28: 0000000000008070     0 NOTYPE  LOCAL  DEFAULT    2 \$x
38fe89
     29: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT  UND f_base_global_default_undef
38fe89
-    30: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT \[VARIANT_PCS\]   UND f_spec_global_default_undef
38fe89
-    31: 0000000000008000     0 IFUNC   GLOBAL DEFAULT \[VARIANT_PCS\]     1 f_spec_global_default_ifunc
38fe89
+    30: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT  UND f_spec_global_default_undef 	\[VARIANT_PCS\] 
38fe89
+    31: 0000000000008000     0 IFUNC   GLOBAL DEFAULT    1 f_spec_global_default_ifunc 	\[VARIANT_PCS\] 
38fe89
     32: 0000000000008000     0 NOTYPE  GLOBAL DEFAULT    1 f_base_global_default_def
38fe89
-    33: 0000000000008000     0 NOTYPE  GLOBAL DEFAULT \[VARIANT_PCS\]     1 f_spec_global_default_def
38fe89
+    33: 0000000000008000     0 NOTYPE  GLOBAL DEFAULT    1 f_spec_global_default_def 	\[VARIANT_PCS\] 
38fe89
     34: 0000000000008000     0 IFUNC   GLOBAL DEFAULT    1 f_base_global_default_ifunc