|
 |
843f86 |
commit 7a86d66f27a8c657a3cd9fbecdf26d167c2ee92e
|
|
|
843f86 |
Author: Thomas Woerner <twoerner@redhat.com>
|
|
|
843f86 |
Date: Wed Apr 26 15:07:18 2017 +0200
|
|
|
843f86 |
|
|
|
843f86 |
firewall-cmd: Fix --{set,get}-{short,description} for zone
|
|
|
843f86 |
|
|
|
843f86 |
The options --{set,get}-{short,description} have been used on the wrong object
|
|
|
843f86 |
in firewall-cmd which resulted in a back trace.
|
|
|
843f86 |
|
|
|
843f86 |
Fixes: RHBZ#1445238
|
|
|
843f86 |
|
|
|
843f86 |
diff --git a/src/firewall-cmd b/src/firewall-cmd
|
|
|
843f86 |
index 9988a79..1a864b3 100755
|
|
|
843f86 |
--- a/src/firewall-cmd
|
|
|
843f86 |
+++ b/src/firewall-cmd
|
|
|
843f86 |
@@ -1987,31 +1987,31 @@ if a.permanent:
|
|
|
843f86 |
elif a.list_all_zones:
|
|
|
843f86 |
names = fw.config().getZoneNames()
|
|
|
843f86 |
for zone in sorted(names):
|
|
|
843f86 |
- settings = fw.config().getZoneByName(zone)
|
|
|
843f86 |
- cmd.print_zone_info(zone, settings.getSettings())
|
|
|
843f86 |
+ settings = fw.config().getZoneByName(zone).getSettings()
|
|
|
843f86 |
+ cmd.print_zone_info(zone, settings)
|
|
|
843f86 |
cmd.print_msg("")
|
|
|
843f86 |
sys.exit(0)
|
|
|
843f86 |
|
|
|
843f86 |
# set zone description
|
|
|
843f86 |
elif a.set_description:
|
|
|
843f86 |
- settings = fw.config().getZoneByName(zone)
|
|
|
843f86 |
+ settings = fw.config().getZoneByName(zone).getSettings()
|
|
|
843f86 |
settings.setDescription(a.set_description)
|
|
|
843f86 |
fw_zone.update(settings)
|
|
|
843f86 |
|
|
|
843f86 |
# get zone description
|
|
|
843f86 |
elif a.get_description:
|
|
|
843f86 |
- settings = fw.config().getZoneByName(zone)
|
|
|
843f86 |
+ settings = fw.config().getZoneByName(zone).getSettings()
|
|
|
843f86 |
cmd.print_and_exit(settings.getDescription())
|
|
|
843f86 |
|
|
|
843f86 |
# set zone short description
|
|
|
843f86 |
elif a.set_short:
|
|
|
843f86 |
- settings = fw.config().getZoneByName(zone)
|
|
|
843f86 |
+ settings = fw.config().getZoneByName(zone).getSettings()
|
|
|
843f86 |
settings.setShort(a.set_short)
|
|
|
843f86 |
fw_zone.update(settings)
|
|
|
843f86 |
|
|
|
843f86 |
# get zone short description
|
|
|
843f86 |
elif a.get_short:
|
|
|
843f86 |
- settings = fw.config().getZoneByName(zone)
|
|
|
843f86 |
+ settings = fw.config().getZoneByName(zone).getSettings()
|
|
|
843f86 |
cmd.print_and_exit(settings.getShort())
|
|
|
843f86 |
|
|
|
843f86 |
elif a.version:
|