Blame SOURCES/firewalld-0.3.9-RHBZ#1122739,1128563.patch

3d17f4
commit 302d7f28fb9c09d624e34d9b9966a7d2974bbd3a
3d17f4
Author: Jiri Popelka <jpopelka@redhat.com>
3d17f4
Date:   Thu Aug 14 14:44:13 2014 +0200
3d17f4
3d17f4
    man: '--permanent --add-interface' vs. ZONE= in ifcfg (RHBZ#1128563)
3d17f4
3d17f4
diff --git a/doc/xml/firewall-cmd.xml b/doc/xml/firewall-cmd.xml
3d17f4
index 44f6799..dabb9a4 100644
3d17f4
--- a/doc/xml/firewall-cmd.xml
3d17f4
+++ b/doc/xml/firewall-cmd.xml
3d17f4
@@ -648,8 +648,10 @@
3d17f4
 	      Bind interface <replaceable>interface</replaceable> to zone <replaceable>zone</replaceable>. If zone is omitted, default zone will be used.
3d17f4
 	    </para>
3d17f4
 	    <para>
3d17f4
-	      As a end user you don't need this in most cases, because NetworkManager adds interfaces into zones automatically.
3d17f4
-	      For permanent association of interface with a zone, see 'How to set or change a zone for a connection?' in <citerefentry><refentrytitle>firewalld.zones</refentrytitle><manvolnum>5</manvolnum></citerefentry>.
3d17f4
+	      As a end user you don't need this in most cases, because NetworkManager (or legacy network service) adds interfaces into zones automatically (according to <option>ZONE=</option> option from ifcfg-<replaceable>interface</replaceable> file).
3d17f4
+	      You should do it only if there's no /etc/sysconfig/network-scripts/ifcfg-<replaceable>interface</replaceable> file.
3d17f4
+	      If there is such file and you add interface to zone with this <option>--add-interface</option> option, make sure the zone is the same in both cases, otherwise the behaviour would be undefined.
3d17f4
+	      For permanent association of interface with a zone, see also 'How to set or change a zone for a connection?' in <citerefentry><refentrytitle>firewalld.zones</refentrytitle><manvolnum>5</manvolnum></citerefentry>.
3d17f4
 	    </para>
3d17f4
 	  </listitem>
3d17f4
 	</varlistentry>
3d17f4
diff --git a/doc/xml/firewalld.xml b/doc/xml/firewalld.xml
3d17f4
index 4ccf4e3..24d7541 100644
3d17f4
--- a/doc/xml/firewalld.xml
3d17f4
+++ b/doc/xml/firewalld.xml
3d17f4
@@ -123,7 +123,12 @@
3d17f4
       firewalld provides support for zones, predefined services and ICMP types and has a separation of runtime and permanent configuration options. Permanent configuration is loaded from XML files in <filename class="directory">/usr/lib/firewalld</filename> or <filename class="directory">/etc/firewalld</filename> (see <xref linkend="directories"/>).
3d17f4
     </para>
3d17f4
     <para>
3d17f4
-      If NetworkManager is not used, there are some limitations: firewalld will not get notified about network device renames. If firewalld gets started after the network is already up, the connections are not bound to a zone. Manually created interfaces are not bound to a zone. Please add them to a zone with <command>firewall-cmd --zone=zone --add-interface=interface</command>.
3d17f4
+      If NetworkManager is not used, there are some limitations: firewalld will not get notified about network device renames.
3d17f4
+      If firewalld gets started after the network is already up, the connections and manually created interfaces are not bound to a zone.
3d17f4
+      You can add them to a zone with <command>firewall-cmd [--permanent] --zone=<replaceable>zone</replaceable> --add-interface=<replaceable>interface</replaceable></command>,
3d17f4
+      but make sure that if there's a /etc/sysconfig/network-scripts/ifcfg-<replaceable>interface</replaceable>,
3d17f4
+      the zone specified there with ZONE=<replaceable>zone</replaceable>
3d17f4
+      is the same (or both are empty/missing for default zone), otherwise the behaviour would be undefined.
3d17f4
     </para>
3d17f4
 
3d17f4
     <refsect2>
3d17f4
commit f0d25a618c26dc47c552e63ac7d7c9a2c57151b7
3d17f4
Author: Thomas Woerner <twoerner@redhat.com>
3d17f4
Date:   Tue Jul 7 10:32:31 2015 +0200
3d17f4
3d17f4
    man: Interface handling with and without NetworkManager (RHBZ#1122739 RHBZ#1128563)
3d17f4
3d17f4
diff --git a/doc/xml/firewall-cmd.xml b/doc/xml/firewall-cmd.xml
3d17f4
index 74c9e1c..8603ca8 100644
3d17f4
--- a/doc/xml/firewall-cmd.xml
3d17f4
+++ b/doc/xml/firewall-cmd.xml
3d17f4
@@ -660,9 +660,10 @@
3d17f4
 	      Bind interface <replaceable>interface</replaceable> to zone <replaceable>zone</replaceable>. If zone is omitted, default zone will be used.
3d17f4
 	    </para>
3d17f4
 	    <para>
3d17f4
-	      As a end user you don't need this in most cases, because NetworkManager (or legacy network service) adds interfaces into zones automatically (according to <option>ZONE=</option> option from ifcfg-<replaceable>interface</replaceable> file).
3d17f4
+	      As a end user you don't need this in most cases, because NetworkManager (or legacy network service) adds interfaces into zones automatically (according to <option>ZONE=</option> option from ifcfg-<replaceable>interface</replaceable> file) if <replaceable>NM_CONTROLLED=no</replaceable> is not set.
3d17f4
 	      You should do it only if there's no /etc/sysconfig/network-scripts/ifcfg-<replaceable>interface</replaceable> file.
3d17f4
 	      If there is such file and you add interface to zone with this <option>--add-interface</option> option, make sure the zone is the same in both cases, otherwise the behaviour would be undefined.
3d17f4
+	      Please also have a look at the <citerefentry><refentrytitle>firewalld</refentrytitle><manvolnum>1</manvolnum></citerefentry> man page in the <replaceable>Concepts</replaceable> section.
3d17f4
 	      For permanent association of interface with a zone, see also 'How to set or change a zone for a connection?' in <citerefentry><refentrytitle>firewalld.zones</refentrytitle><manvolnum>5</manvolnum></citerefentry>.
3d17f4
 	    </para>
3d17f4
 	  </listitem>
3d17f4
diff --git a/doc/xml/firewalld.xml b/doc/xml/firewalld.xml
3d17f4
index df26ff7..ee16cd0 100644
3d17f4
--- a/doc/xml/firewalld.xml
3d17f4
+++ b/doc/xml/firewalld.xml
3d17f4
@@ -123,13 +123,24 @@
3d17f4
       firewalld provides support for zones, predefined services and ICMP types and has a separation of runtime and permanent configuration options. Permanent configuration is loaded from XML files in <filename class="directory">/usr/lib/firewalld</filename> or <filename class="directory">/etc/firewalld</filename> (see <xref linkend="directories"/>).
3d17f4
     </para>
3d17f4
     <para>
3d17f4
-      If NetworkManager is not used, there are some limitations: firewalld will not get notified about network device renames.
3d17f4
-      If firewalld gets started after the network is already up, the connections and manually created interfaces are not bound to a zone.
3d17f4
-      You can add them to a zone with <command>firewall-cmd [--permanent] --zone=<replaceable>zone</replaceable> --add-interface=<replaceable>interface</replaceable></command>,
3d17f4
+      If NetworkManager is not in use and firewalld gets started after the network is already up, the connections and manually created interfaces are not bound to the zone specified in the ifcfg file.
3d17f4
+      The interfaces will automatically be handled by the default zone.
3d17f4
+      firewalld will also not get notified about network device renames.
3d17f4
+      All this also applies to interfaces that are not controlled by NetworkManager if <replaceable>NM_CONTROLLED=no</replaceable> is set.
3d17f4
+    </para>
3d17f4
+    <para>
3d17f4
+      You can add these interfaces to a zone with <command>firewall-cmd [--permanent] --zone=<replaceable>zone</replaceable> --add-interface=<replaceable>interface</replaceable></command>,
3d17f4
       but make sure that if there's a /etc/sysconfig/network-scripts/ifcfg-<replaceable>interface</replaceable>,
3d17f4
       the zone specified there with ZONE=<replaceable>zone</replaceable>
3d17f4
       is the same (or both are empty/missing for default zone), otherwise the behaviour would be undefined.
3d17f4
     </para>
3d17f4
+    <para>
3d17f4
+      If firewalld gets reloaded, it will restore the interface bindings that were in place before reloading to keep interface bindings stable in the case of NetworkManager uncontrolled interfaces.
3d17f4
+      This mechanism is not possible in the case of a firewalld service restart.
3d17f4
+    </para>
3d17f4
+    <para>
3d17f4
+      It is essential to keep the ZONE= setting in the ifcfg file consistent to the binding in firewalld in the case of NetworkManager uncontrolled interfaces.
3d17f4
+    </para>
3d17f4
 
3d17f4
     <refsect2>
3d17f4
       <title>Zones</title>