|
 |
66253d |
From e84f00aee61d5055c2da2c9c1aff683f20b84f56 Mon Sep 17 00:00:00 2001
|
|
|
66253d |
From: Eric Garver <eric@garver.life>
|
|
|
66253d |
Date: Tue, 4 Feb 2020 13:12:31 -0500
|
|
|
66253d |
Subject: [PATCH 38/39] fix: firewall-offline-cmd: Don't print warning about
|
|
|
66253d |
AllowZoneDrifting
|
|
|
66253d |
|
|
|
66253d |
If we're called from firewall-offline-cmd, don't log the warning. It's
|
|
|
66253d |
overly verbose to warn on every invocation.
|
|
|
66253d |
|
|
|
66253d |
Fixes: afadd377b09d ("feat: AllowZoneDrifting config option")
|
|
|
66253d |
(cherry picked from commit eefcb1a712ffca5e08dcefa6aa17c935c16b835f)
|
|
|
66253d |
(cherry picked from commit ba1f1a744ca543b4e9359ab26b4b1f9ff70fcb64)
|
|
|
66253d |
---
|
|
|
66253d |
src/firewall/core/fw.py | 9 +++++----
|
|
|
66253d |
1 file changed, 5 insertions(+), 4 deletions(-)
|
|
|
66253d |
|
|
|
66253d |
diff --git a/src/firewall/core/fw.py b/src/firewall/core/fw.py
|
|
|
66253d |
index 6206ed586988..ebadd6cce20e 100644
|
|
|
66253d |
--- a/src/firewall/core/fw.py
|
|
|
66253d |
+++ b/src/firewall/core/fw.py
|
|
|
66253d |
@@ -293,10 +293,11 @@ class Firewall(object):
|
|
|
66253d |
self._allow_zone_drifting = False
|
|
|
66253d |
else:
|
|
|
66253d |
self._allow_zone_drifting = True
|
|
|
66253d |
- log.warning("AllowZoneDrifting is enabled. This is considered "
|
|
|
66253d |
- "an insecure configuration option. It will be "
|
|
|
66253d |
- "removed in a future release. Please consider "
|
|
|
66253d |
- "disabling it now.")
|
|
|
66253d |
+ if not self._offline:
|
|
|
66253d |
+ log.warning("AllowZoneDrifting is enabled. This is considered "
|
|
|
66253d |
+ "an insecure configuration option. It will be "
|
|
|
66253d |
+ "removed in a future release. Please consider "
|
|
|
66253d |
+ "disabling it now.")
|
|
|
66253d |
log.debug1("AllowZoneDrifting is set to '%s'",
|
|
|
66253d |
self._allow_zone_drifting)
|
|
|
66253d |
|
|
|
66253d |
--
|
|
|
66253d |
2.23.0
|
|
|
66253d |
|