24f428
From 1be85646ad9277008dfc2e7fb48a5ca5af9a176a Mon Sep 17 00:00:00 2001
24f428
From: Daniel Nicolai <dalanicolai@gmail.com>
24f428
Date: Mon, 11 Feb 2019 12:16:31 +0100
24f428
Subject: [PATCH 19/23] fix issue #457
24f428
24f428
I found out I did not set a value for invert when adding the rich rule via firewall-cmd. Then I got the error as mentioned in issue #457 because the invert attribute was given a default value None. I corrected it here so that it gets the default value False. This fixed the issue for me.
24f428
24f428
(cherry picked from commit 7da05eff467244f0da6a4e7c1370dd6c7605e9f4)
24f428
---
24f428
 src/firewall/core/rich.py | 2 +-
24f428
 1 file changed, 1 insertion(+), 1 deletion(-)
24f428
24f428
diff --git a/src/firewall/core/rich.py b/src/firewall/core/rich.py
24f428
index 04791da612a2..ad8808556729 100644
24f428
--- a/src/firewall/core/rich.py
24f428
+++ b/src/firewall/core/rich.py
24f428
@@ -385,7 +385,7 @@ class Rich_Rule(object):
24f428
                 elif element in ['not', 'NOT']:
24f428
                     attrs['invert'] = True
24f428
                 else:
24f428
-                    self.source = Rich_Source(attrs.get('address'), attrs.get('mac'), attrs.get('ipset'), attrs.get('invert'))
24f428
+                    self.source = Rich_Source(attrs.get('address'), attrs.get('mac'), attrs.get('ipset'), attrs.get('invert', False))
24f428
                     in_elements.pop() # source
24f428
                     attrs.clear()
24f428
                     index = index -1 # return token to input
24f428
-- 
24f428
2.20.1
24f428