83e1c4
commit 0b91f8a668201fc58fa732b8acc496caedfdbae0
83e1c4
Author: Florian Weimer <fw@deneb.enyo.de>
83e1c4
Date:   Sun Apr 29 12:18:33 2018 -0700
83e1c4
83e1c4
    Indicate that _PyGC_Head is only 8-byte aligned. (closes bpo-33374)
83e1c4
83e1c4
    By spec, the "long double" in _PyGC_Head requires the union to always be 16-byte
83e1c4
    aligned. However, obmalloc only yields 8-byte alignment. Compilers including GCC
83e1c4
    8 are starting to use alignment information to do store-merging. So, the "long
83e1c4
    double" needs to be changed to a simple "double" as was long ago done in Python
83e1c4
    3 by e348c8d154cf6342c79d627ebfe89dfe9de23817. For 2.7, we need to add some
83e1c4
    dummy padding to make sure _PyGC_Head stays the same size.
83e1c4
83e1c4
diff --git a/Include/objimpl.h b/Include/objimpl.h
83e1c4
index 5f28683329..cbf6bc3f87 100644
83e1c4
--- Python-2.7.13/Include/objimpl.h
83e1c4
+++ Python-2.7.13/Include/objimpl.h
83e1c4
@@ -248,6 +248,20 @@ PyAPI_FUNC(PyVarObject *) _PyObject_GC_Resize(PyVarObject *, Py_ssize_t);
83e1c4
 /* for source compatibility with 2.2 */
83e1c4
 #define _PyObject_GC_Del PyObject_GC_Del
83e1c4
83e1c4
+/*
83e1c4
+ * Former over-aligned definition of PyGC_Head, used to compute the size of the
83e1c4
+ * padding for the new version below.
83e1c4
+ */
83e1c4
+union _gc_head;
83e1c4
+union _gc_head_old {
83e1c4
+    struct {
83e1c4
+        union _gc_head_old *gc_next;
83e1c4
+        union _gc_head_old *gc_prev;
83e1c4
+        Py_ssize_t gc_refs;
83e1c4
+    } gc;
83e1c4
+    long double dummy;
83e1c4
+};
83e1c4
+
83e1c4
 /* GC information is stored BEFORE the object structure. */
83e1c4
 typedef union _gc_head {
83e1c4
     struct {
83e1c4
@@ -255,7 +269,8 @@ typedef union _gc_head {
83e1c4
         union _gc_head *gc_prev;
83e1c4
         Py_ssize_t gc_refs;
83e1c4
     } gc;
83e1c4
-    long double dummy;  /* force worst-case alignment */
83e1c4
+    double dummy; /* Force at least 8-byte alignment. */
83e1c4
+    char dummy_padding[sizeof(union _gc_head_old)];
83e1c4
 } PyGC_Head;
83e1c4
83e1c4
 extern PyGC_Head *_PyGC_generation0;
83e1c4
diff --git a/Misc/NEWS.d/next/Core and Builtins/2018-04-29-12-07-00.bpo-33374.-xegL6.rst b/Misc/NEWS.d/next/Core and Builtins/2018-04-29-12-07-00.bpo-33374.-xegL6.rst
83e1c4
new file mode 100644
83e1c4
index 0000000000..9ec1a605c8
83e1c4
--- /dev/null
83e1c4
+++ Python-2.7.13/Misc/NEWS.d/next/Core and Builtins/2018-04-29-12-07-00.bpo-33374.-xegL6.rst
83e1c4
@@ -0,0 +1,3 @@
83e1c4
+Tweak the definition of PyGC_Head, so compilers do not believe it is always
83e1c4
+16-byte aligned on x86. This prevents crashes with more aggressive
83e1c4
+optimizations present in GCC 8.