Blame SOURCES/file-5.33-bound-file_strncmp.patch

1f6a13
diff -urp file-5.33.orig/src/softmagic.c file-5.33/src/softmagic.c
1f6a13
--- file-5.33.orig/src/softmagic.c	2020-12-14 12:26:50.286849841 -0500
1f6a13
+++ file-5.33/src/softmagic.c	2020-12-14 12:35:52.679166211 -0500
1f6a13
@@ -1748,7 +1748,8 @@ mget(struct magic_set *ms, struct magic
1f6a13
 }
1f6a13
 
1f6a13
 private uint64_t
1f6a13
-file_strncmp(const char *s1, const char *s2, size_t len, uint32_t flags)
1f6a13
+file_strncmp(const char *s1, const char *s2, size_t len, size_t maxlen,
1f6a13
+    uint32_t flags)
1f6a13
 {
1f6a13
 	/*
1f6a13
 	 * Convert the source args to unsigned here so that (1) the
1f6a13
@@ -1760,7 +1761,7 @@ file_strncmp(const char *s1, const char
1f6a13
 	const unsigned char *b = (const unsigned char *)s2;
1f6a13
 	uint32_t ws = flags & (STRING_COMPACT_WHITESPACE |
1f6a13
 		STRING_COMPACT_OPTIONAL_WHITESPACE);
1f6a13
-	const unsigned char *eb = b + (ws ? strlen(s2) : len);
1f6a13
+	const unsigned char *eb = b + (ws ? maxlen : len);
1f6a13
 	uint64_t v;
1f6a13
 
1f6a13
 	/*
1f6a13
@@ -1818,7 +1819,8 @@ file_strncmp(const char *s1, const char
1f6a13
 }
1f6a13
 
1f6a13
 private uint64_t
1f6a13
-file_strncmp16(const char *a, const char *b, size_t len, uint32_t flags)
1f6a13
+file_strncmp16(const char *a, const char *b, size_t len, size_t maxlen,
1f6a13
+    uint32_t flags)
1f6a13
 {
1f6a13
 	/*
1f6a13
 	 * XXX - The 16-bit string compare probably needs to be done
1f6a13
@@ -1826,7 +1828,7 @@ file_strncmp16(const char *a, const char
1f6a13
 	 * At the moment, I am unsure.
1f6a13
 	 */
1f6a13
 	flags = 0;
1f6a13
-	return file_strncmp(a, b, len, flags);
1f6a13
+	return file_strncmp(a, b, len, maxlen, flags);
1f6a13
 }
1f6a13
 
1f6a13
 private int
1f6a13
@@ -1954,13 +1956,15 @@ magiccheck(struct magic_set *ms, struct
1f6a13
 	case FILE_STRING:
1f6a13
 	case FILE_PSTRING:
1f6a13
 		l = 0;
1f6a13
-		v = file_strncmp(m->value.s, p->s, (size_t)m->vallen, m->str_flags);
1f6a13
+		v = file_strncmp(m->value.s, p->s, (size_t)m->vallen,
1f6a13
+		       sizeof(p->s), m->str_flags);
1f6a13
 		break;
1f6a13
 
1f6a13
 	case FILE_BESTRING16:
1f6a13
 	case FILE_LESTRING16:
1f6a13
 		l = 0;
1f6a13
-		v = file_strncmp16(m->value.s, p->s, (size_t)m->vallen, m->str_flags);
1f6a13
+		v = file_strncmp16(m->value.s, p->s, (size_t)m->vallen,
1f6a13
+		       sizeof(p->s), m->str_flags);
1f6a13
 		break;
1f6a13
 
1f6a13
 	case FILE_SEARCH: { /* search ms->search.s for the string m->value.s */
1f6a13
@@ -1979,7 +1983,7 @@ magiccheck(struct magic_set *ms, struct
1f6a13
 				return 0;
1f6a13
 
1f6a13
 			v = file_strncmp(m->value.s, ms->search.s + idx, slen,
1f6a13
-			    m->str_flags);
1f6a13
+			    ms->search.s_len - idx, m->str_flags);
1f6a13
 			if (v == 0) {	/* found match */
1f6a13
 				ms->search.offset += idx;
1f6a13
 				ms->search.rm_len = ms->search.s_len - idx;