435ea7
From 1803228597e82218a8c105e67975bc50e6f5bf0d Mon Sep 17 00:00:00 2001
435ea7
From: Remi Collet <remi@php.net>
435ea7
Date: Wed, 22 Oct 2014 15:37:04 +0200
435ea7
Subject: [PATCH] Fix bug #68283: fileinfo: out-of-bounds read in elf note
435ea7
 headers
435ea7
435ea7
Upstream commit
435ea7
https://github.com/file/file/commit/39c7ac1106be844a5296d3eb5971946cc09ffda0
435ea7
435ea7
CVE -2014-3710
435ea7
---
435ea7
 ext/fileinfo/libmagic/readelf.c | 7 +++++++
435ea7
 1 file changed, 7 insertions(+)
435ea7
435ea7
diff --git a/ext/fileinfo/libmagic/readelf.c b/ext/fileinfo/libmagic/readelf.c
435ea7
index 1c3845f..bb6f70f 100644
435ea7
--- a/src/readelf.c
435ea7
+++ b/src/readelf.c
435ea7
@@ -366,6 +366,13 @@ donote(struct magic_set *ms, void *vbuf, size_t offset, size_t size,
435ea7
 	uint32_t namesz, descsz;
435ea7
 	unsigned char *nbuf = CAST(unsigned char *, vbuf);
435ea7
 
435ea7
+	if (xnh_sizeof + offset > size) {
435ea7
+		/*
435ea7
+		 * We're out of note headers.
435ea7
+		 */
435ea7
+		return xnh_sizeof + offset;
435ea7
+	}
435ea7
+
435ea7
 	(void)memcpy(xnh_addr, &nbuf[offset], xnh_sizeof);
435ea7
 	offset += xnh_sizeof;
435ea7
 
435ea7
-- 
435ea7
2.1.0
435ea7