|
 |
89be67 |
From 68ce2d0ea6da79b12a365e375e1c2ce882c77480 Mon Sep 17 00:00:00 2001
|
|
|
89be67 |
From: Stanislav Malyshev <stas@php.net>
|
|
|
89be67 |
Date: Mon, 26 May 2014 17:50:14 -0700
|
|
|
89be67 |
Subject: [PATCH] Fix bug #67328 (fileinfo: numerous file_printf calls
|
|
|
89be67 |
resulting in performance degradation)
|
|
|
89be67 |
|
|
|
89be67 |
Upstream patch: https://github.com/file/file/commit/b8acc83781d5a24cc5101e525d15efe0482c280d
|
|
|
89be67 |
---
|
|
|
89be67 |
ext/fileinfo/libmagic/cdf.c | 16 ++++------------
|
|
|
89be67 |
1 file changed, 4 insertions(+), 12 deletions(-)
|
|
|
89be67 |
|
|
|
89be67 |
diff --git a/ext/fileinfo/libmagic/cdf.c b/ext/fileinfo/libmagic/cdf.c
|
|
|
89be67 |
index dd7177e..8dacd2f 100644
|
|
|
89be67 |
--- a/src/cdf.c
|
|
|
89be67 |
+++ b/src/cdf.c
|
|
|
89be67 |
@@ -929,7 +929,7 @@ int
|
|
|
89be67 |
cdf_unpack_summary_info(const cdf_stream_t *sst, const cdf_header_t *h,
|
|
|
89be67 |
cdf_summary_info_header_t *ssi, cdf_property_info_t **info, size_t *count)
|
|
|
89be67 |
{
|
|
|
89be67 |
- size_t i, maxcount;
|
|
|
89be67 |
+ size_t maxcount;
|
|
|
89be67 |
const cdf_summary_info_header_t *si =
|
|
|
89be67 |
CAST(const cdf_summary_info_header_t *, sst->sst_tab);
|
|
|
89be67 |
const cdf_section_declaration_t *sd =
|
|
|
89be67 |
@@ -944,21 +944,13 @@ cdf_unpack_summary_info(const cdf_stream_t *sst, const cdf_header_t *h,
|
|
|
89be67 |
ssi->si_os = CDF_TOLE2(si->si_os);
|
|
|
89be67 |
ssi->si_class = si->si_class;
|
|
|
89be67 |
cdf_swap_class(&ssi->si_class);
|
|
|
89be67 |
- ssi->si_count = CDF_TOLE2(si->si_count);
|
|
|
89be67 |
+ ssi->si_count = CDF_TOLE4(si->si_count);
|
|
|
89be67 |
*count = 0;
|
|
|
89be67 |
maxcount = 0;
|
|
|
89be67 |
*info = NULL;
|
|
|
89be67 |
- for (i = 0; i < CDF_TOLE4(si->si_count); i++) {
|
|
|
89be67 |
- if (i >= CDF_LOOP_LIMIT) {
|
|
|
89be67 |
- DPRINTF(("Unpack summary info loop limit"));
|
|
|
89be67 |
- errno = EFTYPE;
|
|
|
89be67 |
- return -1;
|
|
|
89be67 |
- }
|
|
|
89be67 |
- if (cdf_read_property_info(sst, h, CDF_TOLE4(sd->sd_offset),
|
|
|
89be67 |
- info, count, &maxcount) == -1) {
|
|
|
89be67 |
+ if (cdf_read_property_info(sst, h, CDF_TOLE4(sd->sd_offset), info,
|
|
|
89be67 |
+ count, &maxcount) == -1)
|
|
|
89be67 |
return -1;
|
|
|
89be67 |
- }
|
|
|
89be67 |
- }
|
|
|
89be67 |
return 0;
|
|
|
89be67 |
}
|
|
|
89be67 |
|
|
|
89be67 |
--
|
|
|
89be67 |
1.9.2
|
|
|
89be67 |
|