89be67
From 4fcb9a9d1b1063a65fbeb27395de4979c75bd962 Mon Sep 17 00:00:00 2001
89be67
From: Remi Collet <remi@php.net>
89be67
Date: Tue, 3 Jun 2014 11:05:00 +0200
89be67
Subject: [PATCH] Fix bug #67326	fileinfo: cdf_read_short_sector insufficient
89be67
 boundary check
89be67
89be67
Upstream fix https://github.com/file/file/commit/6d209c1c489457397a5763bca4b28e43aac90391.patch
89be67
Only revelant part applied
89be67
---
89be67
 ext/fileinfo/libmagic/cdf.c | 4 ++--
89be67
 1 file changed, 2 insertions(+), 2 deletions(-)
89be67
89be67
diff --git a/ext/fileinfo/libmagic/cdf.c b/ext/fileinfo/libmagic/cdf.c
89be67
index 4712e84..16649f1 100644
89be67
--- a/src/cdf.c
89be67
+++ b/src/cdf.c
89be67
@@ -352,10 +352,10 @@ cdf_read_short_sector(const cdf_stream_t *sst, void *buf, size_t offs,
89be67
 	size_t ss = CDF_SHORT_SEC_SIZE(h);
89be67
 	size_t pos = CDF_SHORT_SEC_POS(h, id);
89be67
 	assert(ss == len);
89be67
-	if (pos > CDF_SEC_SIZE(h) * sst->sst_len) {
89be67
+	if (pos + len > CDF_SEC_SIZE(h) * sst->sst_len) {
89be67
 		DPRINTF(("Out of bounds read %" SIZE_T_FORMAT "u > %"
89be67
 		    SIZE_T_FORMAT "u\n",
89be67
-		    pos, CDF_SEC_SIZE(h) * sst->sst_len));
89be67
+		    pos + len, CDF_SEC_SIZE(h) * sst->sst_len));
89be67
 		return -1;
89be67
 	}
89be67
 	(void)memcpy(((char *)buf) + offs,
89be67
-- 
89be67
1.9.2
89be67