435ea7
From 4fcb9a9d1b1063a65fbeb27395de4979c75bd962 Mon Sep 17 00:00:00 2001
435ea7
From: Remi Collet <remi@php.net>
435ea7
Date: Tue, 3 Jun 2014 11:05:00 +0200
435ea7
Subject: [PATCH] Fix bug #67326	fileinfo: cdf_read_short_sector insufficient
435ea7
 boundary check
435ea7
435ea7
Upstream fix https://github.com/file/file/commit/6d209c1c489457397a5763bca4b28e43aac90391.patch
435ea7
Only revelant part applied
435ea7
---
435ea7
 ext/fileinfo/libmagic/cdf.c | 4 ++--
435ea7
 1 file changed, 2 insertions(+), 2 deletions(-)
435ea7
435ea7
diff --git a/ext/fileinfo/libmagic/cdf.c b/ext/fileinfo/libmagic/cdf.c
435ea7
index 4712e84..16649f1 100644
435ea7
--- a/src/cdf.c
435ea7
+++ b/src/cdf.c
435ea7
@@ -352,10 +352,10 @@ cdf_read_short_sector(const cdf_stream_t *sst, void *buf, size_t offs,
435ea7
 	size_t ss = CDF_SHORT_SEC_SIZE(h);
435ea7
 	size_t pos = CDF_SHORT_SEC_POS(h, id);
435ea7
 	assert(ss == len);
435ea7
-	if (pos > CDF_SEC_SIZE(h) * sst->sst_len) {
435ea7
+	if (pos + len > CDF_SEC_SIZE(h) * sst->sst_len) {
435ea7
 		DPRINTF(("Out of bounds read %" SIZE_T_FORMAT "u > %"
435ea7
 		    SIZE_T_FORMAT "u\n",
435ea7
-		    pos, CDF_SEC_SIZE(h) * sst->sst_len));
435ea7
+		    pos + len, CDF_SEC_SIZE(h) * sst->sst_len));
435ea7
 		return -1;
435ea7
 	}
435ea7
 	(void)memcpy(((char *)buf) + offs,
435ea7
-- 
435ea7
1.9.2
435ea7