Blame SOURCES/bz1384181-make_the_libvirt_backend_survive_libvirtd.patch

2520b6
diff -ur a/server/checkpoint.c b/server/checkpoint.c
2520b6
--- a/server/checkpoint.c	2014-06-23 15:56:09.000000000 -0400
2520b6
+++ b/server/checkpoint.c	2017-08-09 13:30:40.708689303 -0400
2520b6
@@ -79,7 +79,7 @@
2520b6
 {
2520b6
 	virt_list_t *list = NULL;
2520b6
 
2520b6
-	list = vl_get(vp, my_id);
2520b6
+	list = vl_get(vp, 1, my_id);
2520b6
 	if (!list)
2520b6
 		return -1;
2520b6
 
2520b6
diff -ur a/server/libvirt.c b/server/libvirt.c
2520b6
--- a/server/libvirt.c	2014-06-23 15:56:09.000000000 -0400
2520b6
+++ b/server/libvirt.c	2017-08-09 13:30:40.709689288 -0400
2520b6
@@ -1,5 +1,5 @@
2520b6
 /*
2520b6
-  Copyright Red Hat, Inc. 2006
2520b6
+  Copyright Red Hat, Inc. 2006-2017
2520b6
 
2520b6
   This program is free software; you can redistribute it and/or modify it
2520b6
   under the terms of the GNU General Public License as published by the
2520b6
@@ -61,13 +61,15 @@
2520b6
 
2520b6
 
2520b6
 #define NAME "libvirt"
2520b6
-#define VERSION "0.1"
2520b6
+#define VERSION "0.3"
2520b6
 
2520b6
 #define MAGIC 0x1e19317a
2520b6
 
2520b6
 struct libvirt_info {
2520b6
 	int magic;
2520b6
-	virConnectPtr vp;
2520b6
+	config_object_t *config;
2520b6
+	int vp_count;
2520b6
+	virConnectPtr *vp;
2520b6
 };
2520b6
 
2520b6
 #define VALIDATE(arg) \
2520b6
@@ -79,179 +81,128 @@
2520b6
 } while(0)
2520b6
 
2520b6
 
2520b6
-static inline int
2520b6
-wait_domain(const char *vm_name, virConnectPtr vp,
2520b6
-	    int timeout)
2520b6
-{
2520b6
-	int tries = 0;
2520b6
-	int response = 1;
2520b6
-	int ret;
2520b6
-	virDomainPtr vdp;
2520b6
-	virDomainInfo vdi;
2520b6
-	int uuid_check;
2520b6
-	
2520b6
-	uuid_check = is_uuid(vm_name);
2520b6
-
2520b6
-	if (uuid_check) {
2520b6
-		vdp = virDomainLookupByUUIDString(vp, (const char *)vm_name);
2520b6
-	} else {
2520b6
-		vdp = virDomainLookupByName(vp, vm_name);
2520b6
+static void
2520b6
+libvirt_init_libvirt_conf(struct libvirt_info *info) {
2520b6
+	config_object_t *config = info->config;
2520b6
+	int i = 0;
2520b6
+
2520b6
+	if (info->vp) {
2520b6
+		dbg_printf(2, "Lost libvirtd connection. Reinitializing.\n");
2520b6
+		for (i = 0 ; i < info->vp_count ; i++)
2520b6
+			virConnectClose(info->vp[i]);
2520b6
+		free(info->vp);
2520b6
+		info->vp = NULL;
2520b6
 	}
2520b6
-	if (!vdp)
2520b6
-		return 0;
2520b6
+	info->vp_count = 0;
2520b6
 
2520b6
-	/* Check domain liveliness.  If the domain is still here,
2520b6
-	   we return failure, and the client must then retry */
2520b6
-	/* XXX On the xen 3.0.4 API, we will be able to guarantee
2520b6
-	   synchronous virDomainDestroy, so this check will not
2520b6
-	   be necessary */
2520b6
 	do {
2520b6
-		if (++tries > timeout)
2520b6
-			break;
2520b6
+		virConnectPtr vp;
2520b6
+		virConnectPtr *vpl = NULL;
2520b6
+		char conf_attr[256];
2520b6
+		char value[1024];
2520b6
+		char *uri;
2520b6
+
2520b6
+		if (i != 0) {
2520b6
+			snprintf(conf_attr, sizeof(conf_attr),
2520b6
+				"backends/libvirt/@uri%d", i);
2520b6
+		} else
2520b6
+			snprintf(conf_attr, sizeof(conf_attr), "backends/libvirt/@uri");
2520b6
+		++i;
2520b6
 
2520b6
-		sleep(1);
2520b6
-		if (uuid_check) {
2520b6
-			vdp = virDomainLookupByUUIDString(vp,
2520b6
-					(const char *)vm_name);
2520b6
-		} else {
2520b6
-			vdp = virDomainLookupByName(vp, vm_name);
2520b6
-		}
2520b6
-		if (!vdp) {
2520b6
-			dbg_printf(2, "Domain no longer exists\n");
2520b6
-			response = 0;
2520b6
+		if (sc_get(config, conf_attr, value, sizeof(value)) != 0)
2520b6
 			break;
2520b6
-		}
2520b6
 
2520b6
-		memset(&vdi, 0, sizeof(vdi));
2520b6
-		ret = virDomainGetInfo(vdp, &vdi;;
2520b6
-		virDomainFree(vdp);
2520b6
-		if (ret < 0)
2520b6
+		uri = value;
2520b6
+		vp = virConnectOpen(uri);
2520b6
+		if (!vp) {
2520b6
+			dbg_printf(1, "[libvirt:INIT] Failed to connect to URI: %s\n", uri);
2520b6
 			continue;
2520b6
+		}
2520b6
 
2520b6
-		if (vdi.state == VIR_DOMAIN_SHUTOFF) {
2520b6
-			dbg_printf(2, "Domain has been shut off\n");
2520b6
-			response = 0;
2520b6
-			break;
2520b6
+		vpl = realloc(info->vp, sizeof(*info->vp) * (info->vp_count + 1));
2520b6
+		if (!vpl) {
2520b6
+			dbg_printf(1, "[libvirt:INIT] Out of memory allocating URI: %s\n",
2520b6
+				uri);
2520b6
+			virConnectClose(vp);
2520b6
+			continue;
2520b6
 		}
2520b6
-		
2520b6
-		dbg_printf(4, "Domain still exists (state %d) "
2520b6
-			   "after %d seconds\n",
2520b6
-			   vdi.state, tries);
2520b6
+
2520b6
+		info->vp = vpl;
2520b6
+		info->vp[info->vp_count++] = vp;
2520b6
+
2520b6
+		if (i > 1)
2520b6
+			dbg_printf(1, "[libvirt:INIT] Added URI%d %s\n", i - 1, uri);
2520b6
+		else
2520b6
+			dbg_printf(1, "[libvirt:INIT] Added URI %s\n", uri);
2520b6
 	} while (1);
2520b6
+}
2520b6
 
2520b6
-	return response;
2520b6
+
2520b6
+static int
2520b6
+libvirt_bad_connections(struct libvirt_info *info) {
2520b6
+	int bad = 0;
2520b6
+	int i;
2520b6
+
2520b6
+	for (i = 0 ; i < info->vp_count ; i++) {
2520b6
+		/*
2520b6
+		** Send a dummy command to trigger an error if libvirtd
2520b6
+		** died or restarted
2520b6
+		*/
2520b6
+		virConnectNumOfDomains(info->vp[i]);
2520b6
+		if (!virConnectIsAlive(info->vp[i])) {
2520b6
+			dbg_printf(1, "libvirt connection %d is dead\n", i);
2520b6
+			bad++;
2520b6
+		}
2520b6
+	}
2520b6
+
2520b6
+	if (info->vp_count < 1 || bad)
2520b6
+		libvirt_init_libvirt_conf(info);
2520b6
+
2520b6
+	return bad || info->vp_count < 1;
2520b6
 }
2520b6
 
2520b6
+static void
2520b6
+libvirt_validate_connections(struct libvirt_info *info) {
2520b6
+	while (1) {
2520b6
+		if (libvirt_bad_connections(info))
2520b6
+			sleep(1);
2520b6
+		else
2520b6
+			break;
2520b6
+	}
2520b6
+}
2520b6
 
2520b6
 static int
2520b6
 libvirt_null(const char *vm_name, void *priv)
2520b6
 {
2520b6
-	dbg_printf(5, "%s %s\n", __FUNCTION__, vm_name);
2520b6
+	dbg_printf(5, "ENTER %s %s\n", __FUNCTION__, vm_name);
2520b6
 	printf("NULL operation: returning failure\n");
2520b6
 	return 1;
2520b6
 }
2520b6
 
2520b6
 
2520b6
 static int
2520b6
-libvirt_off(const char *vm_name, const char *src,
2520b6
-	    uint32_t seqno, void *priv)
2520b6
+libvirt_off(const char *vm_name, const char *src, uint32_t seqno, void *priv)
2520b6
 {
2520b6
 	struct libvirt_info *info = (struct libvirt_info *)priv;
2520b6
-	virDomainPtr vdp;
2520b6
-	virDomainInfo vdi;
2520b6
-	int ret = -1;
2520b6
 
2520b6
-	dbg_printf(5, "%s %s\n", __FUNCTION__, vm_name);
2520b6
+	dbg_printf(5, "ENTER %s %s %u\n", __FUNCTION__, vm_name, seqno);
2520b6
 	VALIDATE(info);
2520b6
 
2520b6
-	if (is_uuid(vm_name)) {
2520b6
-		vdp = virDomainLookupByUUIDString(info->vp,
2520b6
-					    (const char *)vm_name);
2520b6
-	} else {
2520b6
-		vdp = virDomainLookupByName(info->vp, vm_name);
2520b6
-	}
2520b6
-
2520b6
-	if (!vdp) {
2520b6
-		dbg_printf(2, "Nothing to do - domain does not exist\n");
2520b6
-		return 1;
2520b6
-	}
2520b6
-
2520b6
-	if (((virDomainGetInfo(vdp, &vdi) == 0) &&
2520b6
-	     (vdi.state == VIR_DOMAIN_SHUTOFF))) {
2520b6
-		dbg_printf(2, "Nothing to do - domain is off\n");
2520b6
-		virDomainFree(vdp);
2520b6
-		return 0;
2520b6
-	}
2520b6
-
2520b6
-	syslog(LOG_NOTICE, "Destroying domain %s\n", vm_name);
2520b6
-	dbg_printf(2, "[OFF] Calling virDomainDestroy\n");
2520b6
-	ret = virDomainDestroy(vdp);
2520b6
-	if (ret < 0) {
2520b6
-		syslog(LOG_NOTICE, "Failed to destroy domain: %d\n", ret);
2520b6
-		printf("virDomainDestroy() failed: %d\n", ret);
2520b6
-		return 1;
2520b6
-	}
2520b6
-
2520b6
-	if (ret) {
2520b6
-		syslog(LOG_NOTICE,
2520b6
-		       "Domain %s still exists; fencing failed\n",
2520b6
-		       vm_name);
2520b6
-		printf("Domain %s still exists; fencing failed\n", vm_name);
2520b6
-		return 1;
2520b6
-	}
2520b6
-
2520b6
-	return 0;
2520b6
+	libvirt_validate_connections(info);
2520b6
+	return vm_off(info->vp, info->vp_count, vm_name);
2520b6
 }
2520b6
 
2520b6
 
2520b6
 static int
2520b6
-libvirt_on(const char *vm_name, const char *src,
2520b6
-	   uint32_t seqno, void *priv)
2520b6
+libvirt_on(const char *vm_name, const char *src, uint32_t seqno, void *priv)
2520b6
 {
2520b6
 	struct libvirt_info *info = (struct libvirt_info *)priv;
2520b6
-	virDomainPtr vdp;
2520b6
-	virDomainInfo vdi;
2520b6
-	int ret = -1;
2520b6
 
2520b6
-	dbg_printf(5, "%s %s\n", __FUNCTION__, vm_name);
2520b6
+	dbg_printf(5, "ENTER %s %s %u\n", __FUNCTION__, vm_name, seqno);
2520b6
 	VALIDATE(info);
2520b6
 
2520b6
-	if (is_uuid(vm_name)) {
2520b6
-		vdp = virDomainLookupByUUIDString(info->vp,
2520b6
-					    (const char *)vm_name);
2520b6
-	} else {
2520b6
-		vdp = virDomainLookupByName(info->vp, vm_name);
2520b6
-	}
2520b6
-
2520b6
-	if (vdp &&
2520b6
-	    ((virDomainGetInfo(vdp, &vdi) == 0) &&
2520b6
-	     (vdi.state != VIR_DOMAIN_SHUTOFF))) {
2520b6
-		dbg_printf(2, "Nothing to do - domain is running\n");
2520b6
-
2520b6
-		if (vdp)
2520b6
-			virDomainFree(vdp);
2520b6
-		return 0;
2520b6
-	}
2520b6
-
2520b6
-	syslog(LOG_NOTICE, "Starting domain %s\n", vm_name);
2520b6
-	dbg_printf(2, "[ON] Calling virDomainCreate\n");
2520b6
-	ret = virDomainCreate(vdp);
2520b6
-	if (ret < 0) {
2520b6
-		syslog(LOG_NOTICE, "Failed to start domain: %d\n", ret);
2520b6
-		printf("virDomainCreate() failed: %d\n", ret);
2520b6
-		return 1;
2520b6
-	}
2520b6
-
2520b6
-	if (ret) {
2520b6
-		syslog(LOG_NOTICE,
2520b6
-		       "Domain %s did not start\n",
2520b6
-		       vm_name);
2520b6
-		printf("Domain %s did not start\n", vm_name);
2520b6
-		return 1;
2520b6
-	}
2520b6
-	syslog(LOG_NOTICE, "Domain %s started\n", vm_name);
2520b6
-
2520b6
-	return 0;
2520b6
+	libvirt_validate_connections(info);
2520b6
+	return vm_on(info->vp, info->vp_count, vm_name);
2520b6
 }
2520b6
 
2520b6
 
2520b6
@@ -270,126 +221,25 @@
2520b6
 libvirt_status(const char *vm_name, void *priv)
2520b6
 {
2520b6
 	struct libvirt_info *info = (struct libvirt_info *)priv;
2520b6
-	virDomainPtr vdp;
2520b6
-	virDomainInfo vdi;
2520b6
-	int ret = 0;
2520b6
 
2520b6
-	dbg_printf(5, "%s %s\n", __FUNCTION__, vm_name);
2520b6
+	dbg_printf(5, "ENTER %s %s\n", __FUNCTION__, vm_name);
2520b6
 	VALIDATE(info);
2520b6
 
2520b6
-	if (is_uuid(vm_name)) {
2520b6
-		vdp = virDomainLookupByUUIDString(info->vp,
2520b6
-					    (const char *)vm_name);
2520b6
-	} else {
2520b6
-		vdp = virDomainLookupByName(info->vp, vm_name);
2520b6
-	}
2520b6
-
2520b6
-	if (!vdp || ((virDomainGetInfo(vdp, &vdi) == 0) &&
2520b6
-	     (vdi.state == VIR_DOMAIN_SHUTOFF))) {
2520b6
-		ret = RESP_OFF;
2520b6
-	}
2520b6
-
2520b6
-	if (vdp)
2520b6
-		virDomainFree(vdp);
2520b6
-	return ret;
2520b6
+	libvirt_validate_connections(info);
2520b6
+	return vm_status(info->vp, info->vp_count, vm_name);
2520b6
 }
2520b6
 
2520b6
 
2520b6
 static int
2520b6
-libvirt_reboot(const char *vm_name, const char *src,
2520b6
-	       uint32_t seqno, void *priv)
2520b6
+libvirt_reboot(const char *vm_name, const char *src, uint32_t seqno, void *priv)
2520b6
 {
2520b6
 	struct libvirt_info *info = (struct libvirt_info *)priv;
2520b6
-	virDomainPtr vdp, nvdp;
2520b6
-	virDomainInfo vdi;
2520b6
-	char *domain_desc;
2520b6
-	int ret;
2520b6
 
2520b6
-	//uuid_unparse(vm_uuid, uu_string);
2520b6
-	dbg_printf(5, "%s %s\n", __FUNCTION__, vm_name);
2520b6
+	dbg_printf(5, "ENTER %s %s %u\n", __FUNCTION__, vm_name, seqno);
2520b6
 	VALIDATE(info);
2520b6
-	
2520b6
-	if (is_uuid(vm_name)) {
2520b6
-		vdp = virDomainLookupByUUIDString(info->vp,
2520b6
-					    (const char *)vm_name);
2520b6
-	} else {
2520b6
-		vdp = virDomainLookupByName(info->vp, vm_name);
2520b6
-	}
2520b6
-
2520b6
-	if (!vdp) {
2520b6
-		dbg_printf(2, "[libvirt:REBOOT] Nothing to "
2520b6
-			   "do - domain does not exist\n");
2520b6
-		return 1;
2520b6
-	}
2520b6
-
2520b6
-	if (((virDomainGetInfo(vdp, &vdi) == 0) &&
2520b6
-	     (vdi.state == VIR_DOMAIN_SHUTOFF))) {
2520b6
-			dbg_printf(2, "[libvirt:REBOOT] Nothing to "
2520b6
-				   "do - domain is off\n");
2520b6
-		virDomainFree(vdp);
2520b6
-		return 0;
2520b6
-	}
2520b6
-
2520b6
-
2520b6
-	syslog(LOG_NOTICE, "Rebooting domain %s\n", vm_name);
2520b6
-	printf("Rebooting domain %s...\n", vm_name);
2520b6
-	domain_desc = virDomainGetXMLDesc(vdp, 0);
2520b6
-
2520b6
-	if (!domain_desc) {
2520b6
-		printf("Failed getting domain description from "
2520b6
-		       "libvirt\n");
2520b6
-	}
2520b6
-
2520b6
-	dbg_printf(2, "[REBOOT] Calling virDomainDestroy(%p)\n", vdp);
2520b6
-	ret = virDomainDestroy(vdp);
2520b6
-	if (ret < 0) {
2520b6
-		printf("virDomainDestroy() failed: %d/%d\n", ret, errno);
2520b6
-		free(domain_desc);
2520b6
-		virDomainFree(vdp);
2520b6
-		return 1;
2520b6
-	}
2520b6
-
2520b6
-	ret = wait_domain(vm_name, info->vp, 15);
2520b6
-
2520b6
-	if (ret) {
2520b6
-		syslog(LOG_NOTICE, "Domain %s still exists; fencing failed\n",
2520b6
-		       vm_name);
2520b6
-		printf("Domain %s still exists; fencing failed\n", vm_name);
2520b6
-		if (domain_desc)
2520b6
-			free(domain_desc);
2520b6
-		return 1;
2520b6
-	}
2520b6
-		
2520b6
-	if (!domain_desc)
2520b6
-		return 0;
2520b6
 
2520b6
-	/* 'on' is not a failure */
2520b6
-	ret = 0;
2520b6
-
2520b6
-	dbg_printf(3, "[[ XML Domain Info ]]\n");
2520b6
-	dbg_printf(3, "%s\n[[ XML END ]]\n", domain_desc);
2520b6
-	dbg_printf(2, "Calling virDomainCreateLinux()...\n");
2520b6
-
2520b6
-	nvdp = virDomainCreateLinux(info->vp, domain_desc, 0);
2520b6
-	if (nvdp == NULL) {
2520b6
-		/* More recent versions of libvirt or perhaps the
2520b6
-		 * KVM back-end do not let you create a domain from
2520b6
-		 * XML if there is already a defined domain description
2520b6
-		 * with the same name that it knows about.  You must
2520b6
-		 * then call virDomainCreate() */
2520b6
-		dbg_printf(2, "Failed; Trying virDomainCreate()...\n");
2520b6
-		if (virDomainCreate(vdp) < 0) {
2520b6
-			syslog(LOG_NOTICE,
2520b6
-			       "Could not restart %s\n",
2520b6
-			       vm_name);
2520b6
-			dbg_printf(1, "Failed to recreate guest"
2520b6
-				   " %s!\n", vm_name);
2520b6
-		}
2520b6
-	}
2520b6
-
2520b6
-	free(domain_desc);
2520b6
-
2520b6
-	return ret;
2520b6
+	libvirt_validate_connections(info);
2520b6
+	return vm_reboot(info->vp, info->vp_count, vm_name);
2520b6
 }
2520b6
 
2520b6
 
2520b6
@@ -400,22 +250,27 @@
2520b6
 	virt_list_t *vl;
2520b6
 	int x;
2520b6
 
2520b6
-	dbg_printf(5, "%s\n", __FUNCTION__);
2520b6
+	dbg_printf(5, "ENTER %s\n", __FUNCTION__);
2520b6
 	VALIDATE(info);
2520b6
 
2520b6
-	vl = vl_get(info->vp, 1);
2520b6
+	libvirt_validate_connections(info);
2520b6
+
2520b6
+	vl = vl_get(info->vp, info->vp_count, 1);
2520b6
 	if (!vl)
2520b6
-		return 1;
2520b6
+		return 0;
2520b6
 
2520b6
 	for (x = 0; x < vl->vm_count; x++) {
2520b6
-		dbg_printf(10, "Sending %s\n", vl->vm_states[x].v_uuid);
2520b6
 		callback(vl->vm_states[x].v_name,
2520b6
-			 vl->vm_states[x].v_uuid,
2520b6
-			 vl->vm_states[x].v_state.s_state, arg);
2520b6
+				 vl->vm_states[x].v_uuid,
2520b6
+				 vl->vm_states[x].v_state.s_state, arg);
2520b6
+
2520b6
+		dbg_printf(10, "[libvirt:HOSTLIST] Sent %s %s %d\n",
2520b6
+			vl->vm_states[x].v_name,
2520b6
+			vl->vm_states[x].v_uuid,
2520b6
+			vl->vm_states[x].v_state.s_state);
2520b6
 	}
2520b6
 
2520b6
 	vl_free(vl);
2520b6
-
2520b6
 	return 0;
2520b6
 }
2520b6
 
2520b6
@@ -423,46 +278,33 @@
2520b6
 static int
2520b6
 libvirt_init(backend_context_t *c, config_object_t *config)
2520b6
 {
2520b6
-	virConnectPtr vp;
2520b6
 	char value[256];
2520b6
 	struct libvirt_info *info = NULL;
2520b6
-	char *uri = NULL;
2520b6
 
2520b6
-	info = malloc(sizeof(*info));
2520b6
+	dbg_printf(5, "ENTER [%s:%d %s]\n", __FILE__, __LINE__, __FUNCTION__);
2520b6
+
2520b6
+	info = calloc(1, sizeof(*info));
2520b6
 	if (!info)
2520b6
 		return -1;
2520b6
+	info->magic = MAGIC;
2520b6
+	info->config = config;
2520b6
 
2520b6
-	dbg_printf(5, "[%s:%d %s]\n", __FILE__, __LINE__, __FUNCTION__);
2520b6
-	memset(info, 0, sizeof(*info));
2520b6
+	libvirt_init_libvirt_conf(info);
2520b6
 
2520b6
 #ifdef _MODULE
2520b6
-	if (sc_get(config, "fence_virtd/@debug", value, sizeof(value))==0)
2520b6
+	if (sc_get(config, "fence_virtd/@debug", value, sizeof(value)) == 0)
2520b6
 		dset(atoi(value));
2520b6
 #endif
2520b6
 
2520b6
-	if (sc_get(config, "backends/libvirt/@uri",
2520b6
-		   value, sizeof(value)) == 0) {
2520b6
-		uri = strdup(value);
2520b6
-		if (!uri) {
2520b6
-			free(info);
2520b6
-			return -1;
2520b6
-		}
2520b6
-		dbg_printf(1, "Using %s\n", uri);
2520b6
-	}
2520b6
-
2520b6
-	/* We don't need to store the URI; we only use it once */
2520b6
-	vp = virConnectOpen(uri);
2520b6
-	if (!vp) {
2520b6
-		free(uri);
2520b6
+	if (info->vp_count < 1) {
2520b6
+		dbg_printf(1, "[libvirt:INIT] Could not connect to any hypervisors\n");
2520b6
+		if (info->vp)
2520b6
+			free(info->vp);
2520b6
 		free(info);
2520b6
 		return -1;
2520b6
 	}
2520b6
-	free(uri);
2520b6
-
2520b6
-	info->magic = MAGIC;
2520b6
-	info->vp = vp;
2520b6
 
2520b6
-	*c = (void *)info;
2520b6
+	*c = (void *) info;
2520b6
 	return 0;
2520b6
 }
2520b6
 
2520b6
@@ -471,16 +313,19 @@
2520b6
 libvirt_shutdown(backend_context_t c)
2520b6
 {
2520b6
 	struct libvirt_info *info = (struct libvirt_info *)c;
2520b6
+	int i;
2520b6
+	int ret = 0;
2520b6
 
2520b6
 	VALIDATE(info);
2520b6
 
2520b6
-	if (virConnectClose(info->vp) < 0) {
2520b6
-		free(info);
2520b6
-		return -errno;
2520b6
+	for (i = 0 ; i < info->vp_count ; i++) {
2520b6
+		if (virConnectClose(info->vp[i]) < 0)
2520b6
+			ret = -errno;
2520b6
 	}
2520b6
 
2520b6
+	free(info->vp);
2520b6
 	free(info);
2520b6
-	return 0;
2520b6
+	return ret;
2520b6
 }
2520b6
 
2520b6
 
2520b6
diff -ur a/server/virt.c b/server/virt.c
2520b6
--- a/server/virt.c	2014-06-23 15:56:09.000000000 -0400
2520b6
+++ b/server/virt.c	2017-08-09 13:35:07.247875913 -0400
2520b6
@@ -1,5 +1,5 @@
2520b6
 /*
2520b6
-  Copyright Red Hat, Inc. 2006
2520b6
+  Copyright Red Hat, Inc. 2006-2017
2520b6
 
2520b6
   This program is free software; you can redistribute it and/or modify it
2520b6
   under the terms of the GNU General Public License as published by the
2520b6
@@ -16,7 +16,9 @@
2520b6
   Free Software Foundation, Inc.,  675 Mass Ave, Cambridge, 
2520b6
   MA 02139, USA.
2520b6
 */
2520b6
+
2520b6
 #include <stdio.h>
2520b6
+#include <unistd.h>
2520b6
 #include <sys/types.h>
2520b6
 #include <stdlib.h>
2520b6
 #include <libvirt/libvirt.h>
2520b6
@@ -24,8 +26,11 @@
2520b6
 #include <malloc.h>
2520b6
 #include <stdint.h>
2520b6
 #include <errno.h>
2520b6
-#include "virt.h"
2520b6
+#include <syslog.h>
2520b6
 
2520b6
+#include "debug.h"
2520b6
+#include "uuid-test.h"
2520b6
+#include "virt.h"
2520b6
 
2520b6
 static int
2520b6
 _compare_virt(const void *_left, const void *_right)
2520b6
@@ -37,96 +42,98 @@
2520b6
 }
2520b6
 
2520b6
 
2520b6
-virt_list_t *vl_get(virConnectPtr vp, int my_id)
2520b6
-{
2520b6
-	virt_list_t *vl = NULL;
2520b6
-	int d_count, x, saved_errno;
2520b6
-	virDomainPtr *dom_list;
2520b6
-
2520b6
-	errno = EINVAL;
2520b6
-	if (!vp)
2520b6
-		return NULL;
2520b6
-
2520b6
-	d_count = virConnectListAllDomains(vp, &dom_list, 0);
2520b6
-	if (d_count <= 0)
2520b6
-		goto out_fail;
2520b6
+static void
2520b6
+_free_dom_list(virDomainPtr *dom_list, int len) {
2520b6
+	int x;
2520b6
 
2520b6
-	vl = malloc(sizeof(uint32_t) + sizeof(virt_state_t) * d_count);
2520b6
-	if (!vl)
2520b6
-		goto out_fail;
2520b6
+	if (!dom_list || len <= 0)
2520b6
+		return;
2520b6
+	for (x = 0 ; x < len; x++)
2520b6
+		virDomainFree(dom_list[x]);
2520b6
 
2520b6
-	vl->vm_count = d_count;
2520b6
+	free(dom_list);
2520b6
+}
2520b6
 
2520b6
-	/* Ok, we have the domain IDs - let's get their names and states */
2520b6
-	for (x = 0; x < d_count; x++) {
2520b6
-		char *d_name;
2520b6
-		virDomainInfo d_info;
2520b6
-		char d_uuid[MAX_DOMAINNAME_LENGTH];
2520b6
-		virDomainPtr dom = dom_list[x];
2520b6
 
2520b6
-		if (!(d_name = (char *)virDomainGetName(dom)))
2520b6
-			goto out_fail;
2520b6
+virt_list_t *vl_get(virConnectPtr *vp, int vp_count, int my_id)
2520b6
+{
2520b6
+	virt_list_t *vl = NULL;
2520b6
+	int d_count = 0;
2520b6
+	int i;
2520b6
 
2520b6
-		if (virDomainGetUUIDString(dom, d_uuid) != 0)
2520b6
-			goto out_fail;
2520b6
+	errno = EINVAL;
2520b6
+	if (!vp || vp_count < 1)
2520b6
+		return NULL;
2520b6
 
2520b6
-		if (virDomainGetInfo(dom, &d_info) < 0)
2520b6
-			goto out_fail;
2520b6
+	for (i = 0 ; i < vp_count ; i++) {
2520b6
+		int x;
2520b6
+		virDomainPtr *dom_list;
2520b6
+		virt_list_t *new_vl;
2520b6
+
2520b6
+		int ret = virConnectListAllDomains(vp[i], &dom_list, 0);
2520b6
+		if (ret == 0)
2520b6
+			continue;
2520b6
+
2520b6
+		if (ret < 0) {
2520b6
+			int saved_errno = errno;
2520b6
+			dbg_printf(2, "Error: virConnectListAllDomains: %d %d\n",
2520b6
+				ret, saved_errno);
2520b6
+			if (vl)
2520b6
+				free(vl);
2520b6
+			errno = saved_errno;
2520b6
+			return NULL;
2520b6
+		}
2520b6
+
2520b6
+		d_count += ret;
2520b6
+		new_vl = realloc(vl, sizeof(uint32_t) + sizeof(virt_state_t) * d_count);
2520b6
+		if (!new_vl) {
2520b6
+			_free_dom_list(dom_list, ret);
2520b6
+			free(vl);
2520b6
+			return NULL;
2520b6
+		}
2520b6
+		vl = new_vl;
2520b6
+		vl->vm_count = d_count;
2520b6
+
2520b6
+		/* Ok, we have the domain IDs - let's get their names and states */
2520b6
+		for (x = 0; x < ret; x++) {
2520b6
+			char *d_name;
2520b6
+			virDomainInfo d_info;
2520b6
+			char d_uuid[MAX_DOMAINNAME_LENGTH];
2520b6
+			virDomainPtr dom = dom_list[x];
2520b6
+
2520b6
+			if (!(d_name = (char *)virDomainGetName(dom))) {
2520b6
+				_free_dom_list(dom_list, ret);
2520b6
+				free(vl);
2520b6
+				return NULL;
2520b6
+			}
2520b6
+
2520b6
+			if (virDomainGetUUIDString(dom, d_uuid) != 0) {
2520b6
+				_free_dom_list(dom_list, ret);
2520b6
+				free(vl);
2520b6
+				return NULL;
2520b6
+			}
2520b6
+
2520b6
+			if (virDomainGetInfo(dom, &d_info) < 0) {
2520b6
+				_free_dom_list(dom_list, ret);
2520b6
+				free(vl);
2520b6
+				return NULL;
2520b6
+			}
2520b6
+
2520b6
+			/* Store the name & state */
2520b6
+			strncpy(vl->vm_states[x].v_name, d_name, MAX_DOMAINNAME_LENGTH);
2520b6
+			strncpy(vl->vm_states[x].v_uuid, d_uuid, MAX_DOMAINNAME_LENGTH);
2520b6
+			vl->vm_states[x].v_state.s_state = d_info.state;
2520b6
+			vl->vm_states[x].v_state.s_owner = my_id;
2520b6
+		}
2520b6
 
2520b6
-		/* Store the name & state */
2520b6
-		strncpy(vl->vm_states[x].v_name, d_name, MAX_DOMAINNAME_LENGTH);
2520b6
-		strncpy(vl->vm_states[x].v_uuid, d_uuid, MAX_DOMAINNAME_LENGTH);
2520b6
-		vl->vm_states[x].v_state.s_state = d_info.state;
2520b6
-		vl->vm_states[x].v_state.s_owner = my_id;
2520b6
+		_free_dom_list(dom_list, ret);
2520b6
 	}
2520b6
 
2520b6
-	for (x = 0 ; x < d_count; x++)
2520b6
-		virDomainFree(dom_list[x]);
2520b6
-	free(dom_list);
2520b6
-
2520b6
 	/* We have all the locally running domains & states now */
2520b6
 	/* Sort */
2520b6
 	qsort(&vl->vm_states[0], vl->vm_count, sizeof(vl->vm_states[0]),
2520b6
 	      _compare_virt);
2520b6
 	return vl;	
2520b6
-
2520b6
-out_fail:
2520b6
-	saved_errno = errno;
2520b6
-	for (x = 0 ; x < d_count; x++)
2520b6
-		virDomainFree(dom_list[x]);
2520b6
-	free(dom_list);
2520b6
-
2520b6
-	if (vl)
2520b6
-		free(vl);
2520b6
-	errno = saved_errno;
2520b6
-	return NULL;
2520b6
-}
2520b6
-
2520b6
-
2520b6
-/* Returns 0 if equal, nonzero if not */
2520b6
-int
2520b6
-vl_cmp(virt_list_t *left, virt_list_t *right)
2520b6
-{
2520b6
-	int x;
2520b6
-
2520b6
-	/* Quick checks */
2520b6
-	if (!left->vm_count && !right->vm_count)
2520b6
-		return 1;
2520b6
-	if (left->vm_count != right->vm_count)
2520b6
-		return 0;
2520b6
-
2520b6
-	for (x = 0; x < left->vm_count; x++) {
2520b6
-		if (strcmp(left->vm_states[x].v_name,
2520b6
-			   right->vm_states[x].v_name))
2520b6
-			return 1;
2520b6
-		/*
2520b6
-		if (left->vm_states[x].v_state.s_state !=
2520b6
-		    right->vm_states[x].v_state.s_state)
2520b6
-			return 1;
2520b6
-		 */
2520b6
-	}
2520b6
-
2520b6
-	return 0;
2520b6
 }
2520b6
 
2520b6
 
2520b6
@@ -192,3 +199,333 @@
2520b6
 {
2520b6
 	free(old);
2520b6
 }
2520b6
+
2520b6
+
2520b6
+static inline int
2520b6
+wait_domain(const char *vm_name, virConnectPtr vp, int timeout)
2520b6
+{
2520b6
+	int tries = 0;
2520b6
+	int response = 1;
2520b6
+	int ret;
2520b6
+	virDomainPtr vdp;
2520b6
+	virDomainInfo vdi;
2520b6
+	int uuid_check;
2520b6
+
2520b6
+	uuid_check = is_uuid(vm_name);
2520b6
+
2520b6
+	if (uuid_check) {
2520b6
+		vdp = virDomainLookupByUUIDString(vp, (const char *)vm_name);
2520b6
+	} else {
2520b6
+		vdp = virDomainLookupByName(vp, vm_name);
2520b6
+	}
2520b6
+	if (!vdp)
2520b6
+		return 0;
2520b6
+
2520b6
+	/* Check domain liveliness.  If the domain is still here,
2520b6
+	   we return failure, and the client must then retry */
2520b6
+	/* XXX On the xen 3.0.4 API, we will be able to guarantee
2520b6
+	   synchronous virDomainDestroy, so this check will not
2520b6
+	   be necessary */
2520b6
+	do {
2520b6
+		if (++tries > timeout)
2520b6
+			break;
2520b6
+
2520b6
+		sleep(1);
2520b6
+		if (uuid_check) {
2520b6
+			vdp = virDomainLookupByUUIDString(vp, (const char *)vm_name);
2520b6
+		} else {
2520b6
+			vdp = virDomainLookupByName(vp, vm_name);
2520b6
+		}
2520b6
+		if (!vdp) {
2520b6
+			dbg_printf(2, "Domain no longer exists\n");
2520b6
+			response = 0;
2520b6
+			break;
2520b6
+		}
2520b6
+
2520b6
+		memset(&vdi, 0, sizeof(vdi));
2520b6
+		ret = virDomainGetInfo(vdp, &vdi;;
2520b6
+		virDomainFree(vdp);
2520b6
+		if (ret < 0)
2520b6
+			continue;
2520b6
+
2520b6
+		if (vdi.state == VIR_DOMAIN_SHUTOFF) {
2520b6
+			dbg_printf(2, "Domain has been shut off\n");
2520b6
+			response = 0;
2520b6
+			break;
2520b6
+		}
2520b6
+
2520b6
+		dbg_printf(4, "Domain still exists (state %d) after %d seconds\n",
2520b6
+			vdi.state, tries);
2520b6
+	} while (1);
2520b6
+
2520b6
+	return response;
2520b6
+}
2520b6
+
2520b6
+
2520b6
+int
2520b6
+vm_off(virConnectPtr *vp, int vp_count, const char *vm_name)
2520b6
+{
2520b6
+	virDomainPtr vdp = NULL;
2520b6
+	virDomainInfo vdi;
2520b6
+	virDomainPtr (*virt_lookup_fn)(virConnectPtr, const char *);
2520b6
+	int ret = -1;
2520b6
+	int i;
2520b6
+
2520b6
+	if (is_uuid(vm_name))
2520b6
+		virt_lookup_fn = virDomainLookupByUUIDString;
2520b6
+	else
2520b6
+		virt_lookup_fn = virDomainLookupByName;
2520b6
+
2520b6
+	for (i = 0 ; i < vp_count ; i++) {
2520b6
+		vdp = virt_lookup_fn(vp[i], vm_name);
2520b6
+		if (vdp)
2520b6
+			break;
2520b6
+	}
2520b6
+
2520b6
+	if (!vdp) {
2520b6
+		dbg_printf(2, "[virt:OFF] Domain %s does not exist\n", vm_name);
2520b6
+		return 1;
2520b6
+	}
2520b6
+
2520b6
+	if (virDomainGetInfo(vdp, &vdi) == 0 && vdi.state == VIR_DOMAIN_SHUTOFF)
2520b6
+	{
2520b6
+		dbg_printf(2, "[virt:OFF] Nothing to do - "
2520b6
+			"domain %s is already off\n",
2520b6
+			vm_name);
2520b6
+		virDomainFree(vdp);
2520b6
+		return 0;
2520b6
+	}
2520b6
+
2520b6
+	syslog(LOG_NOTICE, "Destroying domain %s\n", vm_name);
2520b6
+	dbg_printf(2, "[virt:OFF] Calling virDomainDestroy for %s\n", vm_name);
2520b6
+
2520b6
+	ret = virDomainDestroy(vdp);
2520b6
+	virDomainFree(vdp);
2520b6
+
2520b6
+	if (ret < 0) {
2520b6
+		syslog(LOG_NOTICE,
2520b6
+			"Failed to destroy domain %s: %d\n", vm_name, ret);
2520b6
+		dbg_printf(2, "[virt:OFF] Failed to destroy domain: %s %d\n",
2520b6
+			vm_name, ret);
2520b6
+		return 1;
2520b6
+	}
2520b6
+
2520b6
+	if (ret) {
2520b6
+		syslog(LOG_NOTICE, "Domain %s still exists; fencing failed\n",
2520b6
+			vm_name);
2520b6
+		dbg_printf(2,
2520b6
+			"[virt:OFF] Domain %s still exists; fencing failed\n",
2520b6
+			vm_name);
2520b6
+		return 1;
2520b6
+	}
2520b6
+
2520b6
+	dbg_printf(2, "[virt:OFF] Success for %s\n", vm_name);
2520b6
+	return 0;
2520b6
+}
2520b6
+
2520b6
+
2520b6
+int
2520b6
+vm_on(virConnectPtr *vp, int vp_count, const char *vm_name)
2520b6
+{
2520b6
+	virDomainPtr vdp = NULL;
2520b6
+	virDomainInfo vdi;
2520b6
+	virDomainPtr (*virt_lookup_fn)(virConnectPtr, const char *);
2520b6
+	int ret = -1;
2520b6
+	int i;
2520b6
+
2520b6
+	if (is_uuid(vm_name))
2520b6
+		virt_lookup_fn = virDomainLookupByUUIDString;
2520b6
+	else
2520b6
+		virt_lookup_fn = virDomainLookupByName;
2520b6
+
2520b6
+	for (i = 0 ; i < vp_count ; i++) {
2520b6
+		vdp = virt_lookup_fn(vp[i], vm_name);
2520b6
+		if (vdp)
2520b6
+			break;
2520b6
+	}
2520b6
+
2520b6
+	if (!vdp) {
2520b6
+		dbg_printf(2, "[virt:ON] Domain %s does not exist\n", vm_name);
2520b6
+		return 1;
2520b6
+	}
2520b6
+
2520b6
+	if (virDomainGetInfo(vdp, &vdi) == 0 && vdi.state != VIR_DOMAIN_SHUTOFF) {
2520b6
+		dbg_printf(2, "Nothing to do - domain %s is already running\n",
2520b6
+			vm_name);
2520b6
+		virDomainFree(vdp);
2520b6
+		return 0;
2520b6
+	}
2520b6
+
2520b6
+	syslog(LOG_NOTICE, "Starting domain %s\n", vm_name);
2520b6
+	dbg_printf(2, "[virt:ON] Calling virDomainCreate for %s\n", vm_name);
2520b6
+
2520b6
+	ret = virDomainCreate(vdp);
2520b6
+	virDomainFree(vdp);
2520b6
+
2520b6
+	if (ret < 0) {
2520b6
+		syslog(LOG_NOTICE, "Failed to start domain %s: %d\n", vm_name, ret);
2520b6
+		dbg_printf(2, "[virt:ON] virDomainCreate() failed for %s: %d\n",
2520b6
+			vm_name, ret);
2520b6
+		return 1;
2520b6
+	}
2520b6
+
2520b6
+	if (ret) {
2520b6
+		syslog(LOG_NOTICE, "Domain %s did not start\n", vm_name);
2520b6
+		dbg_printf(2, "[virt:ON] Domain %s did not start\n", vm_name);
2520b6
+		return 1;
2520b6
+	}
2520b6
+
2520b6
+	syslog(LOG_NOTICE, "Domain %s started\n", vm_name);
2520b6
+	dbg_printf(2, "[virt:ON] Success for %s\n", vm_name);
2520b6
+	return 0;
2520b6
+}
2520b6
+
2520b6
+
2520b6
+int
2520b6
+vm_status(virConnectPtr *vp, int vp_count, const char *vm_name)
2520b6
+{
2520b6
+	virDomainPtr vdp = NULL;
2520b6
+	virDomainInfo vdi;
2520b6
+	int ret = 0;
2520b6
+	int i;
2520b6
+	virDomainPtr (*virt_lookup_fn)(virConnectPtr, const char *);
2520b6
+
2520b6
+	if (is_uuid(vm_name))
2520b6
+		virt_lookup_fn = virDomainLookupByUUIDString;
2520b6
+	else
2520b6
+		virt_lookup_fn = virDomainLookupByName;
2520b6
+
2520b6
+	for (i = 0 ; i < vp_count ; i++) {
2520b6
+		vdp = virt_lookup_fn(vp[i], vm_name);
2520b6
+		if (vdp)
2520b6
+			break;
2520b6
+	}
2520b6
+
2520b6
+	if (!vdp) {
2520b6
+		dbg_printf(2, "[virt:STATUS] Unknown VM %s - return OFF\n", vm_name);
2520b6
+		return RESP_OFF;
2520b6
+	}
2520b6
+
2520b6
+	if (virDomainGetInfo(vdp, &vdi) == 0 && vdi.state == VIR_DOMAIN_SHUTOFF) {
2520b6
+		dbg_printf(2, "[virt:STATUS] VM %s is OFF\n", vm_name);
2520b6
+		ret = RESP_OFF;
2520b6
+	}
2520b6
+
2520b6
+	if (vdp)
2520b6
+		virDomainFree(vdp);
2520b6
+	return ret;
2520b6
+}
2520b6
+
2520b6
+
2520b6
+int
2520b6
+vm_reboot(virConnectPtr *vp, int vp_count, const char *vm_name)
2520b6
+{
2520b6
+	virDomainPtr vdp = NULL, nvdp;
2520b6
+	virDomainInfo vdi;
2520b6
+	char *domain_desc;
2520b6
+	virConnectPtr vcp = NULL;
2520b6
+	virDomainPtr (*virt_lookup_fn)(virConnectPtr, const char *);
2520b6
+	int ret;
2520b6
+	int i;
2520b6
+
2520b6
+	if (is_uuid(vm_name))
2520b6
+		virt_lookup_fn = virDomainLookupByUUIDString;
2520b6
+	else
2520b6
+		virt_lookup_fn = virDomainLookupByName;
2520b6
+
2520b6
+	for (i = 0 ; i < vp_count ; i++) {
2520b6
+		vdp = virt_lookup_fn(vp[i], vm_name);
2520b6
+		if (vdp) {
2520b6
+			vcp = vp[i];
2520b6
+			break;
2520b6
+		}
2520b6
+	}
2520b6
+
2520b6
+	if (!vdp || !vcp) {
2520b6
+		dbg_printf(2,
2520b6
+			"[virt:REBOOT] Nothing to do - domain %s does not exist\n",
2520b6
+			vm_name);
2520b6
+		return 1;
2520b6
+	}
2520b6
+
2520b6
+	if (virDomainGetInfo(vdp, &vdi) == 0 && vdi.state == VIR_DOMAIN_SHUTOFF) {
2520b6
+		dbg_printf(2, "[virt:REBOOT] Nothing to do - domain %s is off\n",
2520b6
+			vm_name);
2520b6
+		virDomainFree(vdp);
2520b6
+		return 0;
2520b6
+	}
2520b6
+
2520b6
+	syslog(LOG_NOTICE, "Rebooting domain %s\n", vm_name);
2520b6
+	dbg_printf(5, "[virt:REBOOT] Rebooting domain %s...\n", vm_name);
2520b6
+
2520b6
+	domain_desc = virDomainGetXMLDesc(vdp, 0);
2520b6
+
2520b6
+	if (!domain_desc) {
2520b6
+		dbg_printf(5, "[virt:REBOOT] Failed getting domain description "
2520b6
+			"from libvirt for %s...\n", vm_name);
2520b6
+	}
2520b6
+
2520b6
+	dbg_printf(2, "[virt:REBOOT] Calling virDomainDestroy(%p) for %s\n",
2520b6
+		vdp, vm_name);
2520b6
+
2520b6
+	ret = virDomainDestroy(vdp);
2520b6
+	if (ret < 0) {
2520b6
+		dbg_printf(2,
2520b6
+			"[virt:REBOOT] virDomainDestroy() failed for %s: %d/%d\n",
2520b6
+			vm_name, ret, errno);
2520b6
+
2520b6
+		if (domain_desc)
2520b6
+			free(domain_desc);
2520b6
+		virDomainFree(vdp);
2520b6
+		return 1;
2520b6
+	}
2520b6
+
2520b6
+	ret = wait_domain(vm_name, vcp, 15);
2520b6
+
2520b6
+	if (ret) {
2520b6
+		syslog(LOG_NOTICE, "Domain %s still exists; fencing failed\n", vm_name);
2520b6
+		dbg_printf(2,
2520b6
+			"[virt:REBOOT] Domain %s still exists; fencing failed\n",
2520b6
+			vm_name);
2520b6
+
2520b6
+		if (domain_desc)
2520b6
+			free(domain_desc);
2520b6
+		virDomainFree(vdp);
2520b6
+		return 1;
2520b6
+	}
2520b6
+
2520b6
+	if (!domain_desc)
2520b6
+		return 0;
2520b6
+
2520b6
+	/* 'on' is not a failure */
2520b6
+	ret = 0;
2520b6
+
2520b6
+	dbg_printf(3, "[[ XML Domain Info ]]\n");
2520b6
+	dbg_printf(3, "%s\n[[ XML END ]]\n", domain_desc);
2520b6
+
2520b6
+	dbg_printf(2, "[virt:REBOOT] Calling virDomainCreateLinux() for %s\n",
2520b6
+		vm_name);
2520b6
+
2520b6
+	nvdp = virDomainCreateLinux(vcp, domain_desc, 0);
2520b6
+	if (nvdp == NULL) {
2520b6
+		/* More recent versions of libvirt or perhaps the
2520b6
+		 * KVM back-end do not let you create a domain from
2520b6
+		 * XML if there is already a defined domain description
2520b6
+		 * with the same name that it knows about.  You must
2520b6
+		 * then call virDomainCreate() */
2520b6
+		dbg_printf(2,
2520b6
+			"[virt:REBOOT] virDomainCreateLinux() failed for %s; "
2520b6
+			"Trying virDomainCreate()\n",
2520b6
+			vm_name);
2520b6
+
2520b6
+		if (virDomainCreate(vdp) < 0) {
2520b6
+			syslog(LOG_NOTICE, "Could not restart %s\n", vm_name);
2520b6
+			dbg_printf(1, "[virt:REBOOT] Failed to recreate guest %s!\n",
2520b6
+				vm_name);
2520b6
+		}
2520b6
+	}
2520b6
+
2520b6
+	free(domain_desc);
2520b6
+	virDomainFree(vdp);
2520b6
+	return ret;
2520b6
+}
2520b6
diff -ur a/server/virt.h b/server/virt.h
2520b6
--- a/server/virt.h	2014-06-23 15:56:09.000000000 -0400
2520b6
+++ b/server/virt.h	2017-08-09 13:30:40.709689288 -0400
2520b6
@@ -1,5 +1,5 @@
2520b6
 /*
2520b6
-  Copyright Red Hat, Inc. 2006
2520b6
+  Copyright Red Hat, Inc. 2006-2017
2520b6
 
2520b6
   This program is free software; you can redistribute it and/or modify it
2520b6
   under the terms of the GNU General Public License as published by the
2520b6
@@ -16,11 +16,13 @@
2520b6
   Free Software Foundation, Inc.,  675 Mass Ave, Cambridge, 
2520b6
   MA 02139, USA.
2520b6
 */
2520b6
+
2520b6
 #ifndef _VIRT_H
2520b6
 #define _VIRT_H
2520b6
-#include <libvirt/libvirt.h>
2520b6
+
2520b6
 #include <stdint.h>
2520b6
 #include <netinet/in.h>
2520b6
+#include <libvirt/libvirt.h>
2520b6
 
2520b6
 #include "xvm.h"
2520b6
 
2520b6
@@ -59,15 +61,16 @@
2520b6
 	virt_state_t	vm_states[0];
2520b6
 } virt_list_t;
2520b6
 
2520b6
-virt_list_t *vl_get(virConnectPtr vp, int my_id);
2520b6
-
2520b6
-int vl_cmp(virt_list_t *left, virt_list_t *right);
2520b6
-
2520b6
+virt_list_t *vl_get(virConnectPtr *vp, int vp_count, int my_id);
2520b6
 void vl_print(virt_list_t *vl);
2520b6
 void vl_free(virt_list_t *old);
2520b6
-virt_state_t * vl_find_uuid(virt_list_t *vl, const char *name);
2520b6
-virt_state_t * vl_find_name(virt_list_t *vl, const char *name);
2520b6
+virt_state_t *vl_find_uuid(virt_list_t *vl, const char *name);
2520b6
+virt_state_t *vl_find_name(virt_list_t *vl, const char *name);
2520b6
 
2520b6
+int vm_off(virConnectPtr *vp, int vp_count, const char *vm_name);
2520b6
+int vm_on(virConnectPtr *vp, int vp_count, const char *vm_name);
2520b6
+int vm_status(virConnectPtr *vp, int vp_count, const char *vm_name);
2520b6
+int vm_reboot(virConnectPtr *vp, int vp_count, const char *vm_name);
2520b6
 
2520b6
 typedef void ckpt_handle;
2520b6
 int ckpt_read(void *hp, const char *secid, void *buf, size_t maxlen);