674a4f
From ac83d8ce3d8dd868b0e887528e7c269cee4dcac8 Mon Sep 17 00:00:00 2001
674a4f
From: Oyvind Albrigtsen <oalbrigt@redhat.com>
674a4f
Date: Tue, 31 Jul 2018 15:57:38 +0200
674a4f
Subject: [PATCH] fence_kdump: fix strncpy issue
674a4f
674a4f
---
674a4f
 agents/kdump/fence_kdump.c      | 2 +-
674a4f
 agents/kdump/fence_kdump_send.c | 2 +-
674a4f
 2 files changed, 2 insertions(+), 2 deletions(-)
674a4f
674a4f
diff --git a/agents/kdump/fence_kdump.c b/agents/kdump/fence_kdump.c
674a4f
index e2f3cd80..768a9344 100644
674a4f
--- a/agents/kdump/fence_kdump.c
674a4f
+++ b/agents/kdump/fence_kdump.c
674a4f
@@ -351,7 +351,7 @@ get_options_node (fence_kdump_opts_t *opts)
674a4f
     hints.ai_protocol = IPPROTO_UDP;
674a4f
     hints.ai_flags = AI_NUMERICSERV;
674a4f
 
674a4f
-    strncpy (node->name, opts->nodename, sizeof (node->name));
674a4f
+    strncpy (node->name, opts->nodename, sizeof (node->name) - 1);
674a4f
     snprintf (node->port, sizeof (node->port), "%d", opts->ipport);
674a4f
 
674a4f
     node->info = NULL;
674a4f
diff --git a/agents/kdump/fence_kdump_send.c b/agents/kdump/fence_kdump_send.c
674a4f
index d668bed3..638f8c97 100644
674a4f
--- a/agents/kdump/fence_kdump_send.c
674a4f
+++ b/agents/kdump/fence_kdump_send.c
674a4f
@@ -116,7 +116,7 @@ get_options_node (fence_kdump_opts_t *opts)
674a4f
     hints.ai_protocol = IPPROTO_UDP;
674a4f
     hints.ai_flags = AI_NUMERICSERV;
674a4f
 
674a4f
-    strncpy (node->name, opts->nodename, sizeof (node->name));
674a4f
+    strncpy (node->name, opts->nodename, sizeof (node->name) - 1);
674a4f
     snprintf (node->port, sizeof (node->port), "%d", opts->ipport);
674a4f
 
674a4f
     node->info = NULL;