|
 |
df1f87 |
From d920421ccb3abb42ecb9ea3ba56948db00fe1c80 Mon Sep 17 00:00:00 2001
|
|
|
df1f87 |
From: Oyvind Albrigtsen <oalbrigt@redhat.com>
|
|
|
df1f87 |
Date: Tue, 23 Mar 2021 12:14:11 +0100
|
|
|
df1f87 |
Subject: [PATCH] fence_aws: add filter parameter to be able to limit which
|
|
|
df1f87 |
nodes are listed
|
|
|
df1f87 |
|
|
|
df1f87 |
---
|
|
|
df1f87 |
agents/aws/fence_aws.py | 27 +++++++++++++++++++++------
|
|
|
df1f87 |
tests/data/metadata/fence_aws.xml | 5 +++++
|
|
|
df1f87 |
2 files changed, 26 insertions(+), 6 deletions(-)
|
|
|
df1f87 |
|
|
|
df1f87 |
diff --git a/agents/aws/fence_aws.py b/agents/aws/fence_aws.py
|
|
|
df1f87 |
index 8322df9ed..c947bf29c 100644
|
|
|
df1f87 |
--- a/agents/aws/fence_aws.py
|
|
|
df1f87 |
+++ b/agents/aws/fence_aws.py
|
|
|
df1f87 |
@@ -38,8 +38,15 @@ def get_nodes_list(conn, options):
|
|
|
df1f87 |
logger.info("Starting monitor operation")
|
|
|
df1f87 |
result = {}
|
|
|
df1f87 |
try:
|
|
|
df1f87 |
- for instance in conn.instances.all():
|
|
|
df1f87 |
- result[instance.id] = ("", None)
|
|
|
df1f87 |
+ if "--filter" in options:
|
|
|
df1f87 |
+ filter_key = options["--filter"].split("=")[0].strip()
|
|
|
df1f87 |
+ filter_value = options["--filter"].split("=")[1].strip()
|
|
|
df1f87 |
+ filter = [{ "Name": filter_key, "Values": [filter_value] }]
|
|
|
df1f87 |
+ for instance in conn.instances.filter(Filters=filter):
|
|
|
df1f87 |
+ result[instance.id] = ("", None)
|
|
|
df1f87 |
+ else:
|
|
|
df1f87 |
+ for instance in conn.instances.all():
|
|
|
df1f87 |
+ result[instance.id] = ("", None)
|
|
|
df1f87 |
except ClientError:
|
|
|
df1f87 |
fail_usage("Failed: Incorrect Access Key or Secret Key.")
|
|
|
df1f87 |
except EndpointConnectionError:
|
|
|
df1f87 |
@@ -111,7 +118,7 @@ def define_new_opts():
|
|
|
df1f87 |
all_opt["region"] = {
|
|
|
df1f87 |
"getopt" : "r:",
|
|
|
df1f87 |
"longopt" : "region",
|
|
|
df1f87 |
- "help" : "-r, --region=[region] Region, e.g. us-east-1",
|
|
|
df1f87 |
+ "help" : "-r, --region=[region] Region, e.g. us-east-1",
|
|
|
df1f87 |
"shortdesc" : "Region.",
|
|
|
df1f87 |
"required" : "0",
|
|
|
df1f87 |
"order" : 2
|
|
|
df1f87 |
@@ -132,21 +139,29 @@ def define_new_opts():
|
|
|
df1f87 |
"required" : "0",
|
|
|
df1f87 |
"order" : 4
|
|
|
df1f87 |
}
|
|
|
df1f87 |
+ all_opt["filter"] = {
|
|
|
df1f87 |
+ "getopt" : ":",
|
|
|
df1f87 |
+ "longopt" : "filter",
|
|
|
df1f87 |
+ "help" : "--filter=[key=value] Filter (e.g. vpc-id=[vpc-XXYYZZAA]",
|
|
|
df1f87 |
+ "shortdesc": "Filter for list-action",
|
|
|
df1f87 |
+ "required": "0",
|
|
|
df1f87 |
+ "order": 5
|
|
|
df1f87 |
+ }
|
|
|
df1f87 |
all_opt["boto3_debug"] = {
|
|
|
df1f87 |
"getopt" : "b:",
|
|
|
df1f87 |
"longopt" : "boto3_debug",
|
|
|
df1f87 |
- "help" : "-b, --boto3_debug=[option] Boto3 and Botocore library debug logging",
|
|
|
df1f87 |
+ "help" : "-b, --boto3_debug=[option] Boto3 and Botocore library debug logging",
|
|
|
df1f87 |
"shortdesc": "Boto Lib debug",
|
|
|
df1f87 |
"required": "0",
|
|
|
df1f87 |
"default": "False",
|
|
|
df1f87 |
- "order": 5
|
|
|
df1f87 |
+ "order": 6
|
|
|
df1f87 |
}
|
|
|
df1f87 |
|
|
|
df1f87 |
# Main agent method
|
|
|
df1f87 |
def main():
|
|
|
df1f87 |
conn = None
|
|
|
df1f87 |
|
|
|
df1f87 |
- device_opt = ["port", "no_password", "region", "access_key", "secret_key", "boto3_debug"]
|
|
|
df1f87 |
+ device_opt = ["port", "no_password", "region", "access_key", "secret_key", "filter", "boto3_debug"]
|
|
|
df1f87 |
|
|
|
df1f87 |
atexit.register(atexit_handler)
|
|
|
df1f87 |
|
|
|
df1f87 |
diff --git a/tests/data/metadata/fence_aws.xml b/tests/data/metadata/fence_aws.xml
|
|
|
df1f87 |
index 1f3ab3b97..a767e93c2 100644
|
|
|
df1f87 |
--- a/tests/data/metadata/fence_aws.xml
|
|
|
df1f87 |
+++ b/tests/data/metadata/fence_aws.xml
|
|
|
df1f87 |
@@ -36,6 +36,11 @@ For instructions see: https://boto3.readthedocs.io/en/latest/guide/quickstart.ht
|
|
|
df1f87 |
<content type="string" />
|
|
|
df1f87 |
<shortdesc lang="en">Secret Key.</shortdesc>
|
|
|
df1f87 |
</parameter>
|
|
|
df1f87 |
+ <parameter name="filter" unique="0" required="0">
|
|
|
df1f87 |
+ <getopt mixed="--filter=[key=value]" />
|
|
|
df1f87 |
+ <content type="string" />
|
|
|
df1f87 |
+ <shortdesc lang="en">Filter for list-action</shortdesc>
|
|
|
df1f87 |
+ </parameter>
|
|
|
df1f87 |
<parameter name="boto3_debug" unique="0" required="0">
|
|
|
df1f87 |
<getopt mixed="-b, --boto3_debug=[option]" />
|
|
|
df1f87 |
<content type="string" default="False" />
|