Blame SOURCES/evolution-3.28.5-mangled-deeper-html-quotes.patch

2701e1
diff -up evolution-3.28.5/src/e-util/test-html-editor-units-bugs.c.mangled-deeper-html-quotes evolution-3.28.5/src/e-util/test-html-editor-units-bugs.c
2701e1
--- evolution-3.28.5/src/e-util/test-html-editor-units-bugs.c.mangled-deeper-html-quotes	2018-07-30 15:37:05.000000000 +0200
2701e1
+++ evolution-3.28.5/src/e-util/test-html-editor-units-bugs.c	2018-09-03 15:31:08.028513879 +0200
2701e1
@@ -1205,6 +1205,120 @@ test_bug_750636 (TestFixture *fixture)
2701e1
 		g_test_fail ();
2701e1
 }
2701e1
 
2701e1
+static void
2701e1
+test_issue_86 (TestFixture *fixture)
2701e1
+{
2701e1
+	const gchar *source_text =
2701e1
+		"normal text\n"
2701e1
+		"\n"
2701e1
+		"> level 1\n"
2701e1
+		"> level 1\n"
2701e1
+		"> > level 2\n"
2701e1
+		"> > level 2\n"
2701e1
+		"> >\n"
2701e1
+		"> > level 2\n"
2701e1
+		">\n"
2701e1
+		"> level 1\n"
2701e1
+		"> level 1\n"
2701e1
+		">\n"
2701e1
+		"> > > level 3\n"
2701e1
+		"> > > level 3\n"
2701e1
+		">\n"
2701e1
+		"> > level 2\n"
2701e1
+		"> > level 2\n"
2701e1
+		">\n"
2701e1
+		"> level 1\n"
2701e1
+		"\n"
2701e1
+		"back normal text\n";
2701e1
+	gchar *converted, *to_insert;
2701e1
+
2701e1
+	if (!test_utils_process_commands (fixture,
2701e1
+		"mode:html\n")) {
2701e1
+		g_test_fail ();
2701e1
+		return;
2701e1
+	}
2701e1
+
2701e1
+	converted = camel_text_to_html (source_text,
2701e1
+		CAMEL_MIME_FILTER_TOHTML_PRE |
2701e1
+		CAMEL_MIME_FILTER_TOHTML_CONVERT_URLS |
2701e1
+		CAMEL_MIME_FILTER_TOHTML_CONVERT_ADDRESSES |
2701e1
+		CAMEL_MIME_FILTER_TOHTML_QUOTE_CITATION,
2701e1
+		0xDDDDDD);
2701e1
+
2701e1
+	g_return_if_fail (converted != NULL);
2701e1
+
2701e1
+	to_insert = g_strconcat (converted,
2701e1
+		""
2701e1
+		"",
2701e1
+		NULL);
2701e1
+
2701e1
+	test_utils_insert_content (fixture, to_insert,
2701e1
+		E_CONTENT_EDITOR_INSERT_REPLACE_ALL | E_CONTENT_EDITOR_INSERT_TEXT_HTML);
2701e1
+
2701e1
+	if (!test_utils_run_simple_test (fixture,
2701e1
+		"",
2701e1
+		HTML_PREFIX "
On Today, User wrote:
"
2701e1
+		"
"
2701e1
+			"
normal text
"
2701e1
+			"

"
2701e1
+			"
"
2701e1
+				"
level 1
"
2701e1
+				"
level 1
"
2701e1
+				"
"
2701e1
+					"
level 2
"
2701e1
+					"
level 2
"
2701e1
+					"

"
2701e1
+					"
level 2
"
2701e1
+				""
2701e1
+				"

"
2701e1
+				"
level 1
"
2701e1
+				"
level 1
"
2701e1
+				"

"
2701e1
+				"
"
2701e1
+					"
"
2701e1
+						"
level 3
"
2701e1
+						"
level 3
"
2701e1
+					""
2701e1
+				""
2701e1
+				"

"
2701e1
+				"
"
2701e1
+					"
level 2
"
2701e1
+					"
level 2
"
2701e1
+				""
2701e1
+				"

"
2701e1
+				"
level 1
"
2701e1
+			""
2701e1
+			"

"
2701e1
+			"
back normal text
"
2701e1
+		"" HTML_SUFFIX,
2701e1
+		"On Today, User wrote:\n"
2701e1
+		"> normal text\n"
2701e1
+		"> \n"
2701e1
+		"> > level 1\n"
2701e1
+		"> > level 1\n"
2701e1
+		"> > > level 2\n"
2701e1
+		"> > > level 2\n"
2701e1
+		"> > > \n"
2701e1
+		"> > > level 2\n"
2701e1
+		"> > \n"
2701e1
+		"> > level 1\n"
2701e1
+		"> > level 1\n"
2701e1
+		"> > \n"
2701e1
+		"> > > > level 3\n"
2701e1
+		"> > > > level 3\n"
2701e1
+		"> > \n"
2701e1
+		"> > > level 2\n"
2701e1
+		"> > > level 2\n"
2701e1
+		"> > \n"
2701e1
+		"> > level 1\n"
2701e1
+		"> \n"
2701e1
+		"> back normal text"))
2701e1
+		g_test_fail ();
2701e1
+
2701e1
+	g_free (to_insert);
2701e1
+	g_free (converted);
2701e1
+}
2701e1
+
2701e1
 void
2701e1
 test_add_html_editor_bug_tests (void)
2701e1
 {
2701e1
@@ -1234,4 +1348,5 @@ test_add_html_editor_bug_tests (void)
2701e1
 	test_utils_add_test ("/bug/780088", test_bug_780088);
2701e1
 	test_utils_add_test ("/bug/788829", test_bug_788829);
2701e1
 	test_utils_add_test ("/bug/750636", test_bug_750636);
2701e1
+	test_utils_add_test ("/issue/86", test_issue_86);
2701e1
 }
2701e1
diff -up evolution-3.28.5/src/modules/webkit-editor/web-extension/e-editor-dom-functions.c.mangled-deeper-html-quotes evolution-3.28.5/src/modules/webkit-editor/web-extension/e-editor-dom-functions.c
2701e1
--- evolution-3.28.5/src/modules/webkit-editor/web-extension/e-editor-dom-functions.c.mangled-deeper-html-quotes	2018-07-30 15:37:05.000000000 +0200
2701e1
+++ evolution-3.28.5/src/modules/webkit-editor/web-extension/e-editor-dom-functions.c	2018-09-03 15:32:41.220512591 +0200
2701e1
@@ -6230,7 +6230,6 @@ e_editor_dom_convert_content (EEditorPag
2701e1
 			WEBKIT_DOM_NODE (content_wrapper),
2701e1
 			WEBKIT_DOM_NODE (e_editor_dom_prepare_paragraph (editor_page, FALSE)),
2701e1
 			NULL);
2701e1
-
2701e1
 	if (!cite_body) {
2701e1
 		if (!empty) {
2701e1
 			WebKitDOMNode *child;
2701e1
@@ -8754,6 +8753,133 @@ adapt_to_editor_dom_changes (WebKitDOMDo
2701e1
 	g_clear_object (&collection);
2701e1
 }
2701e1
 
2701e1
+static void
2701e1
+traverse_nodes_to_split_pre (WebKitDOMDocument *document,
2701e1
+			     WebKitDOMNode *node,
2701e1
+			     WebKitDOMNode *new_parent, /* can be NULL, then prepend to out_new_nodes */
2701e1
+			     gboolean is_in_pre,
2701e1
+			     GSList **out_new_nodes) /* WebKitDOMNode * */
2701e1
+{
2701e1
+	if (is_in_pre && WEBKIT_DOM_IS_TEXT (node)) {
2701e1
+		gchar *text;
2701e1
+
2701e1
+		text = webkit_dom_text_get_whole_text (WEBKIT_DOM_TEXT (node));
2701e1
+		if (text) {
2701e1
+			WebKitDOMElement *pre;
2701e1
+			gint ii;
2701e1
+			gchar **strv;
2701e1
+
2701e1
+			strv = g_strsplit (text, "\n", -1);
2701e1
+
2701e1
+			for (ii = 0; strv && strv[ii]; ii++) {
2701e1
+				if (*(strv[ii])) {
2701e1
+					gint len = strlen (strv[ii]);
2701e1
+
2701e1
+					if (strv[ii][len - 1] == '\r') {
2701e1
+						strv[ii][len - 1] = '\0';
2701e1
+					}
2701e1
+				}
2701e1
+
2701e1
+				/* 
 is shown as a block, thus adding a new line at the end behaves like two 
-s */
2701e1
+				if (!*(strv[ii]) && !strv[ii + 1])
2701e1
+					break;
2701e1
+
2701e1
+				pre = webkit_dom_document_create_element (document, "pre", NULL);
2701e1
+
2701e1
+				if (*(strv[ii])) {
2701e1
+					webkit_dom_html_element_set_inner_text (WEBKIT_DOM_HTML_ELEMENT (pre), strv[ii], NULL);
2701e1
+				} else {
2701e1
+					WebKitDOMElement *br;
2701e1
+
2701e1
+					br = webkit_dom_document_create_element (document, "br", NULL);
2701e1
+					webkit_dom_node_append_child (WEBKIT_DOM_NODE (pre), WEBKIT_DOM_NODE (br), NULL);
2701e1
+				}
2701e1
+
2701e1
+				if (new_parent)
2701e1
+					webkit_dom_node_append_child (new_parent, WEBKIT_DOM_NODE (pre), NULL);
2701e1
+				else
2701e1
+					*out_new_nodes = g_slist_prepend (*out_new_nodes, pre);
2701e1
+			}
2701e1
+
2701e1
+			g_strfreev (strv);
2701e1
+		}
2701e1
+
2701e1
+		g_free (text);
2701e1
+	} else if (WEBKIT_DOM_IS_HTML_PRE_ELEMENT (node)) {
2701e1
+		is_in_pre = TRUE;
2701e1
+	} else {
2701e1
+		WebKitDOMNode *nd;
2701e1
+		GError *error = NULL;
2701e1
+
2701e1
+		nd = webkit_dom_node_clone_node_with_error (node, FALSE, &error);
2701e1
+		if (nd) {
2701e1
+			if (new_parent)
2701e1
+				webkit_dom_node_append_child (new_parent, nd, NULL);
2701e1
+			else
2701e1
+				*out_new_nodes = g_slist_prepend (*out_new_nodes, nd);
2701e1
+
2701e1
+			new_parent = nd;
2701e1
+		} else {
2701e1
+			g_warning ("%s: Failed to clone node %s: %s\n", G_STRFUNC, G_OBJECT_TYPE_NAME (node), error ? error->message : "Unknown error");
2701e1
+		}
2701e1
+	}
2701e1
+
2701e1
+	for (node = webkit_dom_node_get_first_child (node);
2701e1
+	     node;
2701e1
+	     node = webkit_dom_node_get_next_sibling (node)) {
2701e1
+		traverse_nodes_to_split_pre (document, node, new_parent, is_in_pre, out_new_nodes);
2701e1
+	}
2701e1
+}
2701e1
+
2701e1
+static void
2701e1
+maybe_split_pre_paragraphs (WebKitDOMDocument *document)
2701e1
+{
2701e1
+	WebKitDOMHTMLElement *body;
2701e1
+	WebKitDOMNodeList *list;
2701e1
+
2701e1
+	body = webkit_dom_document_get_body (document);
2701e1
+	if (!body)
2701e1
+		return;
2701e1
+
2701e1
+	list = webkit_dom_document_query_selector_all (document, "pre", NULL);
2701e1
+	if (webkit_dom_node_list_get_length (list)) {
2701e1
+		WebKitDOMNode *body_node, *node, *current;
2701e1
+		GSList *new_nodes = NULL, *to_remove = NULL, *link;
2701e1
+
2701e1
+		g_clear_object (&list);
2701e1
+
2701e1
+		body_node = WEBKIT_DOM_NODE (body);
2701e1
+		webkit_dom_node_normalize (body_node);
2701e1
+
2701e1
+		for (current = webkit_dom_node_get_first_child (body_node);
2701e1
+		     current;
2701e1
+		     current = webkit_dom_node_get_next_sibling (current)) {
2701e1
+			traverse_nodes_to_split_pre (document, current, NULL, FALSE, &new_nodes);
2701e1
+			to_remove = g_slist_prepend (to_remove, current);
2701e1
+		}
2701e1
+
2701e1
+		for (link = to_remove; link; link = g_slist_next (link)) {
2701e1
+			node = link->data;
2701e1
+
2701e1
+			webkit_dom_node_remove_child (body_node, node, NULL);
2701e1
+		}
2701e1
+
2701e1
+		/* They are in reverse order, thus reverse it */
2701e1
+		new_nodes = g_slist_reverse (new_nodes);
2701e1
+
2701e1
+		for (link = new_nodes; link; link = g_slist_next (link)) {
2701e1
+			node = link->data;
2701e1
+
2701e1
+			webkit_dom_node_append_child (body_node, node, NULL);
2701e1
+		}
2701e1
+
2701e1
+		g_slist_free (to_remove);
2701e1
+		g_slist_free (new_nodes);
2701e1
+	}
2701e1
+
2701e1
+	g_clear_object (&list);
2701e1
+}
2701e1
+
2701e1
 void
2701e1
 e_editor_dom_process_content_after_load (EEditorPage *editor_page)
2701e1
 {
2701e1
@@ -8803,60 +8929,8 @@ e_editor_dom_process_content_after_load
2701e1
 		}
2701e1
 
2701e1
 		goto out;
2701e1
-	} else {
2701e1
-		WebKitDOMNodeList *list;
2701e1
-		gulong ii;
2701e1
-
2701e1
-		list = webkit_dom_document_query_selector_all (document, "pre", NULL);
2701e1
-		for (ii = webkit_dom_node_list_get_length (list); ii--;) {
2701e1
-			WebKitDOMNode *node = webkit_dom_node_list_item (list, ii), *parent;
2701e1
-			WebKitDOMElement *element;
2701e1
-			gchar *inner_html;
2701e1
-
2701e1
-			element = WEBKIT_DOM_ELEMENT (node);
2701e1
-			parent = webkit_dom_node_get_parent_node (node);
2701e1
-			inner_html = webkit_dom_element_get_inner_html (element);
2701e1
-
2701e1
-			if (inner_html && *inner_html) {
2701e1
-				gchar **strv;
2701e1
-
2701e1
-				strv = g_strsplit (inner_html, "\n", -1);
2701e1
-				if (strv && strv[0] && strv[1]) {
2701e1
-					WebKitDOMElement *pre;
2701e1
-					gint jj;
2701e1
-
2701e1
-					for (jj = 0; strv[jj]; jj++) {
2701e1
-						pre = webkit_dom_document_create_element (document, "pre", NULL);
2701e1
-						if (*(strv[jj])) {
2701e1
-							gint len = strlen (strv[jj]);
2701e1
-
2701e1
-							if (strv[jj][len - 1] == '\r') {
2701e1
-								strv[jj][len - 1] = '\0';
2701e1
-							}
2701e1
-						}
2701e1
-
2701e1
-						if (*(strv[jj])) {
2701e1
-							webkit_dom_html_element_set_inner_html (WEBKIT_DOM_HTML_ELEMENT (pre), strv[jj], NULL);
2701e1
-						} else {
2701e1
-							WebKitDOMElement *br;
2701e1
-
2701e1
-							br = webkit_dom_document_create_element (document, "br", NULL);
2701e1
-							webkit_dom_node_append_child (WEBKIT_DOM_NODE (pre), WEBKIT_DOM_NODE (br), NULL);
2701e1
-						}
2701e1
-
2701e1
-						webkit_dom_node_insert_before (parent, WEBKIT_DOM_NODE (pre), node, NULL);
2701e1
-					}
2701e1
-
2701e1
-					remove_node (node);
2701e1
-				}
2701e1
-
2701e1
-				g_strfreev (strv);
2701e1
-			}
2701e1
-
2701e1
-			g_free (inner_html);
2701e1
-		}
2701e1
-
2701e1
-		g_clear_object (&list);
2701e1
+	} else if (!webkit_dom_element_has_attribute (WEBKIT_DOM_ELEMENT (body), "data-evo-draft")) {
2701e1
+		maybe_split_pre_paragraphs (document);
2701e1
 	}
2701e1
 
2701e1
 	adapt_to_editor_dom_changes (document);