Blame SOURCES/evolution-3.28.5-composer-mangled-quotation.patch

3930dc
diff -up evolution-3.28.5/src/e-util/test-html-editor-units-bugs.c.composer-mangled-quotation evolution-3.28.5/src/e-util/test-html-editor-units-bugs.c
3930dc
--- evolution-3.28.5/src/e-util/test-html-editor-units-bugs.c.composer-mangled-quotation	2018-07-30 15:37:05.000000000 +0200
3930dc
+++ evolution-3.28.5/src/e-util/test-html-editor-units-bugs.c	2018-11-09 13:27:45.699170089 +0100
3930dc
@@ -1205,6 +1205,120 @@ test_bug_750636 (TestFixture *fixture)
3930dc
 		g_test_fail ();
3930dc
 }
3930dc
 
3930dc
+static void
3930dc
+test_issue_86 (TestFixture *fixture)
3930dc
+{
3930dc
+	const gchar *source_text =
3930dc
+		"normal text\n"
3930dc
+		"\n"
3930dc
+		"> level 1\n"
3930dc
+		"> level 1\n"
3930dc
+		"> > level 2\n"
3930dc
+		"> > level 2\n"
3930dc
+		"> >\n"
3930dc
+		"> > level 2\n"
3930dc
+		">\n"
3930dc
+		"> level 1\n"
3930dc
+		"> level 1\n"
3930dc
+		">\n"
3930dc
+		"> > > level 3\n"
3930dc
+		"> > > level 3\n"
3930dc
+		">\n"
3930dc
+		"> > level 2\n"
3930dc
+		"> > level 2\n"
3930dc
+		">\n"
3930dc
+		"> level 1\n"
3930dc
+		"\n"
3930dc
+		"back normal text\n";
3930dc
+	gchar *converted, *to_insert;
3930dc
+
3930dc
+	if (!test_utils_process_commands (fixture,
3930dc
+		"mode:html\n")) {
3930dc
+		g_test_fail ();
3930dc
+		return;
3930dc
+	}
3930dc
+
3930dc
+	converted = camel_text_to_html (source_text,
3930dc
+		CAMEL_MIME_FILTER_TOHTML_PRE |
3930dc
+		CAMEL_MIME_FILTER_TOHTML_CONVERT_URLS |
3930dc
+		CAMEL_MIME_FILTER_TOHTML_CONVERT_ADDRESSES |
3930dc
+		CAMEL_MIME_FILTER_TOHTML_QUOTE_CITATION,
3930dc
+		0xDDDDDD);
3930dc
+
3930dc
+	g_return_if_fail (converted != NULL);
3930dc
+
3930dc
+	to_insert = g_strconcat (converted,
3930dc
+		""
3930dc
+		"",
3930dc
+		NULL);
3930dc
+
3930dc
+	test_utils_insert_content (fixture, to_insert,
3930dc
+		E_CONTENT_EDITOR_INSERT_REPLACE_ALL | E_CONTENT_EDITOR_INSERT_TEXT_HTML);
3930dc
+
3930dc
+	if (!test_utils_run_simple_test (fixture,
3930dc
+		"",
3930dc
+		HTML_PREFIX "
On Today, User wrote:
"
3930dc
+		"
"
3930dc
+			"
normal text
"
3930dc
+			"

"
3930dc
+			"
"
3930dc
+				"
level 1
"
3930dc
+				"
level 1
"
3930dc
+				"
"
3930dc
+					"
level 2
"
3930dc
+					"
level 2
"
3930dc
+					"

"
3930dc
+					"
level 2
"
3930dc
+				""
3930dc
+				"

"
3930dc
+				"
level 1
"
3930dc
+				"
level 1
"
3930dc
+				"

"
3930dc
+				"
"
3930dc
+					"
"
3930dc
+						"
level 3
"
3930dc
+						"
level 3
"
3930dc
+					""
3930dc
+				""
3930dc
+				"

"
3930dc
+				"
"
3930dc
+					"
level 2
"
3930dc
+					"
level 2
"
3930dc
+				""
3930dc
+				"

"
3930dc
+				"
level 1
"
3930dc
+			""
3930dc
+			"

"
3930dc
+			"
back normal text
"
3930dc
+		"" HTML_SUFFIX,
3930dc
+		"On Today, User wrote:\n"
3930dc
+		"> normal text\n"
3930dc
+		"> \n"
3930dc
+		"> > level 1\n"
3930dc
+		"> > level 1\n"
3930dc
+		"> > > level 2\n"
3930dc
+		"> > > level 2\n"
3930dc
+		"> > > \n"
3930dc
+		"> > > level 2\n"
3930dc
+		"> > \n"
3930dc
+		"> > level 1\n"
3930dc
+		"> > level 1\n"
3930dc
+		"> > \n"
3930dc
+		"> > > > level 3\n"
3930dc
+		"> > > > level 3\n"
3930dc
+		"> > \n"
3930dc
+		"> > > level 2\n"
3930dc
+		"> > > level 2\n"
3930dc
+		"> > \n"
3930dc
+		"> > level 1\n"
3930dc
+		"> \n"
3930dc
+		"> back normal text"))
3930dc
+		g_test_fail ();
3930dc
+
3930dc
+	g_free (to_insert);
3930dc
+	g_free (converted);
3930dc
+}
3930dc
+
3930dc
 void
3930dc
 test_add_html_editor_bug_tests (void)
3930dc
 {
3930dc
@@ -1234,4 +1348,5 @@ test_add_html_editor_bug_tests (void)
3930dc
 	test_utils_add_test ("/bug/780088", test_bug_780088);
3930dc
 	test_utils_add_test ("/bug/788829", test_bug_788829);
3930dc
 	test_utils_add_test ("/bug/750636", test_bug_750636);
3930dc
+	test_utils_add_test ("/issue/86", test_issue_86);
3930dc
 }
3930dc
diff -up evolution-3.28.5/src/modules/webkit-editor/web-extension/e-editor-dom-functions.c.composer-mangled-quotation evolution-3.28.5/src/modules/webkit-editor/web-extension/e-editor-dom-functions.c
3930dc
--- evolution-3.28.5/src/modules/webkit-editor/web-extension/e-editor-dom-functions.c.composer-mangled-quotation	2018-07-30 15:37:05.000000000 +0200
3930dc
+++ evolution-3.28.5/src/modules/webkit-editor/web-extension/e-editor-dom-functions.c	2018-11-09 13:29:06.551168971 +0100
3930dc
@@ -6230,7 +6230,6 @@ e_editor_dom_convert_content (EEditorPag
3930dc
 			WEBKIT_DOM_NODE (content_wrapper),
3930dc
 			WEBKIT_DOM_NODE (e_editor_dom_prepare_paragraph (editor_page, FALSE)),
3930dc
 			NULL);
3930dc
-
3930dc
 	if (!cite_body) {
3930dc
 		if (!empty) {
3930dc
 			WebKitDOMNode *child;
3930dc
@@ -8754,6 +8753,133 @@ adapt_to_editor_dom_changes (WebKitDOMDo
3930dc
 	g_clear_object (&collection);
3930dc
 }
3930dc
 
3930dc
+static void
3930dc
+traverse_nodes_to_split_pre (WebKitDOMDocument *document,
3930dc
+			     WebKitDOMNode *node,
3930dc
+			     WebKitDOMNode *new_parent, /* can be NULL, then prepend to out_new_nodes */
3930dc
+			     gboolean is_in_pre,
3930dc
+			     GSList **out_new_nodes) /* WebKitDOMNode * */
3930dc
+{
3930dc
+	if (is_in_pre && WEBKIT_DOM_IS_TEXT (node)) {
3930dc
+		gchar *text;
3930dc
+
3930dc
+		text = webkit_dom_text_get_whole_text (WEBKIT_DOM_TEXT (node));
3930dc
+		if (text) {
3930dc
+			WebKitDOMElement *pre;
3930dc
+			gint ii;
3930dc
+			gchar **strv;
3930dc
+
3930dc
+			strv = g_strsplit (text, "\n", -1);
3930dc
+
3930dc
+			for (ii = 0; strv && strv[ii]; ii++) {
3930dc
+				if (*(strv[ii])) {
3930dc
+					gint len = strlen (strv[ii]);
3930dc
+
3930dc
+					if (strv[ii][len - 1] == '\r') {
3930dc
+						strv[ii][len - 1] = '\0';
3930dc
+					}
3930dc
+				}
3930dc
+
3930dc
+				/* 
 is shown as a block, thus adding a new line at the end behaves like two 
-s */
3930dc
+				if (!*(strv[ii]) && !strv[ii + 1])
3930dc
+					break;
3930dc
+
3930dc
+				pre = webkit_dom_document_create_element (document, "pre", NULL);
3930dc
+
3930dc
+				if (*(strv[ii])) {
3930dc
+					webkit_dom_html_element_set_inner_text (WEBKIT_DOM_HTML_ELEMENT (pre), strv[ii], NULL);
3930dc
+				} else {
3930dc
+					WebKitDOMElement *br;
3930dc
+
3930dc
+					br = webkit_dom_document_create_element (document, "br", NULL);
3930dc
+					webkit_dom_node_append_child (WEBKIT_DOM_NODE (pre), WEBKIT_DOM_NODE (br), NULL);
3930dc
+				}
3930dc
+
3930dc
+				if (new_parent)
3930dc
+					webkit_dom_node_append_child (new_parent, WEBKIT_DOM_NODE (pre), NULL);
3930dc
+				else
3930dc
+					*out_new_nodes = g_slist_prepend (*out_new_nodes, pre);
3930dc
+			}
3930dc
+
3930dc
+			g_strfreev (strv);
3930dc
+		}
3930dc
+
3930dc
+		g_free (text);
3930dc
+	} else if (WEBKIT_DOM_IS_HTML_PRE_ELEMENT (node)) {
3930dc
+		is_in_pre = TRUE;
3930dc
+	} else {
3930dc
+		WebKitDOMNode *nd;
3930dc
+		GError *error = NULL;
3930dc
+
3930dc
+		nd = webkit_dom_node_clone_node_with_error (node, FALSE, &error);
3930dc
+		if (nd) {
3930dc
+			if (new_parent)
3930dc
+				webkit_dom_node_append_child (new_parent, nd, NULL);
3930dc
+			else
3930dc
+				*out_new_nodes = g_slist_prepend (*out_new_nodes, nd);
3930dc
+
3930dc
+			new_parent = nd;
3930dc
+		} else {
3930dc
+			g_warning ("%s: Failed to clone node %s: %s\n", G_STRFUNC, G_OBJECT_TYPE_NAME (node), error ? error->message : "Unknown error");
3930dc
+		}
3930dc
+	}
3930dc
+
3930dc
+	for (node = webkit_dom_node_get_first_child (node);
3930dc
+	     node;
3930dc
+	     node = webkit_dom_node_get_next_sibling (node)) {
3930dc
+		traverse_nodes_to_split_pre (document, node, new_parent, is_in_pre, out_new_nodes);
3930dc
+	}
3930dc
+}
3930dc
+
3930dc
+static void
3930dc
+maybe_split_pre_paragraphs (WebKitDOMDocument *document)
3930dc
+{
3930dc
+	WebKitDOMHTMLElement *body;
3930dc
+	WebKitDOMNodeList *list;
3930dc
+
3930dc
+	body = webkit_dom_document_get_body (document);
3930dc
+	if (!body)
3930dc
+		return;
3930dc
+
3930dc
+	list = webkit_dom_document_query_selector_all (document, "pre", NULL);
3930dc
+	if (webkit_dom_node_list_get_length (list)) {
3930dc
+		WebKitDOMNode *body_node, *node, *current;
3930dc
+		GSList *new_nodes = NULL, *to_remove = NULL, *link;
3930dc
+
3930dc
+		g_clear_object (&list);
3930dc
+
3930dc
+		body_node = WEBKIT_DOM_NODE (body);
3930dc
+		webkit_dom_node_normalize (body_node);
3930dc
+
3930dc
+		for (current = webkit_dom_node_get_first_child (body_node);
3930dc
+		     current;
3930dc
+		     current = webkit_dom_node_get_next_sibling (current)) {
3930dc
+			traverse_nodes_to_split_pre (document, current, NULL, FALSE, &new_nodes);
3930dc
+			to_remove = g_slist_prepend (to_remove, current);
3930dc
+		}
3930dc
+
3930dc
+		for (link = to_remove; link; link = g_slist_next (link)) {
3930dc
+			node = link->data;
3930dc
+
3930dc
+			webkit_dom_node_remove_child (body_node, node, NULL);
3930dc
+		}
3930dc
+
3930dc
+		/* They are in reverse order, thus reverse it */
3930dc
+		new_nodes = g_slist_reverse (new_nodes);
3930dc
+
3930dc
+		for (link = new_nodes; link; link = g_slist_next (link)) {
3930dc
+			node = link->data;
3930dc
+
3930dc
+			webkit_dom_node_append_child (body_node, node, NULL);
3930dc
+		}
3930dc
+
3930dc
+		g_slist_free (to_remove);
3930dc
+		g_slist_free (new_nodes);
3930dc
+	}
3930dc
+
3930dc
+	g_clear_object (&list);
3930dc
+}
3930dc
+
3930dc
 void
3930dc
 e_editor_dom_process_content_after_load (EEditorPage *editor_page)
3930dc
 {
3930dc
@@ -8803,60 +8929,8 @@ e_editor_dom_process_content_after_load
3930dc
 		}
3930dc
 
3930dc
 		goto out;
3930dc
-	} else {
3930dc
-		WebKitDOMNodeList *list;
3930dc
-		gulong ii;
3930dc
-
3930dc
-		list = webkit_dom_document_query_selector_all (document, "pre", NULL);
3930dc
-		for (ii = webkit_dom_node_list_get_length (list); ii--;) {
3930dc
-			WebKitDOMNode *node = webkit_dom_node_list_item (list, ii), *parent;
3930dc
-			WebKitDOMElement *element;
3930dc
-			gchar *inner_html;
3930dc
-
3930dc
-			element = WEBKIT_DOM_ELEMENT (node);
3930dc
-			parent = webkit_dom_node_get_parent_node (node);
3930dc
-			inner_html = webkit_dom_element_get_inner_html (element);
3930dc
-
3930dc
-			if (inner_html && *inner_html) {
3930dc
-				gchar **strv;
3930dc
-
3930dc
-				strv = g_strsplit (inner_html, "\n", -1);
3930dc
-				if (strv && strv[0] && strv[1]) {
3930dc
-					WebKitDOMElement *pre;
3930dc
-					gint jj;
3930dc
-
3930dc
-					for (jj = 0; strv[jj]; jj++) {
3930dc
-						pre = webkit_dom_document_create_element (document, "pre", NULL);
3930dc
-						if (*(strv[jj])) {
3930dc
-							gint len = strlen (strv[jj]);
3930dc
-
3930dc
-							if (strv[jj][len - 1] == '\r') {
3930dc
-								strv[jj][len - 1] = '\0';
3930dc
-							}
3930dc
-						}
3930dc
-
3930dc
-						if (*(strv[jj])) {
3930dc
-							webkit_dom_html_element_set_inner_html (WEBKIT_DOM_HTML_ELEMENT (pre), strv[jj], NULL);
3930dc
-						} else {
3930dc
-							WebKitDOMElement *br;
3930dc
-
3930dc
-							br = webkit_dom_document_create_element (document, "br", NULL);
3930dc
-							webkit_dom_node_append_child (WEBKIT_DOM_NODE (pre), WEBKIT_DOM_NODE (br), NULL);
3930dc
-						}
3930dc
-
3930dc
-						webkit_dom_node_insert_before (parent, WEBKIT_DOM_NODE (pre), node, NULL);
3930dc
-					}
3930dc
-
3930dc
-					remove_node (node);
3930dc
-				}
3930dc
-
3930dc
-				g_strfreev (strv);
3930dc
-			}
3930dc
-
3930dc
-			g_free (inner_html);
3930dc
-		}
3930dc
-
3930dc
-		g_clear_object (&list);
3930dc
+	} else if (!webkit_dom_element_has_attribute (WEBKIT_DOM_ELEMENT (body), "data-evo-draft")) {
3930dc
+		maybe_split_pre_paragraphs (document);
3930dc
 	}
3930dc
 
3930dc
 	adapt_to_editor_dom_changes (document);