diff --git a/SOURCES/evince-3.28.4-application-id.patch b/SOURCES/evince-3.28.4-application-id.patch new file mode 100644 index 0000000..6b61d75 --- /dev/null +++ b/SOURCES/evince-3.28.4-application-id.patch @@ -0,0 +1,36 @@ +From 9363553a3087c7dbfa93e1d342283600ceb5993b Mon Sep 17 00:00:00 2001 +From: Marek Kasik +Date: Fri, 22 Jun 2018 17:00:20 +0200 +Subject: shell: Set application-id + +Set "application-id" property for evince's GApplication +to "org.gnome.evince.Application". +An assertion warning is shown in shell if it is not set. + +Even though we use G_APPLICATION_NON_UNIQUE, the application +ID is still required. See: +https://bugzilla.gnome.org/show_bug.cgi?id=646985#c2 + +Closes: https://gitlab.gnome.org/GNOME/evince/issues/918 + +diff --git a/shell/ev-application.c b/shell/ev-application.c +index 7d546933..f173d7a4 100644 +--- a/shell/ev-application.c ++++ b/shell/ev-application.c +@@ -65,6 +65,7 @@ struct _EvApplicationClass { + G_DEFINE_TYPE (EvApplication, ev_application, GTK_TYPE_APPLICATION) + + #ifdef ENABLE_DBUS ++#define APPLICATION_DBUS_NAME "org.gnome.evince.Application" + #define APPLICATION_DBUS_OBJECT_PATH "/org/gnome/evince/Evince" + #define APPLICATION_DBUS_INTERFACE "org.gnome.evince.Application" + +@@ -102,7 +103,7 @@ ev_application_new (void) + const GApplicationFlags flags = G_APPLICATION_NON_UNIQUE; + + return g_object_new (EV_TYPE_APPLICATION, +- "application-id", NULL, ++ "application-id", APPLICATION_DBUS_NAME, + "flags", flags, + NULL); + } diff --git a/SPECS/evince.spec b/SPECS/evince.spec index 584dae7..d279a50 100644 --- a/SPECS/evince.spec +++ b/SPECS/evince.spec @@ -5,7 +5,7 @@ Name: evince Version: 3.28.4 -Release: 6%{?dist} +Release: 7%{?dist} Summary: Document viewer License: GPLv2+ and GPLv3+ and LGPLv2+ and MIT and Afmparse @@ -28,6 +28,9 @@ Patch9: evince-3.28.4-annotations-a11y-names.patch # https://bugzilla.redhat.com/show_bug.cgi?id=1450700 Patch10: evince-3.28.4-move-annotations.patch +# https://bugzilla.redhat.com/show_bug.cgi?id=1842017 +Patch11: evince-3.28.4-application-id.patch + BuildRequires: pkgconfig(adwaita-icon-theme) BuildRequires: pkgconfig(gio-unix-2.0) >= %{glib2_version} BuildRequires: pkgconfig(gnome-desktop-3.0) @@ -256,6 +259,11 @@ desktop-file-validate $RPM_BUILD_ROOT%{_datadir}/applications/evince.desktop %{_libdir}/mozilla/plugins/libevbrowserplugin.so %changelog +* Fri Jun 5 2020 Marek Kasik - 3.28.4-7 +- Set "application-id" property for evince's GApplication +- to "org.gnome.evince.Application" to avoid a critical warning. +- Resolves: #1842017 + * Mon Apr 27 2020 Marek Kasik - 3.28.4-6 - Move annotation popup window to new position - Resolves: #1450700