1db854
From cb83c302eb77748a99940fa41026d5f373976478 Mon Sep 17 00:00:00 2001
1db854
From: Paul Eggert <eggert@cs.ucla.edu>
1db854
Date: Mon, 16 Nov 2015 17:48:08 -0800
1db854
Subject: [PATCH 11/11] ELF unexec: align section header
1db854
MIME-Version: 1.0
1db854
Content-Type: text/plain; charset=UTF-8
1db854
Content-Transfer-Encoding: 8bit
1db854
1db854
This ports the recent unexelf.c changes to Fedora x86-64
1db854
when configured with GCC’s -fsanitize=undefined option.
1db854
* src/unexelf.c (unexec): Align new_data2_size to a multiple
1db854
of ElfW (Shdr)’s alignment, so that NEW_SECTION_H returns a
1db854
pointer aligned appropriately for its type.
1db854
---
1db854
 src/unexelf.c | 11 ++++++++---
1db854
 1 file changed, 8 insertions(+), 3 deletions(-)
1db854
1db854
diff --git a/src/unexelf.c b/src/unexelf.c
1db854
index c10c7f2..03e6daf 100644
1db854
--- a/src/unexelf.c
1db854
+++ b/src/unexelf.c
1db854
@@ -247,7 +247,7 @@ unexec (const char *new_name, const char *old_name)
1db854
 
1db854
   ElfW (Phdr) *old_bss_seg, *new_bss_seg;
1db854
   ElfW (Addr) old_bss_addr, new_bss_addr;
1db854
-  ElfW (Word) old_bss_size, new_data2_size;
1db854
+  ElfW (Word) old_bss_size, bss_size_growth, new_data2_size;
1db854
   ElfW (Off) old_bss_offset, new_data2_offset;
1db854
 
1db854
   ptrdiff_t n;
1db854
@@ -331,7 +331,11 @@ unexec (const char *new_name, const char *old_name)
1db854
 
1db854
   new_break = sbrk (0);
1db854
   new_bss_addr = (ElfW (Addr)) new_break;
1db854
-  new_data2_size = new_bss_addr - old_bss_addr;
1db854
+  bss_size_growth = new_bss_addr - old_bss_addr;
1db854
+  new_data2_size = bss_size_growth;
1db854
+  new_data2_size += alignof (ElfW (Shdr)) - 1;
1db854
+  new_data2_size -= new_data2_size % alignof (ElfW (Shdr));
1db854
+
1db854
   new_data2_offset = old_bss_offset;
1db854
 
1db854
 #ifdef UNEXELF_DEBUG
1db854
@@ -399,7 +403,8 @@ unexec (const char *new_name, const char *old_name)
1db854
   new_bss_seg->p_memsz = new_bss_seg->p_filesz;
1db854
 
1db854
   /* Copy over what we have in memory now for the bss area. */
1db854
-  memcpy (new_base + new_data2_offset, (caddr_t) old_bss_addr, new_data2_size);
1db854
+  memcpy (new_base + new_data2_offset, (caddr_t) old_bss_addr,
1db854
+	  bss_size_growth);
1db854
 
1db854
   /* Walk through all section headers, copying data and updating.  */
1db854
   for (n = 1; n < old_file_h->e_shnum; n++)
1db854
-- 
1db854
2.7.4
1db854